208021 2020-02-20 11:22:10 -0800 [ews] Add build step to set cq- flag on bugzilla patch 2020-02-21 10:25:14 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1621322 0 aakash_jain 2020-02-20 11:22:10 -0800 Add build step to set cq- flag on bugzilla patch. This step would be required for commit-queue, when a patch fails validation (e.g.: ChangeLog contains OOPS, invalid Reviewer etc.) 1621341 1 391315 aakash_jain 2020-02-20 11:45:58 -0800 Created attachment 391315 Patch 1621372 2 391315 jbedard 2020-02-20 13:02:47 -0800 Comment on attachment 391315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391315&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:452 > + flags = [{'name': 'commit-queue', 'status': '-'}] Nit: Any reason to keep this on it's own line? It's only used on line 454, not sure that it makes things more clear. 1621377 3 391315 aakash_jain 2020-02-20 13:05:09 -0800 Comment on attachment 391315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391315&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:452 >> + flags = [{'name': 'commit-queue', 'status': '-'}] > > Nit: Any reason to keep this on it's own line? It's only used on line 454, not sure that it makes things more clear. just for readability. line 454 would have become too long and hard to read with this info in it. 1621696 4 aakash_jain 2020-02-21 10:24:44 -0800 Committed r257147: <https://trac.webkit.org/changeset/257147> 1621698 5 webkit-bug-importer 2020-02-21 10:25:14 -0800 <rdar://problem/59673032> 391315 2020-02-20 11:45:58 -0800 2020-02-20 13:02:47 -0800 Patch bug-208021-20200220144557.patch text/plain 2746 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzA3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgYnVpbGQgc3RlcCB0byBzZXQgY3EtIGZsYWcgb24gYnVn emlsbGEgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwODAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQnVn emlsbGFNaXhpbi5zZXRfY3FfbWludXNfZmxhZ19vbl9wYXRjaCk6CisgICAgICAgIChTZXRDb21t aXRRdWV1ZU1pbnVzRmxhZ09uUGF0Y2gpOgorICAgICAgICAoU2V0Q29tbWl0UXVldWVNaW51c0Zs YWdPblBhdGNoLnN0YXJ0KToKKyAgICAgICAgKFNldENvbW1pdFF1ZXVlTWludXNGbGFnT25QYXRj aC5nZXRSZXN1bHRTdW1tYXJ5KToKKwogMjAyMC0wMi0yMCAgVGltIEhvcnRvbiAgPHRpbW90aHlf aG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBXS1dlYlZpZXcgd2l0aCBub24temVybyBvcmln aW4gaGFzIHRoZSB3cm9uZyB0b3AgY29udGVudCBpbnNldCB3aXRoIE5TV2luZG93U3R5bGVNYXNr RnVsbFNpemVDb250ZW50VmlldwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjU3MDc2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00NDcsNiArNDQ3LDE5IEBA IGNsYXNzIEJ1Z3ppbGxhTWl4aW4ob2JqZWN0KToKICAgICAgICAgICAgIHJldHVybiBGQUlMVVJF CiAgICAgICAgIHJldHVybiBTVUNDRVNTCiAKKyAgICBkZWYgc2V0X2NxX21pbnVzX2ZsYWdfb25f cGF0Y2goc2VsZiwgcGF0Y2hfaWQpOgorICAgICAgICBwYXRjaF91cmwgPSAne31yZXN0L2J1Zy9h dHRhY2htZW50L3t9Jy5mb3JtYXQoQlVHX1NFUlZFUl9VUkwsIHBhdGNoX2lkKQorICAgICAgICBm bGFncyA9IFt7J25hbWUnOiAnY29tbWl0LXF1ZXVlJywgJ3N0YXR1cyc6ICctJ31dCisgICAgICAg IHRyeToKKyAgICAgICAgICAgIHJlc3BvbnNlID0gcmVxdWVzdHMucHV0KHBhdGNoX3VybCwganNv bj17J2ZsYWdzJzogZmxhZ3MsICdCdWd6aWxsYV9hcGlfa2V5Jzogc2VsZi5nZXRfYnVnemlsbGFf YXBpX2tleSgpfSkKKyAgICAgICAgICAgIGlmIHJlc3BvbnNlLnN0YXR1c19jb2RlIG5vdCBpbiBb MjAwLCAyMDFdOgorICAgICAgICAgICAgICAgIHNlbGYuX2FkZFRvTG9nKCdzdGRpbycsICdVbmFi bGUgdG8gc2V0IGNxLSBmbGFnIG9uIHBhdGNoIHt9LiBVbmV4cGVjdGVkIHJlc3BvbnNlIGNvZGUg ZnJvbSBidWd6aWxsYToge30nLmZvcm1hdChwYXRjaF9pZCwgcmVzcG9uc2Uuc3RhdHVzX2NvZGUp KQorICAgICAgICAgICAgICAgIHJldHVybiBGQUlMVVJFCisgICAgICAgIGV4Y2VwdCBFeGNlcHRp b24gYXMgZToKKyAgICAgICAgICAgIHNlbGYuX2FkZFRvTG9nKCdzdGRpbycsICdFcnJvciBpbiBz ZXR0aW5nIGNxLSBmbGFnIG9uIHBhdGNoIHt9Jy5mb3JtYXQocGF0Y2hfaWQpKQorICAgICAgICAg ICAgcmV0dXJuIEZBSUxVUkUKKyAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKwogICAgIGRlZiBjbG9z ZV9idWcoc2VsZiwgYnVnX2lkKToKICAgICAgICAgYnVnX3VybCA9ICd7fXJlc3QvYnVnL3t9Jy5m b3JtYXQoQlVHX1NFUlZFUl9VUkwsIGJ1Z19pZCkKICAgICAgICAgdHJ5OgpAQCAtNTcwLDYgKzU4 MywyMSBAQCBjbGFzcyBWYWxpZGF0ZVBhdGNoKGJ1aWxkc3RlcC5CdWlsZFN0ZXAsCiAgICAgICAg IHJldHVybiBOb25lCiAKIAorY2xhc3MgU2V0Q29tbWl0UXVldWVNaW51c0ZsYWdPblBhdGNoKGJ1 aWxkc3RlcC5CdWlsZFN0ZXAsIEJ1Z3ppbGxhTWl4aW4pOgorICAgIG5hbWUgPSAnc2V0LWNxLW1p bnVzLWZsYWctb24tcGF0Y2gnCisKKyAgICBkZWYgc3RhcnQoc2VsZik6CisgICAgICAgIHBhdGNo X2lkID0gc2VsZi5nZXRQcm9wZXJ0eSgncGF0Y2hfaWQnLCAnJykKKyAgICAgICAgcmMgPSBzZWxm LnNldF9jcV9taW51c19mbGFnX29uX3BhdGNoKHBhdGNoX2lkKQorICAgICAgICBzZWxmLmZpbmlz aGVkKHJjKQorICAgICAgICByZXR1cm4gTm9uZQorCisgICAgZGVmIGdldFJlc3VsdFN1bW1hcnko c2VsZik6CisgICAgICAgIGlmIHNlbGYucmVzdWx0cyA9PSBTVUNDRVNTOgorICAgICAgICAgICAg cmV0dXJuIHt1J3N0ZXAnOiB1J1NldCBjcS0gZmxhZyBvbiBwYXRjaCd9CisgICAgICAgIHJldHVy biB7dSdzdGVwJzogdSdGYWlsZWQgdG8gc2V0IGNxLSBmbGFnIG9uIHBhdGNoJ30KKworCiBjbGFz cyBSZW1vdmVGbGFnc09uUGF0Y2goYnVpbGRzdGVwLkJ1aWxkU3RlcCwgQnVnemlsbGFNaXhpbik6 CiAgICAgbmFtZSA9ICdyZW1vdmUtZmxhZ3MtZnJvbS1wYXRjaCcKICAgICBmbHVua09uRmFpbHVy ZSA9IEZhbHNlCg==