208015 2020-02-20 10:31:36 -0800 REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page 2020-02-20 12:06:24 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 207189 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1621283 0 cdumez 2020-02-20 10:31:36 -0800 Reloading tab with beforeunload prompt closes tab when asking to stay on page since r255677. 1621285 1 cdumez 2020-02-20 10:31:50 -0800 <rdar://problem/59591630> 1621288 2 391304 cdumez 2020-02-20 10:45:08 -0800 Created attachment 391304 Patch 1621289 3 391304 ggaren 2020-02-20 10:48:23 -0800 Comment on attachment 391304 Patch r=me 1621346 4 391304 commit-queue 2020-02-20 12:06:23 -0800 Comment on attachment 391304 Patch Clearing flags on attachment: 391304 Committed r257077: <https://trac.webkit.org/changeset/257077> 1621347 5 commit-queue 2020-02-20 12:06:24 -0800 All reviewed patches have been landed. Closing bug. 391304 2020-02-20 10:45:08 -0800 2020-02-20 12:06:23 -0800 Patch bug-208015-20200220104508.patch text/plain 5312 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAxZGExMWQ5ZGFmMDI2OWE5 YWJmZWM4NGIyZGUxZjgwN2Y5NGZmN2MuLjc5NjdjMGNiMTQ4NzRjZjAwNTk3ZGUyMDczZWViNDQ4 YTY0MDkxZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDItMjAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjU1Njc3KTog UmVsb2FkaW5nIHRhYiB3aXRoIGJlZm9yZXVubG9hZCBwcm9tcHQgY2xvc2VzIHRhYiB3aGVuIGFz a2luZyB0byBzdGF5IG9uIHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwODAxNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk1OTE2MzA+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJl IHdlIG9ubHkgcmVzdGFydCB0aGUgdHJ5Q2xvc2UgdGltZXIgYWZ0ZXIgdGhlIGJlZm9yZXVubG9h ZCBwcm9tcHQgaWYgdGhlIHRpbWVyIHdhcyBhY3R1YWxseQorICAgICAgICBhY3RpdmUgYmVmb3Jl IHRoZSBwcm9tcHQgKGkuZS4gdHJ5Q2xvc2Ugd2FzIGFjdHVhbGx5IGNhbGxlZCkuIE9uIFJlbG9h ZCwgdHJ5Q2xvc2UgaXMgbm90IGNhbGxlZAorICAgICAgICBidXQgYmVmb3JldW5sb2FkIHByb21w dCBtYXkgc3RpbGwgaGFwcGVuLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cnVuQmVmb3JlVW5sb2FkQ29uZmly bVBhbmVsKToKKwogMjAyMC0wMi0yMCAgSmFzb24gTGF3cmVuY2UgIDxsYXdyZW5jZS5qQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjU3MDI1LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggNjVjZGJmZmNkMTMzOWMyZWI5 NjFhNGNhM2E2ODYzNDEyMzNkMTExZS4uODU5ZDQ2ZTQ0NDEwNTA3ZTQ4YTRlOGExN2Q4MTljODNm MmJhN2FjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC01 Njk3LDEwICs1Njk3LDExIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpydW5CZWZvcmVVbmxvYWRDb25m aXJtUGFuZWwoRnJhbWVJZGVudGlmaWVyIGZyYW1lSUQsIFNlY3VyaXR5CiAKICAgICAvLyBTaW5j ZSBydW5CZWZvcmVVbmxvYWRDb25maXJtUGFuZWwoKSBjYW4gc3BpbiBhIG5lc3RlZCBydW4gbG9v cCB3ZSBuZWVkIHRvIHR1cm4gb2ZmIHRoZSByZXNwb25zaXZlbmVzcyB0aW1lciBhbmQgdGhlIHRy eUNsb3NlIHRpbWVyLgogICAgIG1fcHJvY2Vzcy0+c3RvcFJlc3BvbnNpdmVuZXNzVGltZXIoKTsK KyAgICBib29sIHNob3VsZFJlc3VtZVRpbWVyQWZ0ZXJQcm9tcHQgPSBtX3RyeUNsb3NlVGltZW91 dFRpbWVyLmlzQWN0aXZlKCk7CiAgICAgbV90cnlDbG9zZVRpbWVvdXRUaW1lci5zdG9wKCk7CiAg ICAgbV91aUNsaWVudC0+cnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVsKCp0aGlzLCBtZXNzYWdl LCBmcmFtZSwgV1RGTW92ZShzZWN1cml0eU9yaWdpbiksCi0gICAgICAgIFt0aGlzLCB3ZWFrVGhp cyA9IG1ha2VXZWFrUHRyKCp0aGlzKSwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKHJlcGx5 KV0oYm9vbCBzaG91bGRDbG9zZSkgbXV0YWJsZSB7Ci0gICAgICAgICAgICBpZiAod2Vha1RoaXMp CisgICAgICAgIFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKSwgY29tcGxldGlv bkhhbmRsZXIgPSBXVEZNb3ZlKHJlcGx5KSwgc2hvdWxkUmVzdW1lVGltZXJBZnRlclByb21wdF0o Ym9vbCBzaG91bGRDbG9zZSkgbXV0YWJsZSB7CisgICAgICAgICAgICBpZiAod2Vha1RoaXMgJiYg c2hvdWxkUmVzdW1lVGltZXJBZnRlclByb21wdCkKICAgICAgICAgICAgICAgICBtX3RyeUNsb3Nl VGltZW91dFRpbWVyLnN0YXJ0T25lU2hvdCh0cnlDbG9zZVRpbWVvdXREZWxheSk7CiAgICAgICAg ICAgICBjb21wbGV0aW9uSGFuZGxlcihzaG91bGRDbG9zZSk7CiAgICAgfSk7CmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzMzM2NlNzlhNjUyY2Nm MDkwMGU0ZTRiMTE3NzY1N2YzMzMzYzAzOC4uZmI1OTI4OTZiMDM0Njc1YjkxYjVhMmMwYzE0NjY2 YjI5YzNlYzMzMiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAyLTIwICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1NTY3Nyk6IFJlbG9hZGluZyB0YWIg d2l0aCBiZWZvcmV1bmxvYWQgcHJvbXB0IGNsb3NlcyB0YWIgd2hlbiBhc2tpbmcgdG8gc3RheSBv biBwYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDgwMTUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5NTkxNjMwPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBBUEkgdGVzdCBjb3ZlcmFnZS4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTW9kYWxBbGVydHMu bW06CisgICAgICAgIChURVNUKToKKwogMjAyMC0wMi0yMCAgSm9uYXRoYW4gQmVkYXJkICA8amJl ZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcmVzdWx0cy53ZWJraXQub3JnOiBDb3JyZWN0bHkg cmVwb3J0IEpTQyB0ZXN0cyBmb3Igd2luZG93cyAoRm9sbG93LXVwIGZpeCkKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTW9kYWxBbGVydHMubW0gYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL01vZGFsQWxlcnRzLm1tCmluZGV4 IDBiMWIxNWUxODU4YzMzNTBkYzUwODk4YTFmMjhhYjhlNTk4YWQ2YWMuLjRiYTU5M2E1MmEwNzk3 OWNkYjQyODM2MzZhMTQxZDE0ZjA1NTU2NDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvTW9kYWxBbGVydHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Nb2RhbEFsZXJ0cy5tbQpAQCAtMjE1LDYgKzIxNSw1NiBA QCBURVNUKFdlYktpdCwgU2xvd0JlZm9yZVVubG9hZFByb21wdEFsbG93KQogICAgICAgICBUZXN0 V2ViS2l0QVBJOjpVdGlsOjpzbGVlcCgwLjEpOwogfQogCitURVNUKFdlYktpdCwgQmVmb3JlVW5s b2FkUHJvbXB0UmVqZWN0T25SZWxvYWQpCit7CisgICAgYXV0byBzbG93QmVmb3JlVW5sb2FkUHJv bXB0VUlEZWxlZ2F0ZSA9IGFkb3B0TlMoW1tTbG93QmVmb3JlVW5sb2FkUHJvbXB0VUlEZWxlZ2F0 ZSBhbGxvY10gaW5pdF0pOworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJW aWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApXSk7Cisg ICAgW3dlYlZpZXcgc2V0VUlEZWxlZ2F0ZTpzbG93QmVmb3JlVW5sb2FkUHJvbXB0VUlEZWxlZ2F0 ZS5nZXQoKV07CisgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOkAi YmVmb3JldW5sb2FkIl07CisKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpzcGluUnVuTG9vcCgx MCk7CisKKyAgICAvLyBOZWVkIGEgdXNlciBnZXN0dXJlIG9uIHRoZSBwYWdlIGJlZm9yZSBiZWlu ZyBhbGxvd2VkIHRvIHNob3cgdGhlIGJlZm9yZXVubG9hZCBwcm9tcHQuCisgICAgW3dlYlZpZXcg c2VuZENsaWNrc0F0UG9pbnQ6TlNNYWtlUG9pbnQoNSwgNSkgbnVtYmVyT2ZDbGlja3M6MV07CisK KyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpzcGluUnVuTG9vcCgxMCk7CisKKyAgICBzaG91bGRS ZWplY3RDbG9zaW5nVmlhUHJvbXB0ID0gdHJ1ZTsKKyAgICBbd2ViVmlldyByZWxvYWRdOworCisg ICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkaWRSZXNwb25kVG9Qcm9tcHQpOworCisgICAg RVhQRUNUX0ZBTFNFKFt3ZWJWaWV3IF9pc0Nsb3NlZF0pOworCisgICAgVGVzdFdlYktpdEFQSTo6 VXRpbDo6c2xlZXAoMC4xKTsKKyAgICBFWFBFQ1RfRkFMU0UoW3dlYlZpZXcgX2lzQ2xvc2VkXSk7 Cit9CisKK1RFU1QoV2ViS2l0LCBCZWZvcmVVbmxvYWRQcm9tcHRBbGxvd09uUmVsb2FkKQorewor ICAgIGF1dG8gc2xvd0JlZm9yZVVubG9hZFByb21wdFVJRGVsZWdhdGUgPSBhZG9wdE5TKFtbU2xv d0JlZm9yZVVubG9hZFByb21wdFVJRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICBhdXRvIHdl YlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01h a2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOworICAgIFt3ZWJWaWV3IHNldFVJRGVsZWdhdGU6c2xv d0JlZm9yZVVubG9hZFByb21wdFVJRGVsZWdhdGUuZ2V0KCldOworICAgIFt3ZWJWaWV3IHN5bmNo cm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpAImJlZm9yZXVubG9hZCJdOworCisgICAgVGVzdFdl YktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3AoMTApOworCisgICAgLy8gTmVlZCBhIHVzZXIgZ2Vz dHVyZSBvbiB0aGUgcGFnZSBiZWZvcmUgYmVpbmcgYWxsb3dlZCB0byBzaG93IHRoZSBiZWZvcmV1 bmxvYWQgcHJvbXB0LgorICAgIFt3ZWJWaWV3IHNlbmRDbGlja3NBdFBvaW50Ok5TTWFrZVBvaW50 KDUsIDUpIG51bWJlck9mQ2xpY2tzOjFdOworCisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6c3Bp blJ1bkxvb3AoMTApOworCisgICAgc2hvdWxkUmVqZWN0Q2xvc2luZ1ZpYVByb21wdCA9IGZhbHNl OworICAgIFt3ZWJWaWV3IHJlbG9hZF07CisKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4o JmRpZFJlc3BvbmRUb1Byb21wdCk7CisKKyAgICBFWFBFQ1RfRkFMU0UoW3dlYlZpZXcgX2lzQ2xv c2VkXSk7CisKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpzbGVlcCgwLjEpOworICAgIEVYUEVD VF9GQUxTRShbd2ViVmlldyBfaXNDbG9zZWRdKTsKK30KKwogc3RhdGljIGJvb2wgd2ViVmlld0Rp ZENsb3NlQ2FsbGVkID0gZmFsc2U7CiBzdGF0aWMgdW5zaWduZWQgdmlld0RpZENsb3NlQ2FsbENv dW50ID0gMDsKIAo=