208013 2020-02-20 10:10:18 -0800 [First paint] Let's check visually-non-empty state in FrameView::styleAndRenderTreeDidChange 2020-02-20 13:14:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1621271 0 zalan 2020-02-20 10:10:18 -0800 now that qualifiesAsVisuallyNonEmpty() does not depend on geometry anymore. 1621272 1 webkit-bug-importer 2020-02-20 10:10:48 -0800 <rdar://problem/59633427> 1621278 2 391301 zalan 2020-02-20 10:22:41 -0800 Created attachment 391301 Patch 1621390 3 391301 commit-queue 2020-02-20 13:14:56 -0800 Comment on attachment 391301 Patch Clearing flags on attachment: 391301 Committed r257081: <https://trac.webkit.org/changeset/257081> 1621391 4 commit-queue 2020-02-20 13:14:57 -0800 All reviewed patches have been landed. Closing bug. 391301 2020-02-20 10:22:41 -0800 2020-02-20 13:14:56 -0800 Patch bug-208013-20200220102241.patch text/plain 3007 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGFhZmU3MjI4MzBjMzVm MDA4YTVlYzAwODM0ZDU1OTM1MjlkZTdlZi4uYjg3ZDQ2MWMyN2QzZWM1NDFjNGExMmNjNTZhMTM5 MDI1MjRmNmJjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAyLTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZpcnN0IHBhaW50XSBMZXQn cyBjaGVjayB2aXN1YWxseS1ub24tZW1wdHkgc3RhdGUgaW4gRnJhbWVWaWV3OjpzdHlsZUFuZFJl bmRlclRyZWVEaWRDaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwODAxMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk2MzM0Mjc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBj b21wbGV0ZWx5IGRlY291cGxlcyBtX2NvbnRlbnRRdWFsaWZpZXNBc1Zpc3VhbGx5Tm9uRW1wdHkg YW5kIG1fZmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0TWlsZXN0b25lSXNQZW5kaW5nLgorICAg ICAgICBOb3cgRnJhbWVWaWV3IGNhbiBiZSBpbiB0aGUgc3RhdGUgd2hlcmUgbV9jb250ZW50UXVh bGlmaWVzQXNWaXN1YWxseU5vbkVtcHR5IGlzIHRydWUgd2hpbGUKKyAgICAgICAgbV9maXJzdFZp c3VhbGx5Tm9uRW1wdHlMYXlvdXRNaWxlc3RvbmVJc1BlbmRpbmcgaXMgZmFsc2UgKHdoaWNoIGlz IGEgcGVyZmVjdGx5IHZhbGlkIHN0YXRlIHRvIGJlIGluKS4KKyAgICAgICAgVGhpcyB3aWxsIGVu YWJsZSB1cyB0byBkZWxheSBvcHRpb25hbCBsYXlvdXRzIGFmdGVyIHN0eWxlIHJlY2FsY3Mgd2hl biB0aGUgY29udGVudCBpcyBzdGlsbCB2aXN1YWxseSBlbXB0eS4KKyAgICAgICAgKElmIGEgRnJh bWVWaWV3Ojppc1Zpc3VhbGx5Tm9uRW1wdHkoKSBjYWxsZXIgcmVncmVzc2VzIGFmdGVyIHRoaXMg Y2hhbmdlLCBpdCBtZWFucyB0aGF0IHRoZSBjYWxsZXIgaXMgaW50ZXJlc3RlZCBpbgorICAgICAg ICB3aGV0aGVyIHRoZSBub24tZW1wdHkgbWlsZXN0b25lIGhhcyBiZWVuIGlzc3VlZCBvciBub3Qg YW5kIGl0IG5lZWRzIHRvIHN3aXRjaCBvdmVyIHRvIGEgZGlmZmVyZW50IEFQSS4pCisKKyAgICAg ICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnN0 eWxlQW5kUmVuZGVyVHJlZURpZENoYW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6 OmxvYWRQcm9ncmVzc2luZ1N0YXR1c0NoYW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVW aWV3OjpmaXJlTGF5b3V0UmVsYXRlZE1pbGVzdG9uZXNJZk5lZWRlZCk6CisKIDIwMjAtMDItMjAg IFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBTb21ldGlt ZXMgc3ViZnJhbWVzIGRvbid0IGV2ZW4gaGF2ZSBkb2N1bWVudCBlbGVtZW50cy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAppbmRleCBjYmVmNDc3NjY0NWIxOGJmZjMxZGYyZTNlOWMxZTA3YmI2 NzhmZDRlLi4yNGVjMWY4MzEzMjU3NjNhNDZlNjUwNzI1MjA0ZWIyNmI3ZWRiZTFlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC04MDcsNiArODA3LDEwIEBAIHZvaWQgRnJhbWVWaWV3 OjpzdHlsZUFuZFJlbmRlclRyZWVEaWRDaGFuZ2UoKQogICAgIGlmICghcmVuZGVyVmlldykKICAg ICAgICAgcmV0dXJuOwogCisgICAgaWYgKCFtX2NvbnRlbnRRdWFsaWZpZXNBc1Zpc3VhbGx5Tm9u RW1wdHkpIHsKKyAgICAgICAgLy8gTGV0J3MgY2hlY2sgd2hldGhlciB0aGUgbmV3bHkgY29uc3Ry dWN0ZWQgY29udGVudCBxdWFsaWZpZXMgYXMgbm9uLWVtcHR5IG5vdy4KKyAgICAgICAgbV9jb250 ZW50UXVhbGlmaWVzQXNWaXN1YWxseU5vbkVtcHR5ID0gcXVhbGlmaWVzQXNWaXN1YWxseU5vbkVt cHR5KCk7CisgICAgfQogICAgIGF1dG8qIGxheWVyVHJlZU11dGF0aW9uUm9vdCA9IHJlbmRlclZp ZXctPnRha2VTdHlsZUNoYW5nZUxheWVyVHJlZU11dGF0aW9uUm9vdCgpOwogICAgIGlmIChsYXll clRyZWVNdXRhdGlvblJvb3QgJiYgIW5lZWRzTGF5b3V0KCkpCiAgICAgICAgIGxheWVyVHJlZU11 dGF0aW9uUm9vdC0+dXBkYXRlTGF5ZXJQb3NpdGlvbnNBZnRlclN0eWxlQ2hhbmdlKCk7CkBAIC01 MTM3LDggKzUxNDEsMTAgQEAgdm9pZCBGcmFtZVZpZXc6OmZpcmVMYXlvdXRSZWxhdGVkTWlsZXN0 b25lc0lmTmVlZGVkKCkKICAgICB9CiAKICAgICBpZiAobV9maXJzdFZpc3VhbGx5Tm9uRW1wdHlM YXlvdXRNaWxlc3RvbmVJc1BlbmRpbmcpIHsKLSAgICAgICAgaWYgKCFtX2NvbnRlbnRRdWFsaWZp ZXNBc1Zpc3VhbGx5Tm9uRW1wdHkgJiYgcXVhbGlmaWVzQXNWaXN1YWxseU5vbkVtcHR5KCkpIHsK LSAgICAgICAgICAgIG1fY29udGVudFF1YWxpZmllc0FzVmlzdWFsbHlOb25FbXB0eSA9IHRydWU7 CisgICAgICAgIGlmICghbV9jb250ZW50UXVhbGlmaWVzQXNWaXN1YWxseU5vbkVtcHR5KQorICAg ICAgICAgICAgbV9jb250ZW50UXVhbGlmaWVzQXNWaXN1YWxseU5vbkVtcHR5ID0gcXVhbGlmaWVz QXNWaXN1YWxseU5vbkVtcHR5KCk7CisKKyAgICAgICAgaWYgKG1fY29udGVudFF1YWxpZmllc0Fz VmlzdWFsbHlOb25FbXB0eSkgewogICAgICAgICAgICAgbV9maXJzdFZpc3VhbGx5Tm9uRW1wdHlM YXlvdXRNaWxlc3RvbmVJc1BlbmRpbmcgPSBmYWxzZTsKIAogICAgICAgICAgICAgYWRkUGFpbnRQ ZW5kaW5nTWlsZXN0b25lcyhEaWRGaXJzdE1lYW5pbmdmdWxQYWludCk7Cg==