207967 2020-02-19 15:01:07 -0800 Resources larger than 10MB are not stored in the disk cache 2020-02-20 12:27:36 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 207959 1 cdumez cdumez achristensen commit-queue darin ggaren koivisto webkit-bug-importer oldest_to_newest 1620886 0 cdumez 2020-02-19 15:01:07 -0800 Resources larger than 10MB are not stored in the disk cache. 1620887 1 cdumez 2020-02-19 15:01:21 -0800 <rdar://problem/59572084> 1620890 2 391206 cdumez 2020-02-19 15:06:34 -0800 Created attachment 391206 Patch 1621088 3 commit-queue 2020-02-19 22:07:46 -0800 The commit-queue encountered the following flaky tests while processing attachment 391206: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1621090 4 391206 commit-queue 2020-02-19 22:08:16 -0800 Comment on attachment 391206 Patch Clearing flags on attachment: 391206 Committed r257041: <https://trac.webkit.org/changeset/257041> 1621091 5 commit-queue 2020-02-19 22:08:18 -0800 All reviewed patches have been landed. Closing bug. 1621356 6 391206 koivisto 2020-02-20 12:27:36 -0800 Comment on attachment 391206 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391206&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:588 > - // Prevent memory growth in case of streaming data. > - const size_t maximumCacheBufferSize = 10 * 1024 * 1024; > + // Prevent memory growth in case of streaming data and limit size of entries in the cache. > + const size_t maximumCacheBufferSize = m_cache->capacity() / 8; If the capacity computes to less than the 80MB this will reduce the maximum size. Can that be a problem? > Source/WebKit/Shared/CacheModel.cpp:188 > - urlCacheDiskCapacity = 500 * MB; > + urlCacheDiskCapacity = 1 * GB; Maybe also increment DocumentBrowser cache model similarly? 391206 2020-02-19 15:06:34 -0800 2020-02-19 22:08:16 -0800 Patch bug-207967-20200219150633.patch text/plain 3394 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjZThjMGM2ZWE2MTcyMGRj OGMxNzNmMzUzZmRiMDAwNTllMjExY2IuLjVhOWZlNTNiZmM1NmExOTVhNDE3NjI2YTQ1NmY3NDdm ZDk3MWQxNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDItMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXNvdXJjZXMgbGFyZ2VyIHRoYW4g MTBNQiBhcmUgbm90IHN0b3JlZCBpbiB0aGUgZGlzayBjYWNoZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3OTY3CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81OTU3MjA4ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHR3byBwb2xpY3kgY2hhbmdlcyB0byBvdXIgZGlzayBj YWNoZToKKyAgICAgICAgMS4gVGhlIGNhcGFjaXR5IG9mIHRoZSBkaXNrIGNhY2hlIGlzIG5vdyBk b3VibGVkLiBCYXNlZCBvbiBhdmFpbGFibGUgZGlzayBzcGFjZSwgaXQgY291bGQKKyAgICAgICAg ICAgcHJldmlvdXNseSB1c2UgdXAgdG8gNTAwTUIgb2YgZGlzayBzcGFjZS4gVGhlIGxpbWl0IGlz IG5vdyAxR0IuCisgICAgICAgIDIuIFRoZSBwZXIgY2FjaGUtZW50cnkgbGltaXQgaXMgcmFpc2Vk IGZyb20gMTBNQiB0byAxLzggb2YgdGhlIGRpc2sgY2FjaGUgY2FwYWNpdHkgKHNvCisgICAgICAg ICAgIHVwIHRvIDEyOE1CIGJhc2VkIG9uIG5ldyBtYXhpbXVtIGNhcGFjaXR5KS4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChX ZWJLaXQ6Ok5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZUJ1ZmZlcik6CisgICAgICAg ICogU2hhcmVkL0NhY2hlTW9kZWwuY3BwOgorICAgICAgICAoV2ViS2l0OjpjYWxjdWxhdGVVUkxD YWNoZVNpemVzKToKKwogMjAyMC0wMi0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjI0NzU2NykgSFRUUCBEaXNrIGNhY2hlIGNhcGFjaXR5 IGlzIG5vIGxvbmdlciBzZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCBhYTQyN2NmOGUzMTcwYmQzNTY5Yjc2 NDEwYmUwMDJhNGYwNjA5N2MzLi5mZjNhYmQ5OTM4OTFlN2JhMDhkZmY4YTIzYmU3ZjA5YjhhZjkz ODM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNv dXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr UmVzb3VyY2VMb2FkZXIuY3BwCkBAIC01ODQsOCArNTg0LDggQEAgdm9pZCBOZXR3b3JrUmVzb3Vy Y2VMb2FkZXI6OmRpZFJlY2VpdmVCdWZmZXIoUmVmPFNoYXJlZEJ1ZmZlcj4mJiBidWZmZXIsIGlu dCByZXAKICAgICBBU1NFUlQoIW1fY2FjaGVFbnRyeUZvclZhbGlkYXRpb24pOwogCiAgICAgaWYg KG1fYnVmZmVyZWREYXRhRm9yQ2FjaGUpIHsKLSAgICAgICAgLy8gUHJldmVudCBtZW1vcnkgZ3Jv d3RoIGluIGNhc2Ugb2Ygc3RyZWFtaW5nIGRhdGEuCi0gICAgICAgIGNvbnN0IHNpemVfdCBtYXhp bXVtQ2FjaGVCdWZmZXJTaXplID0gMTAgKiAxMDI0ICogMTAyNDsKKyAgICAgICAgLy8gUHJldmVu dCBtZW1vcnkgZ3Jvd3RoIGluIGNhc2Ugb2Ygc3RyZWFtaW5nIGRhdGEgYW5kIGxpbWl0IHNpemUg b2YgZW50cmllcyBpbiB0aGUgY2FjaGUuCisgICAgICAgIGNvbnN0IHNpemVfdCBtYXhpbXVtQ2Fj aGVCdWZmZXJTaXplID0gbV9jYWNoZS0+Y2FwYWNpdHkoKSAvIDg7CiAgICAgICAgIGlmIChtX2J1 ZmZlcmVkRGF0YUZvckNhY2hlLT5zaXplKCkgKyBidWZmZXItPnNpemUoKSA8PSBtYXhpbXVtQ2Fj aGVCdWZmZXJTaXplKQogICAgICAgICAgICAgbV9idWZmZXJlZERhdGFGb3JDYWNoZS0+YXBwZW5k KGJ1ZmZlci5nZXQoKSk7CiAgICAgICAgIGVsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL0NhY2hlTW9kZWwuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ2FjaGVNb2RlbC5j cHAKaW5kZXggOWNiZDZhYjlhYzEwOTU3Njg2YmFkYzAzMjE3ZDFkNjFlMjQ4YjE2OC4uYzNkYWYz MWViZjUwOGQ3MTM4NWNiZmNhN2QzMTBlMjIyNWE2MjE3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9TaGFyZWQvQ2FjaGVNb2RlbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ2Fj aGVNb2RlbC5jcHAKQEAgLTE4NSwxNyArMTg1LDE3IEBAIHZvaWQgY2FsY3VsYXRlVVJMQ2FjaGVT aXplcyhDYWNoZU1vZGVsIGNhY2hlTW9kZWwsIHVpbnQ2NF90IGRpc2tGcmVlU2l6ZSwgdW5zaWdu CiAKICAgICAgICAgLy8gRGlzayBjYWNoZSBjYXBhY2l0eSAoaW4gYnl0ZXMpCiAgICAgICAgIGlm IChkaXNrRnJlZVNpemUgPj0gMTYzODQpCi0gICAgICAgICAgICB1cmxDYWNoZURpc2tDYXBhY2l0 eSA9IDUwMCAqIE1COworICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkgPSAxICogR0I7 CiAgICAgICAgIGVsc2UgaWYgKGRpc2tGcmVlU2l6ZSA+PSA4MTkyKQotICAgICAgICAgICAgdXJs Q2FjaGVEaXNrQ2FwYWNpdHkgPSAyNTAgKiBNQjsKKyAgICAgICAgICAgIHVybENhY2hlRGlza0Nh cGFjaXR5ID0gNTAwICogTUI7CiAgICAgICAgIGVsc2UgaWYgKGRpc2tGcmVlU2l6ZSA+PSA0MDk2 KQotICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkgPSAxMjUgKiBNQjsKKyAgICAgICAg ICAgIHVybENhY2hlRGlza0NhcGFjaXR5ID0gMjUwICogTUI7CiAgICAgICAgIGVsc2UgaWYgKGRp c2tGcmVlU2l6ZSA+PSAyMDQ4KQotICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkgPSAx MDAgKiBNQjsKKyAgICAgICAgICAgIHVybENhY2hlRGlza0NhcGFjaXR5ID0gMjAwICogTUI7CiAg ICAgICAgIGVsc2UgaWYgKGRpc2tGcmVlU2l6ZSA+PSAxMDI0KQotICAgICAgICAgICAgdXJsQ2Fj aGVEaXNrQ2FwYWNpdHkgPSA3NSAqIE1COworICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNp dHkgPSAxNTAgKiBNQjsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2Fw YWNpdHkgPSA1MCAqIE1COworICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkgPSAxMDAg KiBNQjsKIAogICAgICAgICBicmVhazsKICAgICB9Cg==