207964 2020-02-19 14:30:25 -0800 Avoid preconnecting to custom URL schemes 2020-02-19 17:12:33 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 nham nham beidson cdumez commit-queue nham rniwa webkit-bug-importer oldest_to_newest 1620867 0 nham 2020-02-19 14:30:25 -0800 NetworkProcess::preconnectTo preconnects to custom URL schemes, while NetworkConnectionToWebProcess::preconnectTo does not. The former's behavior should match the latter's. This will also fix the debug test failures in TestWebKitAPI.WebKit.DownloadNavigationResponseFromMemoryCache and TestWebKitAPI.ContentFiltering.LazilyLoadPlatformFrameworks introduced by https://bugs.webkit.org/show_bug.cgi?id=207777. The reason for the debug test failure is that both of these tests register a custom HTTP scheme handler, and the scheme handlers are returning responses to the preconnect request which is causing the assert in PreconnectTask::didReceiveResponse to fire. 1620868 1 webkit-bug-importer 2020-02-19 14:30:57 -0800 <rdar://problem/59606178> 1620925 2 391214 nham 2020-02-19 16:03:23 -0800 Created attachment 391214 Patch 1620928 3 391217 nham 2020-02-19 16:17:13 -0800 Created attachment 391217 Patch 1620961 4 391217 commit-queue 2020-02-19 17:12:31 -0800 Comment on attachment 391217 Patch Clearing flags on attachment: 391217 Committed r257008: <https://trac.webkit.org/changeset/257008> 1620962 5 commit-queue 2020-02-19 17:12:33 -0800 All reviewed patches have been landed. Closing bug. 391214 2020-02-19 16:03:23 -0800 2020-02-19 16:17:11 -0800 Patch bug-207964-20200219160323.patch text/plain 1783 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZkYTBlYzNiYjUzZDMzNmIx NTE0OGFiNTJkNmU5YTU1OTZjMDcwZGEuLmMwZjFjMGU5MjYzYzEwYTQ3ZTQwZjQ1YTIyNjkyMjNl MGE2MjIxNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMTkgIEJlbiBOaGFt ICA8bmhhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgcHJlY29ubmVjdGluZyB0byBjdXN0 b20gVVJMIHNjaGVtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNzk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgbWFrZXMgTmV0d29ya1Byb2Nlc3M6OnByZWNvbm5lY3RUbyBub3QgcHJlY29u bmVjdCB0byBjdXN0b20gVVJMIHNjaGVtZXMuIFRoaXMgbWF0Y2hlcworICAgICAgICB0aGUgZXhp c3RpbmcgYmVoYXZpb3IgaW4gTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnByZWNvbm5l Y3RUby4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OnByZWNvbm5lY3RUbyk6CisKIDIwMjAtMDIt MTkgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViUGFnZVByb3h5OjpQb2xpY3lEZWNpc2lvblNlbmRlciBzaG91bGQgc2VuZCBhIHN0cnVjdCBp bnN0ZWFkIG9mIG1hbnkgcGFyYW1ldGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL05ldHdvcmtQcm9jZXNzLmNwcAppbmRleCA5MmMxZWE1NTdlNDM5YWRjNzE4ZTYzYWU5MTNi ZjNlYWVhOTU0MGNhLi42YzA5NzkxODgzNGZiN2YxZDY1YTRiYzM0YzkyMTMyOWU3MDhiNzZkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcApA QCAtMTMwNCw2ICsxMzA0LDExIEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnNldEZpcnN0UGFydHlX ZWJzaXRlRGF0YVJlbW92YWxNb2RlRm9yVGVzdGluZyhQQUw6OlNlc3Npb25JCiB2b2lkIE5ldHdv cmtQcm9jZXNzOjpwcmVjb25uZWN0VG8oUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklELCBjb25zdCBV UkwmIHVybCwgY29uc3QgU3RyaW5nJiB1c2VyQWdlbnQsIFdlYkNvcmU6OlN0b3JlZENyZWRlbnRp YWxzUG9saWN5IHN0b3JlZENyZWRlbnRpYWxzUG9saWN5KQogewogI2lmIEVOQUJMRShTRVJWRVJf UFJFQ09OTkVDVCkKKyNpZiBFTkFCTEUoTEVHQUNZX0NVU1RPTV9QUk9UT0NPTF9NQU5BR0VSKQor ICAgIGlmIChzdXBwbGVtZW50PExlZ2FjeUN1c3RvbVByb3RvY29sTWFuYWdlcj4oKS0+c3VwcG9y dHNTY2hlbWUodXJsLnByb3RvY29sKCkudG9TdHJpbmcoKSkpCisgICAgICAgIHJldHVybjsKKyNl bmRpZgorCiAgICAgTmV0d29ya0xvYWRQYXJhbWV0ZXJzIHBhcmFtZXRlcnM7CiAgICAgcGFyYW1l dGVycy5yZXF1ZXN0ID0gUmVzb3VyY2VSZXF1ZXN0IHsgdXJsIH07CiAgICAgaWYgKCF1c2VyQWdl bnQuaXNFbXB0eSgpKSB7Cg== 391217 2020-02-19 16:17:13 -0800 2020-02-19 17:12:31 -0800 Patch bug-207964-20200219161712.patch text/plain 1781 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZkYTBlYzNiYjUzZDMzNmIx NTE0OGFiNTJkNmU5YTU1OTZjMDcwZGEuLmM5OWQwZTg2Zjk3OTI1MmI1YjVmMDgwYmQyYmJiN2Qx ZjYzODQxOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMTkgIEJlbiBOaGFt ICA8bmhhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgcHJlY29ubmVjdGluZyB0byBjdXN0 b20gVVJMIHNjaGVtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNzk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAg ICAgICBUaGlzIG1ha2VzIE5ldHdvcmtQcm9jZXNzOjpwcmVjb25uZWN0VG8gbm90IHByZWNvbm5l Y3QgdG8gY3VzdG9tIFVSTCBzY2hlbWVzLiBUaGlzIG1hdGNoZXMKKyAgICAgICAgdGhlIGV4aXN0 aW5nIGJlaGF2aW9yIGluIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpwcmVjb25uZWN0 VG8uCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHA6CisgICAg ICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpwcmVjb25uZWN0VG8pOgorCiAyMDIwLTAyLTE5 ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YlBhZ2VQcm94eTo6UG9saWN5RGVjaXNpb25TZW5kZXIgc2hvdWxkIHNlbmQgYSBzdHJ1Y3QgaW5z dGVhZCBvZiBtYW55IHBhcmFtZXRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXggOTJjMWVhNTU3ZTQzOWFkYzcxOGU2M2FlOTEzYmYz ZWFlYTk1NDBjYS4uNmMwOTc5MTg4MzRmYjdmMWQ2NWE0YmMzNGM5MjEzMjllNzA4Yjc2ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKQEAg LTEzMDQsNiArMTMwNCwxMSBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpzZXRGaXJzdFBhcnR5V2Vi c2l0ZURhdGFSZW1vdmFsTW9kZUZvclRlc3RpbmcoUEFMOjpTZXNzaW9uSQogdm9pZCBOZXR3b3Jr UHJvY2Vzczo6cHJlY29ubmVjdFRvKFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCwgY29uc3QgVVJM JiB1cmwsIGNvbnN0IFN0cmluZyYgdXNlckFnZW50LCBXZWJDb3JlOjpTdG9yZWRDcmVkZW50aWFs c1BvbGljeSBzdG9yZWRDcmVkZW50aWFsc1BvbGljeSkKIHsKICNpZiBFTkFCTEUoU0VSVkVSX1BS RUNPTk5FQ1QpCisjaWYgRU5BQkxFKExFR0FDWV9DVVNUT01fUFJPVE9DT0xfTUFOQUdFUikKKyAg ICBpZiAoc3VwcGxlbWVudDxMZWdhY3lDdXN0b21Qcm90b2NvbE1hbmFnZXI+KCktPnN1cHBvcnRz U2NoZW1lKHVybC5wcm90b2NvbCgpLnRvU3RyaW5nKCkpKQorICAgICAgICByZXR1cm47CisjZW5k aWYKKwogICAgIE5ldHdvcmtMb2FkUGFyYW1ldGVycyBwYXJhbWV0ZXJzOwogICAgIHBhcmFtZXRl cnMucmVxdWVzdCA9IFJlc291cmNlUmVxdWVzdCB7IHVybCB9OwogICAgIGlmICghdXNlckFnZW50 LmlzRW1wdHkoKSkgewo=