207958 2020-02-19 13:24:39 -0800 [WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange] must run on the main thread. 2020-02-20 06:07:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach commit-queue darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1620834 0 andresg_22 2020-02-19 13:24:39 -0800 [WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange] must run on the main thread. 1620838 1 391195 andresg_22 2020-02-19 13:33:41 -0800 Created attachment 391195 Patch 1621179 2 391195 commit-queue 2020-02-20 06:06:30 -0800 Comment on attachment 391195 Patch Clearing flags on attachment: 391195 Committed r257052: <https://trac.webkit.org/changeset/257052> 1621180 3 commit-queue 2020-02-20 06:06:31 -0800 All reviewed patches have been landed. Closing bug. 1621182 4 webkit-bug-importer 2020-02-20 06:07:18 -0800 <rdar://problem/59627282> 391195 2020-02-19 13:33:41 -0800 2020-02-20 06:06:30 -0800 Patch bug-207958-20200219163340.patch text/plain 6345 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWNhNDFkZWNhZDdhMzRm MDEyMzIzYWQ4NGQzNzQyZDZkYTA0ODI1My4uMGU5NjZjMzVkMzNmYmFmNDdkZjQwMmZkMGExODA0 MDkyYjljMTc0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAyLTE5ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXIgZG9BWEF0dHJpYnV0ZWRTdHJpbmdGb3JUZXh0TWFya2VyUmFu Z2VdIG11c3QgcnVuIG9uIHRoZSBtYWluIHRocmVhZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzk1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAg ICAgICAgW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGRvQVhBdHRyaWJ1dGVkU3RyaW5n Rm9yVGV4dE1hcmtlclJhbmdlXQorICAgICAgICBjYWxscyBpbnRvIFRleHRJdGVyYXRvciBhbmQg Tm9kZSwgdGh1cyBpdCBtdXN0IGJlIGRpc3BhdGNoZWQgdG8gdGhlCisgICAgICAgIG1haW4gdGhy ZWFkLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy IGRvQVhBdHRyaWJ1dGVkU3RyaW5nRm9yVGV4dE1hcmtlclJhbmdlOnNwZWxsQ2hlY2s6XSk6CisK IDIwMjAtMDItMTkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb TEZDXVtGbG9hdHNdIEZsb2F0aW5nQ29udGV4dDo6Y29uc3RyYWludHMgc2hvdWxkIGJlIGFibGUg dG8gaGFuZGxlIGVtcHR5IGNhbmRpZGF0ZSByYW5nZXMgKHBvaW50cykKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJp bGl0eU9iamVjdFdyYXBwZXJNYWMubW0KaW5kZXggNDZlMjZhNmMyYjdhNTJhYjIxODhmZGNiMjU2 NjdjODQ2NmY4MTY0Mi4uNzFlOGQ5Y2EyOGJlOGFlN2JhYjRiZTkwOWUxODMwOTRhYjIxNDlmYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJp bGl0eU9iamVjdFdyYXBwZXJNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0KQEAgLTEyNzcsNDYgKzEy NzcsNDkgQEAgc3RhdGljIE5TU3RyaW5nKiBuc1N0cmluZ0ZvclJlcGxhY2VkTm9kZShOb2RlKiBy ZXBsYWNlZE5vZGUpCiAKIC0gKE5TQXR0cmlidXRlZFN0cmluZyopZG9BWEF0dHJpYnV0ZWRTdHJp bmdGb3JUZXh0TWFya2VyUmFuZ2U6KGlkKXRleHRNYXJrZXJSYW5nZSBzcGVsbENoZWNrOihCT09M KXNwZWxsQ2hlY2sKIHsKLSAgICBpZiAoIXNlbGYuYXhCYWNraW5nT2JqZWN0KQotICAgICAgICBy ZXR1cm4gbmlsOwotICAgIAotICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBbc2VsZiByYW5nZUZv clRleHRNYXJrZXJSYW5nZTp0ZXh0TWFya2VyUmFuZ2VdOwotICAgIE5TTXV0YWJsZUF0dHJpYnV0 ZWRTdHJpbmcqIGF0dHJTdHJpbmcgPSBbW05TTXV0YWJsZUF0dHJpYnV0ZWRTdHJpbmcgYWxsb2Nd IGluaXRdOwotICAgIFRleHRJdGVyYXRvciBpdChyYW5nZS5nZXQoKSk7Ci0gICAgd2hpbGUgKCFp dC5hdEVuZCgpKSB7Ci0gICAgICAgIC8vIGxvY2F0ZSB0aGUgbm9kZSBhbmQgc3RhcnRpbmcgb2Zm c2V0IGZvciB0aGlzIHJhbmdlCi0gICAgICAgIE5vZGUmIG5vZGUgPSBpdC5yYW5nZSgpLT5zdGFy dENvbnRhaW5lcigpOwotICAgICAgICBBU1NFUlQoJm5vZGUgPT0gJml0LnJhbmdlKCktPmVuZENv bnRhaW5lcigpKTsKLSAgICAgICAgaW50IG9mZnNldCA9IGl0LnJhbmdlKCktPnN0YXJ0T2Zmc2V0 KCk7Ci0gICAgICAgIAotICAgICAgICAvLyBub24temVybyBsZW5ndGggbWVhbnMgdGV4dHVhbCBu b2RlLCB6ZXJvIGxlbmd0aCBtZWFucyByZXBsYWNlZCBub2RlIChBS0EgImF0dGFjaG1lbnRzIiBp biBBWCkKLSAgICAgICAgaWYgKGl0LnRleHQoKS5sZW5ndGgoKSkgewotICAgICAgICAgICAgLy8g QWRkIHRoZSB0ZXh0IG9mIHRoZSBsaXN0IG1hcmtlciBpdGVtIGlmIG5lY2Vzc2FyeS4KLSAgICAg ICAgICAgIFN0cmluZyBsaXN0TWFya2VyVGV4dCA9IEFjY2Vzc2liaWxpdHlPYmplY3Q6Omxpc3RN YXJrZXJUZXh0Rm9yTm9kZUFuZFBvc2l0aW9uKCZub2RlLCBWaXNpYmxlUG9zaXRpb24oaXQucmFu Z2UoKS0+c3RhcnRQb3NpdGlvbigpKSk7Ci0gICAgICAgICAgICBpZiAoIWxpc3RNYXJrZXJUZXh0 LmlzRW1wdHkoKSkKLSAgICAgICAgICAgICAgICBBWEF0dHJpYnV0ZWRTdHJpbmdBcHBlbmRUZXh0 KGF0dHJTdHJpbmcsICZub2RlLCBsaXN0TWFya2VyVGV4dCwgc3BlbGxDaGVjayk7Ci0gICAgICAg ICAgICBBWEF0dHJpYnV0ZWRTdHJpbmdBcHBlbmRUZXh0KGF0dHJTdHJpbmcsICZub2RlLCBpdC50 ZXh0KCksIHNwZWxsQ2hlY2spOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgTm9kZSog cmVwbGFjZWROb2RlID0gbm9kZS50cmF2ZXJzZVRvQ2hpbGRBdChvZmZzZXQpOwotICAgICAgICAg ICAgTlNTdHJpbmcgKmF0dGFjaG1lbnRTdHJpbmcgPSBuc1N0cmluZ0ZvclJlcGxhY2VkTm9kZShy ZXBsYWNlZE5vZGUpOwotICAgICAgICAgICAgaWYgKGF0dGFjaG1lbnRTdHJpbmcpIHsKLSAgICAg ICAgICAgICAgICBOU1JhbmdlIGF0dHJTdHJpbmdSYW5nZSA9IE5TTWFrZVJhbmdlKFthdHRyU3Ry aW5nIGxlbmd0aF0sIFthdHRhY2htZW50U3RyaW5nIGxlbmd0aF0pOwotICAgICAgICAgICAgICAg IAotICAgICAgICAgICAgICAgIC8vIGFwcGVuZCB0aGUgcGxhY2Vob2xkZXIgc3RyaW5nCi0gICAg ICAgICAgICAgICAgW1thdHRyU3RyaW5nIG11dGFibGVTdHJpbmddIGFwcGVuZFN0cmluZzphdHRh Y2htZW50U3RyaW5nXTsKLSAgICAgICAgICAgICAgICAKLSAgICAgICAgICAgICAgICAvLyByZW1v dmUgYWxsIGluaGVyaXRlZCBhdHRyaWJ1dGVzCi0gICAgICAgICAgICAgICAgW2F0dHJTdHJpbmcg c2V0QXR0cmlidXRlczpuaWwgcmFuZ2U6YXR0clN0cmluZ1JhbmdlXTsKLSAgICAgICAgICAgICAg ICAKLSAgICAgICAgICAgICAgICAvLyBhZGQgdGhlIGF0dGFjaG1lbnQgYXR0cmlidXRlCi0gICAg ICAgICAgICAgICAgQWNjZXNzaWJpbGl0eU9iamVjdCogb2JqID0gcmVwbGFjZWROb2RlLT5yZW5k ZXJlcigpLT5kb2N1bWVudCgpLmF4T2JqZWN0Q2FjaGUoKS0+Z2V0T3JDcmVhdGUocmVwbGFjZWRO b2RlLT5yZW5kZXJlcigpKTsKLSAgICAgICAgICAgICAgICBBWEF0dHJpYnV0ZVN0cmluZ1NldEVs ZW1lbnQoYXR0clN0cmluZywgTlNBY2Nlc3NpYmlsaXR5QXR0YWNobWVudFRleHRBdHRyaWJ1dGUs IG9iaiwgYXR0clN0cmluZ1JhbmdlKTsKKyAgICByZXR1cm4gQWNjZXNzaWJpbGl0eTo6cmV0cmll dmVWYWx1ZUZyb21NYWluVGhyZWFkPE5TQXR0cmlidXRlZFN0cmluZyAqPihbJnRleHRNYXJrZXJS YW5nZSwgJnNwZWxsQ2hlY2ssIHByb3RlY3RlZFNlbGYgPSBSZXRhaW5QdHI8V2ViQWNjZXNzaWJp bGl0eU9iamVjdFdyYXBwZXI+KHNlbGYpXSAoKSAtPiBOU0F0dHJpYnV0ZWRTdHJpbmcgKiB7Cisg ICAgICAgIGF1dG8qIGJhY2tpbmdPYmplY3QgPSBwcm90ZWN0ZWRTZWxmLmdldCgpLmF4QmFja2lu Z09iamVjdDsKKyAgICAgICAgaWYgKCFiYWNraW5nT2JqZWN0KQorICAgICAgICAgICAgcmV0dXJu IG5pbDsKKworICAgICAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlID0gW3Byb3RlY3RlZFNlbGYgcmFu Z2VGb3JUZXh0TWFya2VyUmFuZ2U6dGV4dE1hcmtlclJhbmdlXTsKKyAgICAgICAgTlNNdXRhYmxl QXR0cmlidXRlZFN0cmluZyogYXR0clN0cmluZyA9IFtbTlNNdXRhYmxlQXR0cmlidXRlZFN0cmlu ZyBhbGxvY10gaW5pdF07CisgICAgICAgIFRleHRJdGVyYXRvciBpdChyYW5nZS5nZXQoKSk7Cisg ICAgICAgIHdoaWxlICghaXQuYXRFbmQoKSkgeworICAgICAgICAgICAgLy8gbG9jYXRlIHRoZSBu b2RlIGFuZCBzdGFydGluZyBvZmZzZXQgZm9yIHRoaXMgcmFuZ2UKKyAgICAgICAgICAgIE5vZGUm IG5vZGUgPSBpdC5yYW5nZSgpLT5zdGFydENvbnRhaW5lcigpOworICAgICAgICAgICAgQVNTRVJU KCZub2RlID09ICZpdC5yYW5nZSgpLT5lbmRDb250YWluZXIoKSk7CisgICAgICAgICAgICBpbnQg b2Zmc2V0ID0gaXQucmFuZ2UoKS0+c3RhcnRPZmZzZXQoKTsKKworICAgICAgICAgICAgLy8gbm9u LXplcm8gbGVuZ3RoIG1lYW5zIHRleHR1YWwgbm9kZSwgemVybyBsZW5ndGggbWVhbnMgcmVwbGFj ZWQgbm9kZSAoQUtBICJhdHRhY2htZW50cyIgaW4gQVgpCisgICAgICAgICAgICBpZiAoaXQudGV4 dCgpLmxlbmd0aCgpKSB7CisgICAgICAgICAgICAgICAgLy8gQWRkIHRoZSB0ZXh0IG9mIHRoZSBs aXN0IG1hcmtlciBpdGVtIGlmIG5lY2Vzc2FyeS4KKyAgICAgICAgICAgICAgICBTdHJpbmcgbGlz dE1hcmtlclRleHQgPSBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpsaXN0TWFya2VyVGV4dEZvck5vZGVB bmRQb3NpdGlvbigmbm9kZSwgVmlzaWJsZVBvc2l0aW9uKGl0LnJhbmdlKCktPnN0YXJ0UG9zaXRp b24oKSkpOworICAgICAgICAgICAgICAgIGlmICghbGlzdE1hcmtlclRleHQuaXNFbXB0eSgpKQor ICAgICAgICAgICAgICAgICAgICBBWEF0dHJpYnV0ZWRTdHJpbmdBcHBlbmRUZXh0KGF0dHJTdHJp bmcsICZub2RlLCBsaXN0TWFya2VyVGV4dCwgc3BlbGxDaGVjayk7CisgICAgICAgICAgICAgICAg QVhBdHRyaWJ1dGVkU3RyaW5nQXBwZW5kVGV4dChhdHRyU3RyaW5nLCAmbm9kZSwgaXQudGV4dCgp LCBzcGVsbENoZWNrKTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgTm9k ZSogcmVwbGFjZWROb2RlID0gbm9kZS50cmF2ZXJzZVRvQ2hpbGRBdChvZmZzZXQpOworICAgICAg ICAgICAgICAgIE5TU3RyaW5nICphdHRhY2htZW50U3RyaW5nID0gbnNTdHJpbmdGb3JSZXBsYWNl ZE5vZGUocmVwbGFjZWROb2RlKTsKKyAgICAgICAgICAgICAgICBpZiAoYXR0YWNobWVudFN0cmlu ZykgeworICAgICAgICAgICAgICAgICAgICBOU1JhbmdlIGF0dHJTdHJpbmdSYW5nZSA9IE5TTWFr ZVJhbmdlKFthdHRyU3RyaW5nIGxlbmd0aF0sIFthdHRhY2htZW50U3RyaW5nIGxlbmd0aF0pOwor CisgICAgICAgICAgICAgICAgICAgIC8vIGFwcGVuZCB0aGUgcGxhY2Vob2xkZXIgc3RyaW5nCisg ICAgICAgICAgICAgICAgICAgIFtbYXR0clN0cmluZyBtdXRhYmxlU3RyaW5nXSBhcHBlbmRTdHJp bmc6YXR0YWNobWVudFN0cmluZ107CisKKyAgICAgICAgICAgICAgICAgICAgLy8gcmVtb3ZlIGFs bCBpbmhlcml0ZWQgYXR0cmlidXRlcworICAgICAgICAgICAgICAgICAgICBbYXR0clN0cmluZyBz ZXRBdHRyaWJ1dGVzOm5pbCByYW5nZTphdHRyU3RyaW5nUmFuZ2VdOworCisgICAgICAgICAgICAg ICAgICAgIC8vIGFkZCB0aGUgYXR0YWNobWVudCBhdHRyaWJ1dGUKKyAgICAgICAgICAgICAgICAg ICAgQWNjZXNzaWJpbGl0eU9iamVjdCogb2JqID0gcmVwbGFjZWROb2RlLT5yZW5kZXJlcigpLT5k b2N1bWVudCgpLmF4T2JqZWN0Q2FjaGUoKS0+Z2V0T3JDcmVhdGUocmVwbGFjZWROb2RlLT5yZW5k ZXJlcigpKTsKKyAgICAgICAgICAgICAgICAgICAgQVhBdHRyaWJ1dGVTdHJpbmdTZXRFbGVtZW50 KGF0dHJTdHJpbmcsIE5TQWNjZXNzaWJpbGl0eUF0dGFjaG1lbnRUZXh0QXR0cmlidXRlLCBvYmos IGF0dHJTdHJpbmdSYW5nZSk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQorICAg ICAgICAgICAgaXQuYWR2YW5jZSgpOwogICAgICAgICB9Ci0gICAgICAgIGl0LmFkdmFuY2UoKTsK LSAgICB9CiAKLSAgICByZXR1cm4gW2F0dHJTdHJpbmcgYXV0b3JlbGVhc2VdOworICAgICAgICBy ZXR1cm4gW2F0dHJTdHJpbmcgYXV0b3JlbGVhc2VdOworICAgIH0pOwogfQogCiBzdGF0aWMgaWQg dGV4dE1hcmtlclJhbmdlRnJvbVZpc2libGVQb3NpdGlvbnMoQVhPYmplY3RDYWNoZSogY2FjaGUs IGNvbnN0IFZpc2libGVQb3NpdGlvbiYgc3RhcnRQb3NpdGlvbiwgY29uc3QgVmlzaWJsZVBvc2l0 aW9uJiBlbmRQb3NpdGlvbikK