207933 2020-02-19 03:38:51 -0800 [Linux] StackTrace symbols are not demangled 2020-02-25 01:20:17 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand benjamin cdumez cmarcelo dbates ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1620621 0 pnormand 2020-02-19 03:38:51 -0800 The demangle() function should be called when BACKTRACE_SYMBOLS is enabled as well. 1620623 1 391151 pnormand 2020-02-19 03:47:00 -0800 Created attachment 391151 Patch 1622074 2 pnormand 2020-02-24 01:06:30 -0800 Traces are incomplete in WPE because BACKTRACE_SYMBOLS is disabled, we have traces like this: 1 0x7f9be067c7e4 webkitWebViewLoadFailed(_WebKitWebView*, WebKitLoadEvent, char const*, _GError*) 2 0x7f9be0650e31 NavigationClient::didFailProvisionalNavigationWithError(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, API::Navigation*, WebCore::ResourceError const&, API::Object*) 3 0x7f9be05929d0 WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared(WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&) 4 0x7f9be05ce0f3 WebKit::WebPageProxy::didFailProvisionalLoadForFrame(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&) 5 0x7f9be02ff0de void IPC::handleMessage<Messages::WebPageProxy::DidFailProvisionalLoadForFrame, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&)>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&)) 6 0x7f9be02d6744 WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 7 0x7f9be04b1f8a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 8 0x7f9be0589d2f non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 9 0x7f9be04aaca0 IPC::Connection::dispatchMessage(IPC::Decoder&) 10 0x7f9be04ac075 IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_delete<IPC::Decoder> >) 11 0x7f9be04ac90f IPC::Connection::dispatchIncomingMessages() 12 0x7f9bde091e49 WTF::RunLoop::performWork() 13 0x7f9bde0f32f9 14 0x7f9be4a3858e g_main_context_dispatch 15 0x7f9be4a38940 16 0x7f9be4a38c33 g_main_loop_run 17 0x55847d369de9 18 0x7f9be4a60cae 19 0x7f9be4a60a54 20 0x7f9be4a60a54 21 0x7f9be4a6115b g_test_run_suite 22 0x7f9be4a611b5 g_test_run 23 0x55847d368fea 24 0x7f9bd9849173 __libc_start_main 25 0x55847d36915e With backtrace_symbols enabled we'd get: 1 0x7f184b80e074 webkitWebViewLoadFailed(_WebKitWebView*, WebKitLoadEvent, char const*, _GError*) 2 0x7f184b7e26c1 NavigationClient::didFailProvisionalNavigationWithError(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, API::Navigation*, WebCore::ResourceError const&, API::Object*) 3 0x7f184b72556d WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared(WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&) 4 0x7f184b760633 WebKit::WebPageProxy::didFailProvisionalLoadForFrame(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&) 5 0x7f184b4ac0b0 void IPC::handleMessage<Messages::WebPageProxy::DidFailProvisionalLoadForFrame, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&)>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebCore::SecurityOriginData&&, unsigned long, WTF::String const&, WebCore::ResourceError const&, WebCore::WillContinueLoading, WebKit::UserData const&)) 6 0x7f184b4874e7 WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 7 0x7f184b65749a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 8 0x7f184b71cdaf non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 9 0x7f184b6501b0 IPC::Connection::dispatchMessage(IPC::Decoder&) 10 0x7f184b651585 IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_delete<IPC::Decoder> >) 11 0x7f184b651e1f IPC::Connection::dispatchIncomingMessages() 12 0x7f184969bea9 WTF::RunLoop::performWork() 13 0x7f18496fd399 /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18(+0x1442399) [0x7f18496fd399] 14 0x7f184f20b52e g_main_context_dispatch 15 0x7f184f20b8e0 /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x538e0) [0x7f184f20b8e0] 16 0x7f184f20bbd3 g_main_loop_run 17 0x560c97e9ada9 /app/webkit/WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestSSL(+0x6da9) [0x560c97e9ada9] 18 0x7f184f233a5e /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x7ba5e) [0x7f184f233a5e] 19 0x7f184f233804 /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x7b804) [0x7f184f233804] 20 0x7f184f233804 /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x7b804) [0x7f184f233804] 21 0x7f184f233f0b g_test_run_suite 22 0x7f184f233f65 g_test_run 23 0x560c97e99faa /app/webkit/WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestSSL(+0x5faa) [0x560c97e99faa] 24 0x7f184517c173 __libc_start_main 25 0x560c97e9a11e /app/webkit/WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestSSL(+0x611e) [0x560c97e9a11e] 1622292 3 391151 ysuzuki 2020-02-24 13:36:40 -0800 Comment on attachment 391151 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391151&action=review > Source/WTF/wtf/StackTrace.cpp:141 > auto demangled = demangle(stack[i]); > if (demangled) { > mangledName = demangled->mangledName(); > cxaDemangled = demangled->demangledName(); > } If it works, why do we have `HAVE(BACKTRACE_SYMBOLS)` path? It looks like we should always use DLADDR path when we have BACKTRACE_SYMBOLS too. Can we just remove BACKTRACE_SYMBOLS code? 1622303 4 391151 ysuzuki 2020-02-24 13:48:58 -0800 Comment on attachment 391151 Patch Ah, I've missed your comment. OK, dladdr cannot work well if the code is JIT, and HAVE(BACKTRACE_SYMBOLS) can fill some cases. 1622536 5 pnormand 2020-02-25 01:19:40 -0800 Committed r257298: <https://trac.webkit.org/changeset/257298> 1622537 6 webkit-bug-importer 2020-02-25 01:20:17 -0800 <rdar://problem/59758165> 391151 2020-02-19 03:47:00 -0800 2020-02-24 13:48:58 -0800 Patch bug-207933-20200219114658.patch text/plain 1883 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRiODY1MTRkNjhmZWQ3MWEzNTA3MzAx NTVkMTY5YTIxNzZjMGZiMmUuLjJmN2M2NzQyN2IzMmNmZDMxYzYyMDlhMGVjNjZiZmJmMDhmM2Zj YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDItMTkgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtMaW51eF0gU3RhY2tUcmFjZSBzeW1ib2xz IGFyZSBub3QgZGVtYW5nbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDc5MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBEZW1hbmdsZSBzeW1ib2xzIHByb3ZpZGVkIGJ5IGJhY2t0cmFjZV9zeW1ib2xz CisKKyAgICAgICAgKiB3dGYvU3RhY2tUcmFjZS5jcHA6CisgICAgICAgIChXVEY6OlN0YWNrVHJh Y2U6OmR1bXAgY29uc3QpOgorCiAyMDIwLTAyLTE4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBvc19sb2cgUHJpbnRTdHJlYW0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrVHJhY2UuY3BwIGIvU291cmNlL1dURi93dGYvU3Rh Y2tUcmFjZS5jcHAKaW5kZXggNjZmNjEyOTQ0YjVjMjgyZWQ5Yjk0M2RhZDlmNWFlMGY1MjhiNTFi OS4uOWNmODk0MDNlMzQwOTBmYzBhOWI1ODUwZjdhNmRjZTlkY2I0YjI0NCAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvU3RhY2tUcmFjZS5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tU cmFjZS5jcHAKQEAgLTEzMCwxNiArMTMwLDE1IEBAIHZvaWQgU3RhY2tUcmFjZTo6ZHVtcChQcmlu dFN0cmVhbSYgb3V0LCBjb25zdCBjaGFyKiBpbmRlbnRTdHJpbmcpIGNvbnN0CiAgICAgICAgIGNv bnN0IGNoYXIqIGN4YURlbWFuZ2xlZCA9IG51bGxwdHI7CiAjaWYgSEFWRShCQUNLVFJBQ0VfU1lN Qk9MUykKICAgICAgICAgbWFuZ2xlZE5hbWUgPSBzeW1ib2xzW2ldOwotI2VsaWYgSEFWRShETEFE RFIpCisjZWxpZiBPUyhXSU5ET1dTKQorICAgICAgICBpZiAoRGJnSGVscGVyOjpTeW1Gcm9tQWRk cmVzcyhoUHJvYywgcmVpbnRlcnByZXRfY2FzdDxEV09SRDY0PihzdGFja1tpXSksIDAsIHN5bWJv bEluZm8pKQorICAgICAgICAgICAgbWFuZ2xlZE5hbWUgPSBzeW1ib2xJbmZvLT5OYW1lOworI2Vu ZGlmCiAgICAgICAgIGF1dG8gZGVtYW5nbGVkID0gZGVtYW5nbGUoc3RhY2tbaV0pOwogICAgICAg ICBpZiAoZGVtYW5nbGVkKSB7CiAgICAgICAgICAgICBtYW5nbGVkTmFtZSA9IGRlbWFuZ2xlZC0+ bWFuZ2xlZE5hbWUoKTsKICAgICAgICAgICAgIGN4YURlbWFuZ2xlZCA9IGRlbWFuZ2xlZC0+ZGVt YW5nbGVkTmFtZSgpOwogICAgICAgICB9Ci0jZWxpZiBPUyhXSU5ET1dTKQotICAgICAgICBpZiAo RGJnSGVscGVyOjpTeW1Gcm9tQWRkcmVzcyhoUHJvYywgcmVpbnRlcnByZXRfY2FzdDxEV09SRDY0 PihzdGFja1tpXSksIDAsIHN5bWJvbEluZm8pKQotICAgICAgICAgICAgbWFuZ2xlZE5hbWUgPSBz eW1ib2xJbmZvLT5OYW1lOwotI2VuZGlmCiAgICAgICAgIGNvbnN0IGludCBmcmFtZU51bWJlciA9 IGkgKyAxOwogICAgICAgICBpZiAobWFuZ2xlZE5hbWUgfHwgY3hhRGVtYW5nbGVkKQogICAgICAg ICAgICAgb3V0LnByaW50ZigiJXMlLTNkICVwICVzXG4iLCBpbmRlbnRTdHJpbmcsIGZyYW1lTnVt YmVyLCBzdGFja1tpXSwgY3hhRGVtYW5nbGVkID8gY3hhRGVtYW5nbGVkIDogbWFuZ2xlZE5hbWUp Owo=