207929 2020-02-18 21:43:22 -0800 [iOS] Safari sometimes crashes under ViewGestureController::beginSwipeGesture 2020-02-19 12:05:03 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin cdumez commit-queue ddkilzer thorton webkit-bug-importer oldest_to_newest 1620538 0 wenson_hsieh 2020-02-18 21:43:22 -0800 <rdar://problem/59493326> 1620543 1 391144 wenson_hsieh 2020-02-18 22:26:46 -0800 Created attachment 391144 Patch 1620547 2 thorton 2020-02-18 22:50:03 -0800 Please make sure that the SPI notifications are all called (and layer tree unfreeze, etc.) 1620649 3 wenson_hsieh 2020-02-19 07:49:43 -0800 (In reply to Tim Horton from comment #2) > Please make sure that the SPI notifications are all called (and layer tree > unfreeze, etc.) Good point! With my first patch, -_webViewDidBeginNavigationGesture: could get called before bailing from the null check, which would lead to imbalanced SPI delegate calls (to be fair, only in the case where we would otherwise crash the UI process). Another approach I tried initially was to move the null check before the didBegin call, such that the delegate would never need to be notified in the first place. I avoided this out of compat fear (i.e. the case where a client could depend on being able to adjust the back/forward list right before we proceed with the swipe). I think I’ll go for this original approach again, and double check to see if any of our clients actually take advantage of this functionality. 1620652 4 391162 wenson_hsieh 2020-02-19 08:01:43 -0800 Created attachment 391162 Patch 1620686 5 391167 wenson_hsieh 2020-02-19 08:58:30 -0800 Created attachment 391167 With logging 1620788 6 391167 commit-queue 2020-02-19 12:02:07 -0800 Comment on attachment 391167 With logging Rejecting attachment 391167 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 391167, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=391167&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=207929&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 391167 from bug 207929. Fetching: https://bugs.webkit.org/attachment.cgi?id=391167 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 02872ca4de37ce8abb9f24539e6131a494d99f79 and refs/remotes/origin/master differ, using rebase: :040000 040000 8eda8b0881abd09af3f366367f3e00ea187ff52d 0fef4b909914541ddd6f65f343682f60dc70c834 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 02872ca4de37ce8abb9f24539e6131a494d99f79 and refs/remotes/origin/master differ, using rebase: :040000 040000 8eda8b0881abd09af3f366367f3e00ea187ff52d 0fef4b909914541ddd6f65f343682f60dc70c834 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 232710f76d0..b2520a42dab master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 256930 = 232710f76d02a19aec9a30134beaf5c350399a58 r256931 = b2520a42dab0579f68010daf84fc2cf4b70ad2cc Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13325104 1620791 7 wenson_hsieh 2020-02-19 12:05:03 -0800 Committed r256933: <https://trac.webkit.org/changeset/256933> 391144 2020-02-18 22:26:46 -0800 2020-02-19 08:01:42 -0800 Patch bug-207929-20200218222646.patch text/plain 2638 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkNWIyYjg4NzViYjY4OGE0 Mjg1Y2FhYWIzMDQwMjlmOWM5NTAxZTIuLjkwZTgyN2RjYmVhMzEzYWY1Mzk3ZmMyYjg0NGM1NDQz ZmI0YjE3MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjAtMDItMTggIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gU2FmYXJpIHNv bWV0aW1lcyBjcmFzaGVzIHVuZGVyIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6YmVnaW5Td2lwZUdl c3R1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NzkyOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk0OTMzMjY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBWaWV3R2VzdHVyZUNvbnRyb2xs ZXI6OmJlZ2luU3dpcGVHZXN0dXJlIHJvYnVzdCBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgdGFyZ2V0 IGJhY2svZm9yd2FyZCBpdGVtIG5vIGxvbmdlcgorICAgICAgICBleGlzdHMuIFRoaXMgbWVhbnMg dGhhdCBhIGJhY2svZm9yd2FyZCB0YXJnZXQgaXRlbSBleGlzdGVkIHdoZW4gVUlLaXQgY2FsbGVk IGludG8gdXMgaW4gY2FuU3dpcGVJbkRpcmVjdGlvbiwgYnV0CisgICAgICAgIHRoaXMgaXRlbSB3 YXMgcmVtb3ZlZCBieSB0aGUgdGltZSBiZWdpblN3aXBlR2VzdHVyZSBpcyBjYWxsZWQuCisKKyAg ICAgICAgQSBjb3VwbGUgb2YgY29uZGl0aW9ucyBjb3VsZCBtYWtlIHRoaXMgcG9zc2libGUsIHN1 Y2ggYXMgaGFuZGxpbmcgaW5jb21pbmcgc3luY2hyb25vdXMgSVBDIGluIHRoZSBVSSBwcm9jZXNz CisgICAgICAgIHRoYXQgY291bGQgY2hhbmdlIHRoZSBiYWNrL2ZvcndhcmQgbGlzdCBiZWZvcmUg c2VuZGluZyBvdXRnb2luZyBJUEMgdG8gdGhlIHdlYiBwcm9jZXNzOyBhbHRlcm5hdGVseSwgYW4g U1BJCisgICAgICAgIGNsaWVudCBjb3VsZCBiZSBvdmVycmlkaW5nIC1fd2ViVmlld0RpZEJlZ2lu TmF2aWdhdGlvbkdlc3R1cmU6IHRvIHJ1biBzb21lIGxvZ2ljIHRoYXQgcmVtb3ZlcyB0aGUgd291 bGQtYmUKKyAgICAgICAgdGFyZ2V0IGJhY2svZm9yd2FyZCBpdGVtLgorCisgICAgICAgIFRvIHBy b3RlY3QgYWdhaW5zdCB0aGVzZSBzY2VuYXJpb3MsIG51bGwtY2hlY2sgdGFyZ2V0SXRlbSBiZWZv cmUgYXR0ZW1wdGluZyB0byBkZXJlZmVyZW5jZSBpdDsgaWYgaXQgaXMgbnVsbCwKKyAgICAgICAg dGhlbiByZXNldCBzb21lIHN0YXRlIHRoYXQgbWlnaHQndmUgYmVlbiBzZXQgYXMgYSByZXN1bHQg b2YgYmVnaW5uaW5nIHRoZSBzd2lwZSAodGhhdCBpcywgbV9hY3RpdmVHZXN0dXJlVHlwZQorICAg ICAgICBhbmQgbV9jdXJyZW50R2VzdHVyZUlEKSBhbmQgdGhlbiBpbW1lZGlhdGVseSBiYWlsIGJl Zm9yZSBhdHRlbXB0aW5nIHRvIGluc3RhbGwgdGhlIHNuYXBzaG90IHZpZXcgYW5kIHByb2NlZWQK KyAgICAgICAgd2l0aCB0aGUgc3dpcGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1ZpZXdH ZXN0dXJlQ29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250 cm9sbGVyOjpiZWdpblN3aXBlR2VzdHVyZSk6CisKIDIwMjAtMDItMTggIFdlbnNvbiBIc2llaCAg PHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBXZWIgcHJvY2VzcyBt YXkgY3Jhc2ggdW5kZXIgU2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6YnVpbGRQb3RlbnRpYWxI aWdobGlnaHRzSWZOZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvVmlld0dlc3R1cmVDb250cm9sbGVySU9TLm1tCmluZGV4IDQwNDk2OWNlMjg1MzYwMmVmODVj ZDk3ZGQzNDNhNWVmODZlMGFlMzAuLjNhYjc5YTU3ZmU1OTAwZjM3MmI1NGNiMGE1OWMzNGZmZTRm OTIwZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9WaWV3R2VzdHVy ZUNvbnRyb2xsZXJJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1ZpZXdH ZXN0dXJlQ29udHJvbGxlcklPUy5tbQpAQCAtMTk2LDYgKzE5NiwxMCBAQCB2b2lkIFZpZXdHZXN0 dXJlQ29udHJvbGxlcjo6YmVnaW5Td2lwZUdlc3R1cmUoX1VJTmF2aWdhdGlvbkludGVyYWN0aXZl VHJhbnNpdGlvbgogICAgIH0KIAogICAgIFJlZlB0cjxXZWJCYWNrRm9yd2FyZExpc3RJdGVtPiB0 YXJnZXRJdGVtID0gZGlyZWN0aW9uID09IFN3aXBlRGlyZWN0aW9uOjpCYWNrID8gYmFja0Zvcndh cmRMaXN0LmJhY2tJdGVtKCkgOiBiYWNrRm9yd2FyZExpc3QuZm9yd2FyZEl0ZW0oKTsKKyAgICBp ZiAoIXRhcmdldEl0ZW0pIHsKKyAgICAgICAgZGlkRW5kR2VzdHVyZSgpOworICAgICAgICByZXR1 cm47CisgICAgfQogCiAgICAgQ0dSZWN0IGxpdmVTd2lwZVZpZXdGcmFtZSA9IFttX2xpdmVTd2lw ZVZpZXcgZnJhbWVdOwogCg== 391162 2020-02-19 08:01:43 -0800 2020-02-19 08:58:29 -0800 Patch bug-207929-20200219080143.patch text/plain 3913 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVjYzNjYmI1M2M5ZmFmYzkx ODUxZThkNTdjYmUzYjU2ZTQxZDJlNzIuLjUxMGE1ZGIwOGZiNTVlYjNmMTdkYWIzYWQwYzU3YjM3 YmRhN2RlZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjAtMDItMTggIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gU2FmYXJpIHNv bWV0aW1lcyBjcmFzaGVzIHVuZGVyIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6YmVnaW5Td2lwZUdl c3R1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NzkyOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk0OTMzMjY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBWaWV3R2VzdHVyZUNvbnRyb2xs ZXI6OmJlZ2luU3dpcGVHZXN0dXJlIHJvYnVzdCBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgdGFyZ2V0 IGJhY2svZm9yd2FyZCBpdGVtIG5vIGxvbmdlcgorICAgICAgICBleGlzdHMuIFRoaXMgbWVhbnMg dGhhdCBhIGJhY2svZm9yd2FyZCB0YXJnZXQgaXRlbSBleGlzdGVkIHdoZW4gVUlLaXQgY2FsbGVk IGludG8gdXMgaW4gY2FuU3dpcGVJbkRpcmVjdGlvbiwgYnV0CisgICAgICAgIHRoaXMgaXRlbSB3 YXMgcmVtb3ZlZCBieSB0aGUgdGltZSBiZWdpblN3aXBlR2VzdHVyZSBpcyBjYWxsZWQuCisKKyAg ICAgICAgQSBjb3VwbGUgb2YgY29uZGl0aW9ucyBjb3VsZCBtYWtlIHRoaXMgcG9zc2libGUsIHN1 Y2ggYXMgaGFuZGxpbmcgaW5jb21pbmcgc3luY2hyb25vdXMgSVBDIGluIHRoZSBVSSBwcm9jZXNz CisgICAgICAgIHRoYXQgY291bGQgY2hhbmdlIHRoZSBiYWNrL2ZvcndhcmQgbGlzdCBiZWZvcmUg c2VuZGluZyBvdXRnb2luZyBJUEMgdG8gdGhlIHdlYiBwcm9jZXNzOyBhbHRlcm5hdGVseSwgYW4g U1BJCisgICAgICAgIGNsaWVudCBjb3VsZCBiZSBvdmVycmlkaW5nIC1fd2ViVmlld0RpZEJlZ2lu TmF2aWdhdGlvbkdlc3R1cmU6IHRvIHJ1biBzb21lIGxvZ2ljIHRoYXQgcmVtb3ZlcyB0aGUgd291 bGQtYmUKKyAgICAgICAgdGFyZ2V0IGJhY2svZm9yd2FyZCBpdGVtLgorCisgICAgICAgIFRvIHBy b3RlY3QgYWdhaW5zdCB0aGVzZSBzY2VuYXJpb3MsIG51bGwtY2hlY2sgdGFyZ2V0SXRlbSBiZWZv cmUgYXR0ZW1wdGluZyB0byBkZXJlZmVyZW5jZSBpdDsgaWYgaXQgaXMgbnVsbCwKKyAgICAgICAg dGhlbiByZXNldCBzb21lIHN0YXRlIHRoYXQgbWlnaHQndmUgYmVlbiBzZXQgYXMgYSByZXN1bHQg b2YgYmVnaW5uaW5nIHRoZSBzd2lwZSAodGhhdCBpcywgbV9hY3RpdmVHZXN0dXJlVHlwZQorICAg ICAgICBhbmQgbV9jdXJyZW50R2VzdHVyZUlEKSBhbmQgdGhlbiBpbW1lZGlhdGVseSBiYWlsIGJl Zm9yZSBhdHRlbXB0aW5nIHRvIGluc3RhbGwgdGhlIHNuYXBzaG90IHZpZXcgYW5kIHByb2NlZWQK KyAgICAgICAgd2l0aCB0aGUgc3dpcGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1ZpZXdH ZXN0dXJlQ29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250 cm9sbGVyOjpiZWdpblN3aXBlR2VzdHVyZSk6CisKIDIwMjAtMDItMTggIExhdXJvIE1vdXJhICA8 bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dlYktpdF0gQXZvaWQgc2VnZmF1bHQgaWYg ZWRpdG9yIGNsaWVudCBpcyBudWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvVmlld0dlc3R1cmVDb250cm9sbGVySU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5tbQppbmRleCA0MDQ5NjljZTI4NTM2MDJl Zjg1Y2Q5N2RkMzQzYTVlZjg2ZTBhZTMwLi5kMDBjYjFlNTRiMTkyYTE3MWZhNTc1ZTllZDZhZTdj MWYyOGE0MWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvVmlld0dl c3R1cmVDb250cm9sbGVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9W aWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0KQEAgLTE4MiwxMiArMTgyLDE3IEBAIHZvaWQgVmll d0dlc3R1cmVDb250cm9sbGVyOjpiZWdpblN3aXBlR2VzdHVyZShfVUlOYXZpZ2F0aW9uSW50ZXJh Y3RpdmVUcmFuc2l0aW9uCiAgICAgUmVmUHRyPFdlYlBhZ2VQcm94eT4gYWx0ZXJuYXRlQmFja0Zv cndhcmRMaXN0U291cmNlUGFnZSA9IG1fYWx0ZXJuYXRlQmFja0ZvcndhcmRMaXN0U291cmNlUGFn ZS5nZXQoKTsKICAgICBtX3dlYlBhZ2VQcm94eUZvckJhY2tGb3J3YXJkTGlzdEZvckN1cnJlbnRT d2lwZSA9IGFsdGVybmF0ZUJhY2tGb3J3YXJkTGlzdFNvdXJjZVBhZ2UgPyBhbHRlcm5hdGVCYWNr Rm9yd2FyZExpc3RTb3VyY2VQYWdlLmdldCgpIDogJm1fd2ViUGFnZVByb3h5OwogCisgICAgYXV0 byYgYmFja0ZvcndhcmRMaXN0ID0gbV93ZWJQYWdlUHJveHlGb3JCYWNrRm9yd2FyZExpc3RGb3JD dXJyZW50U3dpcGUtPmJhY2tGb3J3YXJkTGlzdCgpOworICAgIGF1dG8gdGFyZ2V0SXRlbSA9IG1h a2VSZWZQdHIoZGlyZWN0aW9uID09IFN3aXBlRGlyZWN0aW9uOjpCYWNrID8gYmFja0ZvcndhcmRM aXN0LmJhY2tJdGVtKCkgOiBiYWNrRm9yd2FyZExpc3QuZm9yd2FyZEl0ZW0oKSk7CisgICAgaWYg KCF0YXJnZXRJdGVtKSB7CisgICAgICAgIGRpZEVuZEdlc3R1cmUoKTsKKyAgICAgICAgcmV0dXJu OworICAgIH0KKwogICAgIG1fd2ViUGFnZVByb3h5Rm9yQmFja0ZvcndhcmRMaXN0Rm9yQ3VycmVu dFN3aXBlLT5uYXZpZ2F0aW9uR2VzdHVyZURpZEJlZ2luKCk7CiAgICAgaWYgKCZtX3dlYlBhZ2VQ cm94eSAhPSBtX3dlYlBhZ2VQcm94eUZvckJhY2tGb3J3YXJkTGlzdEZvckN1cnJlbnRTd2lwZSkK ICAgICAgICAgbV93ZWJQYWdlUHJveHkubmF2aWdhdGlvbkdlc3R1cmVEaWRCZWdpbigpOwogCi0g ICAgYXV0byYgYmFja0ZvcndhcmRMaXN0ID0gbV93ZWJQYWdlUHJveHlGb3JCYWNrRm9yd2FyZExp c3RGb3JDdXJyZW50U3dpcGUtPmJhY2tGb3J3YXJkTGlzdCgpOwotCiAgICAgLy8gQ29weSB0aGUg c25hcHNob3QgZnJvbSB0aGlzIHZpZXcgdG8gdGhlIG9uZSB0aGF0IG93bnMgdGhlIGJhY2sgZm9y d2FyZCBsaXN0LCBzbyB0aGF0CiAgICAgLy8gc3dpcGluZyBmb3J3YXJkIHdpbGwgaGF2ZSB0aGUg Y29ycmVjdCBzbmFwc2hvdC4KICAgICBpZiAobV93ZWJQYWdlUHJveHlGb3JCYWNrRm9yd2FyZExp c3RGb3JDdXJyZW50U3dpcGUgIT0gJm1fd2ViUGFnZVByb3h5KSB7CkBAIC0xOTUsOCArMjAwLDYg QEAgdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OmJlZ2luU3dpcGVHZXN0dXJlKF9VSU5hdmln YXRpb25JbnRlcmFjdGl2ZVRyYW5zaXRpb24KICAgICAgICAgICAgIGJhY2tGb3J3YXJkTGlzdC5j dXJyZW50SXRlbSgpLT5zZXRTbmFwc2hvdChjdXJyZW50Vmlld0hpc3RvcnlJdGVtLT5zbmFwc2hv dCgpKTsKICAgICB9CiAKLSAgICBSZWZQdHI8V2ViQmFja0ZvcndhcmRMaXN0SXRlbT4gdGFyZ2V0 SXRlbSA9IGRpcmVjdGlvbiA9PSBTd2lwZURpcmVjdGlvbjo6QmFjayA/IGJhY2tGb3J3YXJkTGlz dC5iYWNrSXRlbSgpIDogYmFja0ZvcndhcmRMaXN0LmZvcndhcmRJdGVtKCk7Ci0KICAgICBDR1Jl Y3QgbGl2ZVN3aXBlVmlld0ZyYW1lID0gW21fbGl2ZVN3aXBlVmlldyBmcmFtZV07CiAKICAgICBS ZXRhaW5QdHI8VUlWaWV3Q29udHJvbGxlcj4gc25hcHNob3RWaWV3Q29udHJvbGxlciA9IGFkb3B0 TlMoW1tVSVZpZXdDb250cm9sbGVyIGFsbG9jXSBpbml0XSk7Cg== 391167 2020-02-19 08:58:30 -0800 2020-02-19 12:02:07 -0800 With logging bug-207929-20200219085830.patch text/plain 4059 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVjYzNjYmI1M2M5ZmFmYzkx ODUxZThkNTdjYmUzYjU2ZTQxZDJlNzIuLjUxMGE1ZGIwOGZiNTVlYjNmMTdkYWIzYWQwYzU3YjM3 YmRhN2RlZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjAtMDItMTggIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gU2FmYXJpIHNv bWV0aW1lcyBjcmFzaGVzIHVuZGVyIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6YmVnaW5Td2lwZUdl c3R1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NzkyOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk0OTMzMjY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBWaWV3R2VzdHVyZUNvbnRyb2xs ZXI6OmJlZ2luU3dpcGVHZXN0dXJlIHJvYnVzdCBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgdGFyZ2V0 IGJhY2svZm9yd2FyZCBpdGVtIG5vIGxvbmdlcgorICAgICAgICBleGlzdHMuIFRoaXMgbWVhbnMg dGhhdCBhIGJhY2svZm9yd2FyZCB0YXJnZXQgaXRlbSBleGlzdGVkIHdoZW4gVUlLaXQgY2FsbGVk IGludG8gdXMgaW4gY2FuU3dpcGVJbkRpcmVjdGlvbiwgYnV0CisgICAgICAgIHRoaXMgaXRlbSB3 YXMgcmVtb3ZlZCBieSB0aGUgdGltZSBiZWdpblN3aXBlR2VzdHVyZSBpcyBjYWxsZWQuCisKKyAg ICAgICAgQSBjb3VwbGUgb2YgY29uZGl0aW9ucyBjb3VsZCBtYWtlIHRoaXMgcG9zc2libGUsIHN1 Y2ggYXMgaGFuZGxpbmcgaW5jb21pbmcgc3luY2hyb25vdXMgSVBDIGluIHRoZSBVSSBwcm9jZXNz CisgICAgICAgIHRoYXQgY291bGQgY2hhbmdlIHRoZSBiYWNrL2ZvcndhcmQgbGlzdCBiZWZvcmUg c2VuZGluZyBvdXRnb2luZyBJUEMgdG8gdGhlIHdlYiBwcm9jZXNzOyBhbHRlcm5hdGVseSwgYW4g U1BJCisgICAgICAgIGNsaWVudCBjb3VsZCBiZSBvdmVycmlkaW5nIC1fd2ViVmlld0RpZEJlZ2lu TmF2aWdhdGlvbkdlc3R1cmU6IHRvIHJ1biBzb21lIGxvZ2ljIHRoYXQgcmVtb3ZlcyB0aGUgd291 bGQtYmUKKyAgICAgICAgdGFyZ2V0IGJhY2svZm9yd2FyZCBpdGVtLgorCisgICAgICAgIFRvIHBy b3RlY3QgYWdhaW5zdCB0aGVzZSBzY2VuYXJpb3MsIG51bGwtY2hlY2sgdGFyZ2V0SXRlbSBiZWZv cmUgYXR0ZW1wdGluZyB0byBkZXJlZmVyZW5jZSBpdDsgaWYgaXQgaXMgbnVsbCwKKyAgICAgICAg dGhlbiByZXNldCBzb21lIHN0YXRlIHRoYXQgbWlnaHQndmUgYmVlbiBzZXQgYXMgYSByZXN1bHQg b2YgYmVnaW5uaW5nIHRoZSBzd2lwZSAodGhhdCBpcywgbV9hY3RpdmVHZXN0dXJlVHlwZQorICAg ICAgICBhbmQgbV9jdXJyZW50R2VzdHVyZUlEKSBhbmQgdGhlbiBpbW1lZGlhdGVseSBiYWlsIGJl Zm9yZSBhdHRlbXB0aW5nIHRvIGluc3RhbGwgdGhlIHNuYXBzaG90IHZpZXcgYW5kIHByb2NlZWQK KyAgICAgICAgd2l0aCB0aGUgc3dpcGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1ZpZXdH ZXN0dXJlQ29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250 cm9sbGVyOjpiZWdpblN3aXBlR2VzdHVyZSk6CisKIDIwMjAtMDItMTggIExhdXJvIE1vdXJhICA8 bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dlYktpdF0gQXZvaWQgc2VnZmF1bHQgaWYg ZWRpdG9yIGNsaWVudCBpcyBudWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvVmlld0dlc3R1cmVDb250cm9sbGVySU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5tbQppbmRleCA0MDQ5NjljZTI4NTM2MDJl Zjg1Y2Q5N2RkMzQzYTVlZjg2ZTBhZTMwLi4yMDRiZDYzNGEyNmE1ZTc0YTRkN2VjNDM0ZDAyN2Vk NGE0YWJjMDY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvVmlld0dl c3R1cmVDb250cm9sbGVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9W aWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0KQEAgLTE4MiwxMiArMTgyLDE4IEBAIHZvaWQgVmll d0dlc3R1cmVDb250cm9sbGVyOjpiZWdpblN3aXBlR2VzdHVyZShfVUlOYXZpZ2F0aW9uSW50ZXJh Y3RpdmVUcmFuc2l0aW9uCiAgICAgUmVmUHRyPFdlYlBhZ2VQcm94eT4gYWx0ZXJuYXRlQmFja0Zv cndhcmRMaXN0U291cmNlUGFnZSA9IG1fYWx0ZXJuYXRlQmFja0ZvcndhcmRMaXN0U291cmNlUGFn ZS5nZXQoKTsKICAgICBtX3dlYlBhZ2VQcm94eUZvckJhY2tGb3J3YXJkTGlzdEZvckN1cnJlbnRT d2lwZSA9IGFsdGVybmF0ZUJhY2tGb3J3YXJkTGlzdFNvdXJjZVBhZ2UgPyBhbHRlcm5hdGVCYWNr Rm9yd2FyZExpc3RTb3VyY2VQYWdlLmdldCgpIDogJm1fd2ViUGFnZVByb3h5OwogCisgICAgYXV0 byYgYmFja0ZvcndhcmRMaXN0ID0gbV93ZWJQYWdlUHJveHlGb3JCYWNrRm9yd2FyZExpc3RGb3JD dXJyZW50U3dpcGUtPmJhY2tGb3J3YXJkTGlzdCgpOworICAgIGF1dG8gdGFyZ2V0SXRlbSA9IG1h a2VSZWZQdHIoZGlyZWN0aW9uID09IFN3aXBlRGlyZWN0aW9uOjpCYWNrID8gYmFja0ZvcndhcmRM aXN0LmJhY2tJdGVtKCkgOiBiYWNrRm9yd2FyZExpc3QuZm9yd2FyZEl0ZW0oKSk7CisgICAgaWYg KCF0YXJnZXRJdGVtKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFZpZXdHZXN0dXJlcywg IkZhaWxlZCB0byBmaW5kICVzIGl0ZW0gd2hlbiBiZWdpbm5pbmcgc3dpcGUuIiwgZGlyZWN0aW9u ID09IFN3aXBlRGlyZWN0aW9uOjpCYWNrID8gImJhY2siIDogImZvcndhcmQiKTsKKyAgICAgICAg ZGlkRW5kR2VzdHVyZSgpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgbV93ZWJQYWdl UHJveHlGb3JCYWNrRm9yd2FyZExpc3RGb3JDdXJyZW50U3dpcGUtPm5hdmlnYXRpb25HZXN0dXJl RGlkQmVnaW4oKTsKICAgICBpZiAoJm1fd2ViUGFnZVByb3h5ICE9IG1fd2ViUGFnZVByb3h5Rm9y QmFja0ZvcndhcmRMaXN0Rm9yQ3VycmVudFN3aXBlKQogICAgICAgICBtX3dlYlBhZ2VQcm94eS5u YXZpZ2F0aW9uR2VzdHVyZURpZEJlZ2luKCk7CiAKLSAgICBhdXRvJiBiYWNrRm9yd2FyZExpc3Qg PSBtX3dlYlBhZ2VQcm94eUZvckJhY2tGb3J3YXJkTGlzdEZvckN1cnJlbnRTd2lwZS0+YmFja0Zv cndhcmRMaXN0KCk7Ci0KICAgICAvLyBDb3B5IHRoZSBzbmFwc2hvdCBmcm9tIHRoaXMgdmlldyB0 byB0aGUgb25lIHRoYXQgb3ducyB0aGUgYmFjayBmb3J3YXJkIGxpc3QsIHNvIHRoYXQKICAgICAv LyBzd2lwaW5nIGZvcndhcmQgd2lsbCBoYXZlIHRoZSBjb3JyZWN0IHNuYXBzaG90LgogICAgIGlm IChtX3dlYlBhZ2VQcm94eUZvckJhY2tGb3J3YXJkTGlzdEZvckN1cnJlbnRTd2lwZSAhPSAmbV93 ZWJQYWdlUHJveHkpIHsKQEAgLTE5NSw4ICsyMDEsNiBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJv bGxlcjo6YmVnaW5Td2lwZUdlc3R1cmUoX1VJTmF2aWdhdGlvbkludGVyYWN0aXZlVHJhbnNpdGlv bgogICAgICAgICAgICAgYmFja0ZvcndhcmRMaXN0LmN1cnJlbnRJdGVtKCktPnNldFNuYXBzaG90 KGN1cnJlbnRWaWV3SGlzdG9yeUl0ZW0tPnNuYXBzaG90KCkpOwogICAgIH0KIAotICAgIFJlZlB0 cjxXZWJCYWNrRm9yd2FyZExpc3RJdGVtPiB0YXJnZXRJdGVtID0gZGlyZWN0aW9uID09IFN3aXBl RGlyZWN0aW9uOjpCYWNrID8gYmFja0ZvcndhcmRMaXN0LmJhY2tJdGVtKCkgOiBiYWNrRm9yd2Fy ZExpc3QuZm9yd2FyZEl0ZW0oKTsKLQogICAgIENHUmVjdCBsaXZlU3dpcGVWaWV3RnJhbWUgPSBb bV9saXZlU3dpcGVWaWV3IGZyYW1lXTsKIAogICAgIFJldGFpblB0cjxVSVZpZXdDb250cm9sbGVy PiBzbmFwc2hvdFZpZXdDb250cm9sbGVyID0gYWRvcHROUyhbW1VJVmlld0NvbnRyb2xsZXIgYWxs b2NdIGluaXRdKTsK