207914 2020-02-18 15:07:26 -0800 [PlayStation] Get jsc test wrappers using find_package 2020-02-19 11:47:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned annulen commit-queue ews-watchlist gyuyoung.kim keith_miller mark.lam msaboff ross.kirsling ryuan.choi saam sergio tzagallo webkit-bug-importer oldest_to_newest 1620354 0 stephan.szabo 2020-02-18 15:07:26 -0800 Right now JSC is getting the playstation specific test wrappers for the shell via find_library and some manual setting of wrappers that become --Wl,--wrap= arguments. This has the problem that when adding wrappers that call the real function, the shell fails to build until the cmake is changed. Downstream, we've moved to using find_package and having the library provide the correct arguments and dependencies via a config cmake. 1620739 1 391178 stephan.szabo 2020-02-19 10:59:35 -0800 Created attachment 391178 Patch 1620770 2 391178 commit-queue 2020-02-19 11:46:19 -0800 Comment on attachment 391178 Patch Clearing flags on attachment: 391178 Committed r256930: <https://trac.webkit.org/changeset/256930> 1620771 3 commit-queue 2020-02-19 11:46:21 -0800 All reviewed patches have been landed. Closing bug. 1620773 4 webkit-bug-importer 2020-02-19 11:47:15 -0800 <rdar://problem/59599495> 391178 2020-02-19 10:59:35 -0800 2020-02-19 11:46:19 -0800 Patch 207914.1.diff text/plain 1842 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUxYTJiNzI1YzIxLi5jY2NjYjA3NWU2NiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDItMTkgIFN0ZXBo YW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQHNvbnkuY29tPgorCisgICAgICAgIFtQbGF5U3RhdGlv bl0gR2V0IGpzYyB0ZXN0IHdyYXBwZXJzIHVzaW5nIGZpbmRfcGFja2FnZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3OTE0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzaGVsbC9QbGF0Zm9ybVBsYXlT dGF0aW9uLmNtYWtlOgorCiAyMDIwLTAyLTE4ICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIEZpeCBvcmRlciAoaW4gTUlQUykgdW5kZXIgd2hpY2ggQ1MtcmVnaXN0 ZXJzIGFyZSBzYXZlZC9yZXN0b3JlZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3NoZWxsL1BsYXRmb3JtUGxheVN0YXRpb24uY21ha2UgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv c2hlbGwvUGxhdGZvcm1QbGF5U3RhdGlvbi5jbWFrZQppbmRleCAyMDJlYTc1ZmI4MS4uYWIwMDk2 ZjU5NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9QbGF0Zm9ybVBs YXlTdGF0aW9uLmNtYWtlCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9QbGF0Zm9y bVBsYXlTdGF0aW9uLmNtYWtlCkBAIC00LDkgKzQsMTggQEAgbGlzdChBUFBFTkQganNjX1NPVVJD RVMKICAgICAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vc2hlbGwvcGxheXN0YXRpb24vSW5pdGlhbGl6 ZXIuY3BwCiApCiAKLWZpbmRfbGlicmFyeShMSUJURVNUV1JBUFBFUlMgdGVzdHdyYXBwZXJzIFBB VEhTICR7V0VCS0lUX0xJQlJBUklFU19ESVJ9L2xpYikKKyMgR2V0IHRoZSBuZWNlc3Nhcnkgd3Jh cHBlcnMgZm9yIEMgZnVuY3Rpb25zIHRvIG1ha2UganNjIHNoZWxsCisjIGFibGUgdG8gcHJvcGVy bHkgcnVuIHRlc3RzLiBEZXBlbmRpbmcgb24gdmVyc2lvbiwgZmlyc3QgdHJ5CisjIHVzaW5nIGZp bmRfcGFja2FnZSBmb3IgbmV3IHZlcnNpb24gYW5kIGlmIHRoYXQgZG9lc24ndCB3b3JrCisjIGZh bGxiYWNrIHRvIHVzaW5nIGZpbmRfbGlicmFyeSBmb3Igb2xkZXIgdmVyc2lvbnMuCitmaW5kX3Bh Y2thZ2UobGlidGVzdHdyYXBwZXJzKQoraWYgKFRBUkdFVCBsaWJ0ZXN0d3JhcHBlcnM6OnRlc3R3 cmFwcGVycykKKyAgICBsaXN0KEFQUEVORCBqc2NfTElCUkFSSUVTIGxpYnRlc3R3cmFwcGVyczo6 dGVzdHdyYXBwZXJzKQorZWxzZSAoKQorICAgIGZpbmRfbGlicmFyeShMSUJURVNUV1JBUFBFUlMg dGVzdHdyYXBwZXJzIFBBVEhTICR7V0VCS0lUX0xJQlJBUklFU19ESVJ9L2xpYikKKyAgICBzZXQo UExBWVNUQVRJT05fanNjX1dSQVAgZm9wZW4gZ2V0Y3dkIGNoZGlyIG1haW4pCisgICAgbGlzdChB UFBFTkQganNjX0xJQlJBUklFUyAke0xJQlRFU1RXUkFQUEVSU30pCitlbmRpZiAoKQogCiBzZXQo UExBWVNUQVRJT05fanNjX1BST0NFU1NfTkFNRSAiSlNDU2hlbGwiKQogc2V0KFBMQVlTVEFUSU9O X2pzY19NQUlOX1RIUkVBRF9OQU1FICJKU0NTaGVsbCIpCi1zZXQoUExBWVNUQVRJT05fanNjX1dS QVAgZm9wZW4gZ2V0Y3dkIGNoZGlyIG1haW4pCi1saXN0KEFQUEVORCBqc2NfTElCUkFSSUVTICR7 TElCVEVTVFdSQVBQRVJTfSkK