207909 2020-02-18 13:41:30 -0800 Drop getSandboxExtensionsForBlobFiles() as it is dead code 2020-02-18 16:14:06 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson bfulgham commit-queue ddkilzer ggaren pvollan webkit-bug-importer youennf oldest_to_newest 1620301 0 cdumez 2020-02-18 13:41:30 -0800 Drop getSandboxExtensionsForBlobFiles() as it is dead code. 1620302 1 cdumez 2020-02-18 13:42:13 -0800 <rdar://problem/59562180> 1620303 2 391083 cdumez 2020-02-18 13:43:11 -0800 Created attachment 391083 Patch 1620305 3 391083 pvollan 2020-02-18 13:49:42 -0800 Comment on attachment 391083 Patch R=me. 1620306 4 391083 bfulgham 2020-02-18 13:50:25 -0800 Comment on attachment 391083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391083&action=review > Source/WebKit/ChangeLog:3 > + Drop getSandboxExtensionsForBlobFiles() as it is dead code Hooray for dead code removal! 1620416 5 391083 commit-queue 2020-02-18 16:14:04 -0800 Comment on attachment 391083 Patch Clearing flags on attachment: 391083 Committed r256881: <https://trac.webkit.org/changeset/256881> 1620417 6 commit-queue 2020-02-18 16:14:06 -0800 All reviewed patches have been landed. Closing bug. 391083 2020-02-18 13:43:11 -0800 2020-02-18 16:14:04 -0800 Patch bug-207909-20200218134311.patch text/plain 5798 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhkYWNkMzFhZWM1MGE1MzBh ODI2MzAwNGU1YWE5OGYxY2MyMzJiYWIuLjc4ODIwMTM1NTRjYzA3OTUxYTFiMTI0NGRiMWYwZTU3 NGM0NTA2ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDItMTggIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBEcm9wIGdldFNhbmRib3hFeHRlbnNp b25zRm9yQmxvYkZpbGVzKCkgYXMgaXQgaXMgZGVhZCBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc5MDkKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzU5NTYyMTgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwOgorICAgICAgICAqIE5l dHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmg6CisgICAgICAgICogVUlQcm9jZXNzL05ldHdv cmsvTmV0d29ya1Byb2Nlc3NQcm94eS5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL05ldHdvcmsv TmV0d29ya1Byb2Nlc3NQcm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdv cmtQcm9jZXNzUHJveHkubWVzc2FnZXMuaW46CisKIDIwMjAtMDItMTggIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uKHIyNDYxODgpIFdlYlByb2Nl c3MgaXMgbGF1bmNoZWQgdG9vIGVhZ2VybHkgd2hlbiBbV0tXZWJWaWV3IF9yZXN0b3JlU2Vzc2lv blN0YXRlXSBpcyBjYWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Byb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUHJvY2Vzcy5jcHAKaW5kZXggOTFkZjNiODBhMzZhNjczMWNiNmY4ZDNkYjM5OTQ4MmY4Y2Iw MTViNS4uZWMzYTBlNWJiZTE4MTM2NjU2YWU2NjMyMTQwOWNmYWEzZjUwMDBmOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKQEAgLTIzNzcs MTMgKzIzNzcsNiBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpyZXNldFF1b3RhKFBBTDo6U2Vzc2lv bklEIHNlc3Npb25JRCwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZAogICAgIGNvbXBsZXRpb25IYW5k bGVyKCk7CiB9CiAKLSNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJT05TKQotdm9pZCBOZXR3b3Jr UHJvY2Vzczo6Z2V0U2FuZGJveEV4dGVuc2lvbnNGb3JCbG9iRmlsZXMoY29uc3QgVmVjdG9yPFN0 cmluZz4mIGZpbGVuYW1lcywgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChTYW5kYm94RXh0ZW5zaW9u OjpIYW5kbGVBcnJheSYmKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKLXsKLSAgICBwYXJlbnRQcm9j ZXNzQ29ubmVjdGlvbigpLT5zZW5kV2l0aEFzeW5jUmVwbHkoTWVzc2FnZXM6Ok5ldHdvcmtQcm9j ZXNzUHJveHk6OkdldFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYkZpbGVzKGZpbGVuYW1lcyksIFdU Rk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKLX0KLSNlbmRpZiAvLyBFTkFCTEUoU0FOREJPWF9F WFRFTlNJT05TKQotCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQogdm9pZCBOZXR3b3JrUHJv Y2Vzczo6Zm9yRWFjaFNXU2VydmVyKGNvbnN0IEZ1bmN0aW9uPHZvaWQoU1dTZXJ2ZXImKT4mIGNh bGxiYWNrKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vz cy5oCmluZGV4IDJkYzk2NDZjYzVlZjcwZWRlODA0YjI2MmEzYjM2YTM4Y2Q1Y2MyZjguLjkxODA5 MjBhMWM1ODk1MjY2ZWQzN2IwYzIwMTQ1NzRhMzg1YWU0NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmgKQEAgLTI4NywxMCArMjg3LDYgQEAgcHVi bGljOgogCiAgICAgdm9pZCByZXNldFF1b3RhKFBBTDo6U2Vzc2lvbklELCBDb21wbGV0aW9uSGFu ZGxlcjx2b2lkKCk+JiYpOwogCi0jaWYgRU5BQkxFKFNBTkRCT1hfRVhURU5TSU9OUykKLSAgICB2 b2lkIGdldFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYkZpbGVzKGNvbnN0IFZlY3RvcjxTdHJpbmc+ JiBmaWxlbmFtZXMsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoU2FuZGJveEV4dGVuc2lvbjo6SGFu ZGxlQXJyYXkmJik+JiYpOwotI2VuZGlmCi0KICNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCiAg ICAgV2ViQ29yZTo6U1dTZXJ2ZXIqIHN3U2VydmVyRm9yU2Vzc2lvbklmRXhpc3RzKFBBTDo6U2Vz c2lvbklEIHNlc3Npb25JRCkgeyByZXR1cm4gbV9zd1NlcnZlcnMuZ2V0KHNlc3Npb25JRCk7IH0K ICAgICBXZWJDb3JlOjpTV1NlcnZlciYgc3dTZXJ2ZXJGb3JTZXNzaW9uKFBBTDo6U2Vzc2lvbklE KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1By b2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQ cm9jZXNzUHJveHkuY3BwCmluZGV4IDRjOGMyZWI0ZTQ3MmE0MWM1MGFmNTA4ZTVlZWQzNjI2ODRm OTRiYTQuLjFkNzBkNjYzYzI3ZWZkYjIyMGVlZjU5MWVjYWY4MmUwY2M0OWNhMTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1By b3h5LmNwcApAQCAtMTI4NSwxOSArMTI4NSw2IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3NQcm94eTo6 ZGlkRGVzdHJveVdlYlVzZXJDb250ZW50Q29udHJvbGxlclByb3h5KFdlYlVzZXJDb250ZW50CiB9 CiAjZW5kaWYKIAotI2lmIEVOQUJMRShTQU5EQk9YX0VYVEVOU0lPTlMpCi12b2lkIE5ldHdvcmtQ cm9jZXNzUHJveHk6OmdldFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYkZpbGVzKGNvbnN0IFZlY3Rv cjxTdHJpbmc+JiBwYXRocywgTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNzUHJveHk6OkdldFNhbmRi b3hFeHRlbnNpb25zRm9yQmxvYkZpbGVzOjpBc3luY1JlcGx5JiYgcmVwbHkpCi17Ci0gICAgU2Fu ZGJveEV4dGVuc2lvbjo6SGFuZGxlQXJyYXkgZXh0ZW5zaW9uczsKLSAgICBleHRlbnNpb25zLmFs bG9jYXRlKHBhdGhzLnNpemUoKSk7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBwYXRocy5z aXplKCk7ICsraSkgewotICAgICAgICAvLyBSZWFkV3JpdGUgaXMgcmVxdWlyZWQgZm9yIGNyZWF0 aW5nIGhhcmQgbGlua3MsIHdoaWNoIGlzIHNvbWV0aGluZyB0aGF0IG1pZ2h0IGJlIGRvbmUgd2l0 aCB0aGVzZSBleHRlbnNpb25zLgotICAgICAgICBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5k bGUocGF0aHNbaV0sIFNhbmRib3hFeHRlbnNpb246OlR5cGU6OlJlYWRXcml0ZSwgZXh0ZW5zaW9u c1tpXSk7Ci0gICAgfQotICAgIHJlcGx5KFdURk1vdmUoZXh0ZW5zaW9ucykpOwotfQotI2VuZGlm Ci0KICNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCiB2b2lkIE5ldHdvcmtQcm9jZXNzUHJveHk6 OmVzdGFibGlzaFdvcmtlckNvbnRleHRDb25uZWN0aW9uVG9OZXR3b3JrUHJvY2VzcyhSZWdpc3Ry YWJsZURvbWFpbiYmIHJlZ2lzdHJhYmxlRG9tYWluLCBQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQs IENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKIHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94 eS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5 LmgKaW5kZXggNTc4MThiNzdiNjI1YWZiNWFmYTllYWE0NGI0YWM3YzUyOWE2MDQ0NS4uMDlmOWE1 NmUxYzljY2NlODRiMWQzMzFhOTNhZGQwMmMyOGUxMDBjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmgKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmgKQEAgLTI1OSwx MCArMjU5LDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIGNvbnRlbnRFeHRlbnNpb25SdWxlcyhVc2Vy Q29udGVudENvbnRyb2xsZXJJZGVudGlmaWVyKTsKICNlbmRpZgogCi0jaWYgRU5BQkxFKFNBTkRC T1hfRVhURU5TSU9OUykKLSAgICB2b2lkIGdldFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYkZpbGVz KGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBwYXRocywgTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNzUHJv eHk6OkdldFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYkZpbGVzQXN5bmNSZXBseSYmKTsKLSNlbmRp ZgotCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQogICAgIHZvaWQgZXN0YWJsaXNoV29ya2Vy Q29udGV4dENvbm5lY3Rpb25Ub05ldHdvcmtQcm9jZXNzKFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9t YWluJiYsIFBBTDo6U2Vzc2lvbklELCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYpOwogICAg IHZvaWQgd29ya2VyQ29udGV4dENvbm5lY3Rpb25Ob0xvbmdlck5lZWRlZChXZWJDb3JlOjpQcm9j ZXNzSWRlbnRpZmllcik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3 b3JrL05ldHdvcmtQcm9jZXNzUHJveHkubWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkubWVzc2FnZXMuaW4KaW5kZXggNGJkYTc2 OGNkNGY4Y2ZmZmYxZTkwNGU5OTA4MzcxNjIwZTFlNTNjNS4uZDkwNTk4MjZlNmM5MzQ4NjMwMTEy ZjMxMzBlNGY0NDFlNjNlZjk0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv TmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5Lm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5tZXNzYWdlcy5pbgpAQCAt NTcsMTAgKzU3LDYgQEAgbWVzc2FnZXMgLT4gTmV0d29ya1Byb2Nlc3NQcm94eSBMZWdhY3lSZWNl aXZlciBOb3RSZWZDb3VudGVkIHsKIAogICAgIFJldHJpZXZlQ2FjaGVTdG9yYWdlUGFyYW1ldGVy cyhQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQpCiAKLSNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJ T05TKQotICAgIEdldFNhbmRib3hFeHRlbnNpb25zRm9yQmxvYkZpbGVzKFZlY3RvcjxTdHJpbmc+ IHBhdGhzKSAtPiAoV2ViS2l0OjpTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGVBcnJheSBleHRlbnNp b25zKSBBc3luYwotI2VuZGlmCi0KICNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCiAgICAgRXN0 YWJsaXNoV29ya2VyQ29udGV4dENvbm5lY3Rpb25Ub05ldHdvcmtQcm9jZXNzKFdlYkNvcmU6OlJl Z2lzdHJhYmxlRG9tYWluIHJlZ2lzdHJhYmxlRG9tYWluLCBQQUw6OlNlc3Npb25JRCBzZXNzaW9u SUQpIC0+ICgpIEFzeW5jCiAgICAgV29ya2VyQ29udGV4dENvbm5lY3Rpb25Ob0xvbmdlck5lZWRl ZChXZWJDb3JlOjpQcm9jZXNzSWRlbnRpZmllciBpZGVudGlmaWVyKQo=