207907 2020-02-18 13:06:28 -0800 [First paint] Remove elementOverflowRectIsLargerThanThreshold check in qualifiesAsVisuallyNonEmpty 2020-02-18 16:31:53 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue ggaren simon.fraser webkit-bug-importer zalan oldest_to_newest 1620286 0 zalan 2020-02-18 13:06:28 -0800 This is in preparation for being able to qualify for a visually non-empty content without looking at geometry. 1620287 1 webkit-bug-importer 2020-02-18 13:06:49 -0800 <rdar://problem/59562169> 1620312 2 391087 zalan 2020-02-18 14:01:21 -0800 Created attachment 391087 Patch 1620374 3 391087 ggaren 2020-02-18 15:24:47 -0800 Comment on attachment 391087 Patch r=me 1620431 4 391087 commit-queue 2020-02-18 16:31:52 -0800 Comment on attachment 391087 Patch Clearing flags on attachment: 391087 Committed r256883: <https://trac.webkit.org/changeset/256883> 1620432 5 commit-queue 2020-02-18 16:31:53 -0800 All reviewed patches have been landed. Closing bug. 391087 2020-02-18 14:01:21 -0800 2020-02-18 16:31:52 -0800 Patch bug-207907-20200218140120.patch text/plain 3196 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JmZjMzZGU0MTkwYjcz YjU5YzhhYmFjMTExOTBjYjBiYzYxOTMxYi4uMmQ0NDY4ODFlODBjZGM3NWIxYTNjOWMzOGUxNmE4 MWNmN2ZjZTIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAyLTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZpcnN0IHBhaW50XSBSZW1v dmUgZWxlbWVudE92ZXJmbG93UmVjdElzTGFyZ2VyVGhhblRocmVzaG9sZCBjaGVjayBpbiBxdWFs aWZpZXNBc1Zpc3VhbGx5Tm9uRW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzkwNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk1NjIxNjk+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBp cyBpbiBwcmVwYXJhdGlvbiBmb3IgYmVpbmcgYWJsZSB0byBxdWFsaWZ5IGZvciB2aXN1YWxseSBu b24tZW1wdHkgY29udGVudCB3aXRob3V0IGxvb2tpbmcgYXQgZ2VvbWV0cnkuCisgICAgICAgIFRo aXMgY2hlY2sgd2FzIGFkZGVkIGxvbmcgYWdvLCBpbml0aWFsbHkgd2l0aCBhIDIwMHB4IHZhbHVl IHdoaWNoIGdvdCByZWR1Y2VkIHRvIDQ4cHggdG8gcmVkdWNlIHBhaW50aW5nIGxhdGVuY3kgb24g Z29vZ2xlIHNlYXJjaCByZXN1bHQgcGFnZS4KKyAgICAgICAgQXQgdGhpcyBwb2ludCBhIDQ4cHgg dGhyZXNob2xkIGRvZXMgbm90IG1ha2UgdG9vIG11Y2ggc2Vuc2UuCisKKyAgICAgICAgKiBwYWdl L0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnF1YWxpZmllc0Fz U2lnbmlmaWNhbnRSZW5kZXJlZFRleHQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVW aWV3OjpxdWFsaWZpZXNBc1Zpc3VhbGx5Tm9uRW1wdHkgY29uc3QpOgorICAgICAgICAoV2ViQ29y ZTo6ZWxlbWVudE92ZXJmbG93UmVjdElzTGFyZ2VyVGhhblRocmVzaG9sZCk6IERlbGV0ZWQuCisK IDIwMjAtMDItMTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgTW92ZSBmcm9tICJsYXllciBmbHVzaCIgdGVybWlub2xvZ3kgdG8gInJlbmRlcmluZyB1 cGRhdGUiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggYzlmMGQ1ZWNlOTMxYjU1MWYw YmQ2ZDJiY2U1ZGQyZWFlM2FhNzNhMC4uMjE4MmI3NzQ4Nzg3YWNhZDE5NGI5NzI1M2I2MzUxMTg2 NGYyNDI1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtNDM4NywxNyArNDM4Nyw2 IEBAIHZvaWQgRnJhbWVWaWV3OjppbmNyZW1lbnRWaXN1YWxseU5vbkVtcHR5Q2hhcmFjdGVyQ291 bnQoY29uc3QgU3RyaW5nJiBpbmxpbmVUZXh0CiAgICAgKyttX3RleHRSZW5kZXJlckNvdW50Rm9y VmlzdWFsbHlOb25FbXB0eUNoYXJhY3RlcnM7CiB9CiAKLXN0YXRpYyBib29sIGVsZW1lbnRPdmVy Zmxvd1JlY3RJc0xhcmdlclRoYW5UaHJlc2hvbGQoY29uc3QgRWxlbWVudCYgZWxlbWVudCkKLXsK LSAgICAvLyBSZXF1aXJlIHRoZSBkb2N1bWVudCB0byBncm93IGEgYml0LgotICAgIC8vIFVzaW5n IGEgdmFsdWUgb2YgNDggYWxsb3dzIHRoZSBoZWFkZXIgb24gR29vZ2xlJ3Mgc2VhcmNoIHBhZ2Ug dG8gcmVuZGVyIGltbWVkaWF0ZWx5IGJlZm9yZSBzZWFyY2ggcmVzdWx0cyBwb3B1bGF0ZSBsYXRl ci4KLSAgICBzdGF0aWMgY29uc3QgaW50IGRvY3VtZW50SGVpZ2h0VGhyZXNob2xkID0gNDg7Ci0g ICAgaWYgKGF1dG8qIGVsZW1lbnRSZW5kZXJCb3ggPSBlbGVtZW50LnJlbmRlckJveCgpKQotICAg ICAgICByZXR1cm4gc25hcHBlZEludFJlY3QoZWxlbWVudFJlbmRlckJveC0+bGF5b3V0T3ZlcmZs b3dSZWN0KCkpLmhlaWdodCgpID49IGRvY3VtZW50SGVpZ2h0VGhyZXNob2xkOwotCi0gICAgcmV0 dXJuIGZhbHNlOwotfQotCiB2b2lkIEZyYW1lVmlldzo6dXBkYXRlSGFzUmVhY2hlZFNpZ25pZmlj YW50UmVuZGVyZWRUZXh0VGhyZXNob2xkKCkKIHsKICAgICBpZiAobV9oYXNSZWFjaGVkU2lnbmlm aWNhbnRSZW5kZXJlZFRleHRUaHJlc2hvbGQpCkBAIC00NDMwLDExICs0NDE5LDYgQEAgYm9vbCBG cmFtZVZpZXc6OnF1YWxpZmllc0FzU2lnbmlmaWNhbnRSZW5kZXJlZFRleHQoKSBjb25zdAogICAg IGF1dG8qIGRvY3VtZW50ID0gZnJhbWUoKS5kb2N1bWVudCgpOwogICAgIGlmICghZG9jdW1lbnQg fHwgZG9jdW1lbnQtPnN0eWxlU2NvcGUoKS5oYXNQZW5kaW5nU2hlZXRzQmVmb3JlQm9keSgpKQog ICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBhdXRvKiBkb2N1bWVudEVsZW1lbnQgPSBkb2N1 bWVudC0+ZG9jdW1lbnRFbGVtZW50KCk7Ci0gICAgaWYgKCFkb2N1bWVudEVsZW1lbnQgfHwgIWVs ZW1lbnRPdmVyZmxvd1JlY3RJc0xhcmdlclRoYW5UaHJlc2hvbGQoKmRvY3VtZW50RWxlbWVudCkp Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIHJldHVybiBtX2hhc1JlYWNoZWRTaWduaWZp Y2FudFJlbmRlcmVkVGV4dFRocmVzaG9sZDsKIH0KIApAQCAtNDQ2OCw5ICs0NDUyLDYgQEAgYm9v bCBGcmFtZVZpZXc6OnF1YWxpZmllc0FzVmlzdWFsbHlOb25FbXB0eSgpIGNvbnN0CiAgICAgaWYg KCFpc1Zpc2libGUoZnJhbWUoKS5kb2N1bWVudCgpLT5ib2R5KCkpKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKLSAgICBpZiAoIWVsZW1lbnRPdmVyZmxvd1JlY3RJc0xhcmdlclRoYW5UaHJlc2hv bGQoKmRvY3VtZW50RWxlbWVudCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIC8vIFRo ZSBmaXJzdCBmZXcgaHVuZHJlZCBjaGFyYWN0ZXJzIHJhcmVseSBjb250YWluIHRoZSBpbnRlcmVz dGluZyBjb250ZW50IG9mIHRoZSBwYWdlLgogICAgIGlmIChtX3Zpc3VhbGx5Tm9uRW1wdHlDaGFy YWN0ZXJDb3VudCA+IHZpc3VhbENoYXJhY3RlclRocmVzaG9sZCkKICAgICAgICAgcmV0dXJuIHRy dWU7Cg==