207890 2020-02-18 08:10:26 -0800 [WPE] undefined reference to `JSC::ExecutableBase::hasJITCodeForCall() const' 2020-03-01 16:06:42 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply clopez commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo ysuzuki oldest_to_newest 1620143 0 cturner 2020-02-18 08:10:26 -0800 Hitting this on arm-buildroot-linux-gnueabihf with GCC 9.2.0, [ 74%] Linking CXX executable ../../../bin/jsc /home/cht/igalia/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabihf/9.2.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: ../../../lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-25.cpp.o: in function `JSC::ExecutableBase::hasJITCodeFor(JSC::CodeSpecializationKind) const': /home/cht/igalia/buildroot/output/build/wpewebkit-2.26.4/Source/JavaScriptCore/runtime/ExecutableBase.h:183: undefined reference to `JSC::ExecutableBase::hasJITCodeForCall() const' /home/cht/igalia/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabihf/9.2.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: /home/cht/igalia/buildroot/output/build/wpewebkit-2.26.4/Source/JavaScriptCore/runtime/ExecutableBase.h:185: undefined reference to `JSC::ExecutableBase::hasJITCodeForConstruct() const' collect2: error: ld returned 1 exit status Adding #include "ExecutableBaseInlines.h" to Source/JavaScriptCore/runtime/NativeExecutable.cpp fixes the issue, not sure if that's the best solution. 1620144 1 391047 cturner 2020-02-18 08:13:04 -0800 Created attachment 391047 Patch 1620628 2 391047 clopez 2020-02-19 04:45:39 -0800 Comment on attachment 391047 Patch Not sure if this its the best fix. Source/JavaScriptCore/runtime/ExecutableBase.h declares the function prototype for hasJITCodeForCall() and hasJITCodeForConstruct() but ExecutableBase.cpp doesn't define the function hasJITCodeForCall() neither hasJITCodeForConstruct() The functions hasJITCodeForCall() and hasJITCodeForConstruct() seem defined in ScriptExecutable.h I wonder if a better fix would be to remove from ExecutableBase.h the prototypes of hasJITCodeForCall() and hasJITCodeForConstruct() and include ScriptExecutable.h inside ExecutableBase.h ? 1620630 3 cturner 2020-02-19 05:13:37 -0800 (In reply to Carlos Alberto Lopez Perez from comment #2) > Comment on attachment 391047 [details] > Patch > > Not sure if this its the best fix. > > Source/JavaScriptCore/runtime/ExecutableBase.h declares the function > prototype for hasJITCodeForCall() and hasJITCodeForConstruct() but > ExecutableBase.cpp doesn't define the function hasJITCodeForCall() neither > hasJITCodeForConstruct() > > The functions hasJITCodeForCall() and hasJITCodeForConstruct() seem defined > in ScriptExecutable.h They're also in ExecutableBaseInlines.h, and I don't know what purpose this organisation serves. I guess for some sort of ODR-workaround? > > I wonder if a better fix would be to remove from ExecutableBase.h the > prototypes of hasJITCodeForCall() and hasJITCodeForConstruct() and include > ScriptExecutable.h inside ExecutableBase.h ? ScriptExectable is a subclass and the base needs visibility of these symbols, so removing their prototypes doesn't work correctly. This is a hairy organisation which I think is best left to the discretion of a JSC maintainer. 1624255 4 391047 ysuzuki 2020-02-29 01:27:20 -0800 Comment on attachment 391047 Patch r=me 1624422 5 391047 commit-queue 2020-03-01 16:06:40 -0800 Comment on attachment 391047 Patch Clearing flags on attachment: 391047 Committed r257695: <https://trac.webkit.org/changeset/257695> 1624423 6 commit-queue 2020-03-01 16:06:42 -0800 All reviewed patches have been landed. Closing bug. 391047 2020-02-18 08:13:04 -0800 2020-03-01 16:06:40 -0800 Patch bug-207890-20200218161303.patch text/plain 1438 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZDc5NzZiMmM5NDRiNDA5OWU1NWViZWU5ZjA5NzBkNWM2MDVhODQ0Li43NWEyN2Q1MDMxNjkwZjBh ZjkyNmFiZWRiMjdjYTgxN2QyMjhjMTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wMi0xOCAgQ2hhcmxlcyBUdXJuZXIgIDxjdHVybmVyQGlnYWxpYS5j b20+CisKKyAgICAgICAgdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgSlNDOjpFeGVjdXRhYmxlQmFz ZTo6aGFzSklUQ29kZUZvckNhbGwoKSBjb25zdCcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzg5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEVuY291bnRlcmVkIG9uIGFybS1idWlsZHJvb3QtbGludXgt Z251ZWFiaWhmIHdpdGggR0NDIDkuMi4wLgorCisgICAgICAgICogcnVudGltZS9OYXRpdmVFeGVj dXRhYmxlLmNwcDogSW5jbHVzaW9uIG9mCisgICAgICAgIEV4ZWN1dGFibGVCYXNlSW5saW5lcy5o IHJlc29sdmVzIHRoZSBpc3N1ZSBmb3IgbWUuCisKIDIwMjAtMDItMTYgIEZ1amlpIEhpcm9ub3Jp ICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHJlbWFpbmluZyBX VEZfRVhQT1JUIGFuZCBXVEZfSU1QT1JUIGJ5IHJlcGxhY2luZyB0aGVtIHdpdGggV1RGX0VYUE9S VF9ERUNMQVJBVElPTiBhbmQgV1RGX0lNUE9SVF9ERUNMQVJBVElPTgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTmF0aXZlRXhlY3V0YWJsZS5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9OYXRpdmVFeGVjdXRhYmxlLmNwcAppbmRleCAxYTQyOWI1 YTNjYWY0ODg0MmM3MjAxZjE3NGI5MjU1ZjgyOWNjNzRjLi45YmJjMDk0N2I5ODQzNmJlYmViMzVk MWVkODc5MjUwZjRhZDU3M2I3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9OYXRpdmVFeGVjdXRhYmxlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9OYXRpdmVFeGVjdXRhYmxlLmNwcApAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUgIkJh dGNoZWRUcmFuc2l0aW9uT3B0aW1pemVyLmgiCiAjaW5jbHVkZSAiQ29kZUJsb2NrLmgiCiAjaW5j bHVkZSAiRGVidWdnZXIuaCIKKyNpbmNsdWRlICJFeGVjdXRhYmxlQmFzZUlubGluZXMuaCIKICNp bmNsdWRlICJKSVQuaCIKICNpbmNsdWRlICJKU0NJbmxpbmVzLmgiCiAjaW5jbHVkZSAiTExJbnRF bnRyeXBvaW50LmgiCg==