207885 2020-02-18 03:56:34 -0800 [ARM] Build failure on arm due to invalid use of incomplete type 'class WebCore::ImageData' in FEBlendNEON.h 2020-02-18 08:40:52 -0800 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clord clord achristensen clopez commit-queue darin sabouhallawa simon.fraser thorton webkit-bug-importer oldest_to_newest 1620109 0 clord 2020-02-18 03:56:34 -0800 > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28, > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()': > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData' > | 115 | auto* dstPixelArray = imageResult ? imageResult->data() : nullptr; > | | ^~ > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25, > | from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26, > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: I don't know what the best fix is, but including ImageData.h in FEBlendNEON.h does fix it, so I'll attach that patch. 1620110 1 391039 clord 2020-02-18 03:59:31 -0800 Created attachment 391039 Patch 1620118 2 391039 commit-queue 2020-02-18 06:15:45 -0800 Comment on attachment 391039 Patch Clearing flags on attachment: 391039 Committed r256825: <https://trac.webkit.org/changeset/256825> 1620119 3 commit-queue 2020-02-18 06:15:47 -0800 All reviewed patches have been landed. Closing bug. 1620120 4 webkit-bug-importer 2020-02-18 06:16:13 -0800 <rdar://problem/59547710> 1620151 5 sabouhallawa 2020-02-18 08:40:52 -0800 (In reply to Chris Lord from comment #0) > > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28, > > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()': > > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData' > > | 115 | auto* dstPixelArray = imageResult ? imageResult->data() : nullptr; > > | | ^~ > > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25, > > | from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26, > > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > > I don't know what the best fix is, but including ImageData.h in > FEBlendNEON.h does fix it, so I'll attach that patch. Yes this is the right fix. It is caused by the unified sources compilation. Thanks for taking care of this failure. 391039 2020-02-18 03:59:31 -0800 2020-02-18 06:15:45 -0800 Patch bug-207885-20200218115928.patch text/plain 1302 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWI2NWQ2YWE1YWUyZWMz MWRhMDA2MGQxMzRmNGUyZmVmYTJjNzZhNy4uNGYxYjAyMDg2ZjJjMjZmYjI3MWQyNjU0MDdiYzVk NTRjZWY5YzUyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAyLTE4ICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbQVJNXSBCdWlsZCBmYWlsdXJl IG9uIGFybSBkdWUgdG8gaW52YWxpZCB1c2Ugb2YgaW5jb21wbGV0ZSB0eXBlICdjbGFzcyBXZWJD b3JlOjpJbWFnZURhdGEnIGluIEZFQmxlbmRORU9OLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzg4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gZnVuY3Rpb25hbCBjaGFu Z2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRlcnMvRkVCbGVu ZE5FT04uaDoKKwogMjAyMC0wMi0xOCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FA YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgSW1hZ2VCdWZmZXI6OmdldEltYWdlRGF0YSgpIGFu ZCBwdXRJbWFnZURhdGEoKSByZXR1cm4gYW5kIHRha2UgSW1hZ2VEYXRhCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRlcnMvRkVCbGVuZE5F T04uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9hcm0vZmlsdGVycy9G RUJsZW5kTkVPTi5oCmluZGV4IGM5NmUzM2NhNWY2MTMxZTUyZTFlOWQ0NWQ3YzAyMTYzZGU0YWNj MzEuLmRmZTM1MzA1NTBlZGQyZDBmNzA4NjQwYmU5YTE0NjI4OTcwNzYyN2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9hcm0vZmlsdGVycy9GRUJsZW5k TkVPTi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9hcm0vZmls dGVycy9GRUJsZW5kTkVPTi5oCkBAIC0zMSw2ICszMSw3IEBACiAjaWYgSEFWRShBUk1fTkVPTl9J TlRSSU5TSUNTKQogCiAjaW5jbHVkZSAiRkVCbGVuZC5oIgorI2luY2x1ZGUgIkltYWdlRGF0YS5o IgogI2luY2x1ZGUgPGFybV9uZW9uLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK