207879 2020-02-17 20:59:54 -0800 [LFC][TreeBuilding] Take createLineBreakBox's return value 2020-02-18 07:18:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1620060 0 zalan 2020-02-17 20:59:54 -0800 childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)) 1620061 1 webkit-bug-importer 2020-02-17 21:00:18 -0800 <rdar://problem/59537585> 1620062 2 391027 zalan 2020-02-17 21:07:04 -0800 Created attachment 391027 Patch 1620100 3 391027 koivisto 2020-02-18 02:45:09 -0800 Comment on attachment 391027 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391027&action=review > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216 > - createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); > + childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); lol 1620130 4 391027 commit-queue 2020-02-18 06:57:58 -0800 Comment on attachment 391027 Patch Clearing flags on attachment: 391027 Committed r256827: <https://trac.webkit.org/changeset/256827> 1620131 5 commit-queue 2020-02-18 06:58:00 -0800 All reviewed patches have been landed. Closing bug. 1620133 6 zalan 2020-02-18 07:18:35 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 391027 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391027&action=review > > > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216 > > - createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); > > + childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); > > lol exactly my thoughts. 391027 2020-02-17 21:07:04 -0800 2020-02-18 06:57:58 -0800 Patch bug-207879-20200217210704.patch text/plain 3985 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJiOGY3YjViZTAzNzk0 OTRhNzAxYzFlOGEwNjRmNGMyOGJhZTg4ZS4uZjI5ZGMxYTE2MjQ4OThjNjE3ZGNhZWY0OGQ4NWU4 ZmYyNTE3YzEyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAyLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bVHJlZUJ1aWxkaW5n XSBUYWtlIGNyZWF0ZUxpbmVCcmVha0JveCdzIHJldHVybiB2YWx1ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3ODc5CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81OTUzNzU4NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0OiBmYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2JyLWluLWlubGlu ZS1jb250ZW50LXNpbXBsZS5odG1sCisKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlv dXRUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OlRyZWVCdWlsZGVy OjpjcmVhdGVMYXlvdXRCb3gpOgorCiAyMDIwLTAyLTE3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBh cHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBBZGQgbWlzc2luZyBmbG9hdCBjaGVjayBp biBpbmxpbmUgbGluZSBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9s YXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9s YXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcAppbmRleCBkNWVmZTcxMGZiYjY1ZGNmZThj N2ExNTEzMWUwNmQ5NjM2MWI0ZGM4Li40MTI2OWNhNjlkNTQwNTgzOWQ5NzgzYzNjZTA2NDUzOTQy M2QyODk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlv dXRUcmVlQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUv TGF5b3V0VHJlZUJ1aWxkZXIuY3BwCkBAIC0yMTMsNyArMjEzLDcgQEAgQm94KiBUcmVlQnVpbGRl cjo6Y3JlYXRlTGF5b3V0Qm94KGNvbnN0IENvbnRhaW5lckJveCYgcGFyZW50Q29udGFpbmVyLCBj b25zdCBSZW4KICAgICAgICAgaWYgKGlzPFJlbmRlckxpbmVCcmVhaz4ocmVuZGVyZXIpKSB7CiAg ICAgICAgICAgICBjbG9uZWRTdHlsZS5zZXREaXNwbGF5KERpc3BsYXlUeXBlOjpJbmxpbmUpOwog ICAgICAgICAgICAgY2xvbmVkU3R5bGUuc2V0RmxvYXRpbmcoRmxvYXQ6Ok5vKTsKLSAgICAgICAg ICAgIGNyZWF0ZUxpbmVCcmVha0JveChkb3duY2FzdDxSZW5kZXJMaW5lQnJlYWs+KGNoaWxkUmVu ZGVyZXIpLmlzV0JSKCksIFdURk1vdmUoY2xvbmVkU3R5bGUpKTsKKyAgICAgICAgICAgIGNoaWxk TGF5b3V0Qm94ID0gJmNyZWF0ZUxpbmVCcmVha0JveChkb3duY2FzdDxSZW5kZXJMaW5lQnJlYWs+ KGNoaWxkUmVuZGVyZXIpLmlzV0JSKCksIFdURk1vdmUoY2xvbmVkU3R5bGUpKTsKICAgICAgICAg fSBlbHNlIGlmIChpczxSZW5kZXJUYWJsZT4ocmVuZGVyZXIpKSB7CiAgICAgICAgICAgICAvLyBD b25zdHJ1Y3QgdGhlIHByaW5jaXBhbCB0YWJsZSB3cmFwcGVyIGJveCAoYW5kIG5vdCB0aGUgdGFi bGUgYm94IGl0c2VsZikuCiAgICAgICAgICAgICBjaGlsZExheW91dEJveCA9ICZjcmVhdGVDb250 YWluZXIoQm94OjpFbGVtZW50QXR0cmlidXRlcyB7IEJveDo6RWxlbWVudFR5cGU6OlRhYmxlV3Jh cHBlckJveCB9LCBXVEZNb3ZlKGNsb25lZFN0eWxlKSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTViZDkxNjE2MjgxOTk3 ZDA5YWQzM2VkOTBiYzkwMjk3NDJjZjljMy4uOGE3ODc5ODllOWY0YjU3MzhhYzE5N2IwZjM3N2Qz ZTU1NDMxODQ3YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAyLTE3ICBaYWxhbiBCdWp0 YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bVHJlZUJ1aWxkaW5nXSBUYWtl IGNyZWF0ZUxpbmVCcmVha0JveCdzIHJldHVybiB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3ODc5CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81OTUzNzU4NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGZhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvYnItaW4taW5saW5lLWNvbnRlbnQt c2ltcGxlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbGF5b3V0Zm9ybWF0 dGluZ2NvbnRleHQvYnItaW4taW5saW5lLWNvbnRlbnQtc2ltcGxlLmh0bWw6IEFkZGVkLgorCiAy MDIwLTAyLTE3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q11bSUZDXSBBZGQgbWlzc2luZyBmbG9hdCBjaGVjayBpbiBpbmxpbmUgbGluZSBsYXlvdXQKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvYnItaW4t aW5saW5lLWNvbnRlbnQtc2ltcGxlLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2xh eW91dGZvcm1hdHRpbmdjb250ZXh0L2JyLWluLWlubGluZS1jb250ZW50LXNpbXBsZS1leHBlY3Rl ZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjliM2JmMGI4M2M1NmJjODcyMGVhZWZkMTZlYjZmMTMwYTUyNzRl YTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdj b250ZXh0L2JyLWluLWlubGluZS1jb250ZW50LXNpbXBsZS1leHBlY3RlZC5odG1sCkBAIC0wLDAg KzEsMiBAQAorPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0 aW5nQ29udGV4dEVuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0aW5nQ29udGV4dElu dGVncmF0aW9uRW5hYmxlZD1mYWxzZSBdIC0tPgorPGRpdiBzdHlsZT0iYm9yZGVyOiAxcHggc29s aWQgZ3JlZW47IHdpZHRoOiAyMDBweDsgaGVpZ2h0OiAyMDBweDsiPjwvZGl2PgpcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9y bWF0dGluZ2NvbnRleHQvYnItaW4taW5saW5lLWNvbnRlbnQtc2ltcGxlLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2JyLWluLWlubGluZS1jb250ZW50LXNp bXBsZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ2MmMxZjMyM2IzYzg5NjJlNTNhYTMyZDZlZTcwNTc5Mjdk MmQ4ZjgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRp bmdjb250ZXh0L2JyLWluLWlubGluZS1jb250ZW50LXNpbXBsZS5odG1sCkBAIC0wLDAgKzEsMiBA QAorPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0aW5nQ29u dGV4dEVuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0aW5nQ29udGV4dEludGVncmF0 aW9uRW5hYmxlZD1mYWxzZSBdIC0tPgorPGRpdiBzdHlsZT0iYm9yZGVyOiAxcHggc29saWQgZ3Jl ZW47IHdpZHRoOiAyMDBweDsgaGVpZ2h0OiAyMDBweDsgY29sb3I6IHdoaXRlIj50ZXh0PGJyPmFu ZDxicj5zb21lPGJyPm1vcmU8L2Rpdj4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==