207878 2020-02-17 20:30:48 -0800 [LFC][IFC] Add missing float check in inline line layout 2020-02-18 08:03:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1620054 0 zalan 2020-02-17 20:30:48 -0800 ssia 1620058 1 webkit-bug-importer 2020-02-17 20:51:42 -0800 <rdar://problem/59537467> 1620059 2 391026 zalan 2020-02-17 20:54:16 -0800 Created attachment 391026 Patch 1620137 3 391026 commit-queue 2020-02-18 08:02:57 -0800 Comment on attachment 391026 Patch Clearing flags on attachment: 391026 Committed r256829: <https://trac.webkit.org/changeset/256829> 1620138 4 commit-queue 2020-02-18 08:03:01 -0800 All reviewed patches have been landed. Closing bug. 391026 2020-02-17 20:54:16 -0800 2020-02-18 08:02:57 -0800 Patch bug-207878-20200217205415.patch text/plain 7232 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDU5MjU1OTNhMWYyMzMx MDYxNDk5YWU5NmQyODliMmNiYTFiNjA4ZC4uNzJiOGY3YjViZTAzNzk0OTRhNzAxYzFlOGEwNjRm NGMyOGJhZTg4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAyLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBBZGQgbWlz c2luZyBmbG9hdCBjaGVjayBpbiBpbmxpbmUgbGluZSBsYXlvdXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzg3OAorICAgICAgICA8cmRhcjovL3By b2JsZW0vNTk1Mzc0Njc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdDogZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9mbG9hdC1pbi1pbmxp bmUtY29udGV4dC1zaW1wbGUuaHRtbAorCisgICAgICAgIE1ha2Ugc3VyZSBmbG9hdCBjb250ZW50 IGdldHMgbGFpZCBvdXQgYXMgd2VsbC4gCisKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0 dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0OjpsYXlvdXRJbkZsb3dDb250ZW50KToKKyAgICAg ICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OmlzQXRTb2Z0V3JhcE9wcG9ydHVuaXR5KToKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6bmV4dFdyYXBPcHBvcnR1bml0eSk6CisKIDIwMjAtMDItMTcgIFBl bmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggY2hlY2std2Via2l0 LXN0eWxlIGVycm9ycyByZWxhdGVkIHRvIEFWRm91bmRhdGlvblNQSS5oCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29u dGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVG b3JtYXR0aW5nQ29udGV4dC5jcHAKaW5kZXggMmRhMTVmNzhiMmM3ZDc0NDIwYjYyMTQ4OWFkYjM3 ZWM1NTVkN2ZiMS4uMTkyYzE1OTYwY2JhMzE2YjE5OGU3OTYxYjU2YTIwYWZmODliN2FlYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9y bWF0dGluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3Jt YXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcApAQCAtODUsMTMgKzg1LDEzIEBAIHZv aWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91dEluRmxvd0NvbnRlbnQoSW52YWxpZGF0 aW9uU3RhdGUmIGludmFsaWRhdGlvCiAgICAgLy8gMS4gVmlzaXQgZWFjaCBpbmxpbmUgYm94IGFu ZCBwYXJ0aWFsbHkgY29tcHV0ZSB0aGVpciBnZW9tZXRyeSAobWFyZ2lucywgcGFkZGluZ3MgYW5k IGJvcmRlcnMpLgogICAgIC8vIDIuIENvbGxlY3QgdGhlIGlubGluZSBpdGVtcyAoZmxhdHRlbiB0 aGUgdGhlIGxheW91dCB0cmVlKSBhbmQgcGxhY2UgdGhlbSBvbiBsaW5lcyBpbiBiaWRpcmVjdGlv bmFsIG9yZGVyLiAKICAgICB3aGlsZSAobGF5b3V0Qm94KSB7Ci0gICAgICAgIEFTU0VSVChsYXlv dXRCb3gtPmlzSW5saW5lTGV2ZWxCb3goKSk7CisgICAgICAgIEFTU0VSVChsYXlvdXRCb3gtPmlz SW5saW5lTGV2ZWxCb3goKSB8fCBsYXlvdXRCb3gtPmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkpOwog Ci0gICAgICAgIGlmIChsYXlvdXRCb3gtPmlzQXRvbWljSW5saW5lTGV2ZWxCb3goKSkgeworICAg ICAgICBpZiAobGF5b3V0Qm94LT5pc0F0b21pY0lubGluZUxldmVsQm94KCkgfHwgbGF5b3V0Qm94 LT5pc0Zsb2F0aW5nUG9zaXRpb25lZCgpKSB7CiAgICAgICAgICAgICAvLyBJbmxpbmUtYmxvY2tz LCBpbmxpbmUtdGFibGVzIGFuZCByZXBsYWNlZCBlbGVtZW50cyAoaW1nLCB2aWRlbykgY2FuIGJl IHNpemVkIGJ1dCBub3QgeWV0IHBvc2l0aW9uZWQuCiAgICAgICAgICAgICBpZiAobGF5b3V0Qm94 LT5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250ZXh0KCkpIHsKICAgICAgICAgICAgICAgICBBU1NF UlQoaXM8Q29udGFpbmVyQm94PigqbGF5b3V0Qm94KSk7Ci0gICAgICAgICAgICAgICAgQVNTRVJU KGxheW91dEJveC0+aXNJbmxpbmVCbG9ja0JveCgpIHx8IGxheW91dEJveC0+aXNJbmxpbmVUYWJs ZUJveCgpKTsKKyAgICAgICAgICAgICAgICBBU1NFUlQobGF5b3V0Qm94LT5pc0lubGluZUJsb2Nr Qm94KCkgfHwgbGF5b3V0Qm94LT5pc0lubGluZVRhYmxlQm94KCkgfHwgbGF5b3V0Qm94LT5pc0Zs b2F0aW5nUG9zaXRpb25lZCgpKTsKICAgICAgICAgICAgICAgICBhdXRvJiBjb250YWluZXJCb3gg PSBkb3duY2FzdDxDb250YWluZXJCb3g+KCpsYXlvdXRCb3gpOwogICAgICAgICAgICAgICAgIGNv bXB1dGVCb3JkZXJBbmRQYWRkaW5nKGNvbnRhaW5lckJveCwgaG9yaXpvbnRhbENvbnN0cmFpbnRz KTsKICAgICAgICAgICAgICAgICBjb21wdXRlV2lkdGhBbmRNYXJnaW4oY29udGFpbmVyQm94LCBo b3Jpem9udGFsQ29uc3RyYWludHMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwCmluZGV4IDU5MDBj Mjc1MWFlMzA0NGZlYjA4ODdkZTY3MGMzZjA3MDYzYTQ3NTUuLjhjMTY1YzYxMjdiNmJiNGJmNDNj N2MzMTE2MTUwMGU4MzUyMDBhMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAKQEAgLTcyLDgg KzcyLDggQEAgc3RhdGljIGlubGluZSBib29sIGlzQXRTb2Z0V3JhcE9wcG9ydHVuaXR5KGNvbnN0 IElubGluZUl0ZW0mIGN1cnJlbnQsIGNvbnN0IElubGkKICAgICAvLyBlLmcuIFtjb250YWluZXIg c3RhcnRdW3ByaW9yX2NvbnRpbnVvdXNfY29udGVudF1bY29udGFpbmVyIGVuZF0gKDxzcGFuPnBy aW9yX2NvbnRpbnVvdXNfY29udGVudDwvc3Bhbj4pCiAgICAgLy8gQW4gaW5jb21pbmcgPGltZz4g Ym94IHdvdWxkIGVuYWJsZSB1cyB0byBjb21taXQgdGhlICI8c3Bhbj5wcmlvcl9jb250aW51b3Vz X2NvbnRlbnQ8L3NwYW4+IiBjb250ZW50CiAgICAgLy8gYnV0IGFuIGluY29taW5nIHRleHQgY29u dGVudCB3b3VsZCBub3QgbmVjZXNzYXJpbHkuCi0gICAgQVNTRVJUKGN1cnJlbnQuaXNUZXh0KCkg fHwgY3VycmVudC5pc0JveCgpKTsKLSAgICBBU1NFUlQobmV4dC5pc1RleHQoKSB8fCBuZXh0Lmlz Qm94KCkpOworICAgIEFTU0VSVChjdXJyZW50LmlzVGV4dCgpIHx8IGN1cnJlbnQuaXNCb3goKSB8 fCBjdXJyZW50LmlzRmxvYXQoKSk7CisgICAgQVNTRVJUKG5leHQuaXNUZXh0KCkgfHwgbmV4dC5p c0JveCgpIHx8IG5leHQuaXNGbG9hdCgpKTsKICAgICBpZiAoY3VycmVudC5pc1RleHQoKSAmJiBu ZXh0LmlzVGV4dCgpKSB7CiAgICAgICAgIGF1dG8mIGN1cnJlbnRJbmxpbmVUZXh0SXRlbSA9IGRv d25jYXN0PElubGluZVRleHRJdGVtPihjdXJyZW50KTsKICAgICAgICAgYXV0byYgbmV4dElubGlu ZVRleHRJdGVtID0gZG93bmNhc3Q8SW5saW5lVGV4dEl0ZW0+KG5leHQpOwpAQCAtMTAxLDYgKzEw MSwxMSBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNBdFNvZnRXcmFwT3Bwb3J0dW5pdHkoY29uc3Qg SW5saW5lSXRlbSYgY3VycmVudCwgY29uc3QgSW5saQogICAgICAgICAvLyBUaGUgbGluZSBicmVh a2luZyBiZWhhdmlvciBvZiBhIHJlcGxhY2VkIGVsZW1lbnQgb3Igb3RoZXIgYXRvbWljIGlubGlu ZSBpcyBlcXVpdmFsZW50IHRvIGFuIGlkZW9ncmFwaGljIGNoYXJhY3Rlci4KICAgICAgICAgcmV0 dXJuIHRydWU7CiAgICAgfQorICAgIGlmIChjdXJyZW50LmlzRmxvYXQoKSB8fCBuZXh0LmlzRmxv YXQoKSkgeworICAgICAgICAvLyBXaGlsZSBmbG9hdHMgYXJlIG5vdCBwYXJ0IG9mIHRoZSBpbmxp bmUgY29udGVudCwgbGV0J3MganVzdCBoYW5kbGUgdGhlbSBhcyBpZiB0aGV5IHdlcmUgaW5saW5l IGJveGVzIGZvciBub3cgYW5kIHByZXRlbmQKKyAgICAgICAgLy8gdGhlcmUncyBhIHNvZnQgd3Jh cHBpbmcgb3Bwb3J0dW5pdHkgaGVyZSAodGV4dCBiZWZvcmU8ZGl2IHN0eWxlPSJmbG9hdDogbGVm dCI+PC9kaXY+YW5kIGFmdGVyKS4KKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQogICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiB0cnVlOwogfQpAQCAtMTIxLDcgKzEyNiw3 IEBAIHN0YXRpYyBpbmxpbmUgc2l6ZV90IG5leHRXcmFwT3Bwb3J0dW5pdHkoY29uc3QgSW5saW5l SXRlbXMmIGlubGluZUNvbnRlbnQsIHNpemVfCiAgICAgICAgIC8vIEJyZWFrIGF0IHRoZSBmaXJz dCB0ZXh0L2JveC9saW5lIGJyZWFrIGlubGluZSBpdGVtLgogICAgICAgICBmb3IgKDsgaW5kZXgg PCBsYXlvdXRSYW5nZS5lbmQ7ICsraW5kZXgpIHsKICAgICAgICAgICAgIGF1dG8mIGlubGluZUl0 ZW0gPSBpbmxpbmVDb250ZW50W2luZGV4XTsKLSAgICAgICAgICAgIGlmIChpbmxpbmVJdGVtLmlz VGV4dCgpIHx8IGlubGluZUl0ZW0uaXNCb3goKSkKKyAgICAgICAgICAgIGlmIChpbmxpbmVJdGVt LmlzVGV4dCgpIHx8IGlubGluZUl0ZW0uaXNCb3goKSB8fCBpbmxpbmVJdGVtLmlzRmxvYXQoKSkK ICAgICAgICAgICAgICAgICByZXR1cm4gaW5kZXg7CiAgICAgICAgICAgICBpZiAoaW5saW5lSXRl bS5pc0xpbmVCcmVhaygpKSB7CiAgICAgICAgICAgICAgICAgaXNBdExpbmVCcmVhayA9IHRydWU7 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZGE5Yzc3Yzk0ZjgxZGVjNTgzM2FhZDllMTQyODJiZjVhYmQyYmJlMC4uNTViZDkx NjE2MjgxOTk3ZDA5YWQzM2VkOTBiYzkwMjk3NDJjZjljMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTAyLTE3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAg W0xGQ11bSUZDXSBBZGQgbWlzc2luZyBmbG9hdCBjaGVjayBpbiBpbmxpbmUgbGluZSBsYXlvdXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzg3OAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk1Mzc0Njc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0 L2Zsb2F0LWluLWlubGluZS1jb250ZXh0LXNpbXBsZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2Zsb2F0LWluLWlubGluZS1jb250 ZXh0LXNpbXBsZS5odG1sOiBBZGRlZC4KKwogMjAyMC0wMi0xNyAgSmFzb24gTGF3cmVuY2UgIDxs YXdyZW5jZS5qQGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hYyBdIGZhc3QvaW1hZ2VzL3dlYnAt YXMtaW1hZ2UuaHRtbCBpcyBmYWlsaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9s YXlvdXRmb3JtYXR0aW5nY29udGV4dC9mbG9hdC1pbi1pbmxpbmUtY29udGV4dC1zaW1wbGUtZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvZmxv YXQtaW4taW5saW5lLWNvbnRleHQtc2ltcGxlLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzU0 YTQ4MTM1MzQ3MGVjYThkMDAxOGYyYWFiN2Q5Yzc0Mzg3ZTMyNQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvZmxvYXQtaW4taW5saW5l LWNvbnRleHQtc2ltcGxlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw0IEBACis8IS0tIHdlYmtp dC10ZXN0LXJ1bm5lciBbIGludGVybmFsOkxheW91dEZvcm1hdHRpbmdDb250ZXh0RW5hYmxlZD10 cnVlIGludGVybmFsOkxheW91dEZvcm1hdHRpbmdDb250ZXh0SW50ZWdyYXRpb25FbmFibGVkPWZh bHNlIF0gLS0+Cis8ZGl2IHN0eWxlPSJoZWlnaHQ6IDEwMHB4OyBib3JkZXI6IDFweCBzb2xpZCBn cmVlbjsiPgorPGRpdiBzdHlsZT0id2lkdGg6IDIwcHg7IGhlaWdodDogMjBweDsgYm9yZGVyOiAx cHggc29saWQgYmx1ZSI+PC9kaXY+Cis8L2Rpdj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvZmxvYXQtaW4taW5saW5lLWNvbnRleHQtc2ltcGxl Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2Zsb2F0LWlu LWlubGluZS1jb250ZXh0LXNpbXBsZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA1MzNkMmViNTc2ZmU1OTVh NjMzMmZhMTRiNjBhNGE1ODRlNDQzYmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2Zsb2F0LWluLWlubGluZS1jb250ZXh0LXNpbXBs ZS5odG1sCkBAIC0wLDAgKzEsNCBAQAorPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5h bDpMYXlvdXRGb3JtYXR0aW5nQ29udGV4dEVuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpMYXlvdXRGb3Jt YXR0aW5nQ29udGV4dEludGVncmF0aW9uRW5hYmxlZD1mYWxzZSBdIC0tPgorPGRpdiBzdHlsZT0i Y29sb3I6IHdoaXRlOyBoZWlnaHQ6IDEwMHB4OyBib3JkZXI6IDFweCBzb2xpZCBncmVlbjsiPgor dGV4dCBiZWZvcmU8ZGl2IHN0eWxlPSJmbG9hdDogbGVmdDsgd2lkdGg6IDIwcHg7IGhlaWdodDog MjBweDsgYm9yZGVyOiAxcHggc29saWQgYmx1ZSI+PC9kaXY+YWZ0ZXIKKzwvZGl2Pgo=