207860 2020-02-17 14:16:06 -0800 REGRESSION (r251320): Data detectors do not trigger on macCatalyst 2020-02-17 16:50:47 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue thorton wenson_hsieh oldest_to_newest 1619879 0 megan_gardner 2020-02-17 14:16:06 -0800 Send touches to data detectors gesture on macCataylst as the gesture currently runs on touch data. 1619880 1 390979 megan_gardner 2020-02-17 14:19:13 -0800 Created attachment 390979 Patch 1619881 2 megan_gardner 2020-02-17 14:20:02 -0800 <rdar://problem/59038913> 1619885 3 390979 thorton 2020-02-17 14:26:31 -0800 Comment on attachment 390979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390979&action=review > Source/WebKit/ChangeLog:3 > + Send touches to data detectors gesture on macCataylst as the gesture currently runs on touch data. DataDetectors, macCatalyst (the y is misplaced), also this should be the "problem" not the "solution" ("REGRESSION (r???): Data Detectors gesture does not trigger in macCatalyst") 1619895 4 390983 megan_gardner 2020-02-17 14:41:06 -0800 Created attachment 390983 Patch for landing 1619978 5 390983 commit-queue 2020-02-17 16:50:46 -0800 Comment on attachment 390983 Patch for landing Clearing flags on attachment: 390983 Committed r256790: <https://trac.webkit.org/changeset/256790> 1619979 6 commit-queue 2020-02-17 16:50:47 -0800 All reviewed patches have been landed. Closing bug. 390979 2020-02-17 14:19:13 -0800 2020-02-17 14:41:04 -0800 Patch bug-207860-20200217141911.patch text/plain 1775 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE5Y2QxNTNlMDkyMTVhODFl ZTVkMmNhOTY4MGE0YjlkYjNlZDdiZDQuLjkzYWQ0YTMwMmM3N2U3MmJkOTYzMGRjMDU4OWZkYjU2 MGE1MmIwNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDItMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBTZW5kIHRvdWNoZXMg dG8gZGF0YSBkZXRlY3RvcnMgZ2VzdHVyZSBvbiBtYWNDYXRheWxzdCBhcyB0aGUgZ2VzdHVyZSBj dXJyZW50bHkgcnVucyBvbiB0b3VjaCBkYXRhLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3ODYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGxvb2t1cCBnZXN0dXJlIHdoaWNoIHJ1biBkYXRhIGRl dGVjdGlvbiBuZWVkcyB0b3VjaCBpbmZvcm1hdGlvbiB0byBmdW5jdGlvbi4gQWxsb3cgdG91Y2hl cyB0byBiZSBzZW50IHRvIHRoZSBnZXN0dXJlLiAKKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGdl c3R1cmVSZWNvZ25pemVyOnNob3VsZFJlY2VpdmVUb3VjaDpdKToKKwogMjAyMC0wMi0xNyAgWW91 ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdlYkluc3BlY3Rv ciBzdXBwb3J0IHRvIFdlYktpdDo6V2ViU29ja2V0Q2hhbm5lbApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXgg ZTFjMmJiODcyNWI2MWEwNGVlZTBiYWE3MDBmZDNiMWU4ZmJiOGU1Zi4uMDE4NTk1MWJkYmQ5Y2Y2 ZjNhM2EzMjhjZDNhNWY1MjExODZhY2Q3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xNTI5LDcgKzE1 MjksNyBAQCAtICh2b2lkKV9oYW5kbGVUb3VjaEFjdGlvbnNGb3JUb3VjaEV2ZW50Oihjb25zdCBX ZWJLaXQ6Ok5hdGl2ZVdlYlRvdWNoRXZlbnQmKXRvdQogLSAoQk9PTClnZXN0dXJlUmVjb2duaXpl cjooVUlHZXN0dXJlUmVjb2duaXplciAqKWdlc3R1cmVSZWNvZ25pemVyIHNob3VsZFJlY2VpdmVU b3VjaDooVUlUb3VjaCAqKXRvdWNoCiB7CiAjaWYgSEFWRShIT1ZFUl9HRVNUVVJFX1JFQ09HTkla RVIpCi0gICAgaWYgKGdlc3R1cmVSZWNvZ25pemVyICE9IF9tb3VzZUdlc3R1cmVSZWNvZ25pemVy ICYmIFtfbW91c2VHZXN0dXJlUmVjb2duaXplciBtb3VzZVRvdWNoXSA9PSB0b3VjaCkKKyAgICBp ZiAoZ2VzdHVyZVJlY29nbml6ZXIgIT0gX2xvb2t1cEdlc3R1cmVSZWNvZ25pemVyICYmIChnZXN0 dXJlUmVjb2duaXplciAhPSBfbW91c2VHZXN0dXJlUmVjb2duaXplciAmJiBbX21vdXNlR2VzdHVy ZVJlY29nbml6ZXIgbW91c2VUb3VjaF0gPT0gdG91Y2gpKQogICAgICAgICByZXR1cm4gTk87CiAj ZW5kaWYKIAo= 390983 2020-02-17 14:41:06 -0800 2020-02-17 16:50:46 -0800 Patch for landing bug-207860-20200217144105.patch text/plain 1752 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE5Y2QxNTNlMDkyMTVhODFl ZTVkMmNhOTY4MGE0YjlkYjNlZDdiZDQuLjE4ZTJlMTVhMDc0OWE5ZGNlZmQyNzcwYTk5ZGIzMjli YWY3ZWE1ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRhIGRldGVjdG9y cyBkbyBub3QgdHJpZ2dlciBvbiBtYWNDYXRhbHlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3ODYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81 OTAzODkxMz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIFRo ZSBsb29rdXAgZ2VzdHVyZSB3aGljaCBydW4gZGF0YSBkZXRlY3Rpb24gbmVlZHMgdG91Y2ggaW5m b3JtYXRpb24gdG8gZnVuY3Rpb24uIEFsbG93IHRvdWNoZXMgdG8gYmUgc2VudCB0byB0aGUgZ2Vz dHVyZS4gCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBnZXN0dXJlUmVjb2duaXplcjpzaG91bGRS ZWNlaXZlVG91Y2g6XSk6CisKIDIwMjAtMDItMTcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCBXZWJJbnNwZWN0b3Igc3VwcG9ydCB0byBXZWJLaXQ6Oldl YlNvY2tldENoYW5uZWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGUxYzJiYjg3MjViNjFhMDRlZWUwYmFh NzAwZmQzYjFlOGZiYjhlNWYuLjAxODU5NTFiZGJkOWNmNmYzYTNhMzI4Y2QzYTVmNTIxMTg2YWNk NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTUyOSw3ICsxNTI5LDcgQEAgLSAodm9pZClfaGFuZGxl VG91Y2hBY3Rpb25zRm9yVG91Y2hFdmVudDooY29uc3QgV2ViS2l0OjpOYXRpdmVXZWJUb3VjaEV2 ZW50Jil0b3UKIC0gKEJPT0wpZ2VzdHVyZVJlY29nbml6ZXI6KFVJR2VzdHVyZVJlY29nbml6ZXIg KilnZXN0dXJlUmVjb2duaXplciBzaG91bGRSZWNlaXZlVG91Y2g6KFVJVG91Y2ggKil0b3VjaAog ewogI2lmIEhBVkUoSE9WRVJfR0VTVFVSRV9SRUNPR05JWkVSKQotICAgIGlmIChnZXN0dXJlUmVj b2duaXplciAhPSBfbW91c2VHZXN0dXJlUmVjb2duaXplciAmJiBbX21vdXNlR2VzdHVyZVJlY29n bml6ZXIgbW91c2VUb3VjaF0gPT0gdG91Y2gpCisgICAgaWYgKGdlc3R1cmVSZWNvZ25pemVyICE9 IF9sb29rdXBHZXN0dXJlUmVjb2duaXplciAmJiAoZ2VzdHVyZVJlY29nbml6ZXIgIT0gX21vdXNl R2VzdHVyZVJlY29nbml6ZXIgJiYgW19tb3VzZUdlc3R1cmVSZWNvZ25pemVyIG1vdXNlVG91Y2hd ID09IHRvdWNoKSkKICAgICAgICAgcmV0dXJuIE5POwogI2VuZGlmCiAK