<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>207858</bug_id>
          
          <creation_ts>2020-02-17 13:46:44 -0800</creation_ts>
          <short_desc>Changed results due to ANGLE use</short_desc>
          <delta_ts>2025-04-18 05:21:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>212286</dependson>
    
    <dependson>212287</dependson>
    
    <dependson>209139</dependson>
    
    <dependson>210524</dependson>
    
    <dependson>211055</dependson>
    
    <dependson>211758</dependson>
    
    <dependson>212056</dependson>
    
    <dependson>212249</dependson>
    
    <dependson>212271</dependson>
    
    <dependson>212277</dependson>
          <blocked>126404</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dean Jackson">dino</reporter>
          <assigned_to name="Dean Jackson">dino</assigned_to>
          <cc>ap</cc>
    
    <cc>aqeelalamdp</cc>
    
    <cc>dino</cc>
    
    <cc>jacob_uphoff</cc>
    
    <cc>jdarpinian</cc>
    
    <cc>justin_fan</cc>
    
    <cc>kbr</cc>
    
    <cc>Lawrence.j</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1619858</commentid>
    <comment_count>0</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-02-17 13:46:44 -0800</bug_when>
    <thetext>While switching over to ANGLE, the following tests required something more than a rebaseline.

macOS:

fast/canvas/webgl/readPixels-float.html
fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html
fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html
fast/canvas/webgl/webgl2-texture-upload-enums.html
fast/canvas/webgl/texImage2D-video-flipY-false.html (times out)

iOS Simulator:

fast/canvas/webgl/context-attributes-alpha.html (ref test)
fast/canvas/webgl/match-page-color-space.html (ref test)
webgl/smell-test.html (ref test)
webgl/webgl-backing-store-size-update.html (ref test)
webgl/webgl-border.html (ref test)
webgl/webgl-box-shadow.html (ref test)
webgl/misc/switch-to-discrete-gpu.html (why is this even running on iOS?)
fast/canvas/webgl/oes-texture-half-float-uint16.html
fast/canvas/webgl/uninitialized-test.html
fast/canvas/webgl/webgl-depth-texture.html (marked as not supported! why?)
fast/canvas/webgl/webgl-texture-binding-preserved.html
webgl/1.0.3/conformance/canvas/texture-bindings-unaffected-on-resize.html
webgl/1.0.3/conformance/context/context-lost-restored.html
webgl/1.0.3/conformance/extensions/ext-sRGB.html
webgl/1.0.3/conformance/extensions/oes-element-index-uint.html
webgl/1.0.3/conformance/glsl/misc/shader-struct-scope.html
webgl/1.0.3/conformance/misc/delayed-drawing.html
webgl/1.0.3/conformance/misc/uninitialized-test.html
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
webgl/1.0.3/conformance/state/state-uneffected-after-compositing.html
webgl/1.0.3/conformance/textures/default-texture.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgb565.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba4444.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1619859</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-02-17 13:46:54 -0800</bug_when>
    <thetext>&lt;rdar://problem/59524399&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1619903</commentid>
    <comment_count>2</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-02-17 14:53:27 -0800</bug_when>
    <thetext>Also fast/canvas/webgl/oes-texture-float-linear.html is saying OES_texture_float is not supported on iOS simulator.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1619905</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-02-17 14:53:36 -0800</bug_when>
    <thetext>&lt;rdar://problem/59527402&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1619970</commentid>
    <comment_count>4</comment_count>
    <who name="Jacob Uphoff">jacob_uphoff</who>
    <bug_when>2020-02-17 16:43:08 -0800</bug_when>
    <thetext>Please add expectations for the following:

fast/canvas/webgl/program-test.html
webgl/1.0.3/conformance/programs/program-test.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1620007</commentid>
    <comment_count>5</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-02-17 17:43:49 -0800</bug_when>
    <thetext>WebGL 2 macOS:

webgl/2.0.0/conformance/extensions/oes-vertex-array-object.html
webgl/2.0.0/conformance/programs/program-test.html
webgl/2.0.0/conformance2/buffers/buffer-type-restrictions.html (improved overall)
webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html
webgl/2.0.0/conformance2/buffers/one-large-uniform-buffer.html
webgl/2.0.0/conformance2/extensions/promoted-extensions.html
webgl/2.0.0/conformance2/misc/expando-loss-2.html
webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test.html
webgl/2.0.0/conformance2/renderbuffers/invalidate-framebuffer.html
webgl/2.0.0/conformance2/renderbuffers/multisample-with-full-sample-counts.html
webgl/2.0.0/conformance2/renderbuffers/multisampled-renderbuffer-initialization.html
webgl/2.0.0/conformance2/rendering/canvas-resizing-with-pbo-bound.html
webgl/2.0.0/conformance2/rendering/instanced-arrays.html
webgl/2.0.0/conformance2/rendering/instanced-rendering-bug.html
webgl/2.0.0/conformance2/rendering/rgb-format-support.html
webgl/2.0.0/conformance2/textures/image_bitmap_from_image/* (all timed out)
webgl/2.0.0/conformance2/textures/image_bitmap_from_video/* (all timed out)
webgl/2.0.0/conformance2/textures/video (timed out)
webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object.html

(These are just a list of things that started failing more. The results might have been misleading to begin with.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1620011</commentid>
    <comment_count>6</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-02-17 17:52:55 -0800</bug_when>
    <thetext>(In reply to Jacob Uphoff from comment #4)
&gt; Please add expectations for the following:
&gt; 
&gt; fast/canvas/webgl/program-test.html
&gt; webgl/1.0.3/conformance/programs/program-test.html
https://trac.webkit.org/changeset/256802/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1620196</commentid>
    <comment_count>7</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-02-18 09:48:33 -0800</bug_when>
    <thetext>*** Bug 207896 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1620197</commentid>
    <comment_count>8</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-02-18 09:48:45 -0800</bug_when>
    <thetext>iOS:

fast/canvas/webgl/oes-vertex-array-object.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1620198</commentid>
    <comment_count>9</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-02-18 09:52:44 -0800</bug_when>
    <thetext>rdar://59524399</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1621286</commentid>
    <comment_count>10</comment_count>
    <who name="Jacob Uphoff">jacob_uphoff</who>
    <bug_when>2020-02-20 10:33:37 -0800</bug_when>
    <thetext>fast/images/exif-orientation-webgl-texture.html

This test is also failing with the changes made here</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1621785</commentid>
    <comment_count>11</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-02-21 14:38:44 -0800</bug_when>
    <thetext>iOS:
fast/images/exif-orientation-webgl-texture.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622323</commentid>
    <comment_count>12</comment_count>
    <who name="Jason Lawrence">Lawrence.j</who>
    <bug_when>2020-02-24 14:27:01 -0800</bug_when>
    <thetext>This test is flaky failing on Mojave:
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622339</commentid>
    <comment_count>13</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-02-24 14:46:48 -0800</bug_when>
    <thetext>(In reply to Jason Lawrence from comment #12)
&gt; This test is flaky failing on Mojave:
&gt; webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-
&gt; canvas-rgba5551.html

Link to the above failures:
https://results.webkit.org/?suite=layout-tests&amp;test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Ftex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622340</commentid>
    <comment_count>14</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-02-24 14:50:01 -0800</bug_when>
    <thetext>Log from one failure:
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r257160%20(11806)/results.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622342</commentid>
    <comment_count>15</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-02-24 14:57:30 -0800</bug_when>
    <thetext>The diffs are:

 31[ 28: PASS ] shouldBe 0,255,0
 32[ 29: PASS ] shouldBe 255,0,0
 33[ 30: PASS ] shouldBe 0,255,0
 34[ 31: PASS ] shouldBe 255,0,0
 35[ 32: PASS ] shouldBe 0,255,0
 36[ 33: FAIL ] at (0, 0) expected: 255,0,0 was 0,0,0
 37[ 34: FAIL ] at (0, 16) expected: 0,255,0 was 0,0,0
 38[ 35: FAIL ] at (0, 16) expected: 255,0,0 was 0,0,0
 39[ 36: FAIL ] at (0, 0) expected: 0,255,0 was 0,0,0
 40[ 37: FAIL ] at (0, 0) expected: 255,0,0 was 0,0,0
 41[ 38: FAIL ] at (0, 16) expected: 0,255,0 was 0,0,0
 42[ 39: FAIL ] at (0, 16) expected: 255,0,0 was 0,0,0
 43[ 40: FAIL ] at (0, 0) expected: 0,255,0 was 0,0,0
...

The test case that failed in this case is the second whole iteration through the test cases in LayoutTests/webgl/1.0.3/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-webgl-canvas.js , the first test case in the list:

Testing texImage2D with flipY=true canvas size: 1x2 with red-green
Checking top
PASS shouldBe 255,0,0
Checking bottom
PASS shouldBe 0,255,0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622344</commentid>
    <comment_count>16</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-02-24 15:01:20 -0800</bug_when>
    <thetext>The failure of webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html in 
https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r257234%20(7731)/results.html failed a different sub-test, however.

We should probably mark this test flaky. Not 100% sure what could be causing this; Chrome doesn&apos;t seem to have a suppression for this test, but it is running against a newer conformance suite snapshot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624320</commentid>
    <comment_count>17</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-02-29 13:40:44 -0800</bug_when>
    <thetext>webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html fixed by 208331</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1635561</commentid>
    <comment_count>18</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-03-30 10:06:32 -0700</bug_when>
    <thetext>webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1655492</commentid>
    <comment_count>19</comment_count>
    <who name="Justin Fan">justin_fan</who>
    <bug_when>2020-05-22 16:38:14 -0700</bug_when>
    <thetext>These are the remaining WebGL1-based regressions:

iOS/Simulator:
https://bugs.webkit.org/show_bug.cgi?id=212277 webgl/1.0.3/conformance/extensions/ext-sRGB.html
https://bugs.webkit.org/show_bug.cgi?id=212271 fast/canvas/webgl/webgl-depth-texture.html
https://bugs.webkit.org/show_bug.cgi?id=209139 [ iOS wk2 ] webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html is failing. (209139)
https://bugs.webkit.org/show_bug.cgi?id=212249 [ANGLE - iOS] fast/canvas/webgl/uninitialized-test.html is still failing
——
macOS and iOS: https://bugs.webkit.org/show_bug.cgi?id=212287 
fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html (Not a breaking failure)

macOS only: https://bugs.webkit.org/show_bug.cgi?id=212286 
fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html (Not a breaking failure, tested code path will be obsoleted)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1655493</commentid>
    <comment_count>20</comment_count>
    <who name="Justin Fan">justin_fan</who>
    <bug_when>2020-05-22 16:39:16 -0700</bug_when>
    <thetext>final comment about &quot;code path will be obsoleted&quot; was in error, please ignore</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>