207850 2020-02-17 12:14:37 -0800 Update WebKit Tools to issue mach extensions as needed 2022-03-01 02:26:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207743 InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham peng.liu6 pvollan simon.fraser webkit-bug-importer oldest_to_newest 1619780 0 bfulgham 2020-02-17 12:14:37 -0800 Now that we have sandboxed the various tool projects (WebKitTestRunner, TestWebKitAPI, and MiniBrowser), we need to grant them the ability to issue mach extensions to various services needed by the WebContent, Network, and GPU processes. We probably need to get this added to an appropriate system sandbox, but for now we can use a workaround to allow test features to work properly. 1619782 1 webkit-bug-importer 2020-02-17 12:17:37 -0800 <rdar://problem/59521019> 1619784 2 390959 bfulgham 2020-02-17 12:20:56 -0800 Created attachment 390959 Patch 1619887 3 390959 pvollan 2020-02-17 14:29:44 -0800 Comment on attachment 390959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390959&action=review R=me. > Tools/TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:8 > + <key>keychain-access-groups</key> > + <array> > + <string>com.apple.TestWebKitAPI</string> > + </array> Is this needed? 1619907 4 390959 bfulgham 2020-02-17 14:54:30 -0800 Comment on attachment 390959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390959&action=review >> Tools/TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:8 >> + </array> > > Is this needed? Maybe not. We do have that in the WKTR entitlements, but I guess it was never needed previously. I'll take it out. 1619908 5 bfulgham 2020-02-17 14:54:32 -0800 Committed r256777: <https://trac.webkit.org/changeset/256777> 390959 2020-02-17 12:20:56 -0800 2022-03-01 02:26:33 -0800 Patch bug-207850-20200217122055.patch text/plain 6306 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NTcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWJlNzRmZjlkYzk4YzI2NTA4NTk2NWQ4MTI1YzU3OTcw MmQ2Yjc5My4uOGE3M2M0ZTM0NGYzMTI2NmUwYTgyMmU3YTc4YmMyZWQ5MmU3MDY0ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIwLTAyLTE3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisg ICAgICAgIFVwZGF0ZSBXZWJLaXQgVG9vbHMgdG8gaXNzdWUgbWFjaCBleHRlbnNpb25zIGFzIG5l ZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3 ODUwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTUyMTAxOT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZpc2UgdGhlIGNvZGVzaWduIHNldHRp bmdzIGZvciBvdXIgdGVzdGluZyB0b29scyB0byBhbGxvdyB0aGUgcHJvY2VzcyB0byB2ZW5kIG1h Y2ggZXh0ZW5zaW9ucworICAgICAgICB0byBpdHMgY2hpbGQgcHJvY2Vzc2VzIChXZWJDb250ZW50 LCBHUFUsIE5ldHdvcmssIGV0Yy4pIGFzIG5lZWRlZC4KKworICAgICAgICAqIE1pbmlCcm93c2Vy L01pbmlCcm93c2VyLmVudGl0bGVtZW50czoKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL0NvbmZp Z3VyYXRpb25zL1Rlc3RXZWJLaXRBUEktbWFjT1MuZW50aXRsZW1lbnRzOiBBZGRlZC4KKyAgICAg ICAgKiBUZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUEkueGNjb25maWc6 CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0 LnBieHByb2o6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJL aXRUZXN0UnVubmVyLmVudGl0bGVtZW50czoKKwogMjAyMC0wMi0xMyAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIF9XS1Jlc291cmNlTG9hZElu Zm8gc2hvdWxkIGNvbmZvcm0gdG8gTlNTZWN1cmVDb2RpbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL01p bmlCcm93c2VyL01pbmlCcm93c2VyLmVudGl0bGVtZW50cyBiL1Rvb2xzL01pbmlCcm93c2VyL01p bmlCcm93c2VyLmVudGl0bGVtZW50cwppbmRleCBlNGMyYmExODBmMzk1ZGNhMWQzNDFkYjY2NmQ1 YzM0YzJlYTNlYzJlLi4xNmI1OGFiYjkyNTIwOGMxYjA2MTBkMTI3OTZjYWIxYzFlZDZlMjRlIDEw MDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9NaW5pQnJvd3Nlci5lbnRpdGxlbWVudHMKKysr IGIvVG9vbHMvTWluaUJyb3dzZXIvTWluaUJyb3dzZXIuZW50aXRsZW1lbnRzCkBAIC0xNyw1ICsx Nyw5IEBACiAJCTxzdHJpbmc+Y29tLmFwcGxlLlNhZmFyaS5TYWZlQnJvd3NpbmcuU2VydmljZTwv c3RyaW5nPgogCQk8c3RyaW5nPmNvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZ0RhZW1vbjwvc3Ry aW5nPgogCTwvYXJyYXk+CisJPGtleT5jb20uYXBwbGUuc2VjdXJpdHkudGVtcG9yYXJ5LWV4Y2Vw dGlvbi5zYnBsPC9rZXk+CisJPGFycmF5PgorCQk8c3RyaW5nPihhbGxvdyBtYWNoLWlzc3VlLWV4 dGVuc2lvbiAocmVxdWlyZS1hbGwgKGV4dGVuc2lvbi1jbGFzcyAmcXVvdDtjb20uYXBwbGUud2Vi a2l0LmV4dGVuc2lvbi5tYWNoJnF1b3Q7KSkpPC9zdHJpbmc+CisJPC9hcnJheT4KIDwvZGljdD4K IDwvcGxpc3Q+CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25z L1Rlc3RXZWJLaXRBUEktbWFjT1MuZW50aXRsZW1lbnRzIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9D b25maWd1cmF0aW9ucy9UZXN0V2ViS2l0QVBJLW1hY09TLmVudGl0bGVtZW50cwpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5hOWY5Y2RmMDRjMmZiYmQwMmUzYTJlZWYyMjYyNDdhZTZlYjk2MjM4Ci0tLSAvZGV2L251bGwK KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V2ViS2l0QVBJLW1h Y09TLmVudGl0bGVtZW50cwpAQCAtMCwwICsxLDE0IEBACis8P3htbCB2ZXJzaW9uPSIxLjAiIGVu Y29kaW5nPSJVVEYtOCI/PgorPCFET0NUWVBFIHBsaXN0IFBVQkxJQyAiLS8vQXBwbGUvL0RURCBQ TElTVCAxLjAvL0VOIiAiaHR0cDovL3d3dy5hcHBsZS5jb20vRFREcy9Qcm9wZXJ0eUxpc3QtMS4w LmR0ZCI+Cis8cGxpc3QgdmVyc2lvbj0iMS4wIj4KKzxkaWN0PgorCTxrZXk+a2V5Y2hhaW4tYWNj ZXNzLWdyb3Vwczwva2V5PgorCTxhcnJheT4KKwkJPHN0cmluZz5jb20uYXBwbGUuVGVzdFdlYktp dEFQSTwvc3RyaW5nPgorCTwvYXJyYXk+CisJPGtleT5jb20uYXBwbGUuc2VjdXJpdHkudGVtcG9y YXJ5LWV4Y2VwdGlvbi5zYnBsPC9rZXk+CisJPGFycmF5PgorCQk8c3RyaW5nPihhbGxvdyBtYWNo LWlzc3VlLWV4dGVuc2lvbiAocmVxdWlyZS1hbGwgKGV4dGVuc2lvbi1jbGFzcyAmcXVvdDtjb20u YXBwbGUud2Via2l0LmV4dGVuc2lvbi5tYWNoJnF1b3Q7KSkpPC9zdHJpbmc+CisJPC9hcnJheT4K KzwvZGljdD4KKzwvcGxpc3Q+CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZp Z3VyYXRpb25zL1Rlc3RXZWJLaXRBUEkueGNjb25maWcgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0Nv bmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUEkueGNjb25maWcKaW5kZXggYmRhM2ZkZmVjNmZjOGQz NWY2MDU1YjZjNzI5ZjUxNGE5Y2IxOThlNi4uMzBhOGNhZjBjMjQ3MGQ2NzZiNmRjZTM2MjFmMDli MDRhYzc5MGQzMSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9u cy9UZXN0V2ViS2l0QVBJLnhjY29uZmlnCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmln dXJhdGlvbnMvVGVzdFdlYktpdEFQSS54Y2NvbmZpZwpAQCAtNjYsNSArNjYsNiBAQCBPVEhFUl9M REZMQUdTX1BMQVRGT1JNX2NvY29hdG91Y2ggPSAtZnJhbWV3b3JrIFdlYkNvcmUgLWZyYW1ld29y ayBDb3JlR3JhcGhpY3MgLQogTERfUlVOUEFUSF9TRUFSQ0hfUEFUSFMgPSAiQGxvYWRlcl9wYXRo IjsKIAogQ09ERV9TSUdOX0VOVElUTEVNRU5UU1tzZGs9aXBob25lKl0gPSBDb25maWd1cmF0aW9u cy9UZXN0V2ViS2l0QVBJLWlPUy5lbnRpdGxlbWVudHM7CitDT0RFX1NJR05fRU5USVRMRU1FTlRT W3Nkaz1tYWNvc3gqXSA9IENvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUEktbWFjT1MuZW50aXRs ZW1lbnRzOwogCiBTVFJJUF9TVFlMRSA9IGRlYnVnZ2luZzsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oK aW5kZXggNmFhMGU5M2FmYjU5ZGM0NDgwZjIwOWRhZWQwN2E1OGM2MTBiZDk0Yy4uZmMyMzI2NzMw M2ZhNzg4MDAxMWJlZWZkNTFkNjM4Y2Q4OTBkOTcwMiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oK QEAgLTIxMTksNiArMjExOSw3IEBACiAJCTdBOTlEOTkzMUFENEEyOUQwMDM3MzE0MSAvKiBNZW51 VHlwZXNGb3JNb3VzZUV2ZW50cy5tbSAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxl RW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLm9iamNwcDsg cGF0aCA9IE1lbnVUeXBlc0Zvck1vdXNlRXZlbnRzLm1tOyBzb3VyY2VUcmVlID0gIjxncm91cD4i OyB9OwogCQk3QUEwMjFCQTFBQjA5RUE3MDA1Mjk1M0YgLyogRGF0ZU1hdGguY3BwICovID0ge2lz YSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBl ID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gRGF0ZU1hdGguY3BwOyBzb3VyY2VUcmVlID0g Ijxncm91cD4iOyB9OwogCQk3QUE2QTE1MTFBQUMwQjMxMDAyQjJFRDMgLyogV29ya1F1ZXVlLmNw cCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25v d25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLmNwcDsgcGF0aCA9IFdvcmtRdWV1ZS5jcHA7IHNv dXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCTdBQjAxNzM5MjNGQjJCRjAwMDJGODM2NiAvKiBU ZXN0V2ViS2l0QVBJLW1hY09TLmVudGl0bGVtZW50cyAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJl bmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHRleHQucGxpc3QuZW50 aXRsZW1lbnRzOyBwYXRoID0gIlRlc3RXZWJLaXRBUEktbWFjT1MuZW50aXRsZW1lbnRzIjsgc291 cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJN0FDN0I1NkIyMEQ5NzY4RTAwMkMwOUEwIC8qIEN1 c3RvbUJ1bmRsZVBhcmFtZXRlcl9CdW5kbGUubW0gKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5j ZTsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5vYmpjcHA7IHBhdGggPSBDdXN0 b21CdW5kbGVQYXJhbWV0ZXJfQnVuZGxlLm1tOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9Owog CQk3QUM3QjU2QzIwRDk3NjhGMDAyQzA5QTAgLyogQ3VzdG9tQnVuZGxlUGFyYW1ldGVyLm1tICov ID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29k ZS5jcHAub2JqY3BwOyBwYXRoID0gQ3VzdG9tQnVuZGxlUGFyYW1ldGVyLm1tOyBzb3VyY2VUcmVl ID0gIjxncm91cD4iOyB9OwogCQk3QUM3QjU2RjIwRDlCQTVCMDAyQzA5QTAgLyogQ3VzdG9tQnVu ZGxlT2JqZWN0Lm1tICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGxhc3RLbm93bkZpbGVU eXBlID0gc291cmNlY29kZS5jcHAub2JqY3BwOyBwYXRoID0gQ3VzdG9tQnVuZGxlT2JqZWN0Lm1t OyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwpAQCAtMzY3OSw2ICszNjgwLDcgQEAKIAkJCQlC QzU3NUFFMjEyNkU4OEIxMDA2RjBGMTIgLyogSW5qZWN0ZWRCdW5kbGUueGNjb25maWcgKi8sCiAJ CQkJQTFCODlCOTkyMjFFMDI5RjAwRUI0Q0VBIC8qIFNES1ZhcmlhbnQueGNjb25maWcgKi8sCiAJ CQkJNTczNUYwMjUxRjNBNEVBNjAwMEVFODAxIC8qIFRlc3RXZWJLaXRBUEktaU9TLmVudGl0bGVt ZW50cyAqLywKKwkJCQk3QUIwMTczOTIzRkIyQkYwMDAyRjgzNjYgLyogVGVzdFdlYktpdEFQSS1t YWNPUy5lbnRpdGxlbWVudHMgKi8sCiAJCQkJQkM5MDk1ODAxMjU1NENGOTAwMDgzNzU2IC8qIFRl c3RXZWJLaXRBUEkueGNjb25maWcgKi8sCiAJCQkJN0NDRTdFQTMxQTQxMTVDQjAwNDQ3QzRDIC8q IFRlc3RXZWJLaXRBUElMaWJyYXJ5LnhjY29uZmlnICovLAogCQkJCTdDODNFMDI2MUQwQTVCOEQw MEZFQkNGMyAvKiBUZXN0V1RGLnhjY29uZmlnICovLApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVyLmVudGl0bGVtZW50cyBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJhdGlvbnMvV2ViS2l0VGVzdFJ1bm5lci5l bnRpdGxlbWVudHMKaW5kZXggMWZiNDgyNzc5NTY1OTc5NGU4NjBiZmVjMWIyNjQwNzRhMTFjMjQ5 Mi4uZjNhMzg5N2U0N2E1ZDlkMWZiYmNjMmYyNWEwOWY5ZDhhZDI0MWZlOCAxMDA2NDQKLS0tIGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVyLmVu dGl0bGVtZW50cworKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRpb25zL1dl YktpdFRlc3RSdW5uZXIuZW50aXRsZW1lbnRzCkBAIC02LDUgKzYsOSBAQAogICAgICAgICA8YXJy YXk+CiAgICAgICAgICAgICA8c3RyaW5nPmNvbS5hcHBsZS5XZWJLaXRUZXN0UnVubmVyPC9zdHJp bmc+CiAgICAgICAgIDwvYXJyYXk+CisgICAgCTxrZXk+Y29tLmFwcGxlLnNlY3VyaXR5LnRlbXBv cmFyeS1leGNlcHRpb24uc2JwbDwva2V5PgorICAgIAk8YXJyYXk+CisgICAgCQk8c3RyaW5nPihh bGxvdyBtYWNoLWlzc3VlLWV4dGVuc2lvbiAocmVxdWlyZS1hbGwgKGV4dGVuc2lvbi1jbGFzcyAm cXVvdDtjb20uYXBwbGUud2Via2l0LmV4dGVuc2lvbi5tYWNoJnF1b3Q7KSkpPC9zdHJpbmc+Cisg ICAgCTwvYXJyYXk+CiAgICAgPC9kaWN0PgogPC9wbGlzdD4K