207838 2020-02-17 06:16:24 -0800 [GTK][WPE] Set ccache as compiler launcher, add opt-in sccache support 2020-02-20 08:48:27 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208007 P2 Normal --- 1 pnormand pnormand annulen clopez ews-watchlist gyuyoung.kim ryuan.choi sergio oldest_to_newest 1619634 0 pnormand 2020-02-17 06:16:24 -0800 . 1619635 1 390916 pnormand 2020-02-17 06:20:02 -0800 Created attachment 390916 Patch 1619651 2 390916 clopez 2020-02-17 08:05:51 -0800 Comment on attachment 390916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390916&action=review > Source/cmake/WebKitCCache.cmake:6 > set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CMAKE_SOURCE_DIR}/Tools/ccache/ccache-wrapper) I don't like much the idea of calling a bash wrapper instead of ccache directly just to export two environment variables. I think exporting this environment variables can be done also by CMake and we can call ccache directly avoiding the overhead of calling as extra env+bash for each compilation unit. 1619658 3 390916 pnormand 2020-02-17 08:33:14 -0800 Comment on attachment 390916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390916&action=review >> Source/cmake/WebKitCCache.cmake:6 >> set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CMAKE_SOURCE_DIR}/Tools/ccache/ccache-wrapper) > > I don't like much the idea of calling a bash wrapper instead of ccache directly just to export two environment variables. > I think exporting this environment variables can be done also by CMake and we can call ccache directly avoiding the overhead of calling as extra env+bash for each compilation unit. OK then I won't touch this Mac-specific code. Actually I don't think we need those vars for GTK/WPE. Besides, the ccache-wrapper is called by the "clang-wrapper"... 1619677 4 390924 pnormand 2020-02-17 08:49:53 -0800 Created attachment 390924 Patch 1620629 5 pnormand 2020-02-19 04:50:23 -0800 Committed r256917: <https://trac.webkit.org/changeset/256917> 390916 2020-02-17 06:20:02 -0800 2020-02-17 08:49:49 -0800 Patch bug-207838-20200217142001.patch text/plain 1875 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q0NhY2hlLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENDYWNoZS5jbWFrZQppbmRleCA0 NjYwMzJiNzU5OTY2NzI4YjZlMzk0MzFkMjBjMGE1YzQ3OWRmZjg3Li5hNzAzOWRjMWEwYzNiOWJl MjEwYmFlNThlYTBlNDYwYmM3NjBmZmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q0NhY2hlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2UKQEAgLTEs OCArMSwxNSBAQAotIyBFbmFibGUgY2NhY2hlIGJ5IGRlZmF1bHQgZm9yIHRoZSBNYWMgcG9ydCwg aWYgaW5zdGFsbGVkLgorIyBFbmFibGUgY2NhY2hlIGJ5IGRlZmF1bHQsIGlmIGluc3RhbGxlZC4K ICMgU2V0dGluZyBXS19VU0VfQ0NBQ0hFPU5PIGluIHlvdXIgZW52aXJvbm1lbnQgd2lsbCBkaXNh YmxlIGl0LgotaWYgKFBPUlQgU1RSRVFVQUwgIk1hYyIgQU5EIE5PVCAiJEVOVntXS19VU0VfQ0NB Q0hFfSIgU1RSRVFVQUwgIk5PIikKK2lmIChOT1QgIiRFTlZ7V0tfVVNFX0NDQUNIRX0iIFNUUkVR VUFMICJOTyIpCiAgICAgZmluZF9wcm9ncmFtKENDQUNIRV9GT1VORCBjY2FjaGUpCiAgICAgaWYg KENDQUNIRV9GT1VORCkKICAgICAgICAgc2V0X3Byb3BlcnR5KEdMT0JBTCBQUk9QRVJUWSBSVUxF X0xBVU5DSF9DT01QSUxFICR7Q01BS0VfU09VUkNFX0RJUn0vVG9vbHMvY2NhY2hlL2NjYWNoZS13 cmFwcGVyKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQorCitpZiAoIiRFTlZ7V0VCS0lUX1VTRV9T Q0NBQ0hFfSIgU1RSRVFVQUwgIllFUyIpCisgICAgZmluZF9wcm9ncmFtKFNDQ0FDSEVfRk9VTkQg c2NjYWNoZSkKKyAgICBpZiAoU0NDQUNIRV9GT1VORCkKKyAgICAgICAgc2V0X3Byb3BlcnR5KEdM T0JBTCBQUk9QRVJUWSBSVUxFX0xBVU5DSF9DT01QSUxFICR7U0NDQUNIRV9GT1VORH0pCisgICAg ZW5kaWYgKCkKK2VuZGlmICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5k ZXggOGRmMDk4NDNiODU1NmUwOGI2MzA5YzMwOTJjNjM4NjJiYWRlOWVmOS4uYTBjZTA0MjNjM2Ix ZTY3ODE5YTJkZWM3MjY2ZThmMTY5NzBiNjNlZCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTE3ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIFNldCBjY2FjaGUg YXMgY29tcGlsZXIgbGF1bmNoZXIsIGFkZCBvcHQtaW4gc2NjYWNoZSBzdXBwb3J0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc4MzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSBhbGxv d3MgZm9yIG1vcmUgZ3JhbnVsYXIgY29udHJvbCBvdmVyIHRoZSBjb21waWxlcgorICAgICAgICBs YXVuY2hlciBjb25maWd1cmF0aW9uLiBUaGUgYnVpbGQgaG9zdCBzaG91bGQgbm8gbG9uZ2VyIG5l ZWQgdG8KKyAgICAgICAgc2V0IGNjYWNoZSBzeW1ib2xpYyBsaW5rcy4gQWRkaXRpb25hbGx5IG9w dGlvbmFsIHN1cHBvcnQgZm9yCisgICAgICAgIHNjY2FjaGUgaXMgYWRkZWQsIGVuYWJsZWQgd2hl biB0aGUgV0VCS0lUX1VTRV9TQ0NBQ0hFIGVudmlyb25tZW50CisgICAgICAgIHZhcmlhYmxlIGlz IHNldCB0byBZRVMuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0Q0NhY2hlLmNtYWtl OgorCiAyMDIwLTAyLTE0ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAK ICAgICAgICAgW0NNYWtlXSBBZGQgRm9udGNvbmZpZzo6Rm9udGNvbmZpZyB0YXJnZXQK 390924 2020-02-17 08:49:53 -0800 2020-02-19 04:46:07 -0800 Patch bug-207838-20200217164952.patch text/plain 2178 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q0NhY2hlLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENDYWNoZS5jbWFrZQppbmRleCA0 NjYwMzJiNzU5OTY2NzI4YjZlMzk0MzFkMjBjMGE1YzQ3OWRmZjg3Li5mNmZiZDVmOGM0NTE0YWQy YWQwYTFhYjc2YjJhNjU4OGI1NWUyZTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q0NhY2hlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2UKQEAgLTEs OCArMSwyMCBAQAotIyBFbmFibGUgY2NhY2hlIGJ5IGRlZmF1bHQgZm9yIHRoZSBNYWMgcG9ydCwg aWYgaW5zdGFsbGVkLgotIyBTZXR0aW5nIFdLX1VTRV9DQ0FDSEU9Tk8gaW4geW91ciBlbnZpcm9u bWVudCB3aWxsIGRpc2FibGUgaXQuCi1pZiAoUE9SVCBTVFJFUVVBTCAiTWFjIiBBTkQgTk9UICIk RU5We1dLX1VTRV9DQ0FDSEV9IiBTVFJFUVVBTCAiTk8iKQorIyBFbmFibGUgY2NhY2hlIGJ5IGRl ZmF1bHQsIGlmIGluc3RhbGxlZC4gU2V0dGluZyBXS19VU0VfQ0NBQ0hFPU5PIGluIHlvdXIKKyMg ZW52aXJvbm1lbnQgd2lsbCBkaXNhYmxlIGl0LgoraWYgKE5PVCAiJEVOVntXS19VU0VfQ0NBQ0hF fSIgU1RSRVFVQUwgIk5PIikKICAgICBmaW5kX3Byb2dyYW0oQ0NBQ0hFX0ZPVU5EIGNjYWNoZSkK ICAgICBpZiAoQ0NBQ0hFX0ZPVU5EKQotICAgICAgICBzZXRfcHJvcGVydHkoR0xPQkFMIFBST1BF UlRZIFJVTEVfTEFVTkNIX0NPTVBJTEUgJHtDTUFLRV9TT1VSQ0VfRElSfS9Ub29scy9jY2FjaGUv Y2NhY2hlLXdyYXBwZXIpCisgICAgICAgIGlmIChQT1JUIFNUUkVRVUFMICJNYWMiKQorICAgICAg ICAgICAgc2V0KENDQUNIRSAke0NNQUtFX1NPVVJDRV9ESVJ9L1Rvb2xzL2NjYWNoZS9jY2FjaGUt d3JhcHBlcikKKyAgICAgICAgZWxzZSAoKQorICAgICAgICAgICAgc2V0KENDQUNIRSAke0NDQUNI RV9GT1VORH0pCisgICAgICAgIGVuZGlmICgpCisgICAgICAgIHNldF9wcm9wZXJ0eShHTE9CQUwg UFJPUEVSVFkgUlVMRV9MQVVOQ0hfQ09NUElMRSAke0NDQUNIRX0pCisgICAgZW5kaWYgKCkKK2Vu ZGlmICgpCisKK2lmICgiJEVOVntXRUJLSVRfVVNFX1NDQ0FDSEV9IiBTVFJFUVVBTCAiWUVTIikK KyAgICBmaW5kX3Byb2dyYW0oU0NDQUNIRV9GT1VORCBzY2NhY2hlKQorICAgIGlmIChTQ0NBQ0hF X0ZPVU5EKQorICAgICAgICBzZXRfcHJvcGVydHkoR0xPQkFMIFBST1BFUlRZIFJVTEVfTEFVTkNI X0NPTVBJTEUgJHtTQ0NBQ0hFX0ZPVU5EfSkKICAgICBlbmRpZiAoKQogZW5kaWYgKCkKZGlmZiAt LWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxYWNkNTFkYWY3ZDExNDY3NDdiMDhh YjMwODY4YTM3NDE1MDE0ZjQyLi4yNzM5ZmFjZWQ1NDhiNzY2YWY4NzAwNGExYzdhYjk0MDRjZDQw ODI5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMjAtMDItMTcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdW1dQRV0gU2V0IGNjYWNoZSBhcyBjb21waWxlciBsYXVuY2hlciwgYWRk IG9wdC1pbiBzY2NhY2hlIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzgzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIGFsbG93cyBmb3IgbW9yZSBncmFudWxhciBjb250 cm9sIG92ZXIgdGhlIGNvbXBpbGVyCisgICAgICAgIGxhdW5jaGVyIGNvbmZpZ3VyYXRpb24uIFRo ZSBidWlsZCBob3N0IHNob3VsZCBubyBsb25nZXIgbmVlZCB0bworICAgICAgICBzZXQgY2NhY2hl IHN5bWJvbGljIGxpbmtzLiBBZGRpdGlvbmFsbHkgb3B0aW9uYWwgc3VwcG9ydCBmb3IKKyAgICAg ICAgc2NjYWNoZSBpcyBhZGRlZCwgZW5hYmxlZCB3aGVuIHRoZSBXRUJLSVRfVVNFX1NDQ0FDSEUg ZW52aXJvbm1lbnQKKyAgICAgICAgdmFyaWFibGUgaXMgc2V0IHRvIFlFUy4KKworICAgICAgICAq IFNvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2U6CisKIDIwMjAtMDItMTcgIERvbiBPbG1z dGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIFVzZSBidWls dGluIHRhcmdldHMK