207818 2020-02-15 17:05:06 -0800 [LFC][Floats] FloatingContext::positionForFloat needs the horizontal constrains 2020-02-16 07:15:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1619449 0 zalan 2020-02-15 17:05:06 -0800 when calling formattingContext().geometryForBox(*layoutBox.containingBlock()) 1619450 1 webkit-bug-importer 2020-02-15 17:05:32 -0800 <rdar://problem/59489777> 1619459 2 390876 zalan 2020-02-15 17:38:22 -0800 Created attachment 390876 Patch 1619490 3 zalan 2020-02-16 07:15:00 -0800 Committed r256708: <https://trac.webkit.org/changeset/256708> 390876 2020-02-15 17:38:22 -0800 2020-02-16 01:01:09 -0800 Patch bug-207818-20200215173821.patch text/plain 6786 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU0Yjg5NTZhNDczYzNj ODBmNjEzOTM0YjYyYjA2NTlhN2NhNzY1YS4uN2IxZDdmNTU0M2QwNDgwY2M1MGFhZjc4ODVjMmVj MmU0NDE2NWI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRzXSBGbG9h dGluZ0NvbnRleHQ6OnBvc2l0aW9uRm9yRmxvYXQgbmVlZHMgdGhlIGhvcml6b250YWwgY29uc3Ry YWlucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3 ODE4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTQ4OTc3Nz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBuZWVkIHRvIGFjY2VzcyB0aGUgY29u dGFpbmluZyBibG9jaydzIGdlb21ldHJ5IChob3Jpem9udGFsIGNvbnN0cmFpbnRzKSB0byBhbGln biBhIGZsb2F0aW5nIHBvc2l0aW9uZWQKKyAgICAgICAgYm94IGluIGFuIGVtcHR5IGZsb2F0aW5n IGNvbnRleHQuCisKKyAgICAgICAgKiBsYXlvdXQvZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkZsb2F0aW5nQ29udGV4dDo6cG9zaXRpb25Gb3JG bG9hdCBjb25zdCk6CisKIDIwMjAtMDItMTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXVtCRkNdIEZpeCBob3Jpem9udGFsL3ZlcnRpY2FsQ29uc3RyYWlu dHNGb3JBbmNlc3RvciBpbiBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpwcmVjb21wdXRlVmVydGlj YWxQb3NpdGlvbkZvckFuY2VzdG9ycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L0xheW91dFVuaXRzLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0VW5pdHMuaAppbmRl eCBiYmQyNzAyNjg4NzA0NzFmY2FkOTdmMjAxYjc2MGJiNDM0ODBiOWZlLi5hMmJlM2M5ZmY5YTZj MmQwNWZmNGM5M2IxNGM1MzJjZjIyZmYzZjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvTGF5b3V0VW5pdHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0VW5p dHMuaApAQCAtMTUzLDYgKzE1Myw4IEBAIHN0cnVjdCBWZXJ0aWNhbEdlb21ldHJ5IHsKIH07CiAK IHN0cnVjdCBIb3Jpem9udGFsQ29uc3RyYWludHMgeworICAgIExheW91dFVuaXQgbG9naWNhbFJp Z2h0KCkgY29uc3QgeyByZXR1cm4gbG9naWNhbExlZnQgKyBsb2dpY2FsV2lkdGg7IH0KKwogICAg IExheW91dFVuaXQgbG9naWNhbExlZnQ7CiAgICAgTGF5b3V0VW5pdCBsb2dpY2FsV2lkdGg7CiB9 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9j a0Zvcm1hdHRpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1h dHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAKaW5kZXggMTkzN2U2NmU4MGZjMDhhNTIx YzFmOTFmMWQyZmEyY2YwN2U4NzNlNy4uM2ZmMTgyOTZkMjA0YjhlMjdiZTg3MjY1YjNlOTQ0NjQ4 NTMyMDQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGlu Zy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv YmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwCkBAIC0zMTgsNyArMzE4 LDcgQEAgdm9pZCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlUG9zaXRpb25Ub0F2b2lk RmxvYXRzKGNvbnN0IEZsb2F0aW5nQ29udGV4dCYKICAgICAvLyBIb3dldmVyIGFjY29yZGluZyB0 byB0aGUgQkZDIHJ1bGVzLCBhdCB0aGlzIHBvaW50IG9mIHRoZSBsYXlvdXQgZmxvdyB3ZSBkb24n dCB5ZXQgaGF2ZSBjb21wdXRlZCB2ZXJ0aWNhbCBwb3NpdGlvbnMgZm9yIHRoZSBhbmNlc3RvcnMu CiAgICAgaWYgKGxheW91dEJveC5pc0Zsb2F0aW5nUG9zaXRpb25lZCgpKSB7CiAgICAgICAgIHBy ZWNvbXB1dGVWZXJ0aWNhbFBvc2l0aW9uRm9yQW5jZXN0b3JzKGxheW91dEJveCwgaG9yaXpvbnRh bENvbnN0cmFpbnRzLCB2ZXJ0aWNhbENvbnN0cmFpbnRzKTsKLSAgICAgICAgZm9ybWF0dGluZ1N0 YXRlKCkuZGlzcGxheUJveChsYXlvdXRCb3gpLnNldFRvcExlZnQoZmxvYXRpbmdDb250ZXh0LnBv c2l0aW9uRm9yRmxvYXQobGF5b3V0Qm94KSk7CisgICAgICAgIGZvcm1hdHRpbmdTdGF0ZSgpLmRp c3BsYXlCb3gobGF5b3V0Qm94KS5zZXRUb3BMZWZ0KGZsb2F0aW5nQ29udGV4dC5wb3NpdGlvbkZv ckZsb2F0KGxheW91dEJveCwgaG9yaXpvbnRhbENvbnN0cmFpbnRzLmNvbnRhaW5pbmdCbG9jaykp OwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIC8vIE5vbi1mbG9hdCBwb3NpdGlvbmVkIGZs b2F0IGF2b2lkZXJzIChmb3JtYXR0aW5nIGNvbnRleHQgcm9vdHMgYW5kIGNsZWFyIGJveGVzKSBz aG91bGQgYmUgZmluZSB1bmxlc3MgdGhlcmUgYXJlIGZsb2F0cyBpbiB0aGlzIGNvbnRleHQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5jcHAKaW5k ZXggMjEwMDNiODhiZWRkNjY0Zjk4YTc5MDc2NzY0YzA4NWQ3MzRiYjI2Yi4uNDVkZDZmN2FlYzdm MjIwOTBiZDU0M2ZkZTlmMzk3ZDMxNmE4NjJmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Zsb2F0cy9GbG9hdGluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mbG9hdHMvRmxvYXRpbmdDb250ZXh0LmNwcApAQCAtMTYyLDcgKzE2Miw3IEBAIEZsb2F0 aW5nQ29udGV4dDo6RmxvYXRpbmdDb250ZXh0KGNvbnN0IENvbnRhaW5lckJveCYgZmxvYXRpbmdD b250ZXh0Um9vdCwgY29uc3QKIHsKIH0KIAotUG9pbnQgRmxvYXRpbmdDb250ZXh0Ojpwb3NpdGlv bkZvckZsb2F0KGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdAorUG9pbnQgRmxvYXRpbmdDb250 ZXh0Ojpwb3NpdGlvbkZvckZsb2F0KGNvbnN0IEJveCYgbGF5b3V0Qm94LCBjb25zdCBIb3Jpem9u dGFsQ29uc3RyYWludHMmIGhvcml6b250YWxDb25zdHJhaW50cykgY29uc3QKIHsKICAgICBBU1NF UlQobGF5b3V0Qm94LmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkpOwogICAgIEFTU0VSVChhcmVGbG9h dHNIb3Jpem9udGFsbHlTb3J0ZWQobV9mbG9hdGluZ1N0YXRlKSk7CkBAIC0xNzIsMTIgKzE3Miwx MCBAQCBQb2ludCBGbG9hdGluZ0NvbnRleHQ6OnBvc2l0aW9uRm9yRmxvYXQoY29uc3QgQm94JiBs YXlvdXRCb3gpIGNvbnN0CiAKICAgICAgICAgYXV0byBhbGlnbldpdGhDb250YWluaW5nQmxvY2sg PSBbJl0oKSAtPiBQb3NpdGlvbiB7CiAgICAgICAgICAgICAvLyBJZiB0aGVyZSBpcyBubyBmbG9h dGluZyB0byBhbGlnbiB3aXRoLCBwdXNoIHRoZSBib3ggdG8gdGhlIGxlZnQvcmlnaHQgZWRnZSBv ZiBpdHMgY29udGFpbmluZyBibG9jaydzIGNvbnRlbnQgYm94LgotICAgICAgICAgICAgYXV0byYg Y29udGFpbmluZ0Jsb2NrR2VvbWV0cnkgPSBmb3JtYXR0aW5nQ29udGV4dCgpLmdlb21ldHJ5Rm9y Qm94KCpsYXlvdXRCb3guY29udGFpbmluZ0Jsb2NrKCkpOwotCiAgICAgICAgICAgICBpZiAobGF5 b3V0Qm94LmlzTGVmdEZsb2F0aW5nUG9zaXRpb25lZCgpKQotICAgICAgICAgICAgICAgIHJldHVy biBQb3NpdGlvbiB7IGNvbnRhaW5pbmdCbG9ja0dlb21ldHJ5LmNvbnRlbnRCb3hMZWZ0KCkgKyBi b3hHZW9tZXRyeS5tYXJnaW5TdGFydCgpIH07CisgICAgICAgICAgICAgICAgcmV0dXJuIHsgaG9y aXpvbnRhbENvbnN0cmFpbnRzLmxvZ2ljYWxMZWZ0ICsgYm94R2VvbWV0cnkubWFyZ2luU3RhcnQo KSB9OwogCi0gICAgICAgICAgICByZXR1cm4gUG9zaXRpb24geyBjb250YWluaW5nQmxvY2tHZW9t ZXRyeS5jb250ZW50Qm94UmlnaHQoKSAtIGJveEdlb21ldHJ5Lm1hcmdpbkVuZCgpIC0gYm94R2Vv bWV0cnkud2lkdGgoKSB9OworICAgICAgICAgICAgcmV0dXJuIHsgaG9yaXpvbnRhbENvbnN0cmFp bnRzLmxvZ2ljYWxSaWdodCgpIC0gYm94R2VvbWV0cnkubWFyZ2luRW5kKCkgLSBib3hHZW9tZXRy eS53aWR0aCgpIH07CiAgICAgICAgIH07CiAKICAgICAgICAgLy8gTm8gZmxvYXQgYm94IG9uIHRo ZSBjb250ZXh0IHlldCAtPiBhbGlnbiBpdCB3aXRoIHRoZSBjb250YWluaW5nIGJsb2NrJ3MgbGVm dC9yaWdodCBlZGdlLgpAQCAtMTg2LDEwICsxODQsOCBAQCBQb2ludCBGbG9hdGluZ0NvbnRleHQ6 OnBvc2l0aW9uRm9yRmxvYXQoY29uc3QgQm94JiBsYXlvdXRCb3gpIGNvbnN0CiAKICAgICAvLyBG aW5kIHRoZSB0b3AgbW9zdCBwb3NpdGlvbiB3aGVyZSB0aGUgZmxvYXQgYm94IGZpdHMuCiAgICAg YXV0byBhYnNvbHV0ZURpc3BsYXlCb3hDb29yZGluYXRlcyA9IHRoaXMtPmFic29sdXRlRGlzcGxh eUJveENvb3JkaW5hdGVzKGxheW91dEJveCk7Ci0KLSAgICBPcHRpb25hbDxMYXlvdXRVbml0PiBw cmV2aW91c0Zsb2F0QWJzb2x1dGVUb3A7Ci0gICAgaWYgKCFpc0VtcHR5KCkpCi0gICAgICAgIHBy ZXZpb3VzRmxvYXRBYnNvbHV0ZVRvcCA9IGZsb2F0aW5nU3RhdGUoKS5mbG9hdHMoKS5sYXN0KCku cmVjdFdpdGhNYXJnaW4oKS50b3AoKTsKKyAgICBBU1NFUlQoIWlzRW1wdHkoKSk7CisgICAgYXV0 byBwcmV2aW91c0Zsb2F0QWJzb2x1dGVUb3AgPSBmbG9hdGluZ1N0YXRlKCkuZmxvYXRzKCkubGFz dCgpLnJlY3RXaXRoTWFyZ2luKCkudG9wKCk7CiAgICAgYXV0byBmbG9hdEJveCA9IEZsb2F0Qm94 IHsgbGF5b3V0Qm94LCBhYnNvbHV0ZURpc3BsYXlCb3hDb29yZGluYXRlcy5kaXNwbGF5Qm94LCBh YnNvbHV0ZURpc3BsYXlCb3hDb29yZGluYXRlcy5jb250YWluaW5nQmxvY2tUb3BMZWZ0LCBhYnNv bHV0ZURpc3BsYXlCb3hDb29yZGluYXRlcy5jb250YWluaW5nQmxvY2tDb250ZW50Qm94LCBwcmV2 aW91c0Zsb2F0QWJzb2x1dGVUb3AgfTsKICAgICBmaW5kUG9zaXRpb25Gb3JGbG9hdEJveChmbG9h dEJveCk7CiAgICAgcmV0dXJuIGZsb2F0Qm94LnJlY3RJbkNvbnRhaW5pbmdCbG9jaygpLnRvcExl ZnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdD b250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nQ29udGV4dC5o CmluZGV4IDcxZGY0MTEyNTZlZTQxZTFkZmE3NGViMjcyZDc0NGFkMGE0OGZmOGUuLjQ2YjY4ZDE1 ZWViY2VlZDZmMTc4ZDFkMjJmZGMxMWM5MDI3ZTc3Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdDb250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Zsb2F0cy9GbG9hdGluZ0NvbnRleHQuaApAQCAtNDksNyArNDksNyBAQCBwdWJsaWM6 CiAKICAgICBGbG9hdGluZ1N0YXRlJiBmbG9hdGluZ1N0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9m bG9hdGluZ1N0YXRlOyB9CiAKLSAgICBQb2ludCBwb3NpdGlvbkZvckZsb2F0KGNvbnN0IEJveCYp IGNvbnN0OworICAgIFBvaW50IHBvc2l0aW9uRm9yRmxvYXQoY29uc3QgQm94JiwgY29uc3QgSG9y aXpvbnRhbENvbnN0cmFpbnRzJikgY29uc3Q7CiAgICAgT3B0aW9uYWw8UG9pbnQ+IHBvc2l0aW9u Rm9yRm9ybWF0dGluZ0NvbnRleHRSb290KGNvbnN0IEJveCYpIGNvbnN0OwogCiAgICAgc3RydWN0 IENsZWFyYW5jZVBvc2l0aW9uIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcApp bmRleCA0MTBlOGUzMWE5YWM3YjgxMzA2ZmRhNGZiN2ZmMTgyNDQ2ZGUxMTE3Li42NDMzYzY1M2Uw OTM3ZWE0ZTM1NTE1Y2YzZGRiOWQ3NDk4NDk4NzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGlu Z0NvbnRleHQuY3BwCkBAIC00NDUsNyArNDQ1LDcgQEAgdm9pZCBJbmxpbmVGb3JtYXR0aW5nQ29u dGV4dDo6c2V0RGlzcGxheUJveGVzRm9yTGluZShjb25zdCBMaW5lTGF5b3V0Q29udGV4dDo6TGkK ICAgICAgICAgICAgIC8vIFNldCBzdGF0aWMgcG9zaXRpb24gZmlyc3QuCiAgICAgICAgICAgICBk aXNwbGF5Qm94LnNldFRvcExlZnQoeyBsaW5lQm94LmxvZ2ljYWxMZWZ0KCksIGxpbmVCb3gubG9n aWNhbFRvcCgpIH0pOwogICAgICAgICAgICAgLy8gRmxvYXQgaXQuCi0gICAgICAgICAgICBkaXNw bGF5Qm94LnNldFRvcExlZnQoZmxvYXRpbmdDb250ZXh0LnBvc2l0aW9uRm9yRmxvYXQoZmxvYXRC b3gpKTsKKyAgICAgICAgICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdChmbG9hdGluZ0NvbnRleHQu cG9zaXRpb25Gb3JGbG9hdChmbG9hdEJveCwgaG9yaXpvbnRhbENvbnN0cmFpbnRzKSk7CiAgICAg ICAgICAgICBmbG9hdGluZ0NvbnRleHQuYXBwZW5kKGZsb2F0Qm94KTsKICAgICAgICAgfQogICAg IH0K