207799 2020-02-14 16:35:48 -0800 Improve NSURLSession WebSocket message handling in case of error 2020-02-14 18:16:14 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson commit-queue webkit-bug-importer oldest_to_newest 1619288 0 youennf 2020-02-14 16:35:48 -0800 Remove the call to didClose from WebSocketTask::readNextMessage completionHandler 1619305 1 390838 youennf 2020-02-14 17:15:31 -0800 Created attachment 390838 Patch 1619330 2 390838 commit-queue 2020-02-14 18:15:56 -0800 Comment on attachment 390838 Patch Clearing flags on attachment: 390838 Committed r256662: <https://trac.webkit.org/changeset/256662> 1619331 3 commit-queue 2020-02-14 18:15:57 -0800 All reviewed patches have been landed. Closing bug. 1619332 4 webkit-bug-importer 2020-02-14 18:16:14 -0800 <rdar://problem/59480657> 390838 2020-02-14 17:15:31 -0800 2020-02-14 18:15:56 -0800 Patch bug-207799-20200214171530.patch text/plain 3363 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViZWFkZWI2ODJiNzI4ODdh MDhmMTA2ZGRjNzAwMmQ4MTFhZTZkZGMuLjRkZmRkNzQ2NDYyNzFlMGM5NTljZjY3Nzc5NjhmZTc3 YzVjMjhmMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDItMTQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgTlNVUkxTZXNzaW9u IFdlYlNvY2tldCBtZXNzYWdlIGhhbmRsaW5nIGluIGNhc2Ugb2YgZXJyb3IKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzc5OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RlZCBieSBydW5uaW5nIGxh eW91dCB0ZXN0cyB3aXRoIE5TVVJMU2Vzc2lvbiBXZWJTb2NrZXQgY29kZSBwYXRoIGVuYWJsZWQu LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvV2ViU29ja2V0VGFza0NvY29hLm1t OgorICAgICAgICAoV2ViS2l0OjpXZWJTb2NrZXRUYXNrOjpyZWFkTmV4dE1lc3NhZ2UpOgorICAg ICAgICByZWFkTmV4dE1lc3NhZ2UgY29tcGxldGlvbiBoYW5kbGVyIG1heSBiZSBjYWxsZWQgd2hl biB0aGUgY29ubmVjdGlvbiBpcyBjbG9zZWQgb3IgaW4gY2FzZSBvZiByZWFsIGVycm9yLgorICAg ICAgICBXZSBkaXNjcmltaW5hdGUgdGhpcyBjYXNlIGJ5IGNoZWNraW5nIGNsb3NlQ29kZSBhbmQg aWYgbm90IG51bGwsIHdlIGRvIG5vdGhpbmcgc2luY2UgdGhlIGNvbm5lY3Rpb24gaXMgYmVpbmcg Y2xvc2VkLgorICAgICAgICBPdGhlcndpc2UsIHdlIGNvbW11bmljYXRlIHRoZSBlcnJvciB0byBX ZWJQcm9jZXNzIGFuZCBjbG9zZSB0aGUgY29ubmVjdGlvbi4KKyAgICAgICAgKFdlYktpdDo6V2Vi U29ja2V0VGFzazo6c2VuZFN0cmluZyk6CisgICAgICAgIEFkZCB3b3JrYXJvdW5kIHVudGlsIHRo aXMgZ2V0cyBmaXhlZCB1bmRlcm5lYXRoLgorICAgICAgICAoV2ViS2l0OjpXZWJTb2NrZXRUYXNr OjpzZW5kRGF0YSk6CisgICAgICAgIEFkZCB3b3JrYXJvdW5kIHVudGlsIHRoaXMgZ2V0cyBmaXhl ZCB1bmRlcm5lYXRoLgorCiAyMDIwLTAyLTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgV2ViSW5zcGVjdG9yIHN1cHBvcnQgdG8gV2ViS2l0OjpXZWJT b2NrZXRDaGFubmVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2Nv Y29hL1dlYlNvY2tldFRhc2tDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y29jb2EvV2ViU29ja2V0VGFza0NvY29hLm1tCmluZGV4IDMxMjc1MjM4MzU4NmQxZDc1MmQ1OGM3 YTVkZjRmMjBkYjA0YzQwMzQuLjhhZTQ5YjE2MWNiNzRhNmMyYWE2ZDdhYzA0NzEyOWE1OGQxNTY3 ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvV2ViU29j a2V0VGFza0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2Ev V2ViU29ja2V0VGFza0NvY29hLm1tCkBAIC01NCw4ICs1NCwxMSBAQCB2b2lkIFdlYlNvY2tldFRh c2s6OnJlYWROZXh0TWVzc2FnZSgpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgaWYg KGVycm9yKSB7Ci0gICAgICAgICAgICAvLyBGSVhNRTogdGhlIGVycm9yIGNvZGUgaXMgcHJvYmFi bHkgbm90IGEgY29ycmVjdCBXZWJTb2NrZXQgY29kZS4KLSAgICAgICAgICAgIGRpZENsb3NlKFtl cnJvciBjb2RlXSwgW2Vycm9yIGxvY2FsaXplZERlc2NyaXB0aW9uXSk7CisgICAgICAgICAgICAv LyBJZiBjbG9zZUNvZGUgaXMgbm90IHplcm8sIHdlIGFyZSBjbG9zaW5nIHRoZSBjb25uZWN0aW9u IGFuZCBkaWRDbG9zZSB3aWxsIGJlIGNhbGxlZCBmb3IgdXMuCisgICAgICAgICAgICBpZiAoW21f dGFzayBjbG9zZUNvZGVdKQorICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIG1f Y2hhbm5lbC5kaWRSZWNlaXZlTWVzc2FnZUVycm9yKFtlcnJvciBsb2NhbGl6ZWREZXNjcmlwdGlv bl0pOworICAgICAgICAgICAgZGlkQ2xvc2UoV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6Q2xv c2VFdmVudENvZGVBYm5vcm1hbENsb3N1cmUsIGVtcHR5U3RyaW5nKCkpOwogICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICB9CiAKQEAgLTk4LDcgKzEwMSw4IEBAIHZvaWQgV2ViU29ja2V0VGFz azo6c2VuZFN0cmluZyhjb25zdCBTdHJpbmcmIHRleHQgLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lk KCk+JiYKIHsKICAgICBhdXRvIG1lc3NhZ2UgPSBhZG9wdE5TKFtbTlNVUkxTZXNzaW9uV2ViU29j a2V0TWVzc2FnZSBhbGxvY10gaW5pdFdpdGhTdHJpbmc6IHRleHRdKTsKICAgICBbbV90YXNrIHNl bmRNZXNzYWdlOiBtZXNzYWdlLmdldCgpIGNvbXBsZXRpb25IYW5kbGVyOiBtYWtlQmxvY2tQdHIo W2NhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKE5TRXJyb3IgKiBfTnVsbGFibGUpIG11dGFi bGUgewotICAgICAgICBjYWxsYmFjaygpOworICAgICAgICAvLyBXb3JrYXJvdW5kIHJkYXI6Ly9w cm9ibGVtLzU1MzI0OTI2IHVudGlsIGl0IGdldHMgZml4ZWQuCisgICAgICAgIGNhbGxPbk1haW5S dW5Mb29wKFdURk1vdmUoY2FsbGJhY2spKTsKICAgICB9KS5nZXQoKV07CiB9CiAKQEAgLTEwNyw3 ICsxMTEsOCBAQCB2b2lkIFdlYlNvY2tldFRhc2s6OnNlbmREYXRhKGNvbnN0IElQQzo6RGF0YVJl ZmVyZW5jZSYgZGF0YSwgQ29tcGxldGlvbkhhbmRsZXI8dgogICAgIGF1dG8gbnNEYXRhID0gYWRv cHROUyhbW05TRGF0YSBhbGxvY10gaW5pdFdpdGhCeXRlczpkYXRhLmRhdGEoKSBsZW5ndGg6ZGF0 YS5zaXplKCldKTsKICAgICBhdXRvIG1lc3NhZ2UgPSBhZG9wdE5TKFtbTlNVUkxTZXNzaW9uV2Vi U29ja2V0TWVzc2FnZSBhbGxvY10gaW5pdFdpdGhEYXRhOiBuc0RhdGEuZ2V0KCldKTsKICAgICBb bV90YXNrIHNlbmRNZXNzYWdlOiBtZXNzYWdlLmdldCgpIGNvbXBsZXRpb25IYW5kbGVyOiBtYWtl QmxvY2tQdHIoW2NhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKE5TRXJyb3IgKiBfTnVsbGFi bGUpIG11dGFibGUgewotICAgICAgICBjYWxsYmFjaygpOworICAgICAgICAvLyBXb3JrYXJvdW5k IHJkYXI6Ly9wcm9ibGVtLzU1MzI0OTI2IHVudGlsIGl0IGdldHMgZml4ZWQuCisgICAgICAgIGNh bGxPbk1haW5SdW5Mb29wKFdURk1vdmUoY2FsbGJhY2spKTsKICAgICB9KS5nZXQoKV07CiB9CiAK