20779 2008-09-11 05:20:05 -0700 segmentation fault in swfdec mozilla plugin 2009-01-12 15:34:50 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 riccardo.magliocchetti marco.barisione alp christian compnerd hausmann marco.barisione marc.ordinasillopis otte stempubuntu oldest_to_newest 90846 0 riccardo.magliocchetti 2008-09-11 05:20:05 -0700 Since swfdec-mozilla 0.8.0 we have a segmentation fault with webkit based browsers because we dereference a null pointer. Please note that swfdec is linux only for now. I'm seeing this with midori 0.19 / 0.21-git and webkit 1.0.1 / r36309 so it's not a regression. You can reproduce this by installing swfdec and swfdec-mozilla packages (see http://swfdec.freedesktop.org for instructions) and pointing your browser to any site that have a flash object. This is the swfdec bug containing the patch that introduced the segmentation fault: https://bugs.freedesktop.org/show_bug.cgi?id=16717 The bug tracking this issue in swfdec is here: https://bugs.freedesktop.org/show_bug.cgi?id=17521 This is the stack trace: [Switching to Thread 0xb57cd720 (LWP 7846)] 0xb4bdf742 in plugin_set_window (instance=0xb4c06820, window=0xb4c06828) at plugin.c:398 398 plugin_x11_setup_windowed (instance->pdata, (Window) window->window, (gdb) bt 1 full #0 0xb4bdf742 in plugin_set_window (instance=0xb4c06820, window=0xb4c06828) at plugin.c:398 No locals. (More stack frames follow...) (gdb) print window $1 = (NPWindow *) 0xb4c06828 (gdb) print instance->pdata $2 = (void *) 0x9d86000 (gdb) print window->ws_info $3 = (void *) 0x0 (gdb) print window->ws_info->visual Attempt to dereference a generic pointer. 90860 1 otte 2008-09-11 08:33:04 -0700 Yeah, it seems Webkit doesn't provide a ws_info field as it should according to http://developer.mozilla.org/en/NPWindow The code to use it was added because using the wrong Visual might cause an X error, see https://bugs.freedesktop.org/show_bug.cgi?id=16717 and https://bugzilla.mozilla.org/show_bug.cgi?id=445250 91900 2 cookiecaper 2008-09-20 09:46:36 -0700 I may be experiencing this bug as well -- not entirely sure if it's the same or different, but it looks the same to me. This occurs whenever I leave a page with a Flash element and swfdec, using epiphany-webkit 2.23.91 and webkit r36705. Again, the first time a Flash element is loaded, thing is fine, but when one tries to leave this page, thing become sad and crashes. :( I've attached the full backtrace I encountered. Hope it helps. Arch Linux w/ kernel 2.6.26 (x86_64) Webkit r36705 Gnome 2.22.3 / epiphany-webkit 2.23.91 swfdec 0.8.0 Thanks in advance. 91901 3 23602 cookiecaper 2008-09-20 09:49:12 -0700 Created attachment 23602 A backtrace from a segfault caused by swfdec 0.8.0 and webkit. A backtrace from a segfault caused by swfdec 0.8.0 and webkit. 93208 4 marc.ordinasillopis 2008-09-29 00:45:59 -0700 According to http://developer.mozilla.org/en/Gecko_Plugin_API_Reference/Drawing_and_Event_Handling and http://developer.mozilla.org/en/NPP_SetWindow , passing a null window indicates that the window is being destroyed. I seem to have misread that as window *and* ws_info, sorry for that. It should be easy to fix, all's needed is to change the order of deleting ws_info and calling the plugin in PluginView::stop in both WebCore/plugins/gtk/PluginViewGtk.cpp:276 and WebCore/plugins/qt/PluginViewQt.cpp:234. I can't patch myself right away, any takers? 93348 5 cookiecaper 2008-09-30 03:23:31 -0700 I've included a patch that seems to resolve the issue. Thanks for your help and attention. : ) 93349 6 23935 cookiecaper 2008-09-30 03:24:26 -0700 Created attachment 23935 Stop segfault on leaving page with plugin load 93350 7 riccardo.magliocchetti 2008-09-30 03:33:04 -0700 I was doing the same thing(In reply to comment #5) > I've included a patch that seems to resolve the issue. Thanks for your help and > attention. : ) i was doing the exact same thing :) it still crash when you close the page with the flash file (webkit r37056 and midori 0.2.1). Should file a new bug? 93351 8 23936 cookiecaper 2008-09-30 03:33:47 -0700 Created attachment 23936 Stop segfault on leaving page with plugin load - Qt 93352 9 cookiecaper 2008-09-30 03:43:50 -0700 I don't get that crash with epiphany-webkit. Perhaps you're experiencing a Midori bug? 93353 10 marco.barisione 2008-09-30 03:49:46 -0700 I was doing the same, and this is why I assigned the bug to me :) Can you please provide a ChangeLog entry with the patch? (maybe a patch for both gtk and qt is enough) Did you test the qt patch? When the patch is ready for review you should set the review field to "?", so a reviewer can review it. Even fixing this bug I can still see problems (using GtkLauncher) with both swfdec and the adobe flash plugin, if you want you can open a bug report and try to fix that too. 93522 11 riccardo.magliocchetti 2008-10-01 01:02:39 -0700 (In reply to comment #9) > I don't get that crash with epiphany-webkit. Perhaps you're experiencing a > Midori bug? Nope, it happens with GtkLauncher too, filed bug 21240. 93715 12 cookiecaper 2008-10-02 05:09:16 -0700 Thank you for the help Marco. I've uploaded a new patch with ChangeLog and marked it ready for review. Thus far, I've been unable to get QtLauncher to function with swfdec, so I haven't been able to test the patch. I hope to figure this out shortly, and will mark that as needing review once I get that funny business sorted. 93716 13 24017 cookiecaper 2008-10-02 05:11:13 -0700 Created attachment 24017 Stop segfault on leaving page with plugin load -Gtk w/ changelog 93718 14 24017 marco.barisione 2008-10-02 06:05:05 -0700 Comment on attachment 24017 Stop segfault on leaving page with plugin load -Gtk w/ changelog Patches that need a review should be marked as "?", not "+". It's nice to have a link to the bug report in the changelog entry but I don't know if it's a rule or what. The changelog entry should also say how the bug was fixed, not only describe the bug. 94033 15 cookiecaper 2008-10-03 21:55:11 -0700 (In reply to comment #14) > (From update of attachment 24017 [edit]) > Patches that need a review should be marked as "?", not "+". > > It's nice to have a link to the bug report in the changelog entry but I don't > know if it's a rule or what. > > The changelog entry should also say how the bug was fixed, not only describe > the bug. > Thanks Marco. I misclicked on the +, meant ?. Submitting updated patch. 94035 16 24080 cookiecaper 2008-10-03 22:01:58 -0700 Created attachment 24080 Patch for GTK with better changelog. 95224 17 alp 2008-10-13 15:48:57 -0700 (In reply to comment #16) > Created an attachment (id=24080) [edit] > Patch for GTK with better changelog. > Hi, in r37535 a fix for a plugin crasher was landed. It adds a quirk. I wonder if your patch achieves the same thing without the need for a quirk. If so, we can back out r37535 and land your patch instead. Can you check this out? Thanks 95285 18 riccardo.magliocchetti 2008-10-14 05:16:02 -0700 (In reply to comment #17) > Hi, > > in r37535 a fix for a plugin crasher was landed. It adds a quirk. I wonder if > your patch achieves the same thing without the need for a quirk. If so, we can > back out r37535 and land your patch instead. > > Can you check this out? Thanks Hi Alp, Webkit r37567 + this patch + swfdec -> ok Webkit r37567 + this patch + flash 10 rc -> ok Webkit r37567 + this patch + reverted r37535 with a patch generated by trac + flash 10 rc -> segmentation fault in adobe plugin Please land this patch :) 95455 19 24080 zecke 2008-10-15 15:04:16 -0700 Comment on attachment 24080 Patch for GTK with better changelog. Looks sane. I did land this patch. 95456 20 24080 zecke 2008-10-15 15:23:30 -0700 Comment on attachment 24080 Patch for GTK with better changelog. Clearing review flag as this has been applied. 97676 21 hausmann 2008-11-05 07:34:59 -0800 Landed Jeff's patch for the Qt port in 38125 105410 22 gustavo 2009-01-12 15:34:50 -0800 Closing, since it is landed; please reopen if needed. 23602 2008-09-20 09:49:12 -0700 2008-09-20 09:49:12 -0700 A backtrace from a segfault caused by swfdec 0.8.0 and webkit. webkitr36705-swfdec-backtrace.txt text/plain 4138 cookiecaper UHJvZ3JhbSByZWNlaXZlZCBzaWduYWwgU0lHU0VHViwgU2VnbWVudGF0aW9uIGZhdWx0LgpbU3dp dGNoaW5nIHRvIFRocmVhZCAweDdmZWQzNGVlNzc2MCAoTFdQIDMxNDA3KV0KMHgwMDAwN2ZlZDIz ZTc3NWQzIGluIHBsdWdpbl9zZXRfd2luZG93ICgpCiAgIGZyb20gL3Vzci9saWIvbW96aWxsYS9w bHVnaW5zL2xpYnN3ZmRlY21vemlsbGEuc28KKGdkYikgYnQKIzAgIDB4MDAwMDdmZWQyM2U3NzVk MyBpbiBwbHVnaW5fc2V0X3dpbmRvdyAoKQogICBmcm9tIC91c3IvbGliL21vemlsbGEvcGx1Z2lu cy9saWJzd2ZkZWNtb3ppbGxhLnNvCiMxICAweDAwMDA3ZmVkMzQ1NjZkZDUgaW4gV2ViQ29yZTo6 UGx1Z2luVmlldzo6c3RvcCAoKQogICBmcm9tIC91c3IvbGliL2xpYndlYmtpdC0xLjAuc28uMQoj MiAgMHgwMDAwN2ZlZDM0NTY3MTMzIGluIFdlYkNvcmU6OlBsdWdpblZpZXc6On5QbHVnaW5WaWV3 ICgpCiAgIGZyb20gL3Vzci9saWIvbGlid2Via2l0LTEuMC5zby4xCiMzICAweDAwMDA3ZmVkMzQz ZWYwZjggaW4gV2ViQ29yZTo6UmVuZGVyUGFydDo6flJlbmRlclBhcnQgKCkKICAgZnJvbSAvdXNy L2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzQgIDB4MDAwMDdmZWQzNDNlZjNmYSBpbiBXZWJDb3Jl OjpSZW5kZXJQYXJ0T2JqZWN0Ojp+UmVuZGVyUGFydE9iamVjdCAoKQogICBmcm9tIC91c3IvbGli L2xpYndlYmtpdC0xLjAuc28uMQojNSAgMHgwMDAwN2ZlZDM0M2U5NzBmIGluIFdlYkNvcmU6OlJl bmRlck9iamVjdDo6YXJlbmFEZWxldGUgKCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4w LnNvLjEKIzYgIDB4MDAwMDdmZWQzNDE5ZGM0NSBpbiBXZWJDb3JlOjpOb2RlOjpkZXRhY2ggKCkK ICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzcgIDB4MDAwMDdmZWQzNDE2ZWRj NCBpbiBXZWJDb3JlOjpDb250YWluZXJOb2RlOjpkZXRhY2ggKCkKICAgZnJvbSAvdXNyL2xpYi9s aWJ3ZWJraXQtMS4wLnNvLjEKIzggIDB4MDAwMDdmZWQzNDE2ZWRjNCBpbiBXZWJDb3JlOjpDb250 YWluZXJOb2RlOjpkZXRhY2ggKCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEK IzkgIDB4MDAwMDdmZWQzNDE2ZWRjNCBpbiBXZWJDb3JlOjpDb250YWluZXJOb2RlOjpkZXRhY2gg KCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzEwIDB4MDAwMDdmZWQzNDE2 ZWRjNCBpbiBXZWJDb3JlOjpDb250YWluZXJOb2RlOjpkZXRhY2ggKCkKICAgZnJvbSAvdXNyL2xp Yi9saWJ3ZWJraXQtMS4wLnNvLjEKIzExIDB4MDAwMDdmZWQzNDE2ZWRjNCBpbiBXZWJDb3JlOjpD b250YWluZXJOb2RlOjpkZXRhY2ggKCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNv LjEKIzEyIDB4MDAwMDdmZWQzNDE2ZWRjNCBpbiBXZWJDb3JlOjpDb250YWluZXJOb2RlOjpkZXRh Y2ggKCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzEzIDB4MDAwMDdmZWQz NDE2ZWRjNCBpbiBXZWJDb3JlOjpDb250YWluZXJOb2RlOjpkZXRhY2ggKCkKICAgZnJvbSAvdXNy L2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzE0IDB4MDAwMDdmZWQzNDE2ZWRjNCBpbiBXZWJDb3Jl OjpDb250YWluZXJOb2RlOjpkZXRhY2ggKCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4w LnNvLjEKIzE1IDB4MDAwMDdmZWQzNDE2ZWRjNCBpbiBXZWJDb3JlOjpDb250YWluZXJOb2RlOjpk ZXRhY2ggKCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzE2IDB4MDAwMDdm ZWQzNDE2ZWRjNCBpbiBXZWJDb3JlOjpDb250YWluZXJOb2RlOjpkZXRhY2ggKCkKICAgZnJvbSAv dXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzE3IDB4MDAwMDdmZWQzNDE3NmQ0YyBpbiBXZWJD b3JlOjpEb2N1bWVudDo6ZGV0YWNoICgpCiAgIGZyb20gL3Vzci9saWIvbGlid2Via2l0LTEuMC5z by4xCiMxOCAweDAwMDA3ZmVkMzQzMDJmMWUgaW4gV2ViQ29yZTo6RnJhbWU6OnNldFZpZXcgKCkK ICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzE5IDB4MDAwMDdmZWQzNDBiNjBj ZiBpbiBXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50Ojp0cmFuc2l0aW9uVG9Db21taXR0ZWRGb3JO ZXdQYWdlICgpIGZyb20gL3Vzci9saWIvbGlid2Via2l0LTEuMC5zby4xCiMyMCAweDAwMDA3ZmVk MzQyYjkwZWMgaW4gV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnRyYW5zaXRpb25Ub0NvbW1pdHRlZCAo KQogICBmcm9tIC91c3IvbGliL2xpYndlYmtpdC0xLjAuc28uMQojMjEgMHgwMDAwN2ZlZDM0MmI5 ZjFjIGluIFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpjb21taXRQcm92aXNpb25hbExvYWQgKCkKICAg ZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzIyIDB4MDAwMDdmZWQzNDI5YWEwZiBp biBXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y29tbWl0SWZSZWFkeSAoKQogICBmcm9tIC91c3Iv bGliL2xpYndlYmtpdC0xLjAuc28uMQotLS1UeXBlIDxyZXR1cm4+IHRvIGNvbnRpbnVlLCBvciBx IDxyZXR1cm4+IHRvIHF1aXQtLS0KIzIzIDB4MDAwMDdmZWQzNDI5YWNjYiBpbiBXZWJDb3JlOjpE b2N1bWVudExvYWRlcjo6Y29tbWl0TG9hZCAoKQogICBmcm9tIC91c3IvbGliL2xpYndlYmtpdC0x LjAuc28uMQojMjQgMHgwMDAwN2ZlZDM0MmM2MjcyIGluIFdlYkNvcmU6OlJlc291cmNlTG9hZGVy OjpkaWRSZWNlaXZlRGF0YSAoKQogICBmcm9tIC91c3IvbGliL2xpYndlYmtpdC0xLjAuc28uMQoj MjUgMHgwMDAwN2ZlZDM0MmJmNDc1IGluIFdlYkNvcmU6Ok1haW5SZXNvdXJjZUxvYWRlcjo6ZGlk UmVjZWl2ZURhdGEgKCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzI2IDB4 MDAwMDdmZWQzNDQzZjZhMyBpbiBXZWJDb3JlOjp3cml0ZUNhbGxiYWNrICgpCiAgIGZyb20gL3Vz ci9saWIvbGlid2Via2l0LTEuMC5zby4xCiMyNyAweDAwMDA3ZmVkMmNmMTEwYTIgaW4gQ3VybF9j bGllbnRfd3JpdGUgKCkgZnJvbSAvdXNyL2xpYi9saWJjdXJsLnNvLjQKIzI4IDB4MDAwMDdmZWQy Y2YyNzc3YiBpbiBDdXJsX2h0dHBjaHVua19yZWFkICgpIGZyb20gL3Vzci9saWIvbGliY3VybC5z by40CiMyOSAweDAwMDA3ZmVkMmNmMjU2NmMgaW4gQ3VybF9yZWFkd3JpdGUgKCkgZnJvbSAvdXNy L2xpYi9saWJjdXJsLnNvLjQKIzMwIDB4MDAwMDdmZWQyY2YyOWJhYyBpbiBtdWx0aV9ydW5zaW5n bGUgKCkgZnJvbSAvdXNyL2xpYi9saWJjdXJsLnNvLjQKIzMxIDB4MDAwMDdmZWQyY2YyYTQ3YiBp biBjdXJsX211bHRpX3BlcmZvcm0gKCkgZnJvbSAvdXNyL2xpYi9saWJjdXJsLnNvLjQKIzMyIDB4 MDAwMDdmZWQzNDQ0MWI0YyBpbiBXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OmRvd25s b2FkVGltZXJDYWxsYmFjawogICAgKCkgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEK IzMzIDB4MDAwMDdmZWQzNDM0OGJhMyBpbiBXZWJDb3JlOjpUaW1lckJhc2U6OmZpcmVUaW1lcnMg KCkKICAgZnJvbSAvdXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzM0IDB4MDAwMDdmZWQzNDM0 OGM1ZSBpbiBXZWJDb3JlOjpUaW1lckJhc2U6OnNoYXJlZFRpbWVyRmlyZWQgKCkKICAgZnJvbSAv dXNyL2xpYi9saWJ3ZWJraXQtMS4wLnNvLjEKIzM1IDB4MDAwMDdmZWQzNDU3ZWEzMiBpbiBXZWJD b3JlOjp0aW1lb3V0X2NiICgpCiAgIGZyb20gL3Vzci9saWIvbGlid2Via2l0LTEuMC5zby4xCiMz NiAweDAwMDA3ZmVkMmU4ZmYyMmIgaW4gZ190aW1lb3V0X2Rpc3BhdGNoICgpIGZyb20gL3Vzci9s aWIvbGliZ2xpYi0yLjAuc28uMAojMzcgMHgwMDAwN2ZlZDJlOGZlYTkyIGluIGdfbWFpbl9jb250 ZXh0X2Rpc3BhdGNoICgpCiAgIGZyb20gL3Vzci9saWIvbGliZ2xpYi0yLjAuc28uMAojMzggMHgw MDAwN2ZlZDJlOTAyMjFkIGluIGdfbWFpbl9jb250ZXh0X2l0ZXJhdGUgKCkKICAgZnJvbSAvdXNy L2xpYi9saWJnbGliLTIuMC5zby4wCiMzOSAweDAwMDA3ZmVkMmU5MDI3NGQgaW4gZ19tYWluX2xv b3BfcnVuICgpIGZyb20gL3Vzci9saWIvbGliZ2xpYi0yLjAuc28uMAojNDAgMHgwMDAwN2ZlZDMw OTMyZDM3IGluIGd0a19tYWluICgpIGZyb20gL3Vzci9saWIvbGliZ3RrLXgxMS0yLjAuc28uMAoj NDEgMHgwMDAwMDAwMDAwNDQxNDcwIGluIG1haW4gKCkKCg== 23935 2008-09-30 03:24:26 -0700 2008-10-02 05:11:13 -0700 Stop segfault on leaving page with plugin load stoppluginsegfault.diff text/plain 1014 cookiecaper SW5kZXg6IHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsdWdp bnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCShyZXZpc2lvbiAzNzA5MikKKysrIHBsdWdpbnMvZ3Rr L1BsdWdpblZpZXdHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzMsMTEgKzI3Myw2IEBACiAK ICAgICAvLyBDbGVhciB0aGUgd2luZG93CiAgICAgbV9ucFdpbmRvdy53aW5kb3cgPSAwOwotI2lm ZGVmIFhQX1VOSVgKLSAgICBpZiAobV9pc1dpbmRvd2VkICYmIG1fbnBXaW5kb3cud3NfaW5mbykg Ci0gICAgICAgICAgIGRlbGV0ZSAoTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCAqKW1fbnBXaW5k b3cud3NfaW5mbzsKLSAgICBtX25wV2luZG93LndzX2luZm8gPSAwOwotI2VuZGlmCiAgICAgaWYg KG1fcGx1Z2luLT5wbHVnaW5GdW5jcygpLT5zZXR3aW5kb3cgJiYgIW1fcGx1Z2luLT5xdWlya3Mo KS5jb250YWlucyhQbHVnaW5RdWlya0RvbnRTZXROdWxsV2luZG93SGFuZGxlT25EZXN0cm95KSkg ewogICAgICAgICBQbHVnaW5WaWV3OjpzZXRDdXJyZW50UGx1Z2luVmlldyh0aGlzKTsKICAgICAg ICAgc2V0Q2FsbGluZ1BsdWdpbih0cnVlKTsKQEAgLTI4NSw3ICsyODAsMTEgQEAKICAgICAgICAg c2V0Q2FsbGluZ1BsdWdpbihmYWxzZSk7CiAgICAgICAgIFBsdWdpblZpZXc6OnNldEN1cnJlbnRQ bHVnaW5WaWV3KDApOwogICAgIH0KLQorI2lmZGVmIFhQX1VOSVgKKyAgICBpZiAobV9pc1dpbmRv d2VkICYmIG1fbnBXaW5kb3cud3NfaW5mbykgCisgICAgICAgICAgIGRlbGV0ZSAoTlBTZXRXaW5k b3dDYWxsYmFja1N0cnVjdCAqKW1fbnBXaW5kb3cud3NfaW5mbzsKKyAgICBtX25wV2luZG93Lndz X2luZm8gPSAwOworI2VuZGlmCiAgICAgLy8gRGVzdHJveSB0aGUgcGx1Z2luCiAgICAgewogICAg ICAgICBQbHVnaW5WaWV3OjpzZXRDdXJyZW50UGx1Z2luVmlldyh0aGlzKTsK 23936 2008-09-30 03:33:47 -0700 2008-09-30 03:33:47 -0700 Stop segfault on leaving page with plugin load - Qt stopqtplugsegfault.diff text/plain 1074 cookiecaper SW5kZXg6IHBsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcCAgICAgICAgICAgICAgICAgICAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwIChyZXZpc2lvbiAzNzA5Mikg ICAgICAgICAgICAgICAgICAgCisrKyBwbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAgKHdvcmtp bmcgY29weSkgICAgICAgICAgICAgICAgICAgICAKQEAgLTIzMSw4ICsyMzEsNiBAQCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAg Ly8gQ2xlYXIgdGhlIHdpbmRvdyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAKICAgICBtX25wV2luZG93LndpbmRvdyA9IDA7Ci0gICAgZGVsZXRlIChOUFNldFdpbmRv d0NhbGxiYWNrU3RydWN0ICopbV9ucFdpbmRvdy53c19pbmZvOwotICAgIG1fbnBXaW5kb3cud3Nf aW5mbyA9IDA7CiAgICAgaWYgKG1fcGx1Z2luLT5wbHVnaW5GdW5jcygpLT5zZXR3aW5kb3cgJiYg IW1fcGx1Z2luLT5xdWlya3MoKS5jb250YWlucyhQbHVnaW5RdWlya0RvbnRTZXROdWxsV2luZG93 SGFuZGxlT25EZXN0cm95KSkgewogICAgICAgICBQbHVnaW5WaWV3OjpzZXRDdXJyZW50UGx1Z2lu Vmlldyh0aGlzKTsKICAgICAgICAgc2V0Q2FsbGluZ1BsdWdpbih0cnVlKTsKQEAgLTI0MCw3ICsy MzgsMTAgQEAKICAgICAgICAgc2V0Q2FsbGluZ1BsdWdpbihmYWxzZSk7CiAgICAgICAgIFBsdWdp blZpZXc6OnNldEN1cnJlbnRQbHVnaW5WaWV3KDApOwogICAgIH0KLQorCisgICAgZGVsZXRlIChO UFNldFdpbmRvd0NhbGxiYWNrU3RydWN0ICopbV9ucFdpbmRvdy53c19pbmZvOworICAgIG1fbnBX aW5kb3cud3NfaW5mbyA9IDA7CisKICAgICAvLyBEZXN0cm95IHRoZSBwbHVnaW4KICAgICB7CiAg ICAgICAgIFBsdWdpblZpZXc6OnNldEN1cnJlbnRQbHVnaW5WaWV3KHRoaXMpOwoK 24017 2008-10-02 05:11:13 -0700 2008-10-03 22:01:58 -0700 Stop segfault on leaving page with plugin load -Gtk w/ changelog gtkpatchwithchangelog text/plain 1528 cookiecaper SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3MTg5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMTAt MDIgIEplZmYgQ29vayAgPGNvb2tpZWNhcGVyQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9wIFNJR1NFR1Ygd2hlbiBsZWF2aW5n IGEgcGFnZSB3aXRoIGEgRmxhc2ggb2JqZWN0LgorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1 Z2luVmlld0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzdG9wKToKKwog MjAwOC0xMC0wMiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIC0g YnVpbGQgZml4CkluZGV4OiBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAkocmV2aXNpb24gMzcxODkpCisrKyBw bHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjczLDExICsy NzMsNiBAQCB2b2lkIFBsdWdpblZpZXc6OnN0b3AoKQogCiAgICAgLy8gQ2xlYXIgdGhlIHdpbmRv dwogICAgIG1fbnBXaW5kb3cud2luZG93ID0gMDsKLSNpZmRlZiBYUF9VTklYCi0gICAgaWYgKG1f aXNXaW5kb3dlZCAmJiBtX25wV2luZG93LndzX2luZm8pIAotICAgICAgICAgICBkZWxldGUgKE5Q U2V0V2luZG93Q2FsbGJhY2tTdHJ1Y3QgKiltX25wV2luZG93LndzX2luZm87Ci0gICAgbV9ucFdp bmRvdy53c19pbmZvID0gMDsKLSNlbmRpZgogICAgIGlmIChtX3BsdWdpbi0+cGx1Z2luRnVuY3Mo KS0+c2V0d2luZG93ICYmICFtX3BsdWdpbi0+cXVpcmtzKCkuY29udGFpbnMoUGx1Z2luUXVpcmtE b250U2V0TnVsbFdpbmRvd0hhbmRsZU9uRGVzdHJveSkpIHsKICAgICAgICAgUGx1Z2luVmlldzo6 c2V0Q3VycmVudFBsdWdpblZpZXcodGhpcyk7CiAgICAgICAgIHNldENhbGxpbmdQbHVnaW4odHJ1 ZSk7CkBAIC0yODUsNyArMjgwLDExIEBAIHZvaWQgUGx1Z2luVmlldzo6c3RvcCgpCiAgICAgICAg IHNldENhbGxpbmdQbHVnaW4oZmFsc2UpOwogICAgICAgICBQbHVnaW5WaWV3OjpzZXRDdXJyZW50 UGx1Z2luVmlldygwKTsKICAgICB9Ci0KKyNpZmRlZiBYUF9VTklYCisgICAgaWYgKG1faXNXaW5k b3dlZCAmJiBtX25wV2luZG93LndzX2luZm8pIAorICAgICAgICAgICBkZWxldGUgKE5QU2V0V2lu ZG93Q2FsbGJhY2tTdHJ1Y3QgKiltX25wV2luZG93LndzX2luZm87CisgICAgbV9ucFdpbmRvdy53 c19pbmZvID0gMDsKKyNlbmRpZgogICAgIC8vIERlc3Ryb3kgdGhlIHBsdWdpbgogICAgIHsKICAg ICAgICAgUGx1Z2luVmlldzo6c2V0Q3VycmVudFBsdWdpblZpZXcodGhpcyk7Cg== 24080 2008-10-03 22:01:58 -0700 2008-10-15 15:23:30 -0700 Patch for GTK with better changelog. gtkpatchwithbetterchangelog text/plain 1660 cookiecaper SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3Mjgx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAt MDMgIEplZmYgQ29vayA8Y29va2llY2FwZXJAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgU0lHU0VHViB3aGVuIGxlYXZpbmcg YSBwYWdlIHdpdGggYSBGbGFzaCBvYmplY3QgYnkgcmVvcmRlcmluZworCXdpbmRvdyBkZXN0cnVj dGlvbiBhbmQgcGx1Z2luIHN0b3AuIFNlZQorCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDc3OQorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5j cHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzdG9wKToKKwogMjAwOC0xMC0wMyAg TWFyY28gQmFyaXNpb25lICA8bWFyY28uYmFyaXNpb25lQGNvbGxhYm9yYS5jby51az4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBbHAgVG9rZXIuCkluZGV4OiBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3 R3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAkocmV2 aXNpb24gMzcyODEpCisrKyBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjczLDExICsyNzMsNiBAQCB2b2lkIFBsdWdpblZpZXc6OnN0b3AoKQogCiAgICAg Ly8gQ2xlYXIgdGhlIHdpbmRvdwogICAgIG1fbnBXaW5kb3cud2luZG93ID0gMDsKLSNpZmRlZiBY UF9VTklYCi0gICAgaWYgKG1faXNXaW5kb3dlZCAmJiBtX25wV2luZG93LndzX2luZm8pIAotICAg ICAgICAgICBkZWxldGUgKE5QU2V0V2luZG93Q2FsbGJhY2tTdHJ1Y3QgKiltX25wV2luZG93Lndz X2luZm87Ci0gICAgbV9ucFdpbmRvdy53c19pbmZvID0gMDsKLSNlbmRpZgogICAgIGlmIChtX3Bs dWdpbi0+cGx1Z2luRnVuY3MoKS0+c2V0d2luZG93ICYmICFtX3BsdWdpbi0+cXVpcmtzKCkuY29u dGFpbnMoUGx1Z2luUXVpcmtEb250U2V0TnVsbFdpbmRvd0hhbmRsZU9uRGVzdHJveSkpIHsKICAg ICAgICAgUGx1Z2luVmlldzo6c2V0Q3VycmVudFBsdWdpblZpZXcodGhpcyk7CiAgICAgICAgIHNl dENhbGxpbmdQbHVnaW4odHJ1ZSk7CkBAIC0yODUsNyArMjgwLDExIEBAIHZvaWQgUGx1Z2luVmll dzo6c3RvcCgpCiAgICAgICAgIHNldENhbGxpbmdQbHVnaW4oZmFsc2UpOwogICAgICAgICBQbHVn aW5WaWV3OjpzZXRDdXJyZW50UGx1Z2luVmlldygwKTsKICAgICB9Ci0KKyNpZmRlZiBYUF9VTklY CisgICAgaWYgKG1faXNXaW5kb3dlZCAmJiBtX25wV2luZG93LndzX2luZm8pIAorICAgICAgICAg ICBkZWxldGUgKE5QU2V0V2luZG93Q2FsbGJhY2tTdHJ1Y3QgKiltX25wV2luZG93LndzX2luZm87 CisgICAgbV9ucFdpbmRvdy53c19pbmZvID0gMDsKKyNlbmRpZgogICAgIC8vIERlc3Ryb3kgdGhl IHBsdWdpbgogICAgIHsKICAgICAgICAgUGx1Z2luVmlldzo6c2V0Q3VycmVudFBsdWdpblZpZXco dGhpcyk7Cg==