207785 2020-02-14 13:15:26 -0800 [ Mac wk2 ] fast/events/keydown-1.html is flaky failing. 2020-02-16 17:55:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Mac macOS 10.15 ASSIGNED InRadar P2 Normal --- 1 Lawrence.j ap ap commit-queue ryanhaddad webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1619150 0 Lawrence.j 2020-02-14 13:15:26 -0800 fast/events/keydown-1.htm Description: This test is flaky failing occasionally in Mac wk2. The oldest diff that I can load, r254940, is the same. There are other flaky failures before that that are likely the same. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fkeydown-1.html&platform=mac&limit=50000&style=release&flavor=wk2 Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/events/keydown-1-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/events/keydown-1-actual.txt @@ -3,4 +3,4 @@ keydown in subframe: [object KeyboardEvent] keydown in subframe: [object KeyboardEvent] -This sentence should not end with a period + 1619151 1 webkit-bug-importer 2020-02-14 13:15:44 -0800 <rdar://problem/59469424> 1619168 2 Lawrence.j 2020-02-14 13:30:52 -0800 I have marked this test as failing while this issue is investigated. https://trac.webkit.org/changeset/256639/webkit 1619378 3 390857 ap 2020-02-14 23:00:32 -0800 Created attachment 390857 proposed patch 1619379 4 ap 2020-02-14 23:01:18 -0800 We had an older bug for this (bug 154297), but this one has a radar associated with it, so posting the speculative fix here. 1619381 5 ap 2020-02-14 23:01:56 -0800 *** Bug 154297 has been marked as a duplicate of this bug. *** 1619454 6 390857 zalan 2020-02-15 17:34:32 -0800 Comment on attachment 390857 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=390857&action=review > LayoutTests/platform/mac-wk2/TestExpectations:-1043 > -<<<<<<< Updated upstream Looks like some unresolved conflict. 1619455 7 390857 wenson_hsieh 2020-02-15 17:35:28 -0800 Comment on attachment 390857 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=390857&action=review >> LayoutTests/platform/mac-wk2/TestExpectations:-1043 >> -<<<<<<< Updated upstream > > Looks like some unresolved conflict. It seems this was landed by accident in r256656; this patch is fixing it. 1619457 8 zalan 2020-02-15 17:37:34 -0800 (In reply to Wenson Hsieh from comment #7) > Comment on attachment 390857 [details] > proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390857&action=review > > >> LayoutTests/platform/mac-wk2/TestExpectations:-1043 > >> -<<<<<<< Updated upstream > > > > Looks like some unresolved conflict. > > It seems this was landed by accident in r256656; this patch is fixing it. thanks greyscale mode. :( 1619522 9 390857 commit-queue 2020-02-16 16:58:33 -0800 Comment on attachment 390857 proposed patch Rejecting attachment 390857 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 390857, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=390857&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=207785&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 390857 from bug 207785. Fetching: https://bugs.webkit.org/attachment.cgi?id=390857 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/events/keydown-1.html patching file LayoutTests/platform/mac-wk1/TestExpectations patching file LayoutTests/platform/mac-wk2/TestExpectations Hunk #1 FAILED at 1038. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-wk2/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13323639 1619536 10 ap 2020-02-16 17:55:16 -0800 Committed r256717. Dean already removed the markers, but he resolved the conflict in the wrong direction, so follow-up was still needed. 390857 2020-02-14 23:00:32 -0800 2020-02-16 16:58:33 -0800 proposed patch keydown-1.txt text/plain 3569 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1NjcwMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAyLTE0ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFsgTWFjIHdrMiBdIGZhc3QvZXZlbnRzL2tl eWRvd24tMS5odG1sIGlzIGZsYWt5IGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDI5NworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3Nzg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTQ2 OTQyND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZhc3QvZXZlbnRzL2tleWRvd24tMS5odG1sOiBBdHRlbXB0IHRvIGRlZmxha2UgYnkgdXNpbmcg b25sb2FkIGluc3RlYWQgb2YgYSAyMDAgbXMgdGltZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgZmxha3kgZXhwZWN0YXRpb24uCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgZmxha3kg ZXhwZWN0YXRpb24uIEFsc28gY29ycmVjdGVkIGEgCisgICAgICAgIGNvbmZsaWN0IHRoYXQgd2Fz IGxhbmRlZCBpbiByMjU2NjU2IHRvZGF5LgorCiAyMDIwLTAyLTE0ICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMjU2NjMzLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMva2V5ZG93bi0xLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMva2V5ZG93bi0xLmh0bWwJKHJl dmlzaW9uIDI1NjY5OSkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2tleWRvd24tMS5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC00LDYgKzQsMTEgQEAKIDx1bCBpZD0iY29uc29sZSI+PC91bD4K IAogPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworfQorCiBmdW5jdGlv biBsb2coc3RyKSB7CiAgICAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi Y29uc29sZSIpOwogICAgIHZhciBsaSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImxpIik7CkBA IC0yNSw3ICszMCw4IEBAIGZhbHNlKTsKIGZhbHNlKTsKIH0KIAotZnVuY3Rpb24gc3RlcDIoKSB7 Cit3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKQorewogICAgIGFkZEV2ZW50TGlzdGVuZXJzKCk7 CiAgICAgCiAgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikKQEAgLTQ2LDE3ICs1Miw3IEBAIGZ1 bmN0aW9uIHN0ZXAyKCkgewogICAgIGV2ZW50U2VuZGVyLmtleURvd24oImRlbGV0ZSIpOwogCiAg ICAgbG9nKHdpbmRvdy5mcmFtZXNbMF0uZG9jdW1lbnQuYm9keS5pbm5lclRleHQpOwotICAgIHdp bmRvdy50ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUo KTsKIH0KLQotZnVuY3Rpb24gcnVuVGVzdCgpIHsKLSAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKLSAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Ci0gICAgICAgIHdpbmRvdy50ZXN0 UnVubmVyLndhaXRVbnRpbERvbmUoKTsKLSAgICB9Ci0gICAgd2luZG93LnNldFRpbWVvdXQoc3Rl cDIsIDIwMCk7Ci19Ci0KLXJ1blRlc3QoKTsKIDwvc2NyaXB0PgogPC9ib2R5PgpJbmRleDogTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24g MjU2Njk5KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25z CSh3b3JraW5nIGNvcHkpCkBAIC0yMDUsOCArMjA1LDYgQEAgd2Via2l0Lm9yZy9iLzE1MjQ4NSB3 ZWJhdWRpby9hdWRpb2NvbnRleAogCiB3ZWJraXQub3JnL2IvMTUyNzg5IHdlYmFyY2hpdmUvYWRv cHQtYXR0cmlidXRlLXN0eWxlZC1ib2R5LXdlYmFyY2hpdmUuaHRtbCBbIFBhc3MgQ3Jhc2ggXQog Ci13ZWJraXQub3JnL2IvMTU0Mjk3IFsgRGVidWcgXSBmYXN0L2V2ZW50cy9rZXlkb3duLTEuaHRt bCBbIFBhc3MgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNTUxOTYgc2VjdXJpdHkvY29udGVu dFNlY3VyaXR5UG9saWN5L3ZpZGVvLXdpdGgtYmxvYi11cmwtYWxsb3dlZC1ieS1tZWRpYS1zcmMt c3Rhci5odG1sIFsgU2tpcCBdCiAKIHdlYmtpdC5vcmcvYi8xNTUwNjcgc3RvcmFnZS9pbmRleGVk ZGIvdHJhbnNhY3Rpb24tYWJvcnQtcHJpdmF0ZS5odG1sIFsgUGFzcyBDcmFzaCBdCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lv biAyNTY2OTkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMJKHdvcmtpbmcgY29weSkKQEAgLTEwMzgsMTQgKzEwMzgsNiBAQCB3ZWJraXQub3JnL2IvMjA2 Njk5IGh0dHAvdGVzdHMvbWVkaWEvbm93CiAKIHdlYmtpdC5vcmcvYi8yMDc3Nzkgd2ViZ3B1L3do bHNsL2RlcmVmZXJlbmNlLXBvaW50ZXItc2hvdWxkLXR5cGUtY2hlY2suaHRtbCBbIFBhc3MgSW1h Z2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8yMDc3ODUgZmFzdC9ldmVudHMva2V5ZG93 bi0xLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCi08PDw8PDw8IFVwZGF0ZWQgdXBzdHJlYW0KLXdl YmtpdC5vcmcvYi8yMDc3OTMgZmFzdC9odG1sL21hcnF1ZWUtY2hpbGQtd3JhcC5odG1sIFsgUGFz cyBJbWFnZU9ubHlGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzIwNzc5NiBbIFJlbGVhc2UgXSBm YXN0L2JveC1zaGFkb3cvaGlkcGktYm94LXNoYWRvdy5odG1sIFsgUGFzcyBJbWFnZU9ubHlGYWls dXJlIF0KIAogd2Via2l0Lm9yZy9iLzIwNzc5OCB3ZWJydGMvY29ubmVjdGlvbi1zdGF0ZS5odG1s IFsgUGFzcyBGYWlsdXJlIF0KLT09PT09PT0KLXdlYmtpdC5vcmcvYi8yMDc3OTYgWyBSZWxlYXNl IF0gZmFzdC9ib3gtc2hhZG93L2hpZHBpLWJveC1zaGFkb3cuaHRtbCBbIFBhc3MgSW1hZ2VPbmx5 RmFpbHVyZSBdCi0+Pj4+Pj4+IFN0YXNoZWQgY2hhbmdlcwo=