207758 2020-02-14 06:18:16 -0800 [WPE] Use the theme to render the focus ring 2020-02-20 02:32:11 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1618949 0 cgarcia 2020-02-14 06:18:16 -0800 This makes form controls consistent with elements having an auto outline. 1618950 1 390758 cgarcia 2020-02-14 06:21:25 -0800 Created attachment 390758 Patch 1621127 2 390758 aperez 2020-02-20 00:14:32 -0800 Comment on attachment 390758 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390758&action=review > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:298 > + UNUSED_PARAM(offset); What is the reason for these two being ignored? IIUC, it is possible to set some CSS properties on focus rings using the :focus selector, and I think these two values might comes from there in some way e.g. if the shape is not overriden, but only the border width then that would mean “paint the system focus ring, but with a custom width”. I think it's fine to land the patch as-is, but I would leave a TODO comment here. > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:320 > + UNUSED_PARAM(offset); Ditto. 1621144 3 cgarcia 2020-02-20 02:30:24 -0800 (In reply to Adrian Perez from comment #2) > Comment on attachment 390758 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390758&action=review > > > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:298 > > + UNUSED_PARAM(offset); > > What is the reason for these two being ignored? We have always ignored them in GTK port. I checked other browsers and they also seem to ignore it. > IIUC, it is possible > to set some CSS properties on focus rings using the :focus selector, > and I think these two values might comes from there in some way e.g. > if the shape is not overriden, but only the border width then that > would mean “paint the system focus ring, but with a custom width”. I tried to honor them and it didn't really work. In the case of the offset, it sometimes applied already by renderer (depends on the caller). > I think it's fine to land the patch as-is, but I would leave a TODO > comment here. Ok, we can investigate it later. > > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:320 > > + UNUSED_PARAM(offset); > > Ditto. 1621145 4 cgarcia 2020-02-20 02:32:11 -0800 Committed r257049: <https://trac.webkit.org/changeset/257049> 390758 2020-02-14 06:21:25 -0800 2020-02-20 00:14:32 -0800 Patch wpe-focus-ring.diff text/plain 8046 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZTMzZGViOTY3Yi4uOGE3MTM2MWZjNGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAyMC0wMi0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gVXNlIHRoZSB0aGVtZSB0byByZW5kZXIgdGhlIGZv Y3VzIHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNzc1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgbWFrZXMgZm9ybSBjb250cm9scyBjb25zaXN0ZW50IHdpdGggZWxlbWVudHMgaGF2aW5n IGFuIGF1dG8gb3V0bGluZS4KKworICAgICAgICAqIFBsYXRmb3JtV1BFLmNtYWtlOiBBZGQgcGxh dGZvcm0vd3BlIHRvIGluY2x1ZGUgZGlycy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQ6OmRyYXdGb2N1c1JpbmcpOiBVc2UgVGhlbWVXUEU6OmZvY3VzQ29sb3IuCisgICAg ICAgICogcGxhdGZvcm0vd3BlL1JlbmRlclRoZW1lV1BFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRoZW1lV1BFOjpwbGF0Zm9ybUZvY3VzUmluZ0NvbG9yIGNvbnN0KTogSW1wbGVtZW50 IGl0IHRvIHJldHVybiB0aGUgZm9jdXMgY29sb3IgdXNlZCBieSBUaGVtZVdQRS4KKyAgICAgICAg KiBwbGF0Zm9ybS93cGUvUmVuZGVyVGhlbWVXUEUuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS93cGUv VGhlbWVXUEUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGhlbWVXUEU6OmZvY3VzQ29sb3IpOiBS ZXR1cm4gdGhlIGZvY3VzIGNvbG9yLgorICAgICAgICAoV2ViQ29yZTo6VGhlbWVXUEU6OnBhaW50 Rm9jdXMpOiBBZGQgbmV3IG1ldGhvZHMgcmVjZWl2aW5nIGEgcGF0aCBvciBsaXN0IG9mIHJlY3Rh bmdsZXMgYW5kIGEgY29sb3IuCisgICAgICAgICogcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmg6CisK IDIwMjAtMDItMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIEFkZCBzdXBwb3J0IGZvciByZW5kZXJpbmcgc2xpZGVycyBmb3IgcmFu Z2UgZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtl IGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKaW5kZXggZDgzOTdjMDdmZjYuLjE4 NmU3MzY1MzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQor KysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtMzAsNiArMzAsNyBAQCBs aXN0KEFQUEVORCBXZWJDb3JlX1BSSVZBVEVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dF QkNPUkVfRElSfS9wbGF0Zm9ybS9tZWRpYWNhcGFiaWxpdGllcyIKICAgICAiJHtXRUJDT1JFX0RJ Un0vcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyIgogICAgICIke1dFQkNPUkVfRElSfS9w bGF0Zm9ybS90ZXh0L2ljdSIKKyAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vd3BlIgogKQog CiBsaXN0KEFQUEVORCBXZWJDb3JlX1BSSVZBVEVfRlJBTUVXT1JLX0hFQURFUlMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4 dENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBo aWNzQ29udGV4dENhaXJvLmNwcAppbmRleCA5YjAyNWUxNDc2Ny4uMTc3NzMxNGYwODcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29u dGV4dENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKQEAgLTUxLDYgKzUxLDkgQEAKICNpbmNsdWRlIDxj YWlyby13aW4zMi5oPgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShXUEUpCisjaW5jbHVkZSAiVGhl bWVXUEUuaCIKKyNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTI4OSw2ICsyOTIs MTMgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdGb2N1c1JpbmcoY29uc3QgUGF0aCYgcGF0 aCwgZmxvYXQgd2lkdGgsIGZsb2F0IG9mZnNldCwKICAgICBpZiAocGFpbnRpbmdEaXNhYmxlZCgp KQogICAgICAgICByZXR1cm47CiAKKyNpZiBQTEFURk9STShXUEUpCisgICAgVGhlbWVXUEU6OnBh aW50Rm9jdXMoKnRoaXMsIHBhdGgsIGNvbG9yKTsKKyAgICBVTlVTRURfUEFSQU0od2lkdGgpOwor ICAgIFVOVVNFRF9QQVJBTShvZmZzZXQpOworICAgIHJldHVybjsKKyNlbHNlCisKICAgICBpZiAo bV9pbXBsKSB7CiAgICAgICAgIG1faW1wbC0+ZHJhd0ZvY3VzUmluZyhwYXRoLCB3aWR0aCwgb2Zm c2V0LCBjb2xvcik7CiAgICAgICAgIHJldHVybjsKQEAgLTI5Niw2ICszMDYsNyBAQCB2b2lkIEdy YXBoaWNzQ29udGV4dDo6ZHJhd0ZvY3VzUmluZyhjb25zdCBQYXRoJiBwYXRoLCBmbG9hdCB3aWR0 aCwgZmxvYXQgb2Zmc2V0LAogCiAgICAgQVNTRVJUKGhhc1BsYXRmb3JtQ29udGV4dCgpKTsKICAg ICBDYWlybzo6ZHJhd0ZvY3VzUmluZygqcGxhdGZvcm1Db250ZXh0KCksIHBhdGgsIHdpZHRoLCBj b2xvcik7CisjZW5kaWYKIH0KIAogdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdGb2N1c1Jpbmco Y29uc3QgVmVjdG9yPEZsb2F0UmVjdD4mIHJlY3RzLCBmbG9hdCB3aWR0aCwgZmxvYXQgb2Zmc2V0 LCBjb25zdCBDb2xvciYgY29sb3IpCkBAIC0zMDMsNiArMzE0LDEzIEBAIHZvaWQgR3JhcGhpY3ND b250ZXh0OjpkcmF3Rm9jdXNSaW5nKGNvbnN0IFZlY3RvcjxGbG9hdFJlY3Q+JiByZWN0cywgZmxv YXQgd2lkdGgsCiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwog CisjaWYgUExBVEZPUk0oV1BFKQorICAgIFRoZW1lV1BFOjpwYWludEZvY3VzKCp0aGlzLCByZWN0 cywgY29sb3IpOworICAgIFVOVVNFRF9QQVJBTSh3aWR0aCk7CisgICAgVU5VU0VEX1BBUkFNKG9m ZnNldCk7CisgICAgcmV0dXJuOworI2Vsc2UKKwogICAgIGlmIChtX2ltcGwpIHsKICAgICAgICAg bV9pbXBsLT5kcmF3Rm9jdXNSaW5nKHJlY3RzLCB3aWR0aCwgb2Zmc2V0LCBjb2xvcik7CiAgICAg ICAgIHJldHVybjsKQEAgLTMxMCw2ICszMjgsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZHJh d0ZvY3VzUmluZyhjb25zdCBWZWN0b3I8RmxvYXRSZWN0PiYgcmVjdHMsIGZsb2F0IHdpZHRoLAog CiAgICAgQVNTRVJUKGhhc1BsYXRmb3JtQ29udGV4dCgpKTsKICAgICBDYWlybzo6ZHJhd0ZvY3Vz UmluZygqcGxhdGZvcm1Db250ZXh0KCksIHJlY3RzLCB3aWR0aCwgY29sb3IpOworI2VuZGlmCiB9 CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZUZvclRleHQoY29uc3QgRmxvYXRSZWN0 JiByZWN0LCBib29sIHByaW50aW5nLCBib29sIGRvdWJsZVVuZGVybGluZXMsIFN0cm9rZVN0eWxl KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1JlbmRlclRoZW1lV1BF LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9SZW5kZXJUaGVtZVdQRS5jcHAKaW5k ZXggOTllNzQ5MTliMGMuLmYwY2U5NGJmZGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS93cGUvUmVuZGVyVGhlbWVXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3dwZS9SZW5kZXJUaGVtZVdQRS5jcHAKQEAgLTEwMyw2ICsxMDMsMTEgQEAgdm9pZCBSZW5k ZXJUaGVtZVdQRTo6dXBkYXRlQ2FjaGVkU3lzdGVtRm9udERlc2NyaXB0aW9uKENTU1ZhbHVlSUQs IEZvbnRDYXNjYWRlRGUKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQogCitDb2xvciBSZW5kZXJU aGVtZVdQRTo6cGxhdGZvcm1Gb2N1c1JpbmdDb2xvcihPcHRpb25TZXQ8U3R5bGVDb2xvcjo6T3B0 aW9ucz4pIGNvbnN0Cit7CisgICAgcmV0dXJuIFRoZW1lV1BFOjpmb2N1c0NvbG9yKCk7Cit9CisK IFN0cmluZyBSZW5kZXJUaGVtZVdQRTo6ZXh0cmFEZWZhdWx0U3R5bGVTaGVldCgpCiB7CiAgICAg cmV0dXJuIFN0cmluZyh0aGVtZUFkd2FpdGFVc2VyQWdlbnRTdHlsZVNoZWV0LCBzaXplb2YodGhl bWVBZHdhaXRhVXNlckFnZW50U3R5bGVTaGVldCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vd3BlL1JlbmRlclRoZW1lV1BFLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS93cGUvUmVuZGVyVGhlbWVXUEUuaAppbmRleCAyZjliOGI0NTA2ZC4uOTY5ZGU3NzE1OTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9SZW5kZXJUaGVtZVdQRS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9SZW5kZXJUaGVtZVdQRS5oCkBAIC00Nyw2 ICs0Nyw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBzdXBwb3J0c0ZvY3VzUmluZyhjb25zdCBSZW5k ZXJTdHlsZSYpIGNvbnN0IG92ZXJyaWRlOwogCiAgICAgdm9pZCB1cGRhdGVDYWNoZWRTeXN0ZW1G b250RGVzY3JpcHRpb24oQ1NTVmFsdWVJRCwgRm9udENhc2NhZGVEZXNjcmlwdGlvbiYpIGNvbnN0 IG92ZXJyaWRlOworICAgIENvbG9yIHBsYXRmb3JtRm9jdXNSaW5nQ29sb3IoT3B0aW9uU2V0PFN0 eWxlQ29sb3I6Ok9wdGlvbnM+KSBjb25zdCBvdmVycmlkZTsKIAogICAgIGJvb2wgcGFpbnRUZXh0 RmllbGQoY29uc3QgUmVuZGVyT2JqZWN0JiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgRmxvYXRS ZWN0Jikgb3ZlcnJpZGU7CiAgICAgYm9vbCBwYWludFRleHRBcmVhKGNvbnN0IFJlbmRlck9iamVj dCYsIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEZsb2F0UmVjdCYpIG92ZXJyaWRlOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5jcHAKaW5kZXggZDkyMjRmN2M5YTIuLmE0Mjdh ZDU5OTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhlbWVXUEUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5jcHAKQEAgLTM2 LDcgKzM2LDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGNvbnN0IHVuc2lnbmVk IGZvY3VzTGluZVdpZHRoID0gMTsKLXN0YXRpYyBjb25zdCBDb2xvciBmb2N1c0NvbG9yID0gbWFr ZVJHQkEoNDYsIDUyLCA1NCwgMTUwKTsKK3N0YXRpYyBjb25zdCBDb2xvciBmb2N1c1JpbmdDb2xv ciA9IG1ha2VSR0JBKDQ2LCA1MiwgNTQsIDE1MCk7CiBzdGF0aWMgY29uc3QgdW5zaWduZWQgYXJy b3dTaXplID0gMTY7CiBzdGF0aWMgY29uc3QgQ29sb3IgYXJyb3dDb2xvciA9IG1ha2VSR0IoNDYs IDUyLCA1NCk7CiBzdGF0aWMgY29uc3QgaW50IGJ1dHRvbkZvY3VzT2Zmc2V0ID0gLTM7CkBAIC02 NSwxOSArNjUsNDUgQEAgVGhlbWUmIFRoZW1lOjpzaW5nbGV0b24oKQogICAgIHJldHVybiB0aGVt ZTsKIH0KIAorQ29sb3IgVGhlbWVXUEU6OmZvY3VzQ29sb3IoKQoreworICAgIHJldHVybiBmb2N1 c1JpbmdDb2xvcjsKK30KKwogdm9pZCBUaGVtZVdQRTo6cGFpbnRGb2N1cyhHcmFwaGljc0NvbnRl eHQmIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiByZWN0LCBpbnQgb2Zmc2V0KQog ewogICAgIEZsb2F0UmVjdCBmb2N1c1JlY3QgPSByZWN0OwogICAgIGZvY3VzUmVjdC5pbmZsYXRl KG9mZnNldCk7CisgICAgUGF0aCBwYXRoOworICAgIHBhdGguYWRkUm91bmRlZFJlY3QoZm9jdXNS ZWN0LCB7IDIsIDIgfSk7CisgICAgcGFpbnRGb2N1cyhncmFwaGljc0NvbnRleHQsIHBhdGgsIGZv Y3VzUmluZ0NvbG9yKTsKK30KKwordm9pZCBUaGVtZVdQRTo6cGFpbnRGb2N1cyhHcmFwaGljc0Nv bnRleHQmIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgUGF0aCYgcGF0aCwgY29uc3QgQ29sb3ImIGNv bG9yKQoreworICAgIEdyYXBoaWNzQ29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcihncmFwaGlj c0NvbnRleHQpOworCisgICAgZ3JhcGhpY3NDb250ZXh0LmJlZ2luVHJhbnNwYXJlbmN5TGF5ZXIo Y29sb3IuYWxwaGFBc0Zsb2F0KCkpOwogICAgIGdyYXBoaWNzQ29udGV4dC5zZXRTdHJva2VUaGlj a25lc3MoZm9jdXNMaW5lV2lkdGgpOwogICAgIGdyYXBoaWNzQ29udGV4dC5zZXRMaW5lRGFzaCh7 IGZvY3VzTGluZVdpZHRoLCAyICogZm9jdXNMaW5lV2lkdGggfSwgMCk7CiAgICAgZ3JhcGhpY3ND b250ZXh0LnNldExpbmVDYXAoU3F1YXJlQ2FwKTsKICAgICBncmFwaGljc0NvbnRleHQuc2V0TGlu ZUpvaW4oTWl0ZXJKb2luKTsKKyAgICBncmFwaGljc0NvbnRleHQuc2V0U3Ryb2tlQ29sb3IoY29s b3Iub3BhcXVlQ29sb3IoKSk7CisgICAgZ3JhcGhpY3NDb250ZXh0LnN0cm9rZVBhdGgocGF0aCk7 CisgICAgZ3JhcGhpY3NDb250ZXh0LnNldEZpbGxSdWxlKFdpbmRSdWxlOjpOb25aZXJvKTsKKyAg ICBncmFwaGljc0NvbnRleHQuc2V0Q29tcG9zaXRlT3BlcmF0aW9uKENvbXBvc2l0ZU9wZXJhdG9y OjpDbGVhcik7CisgICAgZ3JhcGhpY3NDb250ZXh0LmZpbGxQYXRoKHBhdGgpOworICAgIGdyYXBo aWNzQ29udGV4dC5zZXRDb21wb3NpdGVPcGVyYXRpb24oQ29tcG9zaXRlT3BlcmF0b3I6OlNvdXJj ZU92ZXIpOworICAgIGdyYXBoaWNzQ29udGV4dC5lbmRUcmFuc3BhcmVuY3lMYXllcigpOworfQog Cit2b2lkIFRoZW1lV1BFOjpwYWludEZvY3VzKEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250 ZXh0LCBjb25zdCBWZWN0b3I8RmxvYXRSZWN0PiYgcmVjdHMsIGNvbnN0IENvbG9yJiBjb2xvcikK K3sKKyAgICBGbG9hdFNpemUgY29ybmVyKDIsIDIpOwogICAgIFBhdGggcGF0aDsKLSAgICBwYXRo LmFkZFJvdW5kZWRSZWN0KGZvY3VzUmVjdCwgeyAyLCAyIH0pOwotICAgIGdyYXBoaWNzQ29udGV4 dC5zZXRTdHJva2VDb2xvcihmb2N1c0NvbG9yKTsKLSAgICBncmFwaGljc0NvbnRleHQuc3Ryb2tl UGF0aChwYXRoKTsKKyAgICBmb3IgKGNvbnN0IGF1dG8mIHJlY3QgOiByZWN0cykKKyAgICAgICAg cGF0aC5hZGRSb3VuZGVkUmVjdChyZWN0LCBjb3JuZXIpOworICAgIHBhaW50Rm9jdXMoZ3JhcGhp Y3NDb250ZXh0LCBwYXRoLCBjb2xvcik7CiB9CiAKIHZvaWQgVGhlbWVXUEU6OnBhaW50QXJyb3co R3JhcGhpY3NDb250ZXh0JiBncmFwaGljc0NvbnRleHQsIEFycm93RGlyZWN0aW9uIGRpcmVjdGlv bikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmgKaW5kZXggNmEzNjRkZjk1MTku LjMwNzVhODFiZmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhl bWVXUEUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhlbWVXUEUuaApAQCAt MzEsNyArMzEsMTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBUaGVtZVdQRSBmaW5h bCA6IHB1YmxpYyBUaGVtZSB7CiBwdWJsaWM6CisgICAgc3RhdGljIENvbG9yIGZvY3VzQ29sb3Io KTsKICAgICBzdGF0aWMgdm9pZCBwYWludEZvY3VzKEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IEZs b2F0UmVjdCYsIGludCBvZmZzZXQpOworICAgIHN0YXRpYyB2b2lkIHBhaW50Rm9jdXMoR3JhcGhp Y3NDb250ZXh0JiwgY29uc3QgUGF0aCYsIGNvbnN0IENvbG9yJik7CisgICAgc3RhdGljIHZvaWQg cGFpbnRGb2N1cyhHcmFwaGljc0NvbnRleHQmLCBjb25zdCBWZWN0b3I8RmxvYXRSZWN0PiYsIGNv bnN0IENvbG9yJik7CiAgICAgZW51bSBjbGFzcyBBcnJvd0RpcmVjdGlvbiB7IFVwLCBEb3duIH07 CiAgICAgc3RhdGljIHZvaWQgcGFpbnRBcnJvdyhHcmFwaGljc0NvbnRleHQmLCBBcnJvd0RpcmVj dGlvbik7CiAK