207757 2020-02-14 04:44:38 -0800 [GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan() 2020-02-16 16:52:56 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez calvaris cgarcia commit-queue ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1618939 0 aperez 2020-02-14 04:44:38 -0800 WPE WebKit 2.27.90 (and most surely the GTK port as well) fail to build with Clang when using libc++ (instead of GNU stdlibc++). Configuration command: CC=clang CXX=clang++ \ LDFLAGS='-stdlib=libc++ -fuse-ld=lld' \ CXXLAGS='-stdlib=libc++' \ cmake -DPORT=WPE -DUSE_LD_GOLD=OFF -DUSE_LD_LLD=ON <...> Build error: ../Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1155:10: error: no matching function for call to 'isnan' if (!isnan(priv->downloadStartTime)) { ^~~~~ /usr/bin/../include/c++/v1/math.h:535:1: note: candidate function not viable: no known conversion from 'WTF::WallTime' to 'float' for 1st argument isnan(float __lcpp_x) _NOEXCEPT { return __libcpp_isnan(__lcpp_x); } ^ /usr/bin/../include/c++/v1/math.h:539:1: note: candidate function not viable: no known conversion from 'WTF::WallTime' to 'double' for 1st argument isnan(double __lcpp_x) _NOEXCEPT { return __libcpp_isnan(__lcpp_x); } ^ /usr/bin/../include/c++/v1/math.h:543:1: note: candidate function not viable: no known conversion from 'WTF::WallTime' to 'long double' for 1st argument isnan(long double __lcpp_x) _NOEXCEPT { return __libcpp_isnan(__lcpp_x); } ^ /usr/bin/../include/c++/v1/math.h:521:1: note: candidate template ignored: requirement 'std::is_floating_point<WTF::WallTime>::value' was not satisfied [with _A1 = WTF::WallTime] isnan(_A1 __lcpp_x) _NOEXCEPT ^ /usr/bin/../include/c++/v1/math.h:529:1: note: candidate template ignored: requirement 'std::is_integral<WTF::WallTime>::value' was not satisfied [with _A1 = WTF::WallTime] isnan(_A1) _NOEXCEPT ^ 1 error generated. 1619406 1 aperez 2020-02-15 05:13:01 -0800 This happens in trunk as well. There are “std::isnan()” overloads defined for “WTF::Walltime”, but Clang is being a bit more strict than GCC here and not considering them when using a bare “isnan()“ call (without the namespace) because the overloaded version is inside the namespace, and there us no “using std::isnan;” (or equivalent) anywhere when non-unified builds are disabled. The fix is to add the “std::” namespace prefix to the function call =) 1619407 2 390864 aperez 2020-02-15 05:16:42 -0800 Created attachment 390864 Patch 1619437 3 390864 aperez 2020-02-15 14:20:38 -0800 Comment on attachment 390864 Patch Clearing flags on attachment: 390864 Committed r256706: <https://trac.webkit.org/changeset/256706> 1619438 4 aperez 2020-02-15 14:20:43 -0800 All reviewed patches have been landed. Closing bug. 1619439 5 webkit-bug-importer 2020-02-15 14:21:17 -0800 <rdar://problem/59488736> 390864 2020-02-15 05:16:42 -0800 2020-02-15 14:20:38 -0800 Patch bug-207757-20200215151641.patch text/plain 2154 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjNlYzk3ZDY2OTU3MzIz MmIzYTY1N2Q5OWRiM2ZmN2ZlYzZhYmY3Ni4uZWJlMmQ3MzU4YTAyNzk4NjgzMjUwNjg5NTI5NGVk ZjQ2M2JhN2FkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTE1ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJl YW1lcl0gQnVpbGQgZmFpbHVyZSB3aXRoIENsYW5nL2xpYmMrKyBkdWUgdG8gbWlzc2luZyBXYWxs VGltZeKGkmZsb2F0IGZvciBzdGQ6OmlzbmFuKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzc1NworCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Zml4LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAg ICAgKENhY2hlZFJlc291cmNlU3RyZWFtaW5nQ2xpZW50OjpkYXRhUmVjZWl2ZWQpOiBBZGQgc3Rk OjogbmFtZXNwYWNlIHRvIG92ZXJsb2FkZWQKKyAgICAgICAgc3RkOjppc25hbigpIGZ1bmN0aW9u IGNhbGwgdG8gZW5zdXJlIHRoYXQgdGhlIG92ZXJsb2FkZWQgdmVyc2lvbiBmb3IgV1RGOjpXYWxs VGltZQorICAgICAgICBpcyB1c2VkLgorCiAyMDIwLTAyLTE0ICBKb24gTGVlICA8am9ubGVlQGFw cGxlLmNvbT4KIAogICAgICAgICBNYXNrIFdlYkdMIHN0cmluZ3MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3Ry ZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dl YktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXggMDYwZGY3MWJmY2MyZGM2NzdiMjIwNmI4 ZTA0ODA1YTc2NWUzMjIyMS4uNzI5MDNhMjI0MmM0NGRhMzRhM2QyMDY0YjYzYjEyZjhlYmU2NjMy ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTEx NTIsNyArMTE1Miw3IEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2VTdHJlYW1pbmdDbGllbnQ6OmRhdGFS ZWNlaXZlZChQbGF0Zm9ybU1lZGlhUmVzb3VyY2UmLCBjb25zdCBjCiAgICAgLy8gUm91Z2ggYmFu ZHdpZHRoIGNhbGN1bGF0aW9uLiBXZSBpZ25vcmUgaGVyZSB0aGUgZmlyc3QgZGF0YSBwYWNrYWdl IGJlY2F1c2Ugd2Ugd291bGQgaGF2ZSB0byByZXNldCB0aGUgY291bnRlcnMgd2hlbiB3ZSBpc3N1 ZSB0aGUgcmVxdWVzdCBhbmQKICAgICAvLyB0aGF0IGZpcnN0IHBhY2thZ2UgZGVsaXZlcnkgd291 bGQgaW5jbHVkZSB0aGUgdGltZSBvZiBzZW5kaW5nIG91dCB0aGUgcmVxdWVzdCBhbmQgZ2V0dGlu ZyB0aGUgZGF0YSBiYWNrLiBTaW5jZSB3ZSBjYW4ndCBkaXN0aW5ndWlzaCB0aGUKICAgICAvLyBz ZW5kaW5nIHRpbWUgZnJvbSB0aGUgcmVjZWl2aW5nIHRpbWUsIGl0IGlzIGJldHRlciB0byBpZ25v cmUgaXQuCi0gICAgaWYgKCFpc25hbihwcml2LT5kb3dubG9hZFN0YXJ0VGltZSkpIHsKKyAgICBp ZiAoIXN0ZDo6aXNuYW4ocHJpdi0+ZG93bmxvYWRTdGFydFRpbWUpKSB7CiAgICAgICAgIHByaXYt PnRvdGFsRG93bmxvYWRlZEJ5dGVzICs9IGxlbmd0aDsKICAgICAgICAgZG91YmxlIHRpbWVTaW5j ZVN0YXJ0ID0gKFdhbGxUaW1lOjpub3coKSAtIHByaXYtPmRvd25sb2FkU3RhcnRUaW1lKS5zZWNv bmRzKCk7CiAgICAgICAgIEdTVF9UUkFDRV9PQkpFQ1Qoc3JjLCAiZG93bmxvYWRlZCAlIiBHX0dV SU5UNjRfRk9STUFUICIgYnl0ZXMgaW4gJWYgc2Vjb25kcyA9fiAlMS4wZiBieXRlcy9zZWNvbmQi LCBwcml2LT50b3RhbERvd25sb2FkZWRCeXRlcywgdGltZVNpbmNlU3RhcnQK