207748 2020-02-14 00:01:42 -0800 Null Ptr Deref @ WebCore::Node::Treescope 2020-02-27 17:29:19 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pgyanchandani webkit-unassigned ajuma cdumez commit-queue darin dbates esprehn+autocc ews-watchlist gyuyoung.kim mifenton rniwa wenson_hsieh oldest_to_newest 1618885 0 pgyanchandani 2020-02-14 00:01:42 -0800 Null Ptr Deref @ WebCore::Node::Treescope 1618889 1 390735 pgyanchandani 2020-02-14 00:32:06 -0800 Created attachment 390735 Patch 1618899 2 390735 rniwa 2020-02-14 00:50:34 -0800 Comment on attachment 390735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390735&action=review r- due to the issues listed below. > Source/WebCore/ChangeLog:6 > + Reviewed by Ryosuke Niwa. This is definitely not reviewed by me yet. Please undo this and say NOBODY (OOPS!). > Source/WebCore/html/HTMLTextFormControlElement.cpp:307 > + if (!isTextField()) > + return; Let's check this before getting innerText. It's weird to try to update innerText if it's not a text field > LayoutTests/ChangeLog:6 > + Reviewed by Ryosuke Niwa NOBODY. Ditto. This is definitely not reviewed by me. In fact, since I wrote this case, it's not appropriate for me to review this test. > LayoutTests/ChangeLog:8 > + Added a regression test to verify the fix Missing a period at the end. Also, we need to give the test author (me in this case) a credit in this case. Say something like: "Added a regression test to verify the fix based on a test case written by Ryosuke Niwa". > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:1 > +<html> Missing <!DOCTYPE html>. > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:11 > + const input3 = document.createElement('input'); Please rename this to inputWithAutofocus or something. > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:22 > + Please remove this blank lines. > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:24 > +<p>Testcase passes if there is no crash </p> "Testcase" should be "test case" but I think we should just say "This test". > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:25 > + Ditto. 1619184 3 390810 pgyanchandani 2020-02-14 13:52:14 -0800 Created attachment 390810 Patch 1619518 4 390810 darin 2020-02-16 16:17:39 -0800 Comment on attachment 390810 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390810&action=review > Source/WebCore/html/HTMLTextFormControlElement.cpp:308 > + Should not make this white space change. 1619760 5 390950 pgyanchandani 2020-02-17 11:40:49 -0800 Created attachment 390950 Patch 1619829 6 390950 commit-queue 2020-02-17 13:13:08 -0800 Comment on attachment 390950 Patch Clearing flags on attachment: 390950 Committed r256764: <https://trac.webkit.org/changeset/256764> 1619830 7 commit-queue 2020-02-17 13:13:10 -0800 All reviewed patches have been landed. Closing bug. 1619850 8 rniwa 2020-02-17 13:36:30 -0800 <rdar://problem/58923336> 1623794 9 rniwa 2020-02-27 17:29:19 -0800 *** Bug 208306 has been marked as a duplicate of this bug. *** 390735 2020-02-14 00:32:06 -0800 2020-02-14 13:52:12 -0800 Patch bug-207748-20200214003205.patch text/plain 4135 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE1YjczMWNiZWE5ZmUz ZGQ4MWM4NWQ0MzNkY2Q2ZDNiYzhlOGRmZi4uMGNiM2I4MjFlYTBkZWZiYWI2MmJjNWQ3YzNhNjQz Mjc2MmU1ZjZkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTE0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IFB0ciBEZXJlZiBAIFdlYkNvcmU6Ok5vZGU6OlRyZWVzY29wZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NzQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgUnlvc3VrZSBOaXdhLiAKKworICAgICAgICBBZGRlZCBhIGNoZWNrIGZvciBpc1RleHRGaWVs ZCBhZnRlciB1cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMgYXMgdGhhdCBjb3Vs ZCBjYXVzZSBtb2RpZmljYXRpb24gb2YgaW5wdXQgZWxlbWVudCB0eXBlLgorCisgICAgICAgIFRl c3Q6IGVkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFuZ2Utb24taW5wdXQtc3R5 bGUtY2hhbmdlLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnNl dFNlbGVjdGlvblJhbmdlKToKKwogMjAyMC0wMi0wOSAgQmFzdWtlIFN1enVraSAgPGJhc3VrZS5z dXp1a2lAc29ueS5jb20+CiAKICAgICAgICAgUmVwbGFjZSByZWR1bmRhbnQgZnVuY3Rpb25zIHdp dGggdmFyaWFkaWMgdGVtcGxhdGUgZnVuY3Rpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwCmluZGV4IDcyMzIyOGI1Y2I3N2U0YzBm ZjJkZGViYzhjOWFhZmU4YWFiMDcxOWEuLjBkMDYwZDYxNDY5OWJlNDFjNGFlMTRkZTY2MmVmNjgw OTY0MGIyNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3JtQ29u dHJvbEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3JtQ29u dHJvbEVsZW1lbnQuY3BwCkBAIC0zMDIsNiArMzAyLDkgQEAgdm9pZCBIVE1MVGV4dEZvcm1Db250 cm9sRWxlbWVudDo6c2V0U2VsZWN0aW9uUmFuZ2UoaW50IHN0YXJ0LCBpbnQgZW5kLCBUZXh0Rmll bGQKICAgICAgICAgLy8gRG91YmxlLWNoZWNrIHRoZSBzdGF0ZSBvZiBpbm5lclRleHRFbGVtZW50 IGFmdGVyIHRoZSBsYXlvdXQuCiAgICAgICAgIGlubmVyVGV4dCA9IGlubmVyVGV4dEVsZW1lbnQo KTsKICAgICAgICAgYXV0byogcmVuZGVyZXJUZXh0Q29udHJvbCA9IHJlbmRlcmVyKCk7CisgICAg ICAgIAorICAgICAgICBpZiAoIWlzVGV4dEZpZWxkKCkpCisgICAgICAgICAgICByZXR1cm47CiAK ICAgICAgICAgaWYgKGlubmVyVGV4dCAmJiByZW5kZXJlclRleHRDb250cm9sKSB7CiAgICAgICAg ICAgICBpZiAocmVuZGVyZXJUZXh0Q29udHJvbC0+c3R5bGUoKS52aXNpYmlsaXR5KCkgPT0gVmlz aWJpbGl0eTo6SGlkZGVuIHx8ICFpbm5lclRleHQtPnJlbmRlckJveCgpIHx8ICFpbm5lclRleHQt PnJlbmRlckJveCgpLT5oZWlnaHQoKSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDMwZDEyOGQxNGU3YWJkOTBjMDUzZjYy NTU5Yjc0MzlhOWJiODIxYjkuLjkzOWNlYWM1NmEyOTI2YjM4NTdjYWFiYzUwMTMwYzBiYWI4ZDBi MzAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wMi0xNCAgUGlua2kgR3lhbmNoYW5kYW5p ICA8cGd5YW5jaGFuZGFuaUBhcHBsZS5jb20+CisKKyAgICAgICAgTnVsbCBQdHIgRGVyZWYgQCBX ZWJDb3JlOjpOb2RlOjpUcmVlc2NvcGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzc0OAorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3 YSBOT0JPRFkuCisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QgdG8gdmVyaWZ5IHRo ZSBmaXgKKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFu Z2Utb24taW5wdXQtc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZWRpdGluZy9zZWxlY3Rpb24vaWdub3JlLXNlbGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1zdHlsZS1j aGFuZ2UuaHRtbDogQWRkZWQuCisKIDIwMjAtMDItMDkgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5l X2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgWyBNYWMgd2syIF0gaHR0cC90ZXN0cy9yZXNv dXJjZUxvYWRTdGF0aXN0aWNzL2xvZy1jcm9zcy1zaXRlLWxvYWQtd2l0aC1saW5rLWRlY29yYXRp b24uaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRp bmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFuZ2Utb24taW5wdXQtc3R5bGUtY2hhbmdl LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxl Y3Rpb24tcmFuZ2Utb24taW5wdXQtc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li40ZDk3NmQwZTgzODkwYzA0MzQ4ODVmY2FiMmM5ZDY3NzRhMmU3MzA3Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaWdub3JlLXNlbGVjdGlvbi1yYW5n ZS1vbi1pbnB1dC1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGVz dGNhc2UgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoCisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaWdub3JlLXNlbGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1z dHlsZS1jaGFuZ2UuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1z ZWxlY3Rpb24tcmFuZ2Utb24taW5wdXQtc3R5bGUtY2hhbmdlLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOGVm MmY5MjNlYTM4OTU5NGU0OThjMWM5Y2YzOTE1YTk4ODEwYzZlZgotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFuZ2Utb24t aW5wdXQtc3R5bGUtY2hhbmdlLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPGh0bWw+Cis8c2NyaXB0 PgorCitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgCisg ICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAgY29uc3QgaW5wdXQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdpbnB1dCcpOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQoaW5wdXQpOworCisgICAgY29uc3QgaW5wdXQzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgn aW5wdXQnKTsKKyAgICBpbnB1dDMuc2V0QXR0cmlidXRlKCdhdXRvZm9jdXMnLCAnJyk7CisgICAg aW5wdXQzLmFkZEV2ZW50TGlzdGVuZXIoJ2ZvY3VzJywgKCkgPT4geworICAgICAgICBpbnB1dC50 eXBlID0gJ3N1Ym1pdCc7CisgICAgfSk7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChp bnB1dDMpOworCisgICAgaW5wdXQuc2V0U2VsZWN0aW9uUmFuZ2UoMCwgMCk7CisgICAgZ2V0U2Vs ZWN0aW9uKCkuY29udGFpbnNOb2RlKGRvY3VtZW50LmJvZHkpOworfQorPC9zY3JpcHQ+CisKKzxi b2R5IG9ubG9hZD1ydW5UZXN0KCk+Cis8cD5UZXN0Y2FzZSBwYXNzZXMgaWYgdGhlcmUgaXMgbm8g Y3Jhc2ggPC9wPgorCis8L2JvZHk+Cis8L2h0bWw+Cg== 390810 2020-02-14 13:52:14 -0800 2020-02-17 11:40:47 -0800 Patch bug-207748-20200214135213.patch text/plain 4518 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE1YjczMWNiZWE5ZmUz ZGQ4MWM4NWQ0MzNkY2Q2ZDNiYzhlOGRmZi4uN2Y0NzU4M2U0MzIyMzIzOGZmODdkNWZjZjU2MWQx YzA5NmU0YjdkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTE0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IFB0ciBEZXJlZiBAIFdlYkNvcmU6Ok5vZGU6OlRyZWVzY29wZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NzQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuIAorCisgICAgICAgIEFkZGVkIGEgY2hlY2sgZm9yIGlzVGV4dEZp ZWxkIGFmdGVyIHVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cyBhcyB0aGF0IGNv dWxkIGNhdXNlIG1vZGlmaWNhdGlvbiBvZiBpbnB1dCBlbGVtZW50IHR5cGUuCisKKyAgICAgICAg VGVzdDogZWRpdGluZy9zZWxlY3Rpb24vaWdub3JlLXNlbGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1z dHlsZS1jaGFuZ2UuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6 c2V0U2VsZWN0aW9uUmFuZ2UpOgorCiAyMDIwLTAyLTA5ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtl LnN1enVraUBzb255LmNvbT4KIAogICAgICAgICBSZXBsYWNlIHJlZHVuZGFudCBmdW5jdGlvbnMg d2l0aCB2YXJpYWRpYyB0ZW1wbGF0ZSBmdW5jdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAKaW5kZXggNzIzMjI4YjVjYjc3ZTRj MGZmMmRkZWJjOGM5YWFmZThhYWIwNzE5YS4uZWYyNjFhYjRlNzc3ZjVhZTE3NmM2ODhjZGY0MTk1 OTdkZGI4ZGM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1D b250cm9sRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1D b250cm9sRWxlbWVudC5jcHAKQEAgLTI5OCwxMSArMjk4LDE0IEBAIHZvaWQgSFRNTFRleHRGb3Jt Q29udHJvbEVsZW1lbnQ6OnNldFNlbGVjdGlvblJhbmdlKGludCBzdGFydCwgaW50IGVuZCwgVGV4 dEZpZWxkCiAgICAgaWYgKCFoYXNGb2N1cyAmJiBpbm5lclRleHQpIHsKICAgICAgICAgLy8gRklY TUU6IFJlbW92aW5nIHRoaXMgc3luY2hyb25vdXMgbGF5b3V0IHJlcXVpcmVzIGZpeGluZyBzZXRT ZWxlY3Rpb25XaXRob3V0VXBkYXRpbmdBcHBlYXJhbmNlIG5vdCBuZWVkaW5nIHVwLXRvLWRhdGUg c3R5bGUuCiAgICAgICAgIGRvY3VtZW50KCkudXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxl c2hlZXRzKCk7CisgICAgICAgIAorICAgICAgICBpZiAoIWlzVGV4dEZpZWxkKCkpCisgICAgICAg ICAgICByZXR1cm47CiAKICAgICAgICAgLy8gRG91YmxlLWNoZWNrIHRoZSBzdGF0ZSBvZiBpbm5l clRleHRFbGVtZW50IGFmdGVyIHRoZSBsYXlvdXQuCiAgICAgICAgIGlubmVyVGV4dCA9IGlubmVy VGV4dEVsZW1lbnQoKTsKICAgICAgICAgYXV0byogcmVuZGVyZXJUZXh0Q29udHJvbCA9IHJlbmRl cmVyKCk7Ci0KKyAgICAKICAgICAgICAgaWYgKGlubmVyVGV4dCAmJiByZW5kZXJlclRleHRDb250 cm9sKSB7CiAgICAgICAgICAgICBpZiAocmVuZGVyZXJUZXh0Q29udHJvbC0+c3R5bGUoKS52aXNp YmlsaXR5KCkgPT0gVmlzaWJpbGl0eTo6SGlkZGVuIHx8ICFpbm5lclRleHQtPnJlbmRlckJveCgp IHx8ICFpbm5lclRleHQtPnJlbmRlckJveCgpLT5oZWlnaHQoKSkgewogICAgICAgICAgICAgICAg IGNhY2hlU2VsZWN0aW9uKHN0YXJ0LCBlbmQsIGRpcmVjdGlvbik7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzBkMTI4ZDE0 ZTdhYmQ5MGMwNTNmNjI1NTliNzQzOWE5YmI4MjFiOS4uOTA1MGE0Njc2ZmJhNDM5YTAxYTMyZDZj MGJlZmZkMTg3YTVjYTg1YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTE0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IFB0ciBEZXJlZiBAIFdlYkNvcmU6Ok5vZGU6OlRyZWVzY29wZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NzQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QgcHJv dmlkZWQgYnkgUnlvc3VrZSBOaXdhIHRvIHZlcmlmeSB0aGUgZml4LgorCisgICAgICAgICogZWRp dGluZy9zZWxlY3Rpb24vaWdub3JlLXNlbGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1zdHlsZS1jaGFu Z2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9pZ25v cmUtc2VsZWN0aW9uLXJhbmdlLW9uLWlucHV0LXN0eWxlLWNoYW5nZS5odG1sOiBBZGRlZC4KKwog MjAyMC0wMi0wOSAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAog ICAgICAgICBbIE1hYyB3azIgXSBodHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvbG9n LWNyb3NzLXNpdGUtbG9hZC13aXRoLWxpbmstZGVjb3JhdGlvbi5odG1sIGlzIGEgZmxha3kgZmFp bHVyZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaWdub3JlLXNl bGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaWdub3JlLXNlbGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1z dHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk5N2E0NGZmZjlkZjVmMzgwMjUx YmZjNTA5YmViMzBhYjczZjc2YmUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0 aW5nL3NlbGVjdGlvbi9pZ25vcmUtc2VsZWN0aW9uLXJhbmdlLW9uLWlucHV0LXN0eWxlLWNoYW5n ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJl IGlzIG5vIGNyYXNoCisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rp b24vaWdub3JlLXNlbGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1zdHlsZS1jaGFuZ2UuaHRtbCBiL0xh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFuZ2Utb24taW5w dXQtc3R5bGUtY2hhbmdlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOGVjZGExMTk4MzU5YzUwZGFhMTMyZjNj OTcxYWQ1MzI0YzFmOTk3YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFuZ2Utb24taW5wdXQtc3R5bGUtY2hhbmdlLmh0 bWwKQEAgLTAsMCArMSwyNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxzY3JpcHQ+CisK K2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSAKKyAgICAg ICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKKyAgICBjb25zdCBpbnB1dCA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ2lucHV0Jyk7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChp bnB1dCk7CisKKyAgICBjb25zdCBpbnB1dHdpdGhhdXRvZm9jdXMgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCdpbnB1dCcpOworICAgIGlucHV0d2l0aGF1dG9mb2N1cy5zZXRBdHRyaWJ1dGUoJ2F1 dG9mb2N1cycsICcnKTsKKyAgICBpbnB1dHdpdGhhdXRvZm9jdXMuYWRkRXZlbnRMaXN0ZW5lcign Zm9jdXMnLCAoKSA9PiB7CisgICAgICAgIGlucHV0LnR5cGUgPSAnc3VibWl0JzsKKyAgICB9KTsK KyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlucHV0d2l0aGF1dG9mb2N1cyk7CisKKyAg ICBpbnB1dC5zZXRTZWxlY3Rpb25SYW5nZSgwLCAwKTsKKyAgICBnZXRTZWxlY3Rpb24oKS5jb250 YWluc05vZGUoZG9jdW1lbnQuYm9keSk7Cit9Cis8L3NjcmlwdD4KKzxib2R5IG9ubG9hZD1ydW5U ZXN0KCk+Cis8cD5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoIDwvcD4KKzwv Ym9keT4KKzwvaHRtbD4K 390950 2020-02-17 11:40:49 -0800 2020-02-17 13:13:08 -0800 Patch bug-207748-20200217114049.patch text/plain 4199 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE1YjczMWNiZWE5ZmUz ZGQ4MWM4NWQ0MzNkY2Q2ZDNiYzhlOGRmZi4uNTlkYTI3ODhiNjc5YmNlM2NjODEzZGYzN2VhNWY4 OTg5OGM5MTU2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTE0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IFB0ciBEZXJlZiBAIFdlYkNvcmU6Ok5vZGU6OlRyZWVzY29wZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NzQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWRkZWQgYSBjaGVjayBmb3IgaXNUZXh0RmllbGQg YWZ0ZXIgdXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzIGFzIHRoYXQgY291bGQg Y2F1c2UgbW9kaWZpY2F0aW9uIG9mIGlucHV0IGVsZW1lbnQgdHlwZS4KKworICAgICAgICBUZXN0 OiBlZGl0aW5nL3NlbGVjdGlvbi9pZ25vcmUtc2VsZWN0aW9uLXJhbmdlLW9uLWlucHV0LXN0eWxl LWNoYW5nZS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpzZXRT ZWxlY3Rpb25SYW5nZSk6CisKIDIwMjAtMDItMDkgIEJhc3VrZSBTdXp1a2kgIDxiYXN1a2Uuc3V6 dWtpQHNvbnkuY29tPgogCiAgICAgICAgIFJlcGxhY2UgcmVkdW5kYW50IGZ1bmN0aW9ucyB3aXRo IHZhcmlhZGljIHRlbXBsYXRlIGZ1bmN0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCA3MjMyMjhiNWNiNzdlNGMwZmYy ZGRlYmM4YzlhYWZlOGFhYjA3MTlhLi42NWU5ZjhiYjJkMjE5NzRiODlmMjFiYTFmYWRkNDMyNzUw MjQ3YjdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50LmNwcApAQCAtMjk4LDYgKzI5OCw5IEBAIHZvaWQgSFRNTFRleHRGb3JtQ29udHJv bEVsZW1lbnQ6OnNldFNlbGVjdGlvblJhbmdlKGludCBzdGFydCwgaW50IGVuZCwgVGV4dEZpZWxk CiAgICAgaWYgKCFoYXNGb2N1cyAmJiBpbm5lclRleHQpIHsKICAgICAgICAgLy8gRklYTUU6IFJl bW92aW5nIHRoaXMgc3luY2hyb25vdXMgbGF5b3V0IHJlcXVpcmVzIGZpeGluZyBzZXRTZWxlY3Rp b25XaXRob3V0VXBkYXRpbmdBcHBlYXJhbmNlIG5vdCBuZWVkaW5nIHVwLXRvLWRhdGUgc3R5bGUu CiAgICAgICAgIGRvY3VtZW50KCkudXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRz KCk7CisgICAgICAgIAorICAgICAgICBpZiAoIWlzVGV4dEZpZWxkKCkpCisgICAgICAgICAgICBy ZXR1cm47CiAKICAgICAgICAgLy8gRG91YmxlLWNoZWNrIHRoZSBzdGF0ZSBvZiBpbm5lclRleHRF bGVtZW50IGFmdGVyIHRoZSBsYXlvdXQuCiAgICAgICAgIGlubmVyVGV4dCA9IGlubmVyVGV4dEVs ZW1lbnQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCAzMGQxMjhkMTRlN2FiZDkwYzA1M2Y2MjU1OWI3NDM5YTliYjgyMWI5 Li5lMWRkMDA5YWY4NDExMzZmYWIwNWNmOWQzYTMwNmMwYjhlZjU5YmZiIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjAtMDItMTQgIFBpbmtpIEd5YW5jaGFuZGFuaSAgPHBneWFuY2hhbmRhbmlA YXBwbGUuY29tPgorCisgICAgICAgIE51bGwgUHRyIERlcmVmIEAgV2ViQ29yZTo6Tm9kZTo6VHJl ZXNjb3BlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDc3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBBZGRl ZCBhIHJlZ3Jlc3Npb24gdGVzdCBwcm92aWRlZCBieSBSeW9zdWtlIE5pd2EgdG8gdmVyaWZ5IHRo ZSBmaXguCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9pZ25vcmUtc2VsZWN0aW9uLXJh bmdlLW9uLWlucHV0LXN0eWxlLWNoYW5nZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGVkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFuZ2Utb24taW5wdXQtc3R5bGUt Y2hhbmdlLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAyLTA5ICBLYXRlIENoZW5leSAgPGthdGhlcmlu ZV9jaGVuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIFsgTWFjIHdrMiBdIGh0dHAvdGVzdHMvcmVz b3VyY2VMb2FkU3RhdGlzdGljcy9sb2ctY3Jvc3Mtc2l0ZS1sb2FkLXdpdGgtbGluay1kZWNvcmF0 aW9uLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL3NlbGVjdGlvbi9pZ25vcmUtc2VsZWN0aW9uLXJhbmdlLW9uLWlucHV0LXN0eWxlLWNoYW5n ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pZ25vcmUtc2Vs ZWN0aW9uLXJhbmdlLW9uLWlucHV0LXN0eWxlLWNoYW5nZS1leHBlY3RlZC50eHQKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uOTk3YTQ0ZmZmOWRmNWYzODAyNTFiZmM1MDliZWIzMGFiNzNmNzZiZQotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lnbm9yZS1zZWxlY3Rpb24tcmFu Z2Utb24taW5wdXQtc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1Ro aXMgdGVzdCBwYXNzZXMgaWYgdGhlcmUgaXMgbm8gY3Jhc2gKKworCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pZ25vcmUtc2VsZWN0aW9uLXJhbmdlLW9uLWlucHV0 LXN0eWxlLWNoYW5nZS5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaWdub3Jl LXNlbGVjdGlvbi1yYW5nZS1vbi1pbnB1dC1zdHlsZS1jaGFuZ2UuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44 ZWNkYTExOTgzNTljNTBkYWExMzJmM2M5NzFhZDUzMjRjMWY5OTdhCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaWdub3JlLXNlbGVjdGlvbi1yYW5nZS1v bi1pbnB1dC1zdHlsZS1jaGFuZ2UuaHRtbApAQCAtMCwwICsxLDI2IEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPHNjcmlwdD4KKworZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICBpZiAod2lu ZG93LnRlc3RSdW5uZXIpIAorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAg IGNvbnN0IGlucHV0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnaW5wdXQnKTsKKyAgICBkb2N1 bWVudC5ib2R5LmFwcGVuZENoaWxkKGlucHV0KTsKKworICAgIGNvbnN0IGlucHV0d2l0aGF1dG9m b2N1cyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lucHV0Jyk7CisgICAgaW5wdXR3aXRoYXV0 b2ZvY3VzLnNldEF0dHJpYnV0ZSgnYXV0b2ZvY3VzJywgJycpOworICAgIGlucHV0d2l0aGF1dG9m b2N1cy5hZGRFdmVudExpc3RlbmVyKCdmb2N1cycsICgpID0+IHsKKyAgICAgICAgaW5wdXQudHlw ZSA9ICdzdWJtaXQnOworICAgIH0pOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaW5w dXR3aXRoYXV0b2ZvY3VzKTsKKworICAgIGlucHV0LnNldFNlbGVjdGlvblJhbmdlKDAsIDApOwor ICAgIGdldFNlbGVjdGlvbigpLmNvbnRhaW5zTm9kZShkb2N1bWVudC5ib2R5KTsKK30KKzwvc2Ny aXB0PgorPGJvZHkgb25sb2FkPXJ1blRlc3QoKT4KKzxwPlRoaXMgdGVzdCBwYXNzZXMgaWYgdGhl cmUgaXMgbm8gY3Jhc2ggPC9wPgorPC9ib2R5PgorPC9odG1sPgo=