207729 2020-02-13 16:37:50 -0800 [PlayStation] Make special udis86 C file handling only happen for Visual Studio 2020-02-13 18:25:12 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 stephan.szabo webkit-unassigned annulen commit-queue don.olmstead ews-watchlist gyuyoung.kim keith_miller mark.lam msaboff ryuan.choi saam sergio tzagallo yoshiaki.jitsukawa oldest_to_newest 1618777 0 stephan.szabo 2020-02-13 16:37:50 -0800 For Visual Studio, we have a problem where the c++ standard flag gets set to C files (but Ninja does not add the flag). We now set the source file properties to set the language to CXX which makes Visual Studio building work, however breaks some ninja builds with the same error (now Ninja thinks it's C++ code so adds the flag, but then the compiler tries to compile it as C and fails). 1618781 1 390703 stephan.szabo 2020-02-13 16:41:16 -0800 Created attachment 390703 Patch 1618818 2 commit-queue 2020-02-13 18:24:32 -0800 The commit-queue encountered the following flaky tests while processing attachment 390703: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1618819 3 390703 commit-queue 2020-02-13 18:25:10 -0800 Comment on attachment 390703 Patch Clearing flags on attachment: 390703 Committed r256579: <https://trac.webkit.org/changeset/256579> 1618820 4 commit-queue 2020-02-13 18:25:12 -0800 All reviewed patches have been landed. Closing bug. 390703 2020-02-13 16:41:16 -0800 2020-02-13 18:25:10 -0800 Patch 207729.1.diff text/plain 1996 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDljMmY0Y2FiNGE1Li42NTc1YzAyMmUyNiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDItMTMgIFN0ZXBo YW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQHNvbnkuY29tPgorCisgICAgICAgIFtQbGF5U3RhdGlv bl0gTWFrZSBzcGVjaWFsIHVkaXM4NiBDIGZpbGUgaGFuZGxpbmcgb25seSBoYXBwZW4gZm9yIFZp c3VhbCBTdHVkaW8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwNzcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogUGxhdGZvcm1QbGF5U3RhdGlvbi5jbWFrZToKKwogMjAyMC0wMi0xMiAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIG9wdGlvbnMgZm9yIGRlYnVnZ2lu ZyBXQVNNIGNvZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1Q bGF5U3RhdGlvbi5jbWFrZSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybVBsYXlTdGF0 aW9uLmNtYWtlCmluZGV4IDY0MWIyMjllN2JkLi4zMGVkYzk2ZDdhNiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtUGxheVN0YXRpb24uY21ha2UKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtUGxheVN0YXRpb24uY21ha2UKQEAgLTM0LDE2ICszNCwx OCBAQCBsaXN0KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9TT1VSQ0VTCiAgICAgaW5zcGVjdG9yL3Jl bW90ZS9zb2NrZXQvcG9zaXgvUmVtb3RlSW5zcGVjdG9yU29ja2V0UE9TSVguY3BwCiApCiAKLSMg V2l0aCB0aGUgVmlzdWFsU3R1ZGlvIGdlbmVyYXRvciwgdGhlIGNvbXBpbGVyIGNvbXBsYWlucyBh Ym91dCAtc3RkPWMrKyogZm9yIEMgc291cmNlcy4KLXNldF9zb3VyY2VfZmlsZXNfcHJvcGVydGll cygKLSAgICBkaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Ni5jCi0gICAgZGlzYXNzZW1ibGVyL3Vk aXM4Ni91ZGlzODZfZGVjb2RlLmMKLSAgICBkaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9pdGFi X2hvbGRlci5jCi0gICAgZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLWF0dC5jCi0gICAg ZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLWludGVsLmMKLSAgICBkaXNhc3NlbWJsZXIv dWRpczg2L3VkaXM4Nl9zeW4uYwotICAgIFBST1BFUlRJRVMgTEFOR1VBR0UgQ1hYCi0pCitpZiAo JHtDTUFLRV9HRU5FUkFUT1J9IE1BVENIRVMgIlZpc3VhbCBTdHVkaW8iKQorICAgICMgV2l0aCB0 aGUgVmlzdWFsU3R1ZGlvIGdlbmVyYXRvciwgdGhlIGNvbXBpbGVyIGNvbXBsYWlucyBhYm91dCAt c3RkPWMrKyogZm9yIEMgc291cmNlcy4KKyAgICBzZXRfc291cmNlX2ZpbGVzX3Byb3BlcnRpZXMo CisgICAgICAgIGRpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2LmMKKyAgICAgICAgZGlzYXNzZW1i bGVyL3VkaXM4Ni91ZGlzODZfZGVjb2RlLmMKKyAgICAgICAgZGlzYXNzZW1ibGVyL3VkaXM4Ni91 ZGlzODZfaXRhYl9ob2xkZXIuYworICAgICAgICBkaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9z eW4tYXR0LmMKKyAgICAgICAgZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLWludGVsLmMK KyAgICAgICAgZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLmMKKyAgICAgICAgUFJPUEVS VElFUyBMQU5HVUFHRSBDWFgKKyAgICApCitlbmRpZiAoKQogCiAjIFRoaXMgb3ZlcnJpZGVzIHRo ZSBkZWZhdWx0IHg2NCB2YWx1ZSBvZiAxR0IgZm9yIHRoZSBtZW1vcnkgcG9vbCBzaXplCiBhZGRf ZGVmaW5pdGlvbnMoLURGSVhFRF9FWEVDVVRBQkxFX01FTU9SWV9QT09MX1NJWkVfSU5fTUI9NjQp Cg==