207691 2020-02-13 05:34:43 -0800 [GStreamer][EME] Fix warnings in LOG_DISABLED build 2020-02-14 10:05:10 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply calvaris cgarcia commit-queue ews-watchlist gustavo menard pnormand vjaquez oldest_to_newest 1618453 0 cturner 2020-02-13 05:34:43 -0800 [GStreamer][EME] Fix warnings in LOG_DISABLED build 1618455 1 390634 cturner 2020-02-13 05:36:31 -0800 Created attachment 390634 Patch Fix warnings with LOG_DISABLED. It would be nice if the LOG macro could arrange for VA_ARGS to be UNUSED_VARIABLES when LOG_DISABLED, but I do not know how to achieve this with preprocessor macros 1618512 2 390634 commit-queue 2020-02-13 08:54:50 -0800 Comment on attachment 390634 Patch Rejecting attachment 390634 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 390634, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13322090 1618967 3 390762 cturner 2020-02-14 07:15:37 -0800 Created attachment 390762 Patch 1619056 4 390762 commit-queue 2020-02-14 10:05:08 -0800 Comment on attachment 390762 Patch Clearing flags on attachment: 390762 Committed r256620: <https://trac.webkit.org/changeset/256620> 1619057 5 commit-queue 2020-02-14 10:05:10 -0800 All reviewed patches have been landed. Closing bug. 390634 2020-02-13 05:36:31 -0800 2020-02-14 07:15:33 -0800 Patch bug-207691-20200213133630.patch text/plain 3101 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZhMzAxMDY2ZGExODE2 NGY2ZTY4YzdlMDc1MTEyMWM1YWQ5YmVmNy4uYWIxYjIyYTcxMDBjZTU5MjgzNzNjYjc4ZTYwMWFh YWQ5Y2UwZjNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTEzICBDaGFy bGVzIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXVtF TUVdIEZpeCB3YXJuaW5ncyBpbiBMT0dfRElTQUJMRUQgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzY5MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL2VtZS9DRE1Qcm94eUNsZWFyS2V5LmNwcDogSXQgd291bGQKKyAgICAgICAgYmUgbmljZSBp ZiB0aGUgTE9HIG1hY3JvcyBjb3VsZCBhcnJhbmdlIGZvciB0aGUgVkFfQVJHUyB0byBiZQorICAg ICAgICBVTlVTRURfVkFSSUFCTEUncy4gTm90IHN1cmUgaWYgdGhhdCBpcyBwb3NzaWJsZSwgc28g YmUgdWdseSB3aXRoCisgICAgICAgIHRoZSBpZmRlZidzIGluc3RlYWQuCisgICAgICAgIChXZWJD b3JlOjpDRE1Qcm94eUNsZWFyS2V5OjpjZW5jU2V0Q291bnRlclZlY3Rvcik6CisgICAgICAgIChX ZWJDb3JlOjpDRE1Qcm94eUNsZWFyS2V5OjpjZW5jU2V0RGVjcnlwdGlvbktleSk6CisgICAgICAg IChXZWJDb3JlOjpDRE1Qcm94eUNsZWFyS2V5OjpjZW5jRGVjcnlwdEZ1bGxTYW1wbGUpOgorCiAy MDIwLTAyLTEyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q11bSUZDXSBEbyBub3QgY3JlYXRlIERpc3BsYXk6OkJveGVzIGZvciBhbm9ueW1vdXMgaW5saW5l IHRleHQgYm94ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9lbWUvQ0RNUHJveHlDbGVhcktleS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1lL0NETVByb3h5Q2xlYXJLZXkuY3BwCmluZGV4IDgw NDA0NTI4N2IzOTZhODUxMjgyN2ZjOGNiYTg0N2EyNDFhNTQ0MmMuLjZjNDI1MGRmMDUxYjBhZGFk NWI4OTIwOTE4NTViMzFkM2U4OTMwZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvQ0RNUHJveHlDbGVhcktleS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9DRE1Qcm94eUNsZWFy S2V5LmNwcApAQCAtODQsNyArODQsMTEgQEAgYm9vbCBDRE1Qcm94eUNsZWFyS2V5OjpjZW5jU2V0 Q291bnRlclZlY3Rvcihjb25zdCBjZW5jRGVjcnlwdENvbnRleHQmIGlucHV0KQogICAgICAgICBt ZW1jcHkoY3RyLCBpbnB1dC5pdiwgQ2xlYXJLZXk6OklWU2l6ZUluQnl0ZXMpOwogCiAgICAgaWYg KGdjcnlfZXJyb3JfdCBjaXBoZXJFcnJvciA9IGdjcnlfY2lwaGVyX3NldGN0cihtX2djcnlIYW5k bGUsIGN0ciwgQ2xlYXJLZXk6OklWU2l6ZUluQnl0ZXMpKSB7CisjaWYgIUxPR19ESVNBQkxFRAog ICAgICAgICBMT0coRU1FLCAiRU1FIC0gQ0RNUHJveHlDbGVhcktleSAtIEVSUk9SKGdjcnlfY2lw aGVyX3NldGN0cik6ICVzIiwgZ3BnX3N0cmVycm9yKGNpcGhlckVycm9yKSk7CisjZWxzZQorICAg ICAgICBVTlVTRURfVkFSSUFCTEUoY2lwaGVyRXJyb3IpOworI2VuZGlmCiAgICAgICAgIHJldHVy biBmYWxzZTsKICAgICB9CiAKQEAgLTEwMyw4ICsxMDcsMTIgQEAgYm9vbCBDRE1Qcm94eUNsZWFy S2V5OjpjZW5jU2V0RGVjcnlwdGlvbktleShjb25zdCBjZW5jRGVjcnlwdENvbnRleHQmIGluKQog ICAgIGlmICgha2V5RGF0YSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKGdjcnlf ZXJyb3JfdCBlcnJvciA9IGdjcnlfY2lwaGVyX3NldGtleShtX2djcnlIYW5kbGUsIGtleURhdGEt PmRhdGEoKSwga2V5RGF0YS0+c2l6ZSgpKSkgewotICAgICAgICBMT0coRU1FLCAiRU1FIC0gQ0RN UHJveHlDbGVhcktleSAtIEVSUk9SKGdjcnlfY2lwaGVyX3NldGtleSk6ICVzIiwgZ3BnX3N0cmVy cm9yKGVycm9yKSk7CisgICAgaWYgKGdjcnlfZXJyb3JfdCBjaXBoZXJFcnJvciA9IGdjcnlfY2lw aGVyX3NldGtleShtX2djcnlIYW5kbGUsIGtleURhdGEtPmRhdGEoKSwga2V5RGF0YS0+c2l6ZSgp KSkgeworI2lmICFMT0dfRElTQUJMRUQKKyAgICAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5 Q2xlYXJLZXkgLSBFUlJPUihnY3J5X2NpcGhlcl9zZXRrZXkpOiAlcyIsIGdwZ19zdHJlcnJvcihj aXBoZXJFcnJvcikpOworI2Vsc2UKKyAgICAgICAgVU5VU0VEX1ZBUklBQkxFKGNpcGhlckVycm9y KTsKKyNlbmRpZgogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCkBAIC0xMTksNyArMTI3 LDExIEBAIGJvb2wgQ0RNUHJveHlDbGVhcktleTo6Y2VuY0RlY3J5cHRGdWxsU2FtcGxlKGNlbmNE ZWNyeXB0Q29udGV4dCYgaW4pCiAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5Q2xlYXJLZXkg LSBmdWxsLXNhbXBsZSBkZWNyeXB0aW9uOiAlenUgZW5jcnlwdGVkIGJ5dGVzIiwgaW4uZW5jcnlw dGVkQnVmZmVyU2l6ZUluQnl0ZXMpOwogCiAgICAgaWYgKGdjcnlfZXJyb3JfdCBjaXBoZXJFcnJv ciA9IGdjcnlfY2lwaGVyX2RlY3J5cHQobV9nY3J5SGFuZGxlLCBpbi5lbmNyeXB0ZWRCdWZmZXIs IGluLmVuY3J5cHRlZEJ1ZmZlclNpemVJbkJ5dGVzLCAwLCAwKSkgeworI2lmICFMT0dfRElTQUJM RUQKICAgICAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5Q2xlYXJLZXkgLSBFUlJPUihnY3J5 X2NpcGhlcl9kZWNyeXB0KTogJXMiLCBncGdfc3RyZXJyb3IoY2lwaGVyRXJyb3IpKTsKKyNlbHNl CisgICAgICAgIFVOVVNFRF9WQVJJQUJMRShjaXBoZXJFcnJvcik7CisjZW5kaWYKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIH0KIAo= 390762 2020-02-14 07:15:37 -0800 2020-02-14 10:05:08 -0800 Patch bug-207691-20200214151535.patch text/plain 3095 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZhMzAxMDY2ZGExODE2 NGY2ZTY4YzdlMDc1MTEyMWM1YWQ5YmVmNy4uYjRmYTFkNmU2ZGQ1OTFlNzA2MTI0YTgyMTYwMzY2 ODVmNjkwYTIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTEzICBDaGFy bGVzIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXVtF TUVdIEZpeCB3YXJuaW5ncyBpbiBMT0dfRElTQUJMRUQgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzY5MQorCisgICAgICAgIFVucmV2aWV3 ZWQgYnVpbGQgZml4LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2Vt ZS9DRE1Qcm94eUNsZWFyS2V5LmNwcDogSXQgd291bGQKKyAgICAgICAgYmUgbmljZSBpZiB0aGUg TE9HIG1hY3JvcyBjb3VsZCBhcnJhbmdlIGZvciB0aGUgVkFfQVJHUyB0byBiZQorICAgICAgICBV TlVTRURfVkFSSUFCTEUncy4gTm90IHN1cmUgaWYgdGhhdCBpcyBwb3NzaWJsZSwgc28gYmUgdWds eSB3aXRoCisgICAgICAgIHRoZSBpZmRlZidzIGluc3RlYWQuCisgICAgICAgIChXZWJDb3JlOjpD RE1Qcm94eUNsZWFyS2V5OjpjZW5jU2V0Q291bnRlclZlY3Rvcik6CisgICAgICAgIChXZWJDb3Jl OjpDRE1Qcm94eUNsZWFyS2V5OjpjZW5jU2V0RGVjcnlwdGlvbktleSk6CisgICAgICAgIChXZWJD b3JlOjpDRE1Qcm94eUNsZWFyS2V5OjpjZW5jRGVjcnlwdEZ1bGxTYW1wbGUpOgorCiAyMDIwLTAy LTEyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZD XSBEbyBub3QgY3JlYXRlIERpc3BsYXk6OkJveGVzIGZvciBhbm9ueW1vdXMgaW5saW5lIHRleHQg Ym94ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9lbWUvQ0RNUHJveHlDbGVhcktleS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvZW1lL0NETVByb3h5Q2xlYXJLZXkuY3BwCmluZGV4IDgwNDA0NTI4 N2IzOTZhODUxMjgyN2ZjOGNiYTg0N2EyNDFhNTQ0MmMuLjZjNDI1MGRmMDUxYjBhZGFkNWI4OTIw OTE4NTViMzFkM2U4OTMwZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9lbWUvQ0RNUHJveHlDbGVhcktleS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9DRE1Qcm94eUNsZWFyS2V5LmNw cApAQCAtODQsNyArODQsMTEgQEAgYm9vbCBDRE1Qcm94eUNsZWFyS2V5OjpjZW5jU2V0Q291bnRl clZlY3Rvcihjb25zdCBjZW5jRGVjcnlwdENvbnRleHQmIGlucHV0KQogICAgICAgICBtZW1jcHko Y3RyLCBpbnB1dC5pdiwgQ2xlYXJLZXk6OklWU2l6ZUluQnl0ZXMpOwogCiAgICAgaWYgKGdjcnlf ZXJyb3JfdCBjaXBoZXJFcnJvciA9IGdjcnlfY2lwaGVyX3NldGN0cihtX2djcnlIYW5kbGUsIGN0 ciwgQ2xlYXJLZXk6OklWU2l6ZUluQnl0ZXMpKSB7CisjaWYgIUxPR19ESVNBQkxFRAogICAgICAg ICBMT0coRU1FLCAiRU1FIC0gQ0RNUHJveHlDbGVhcktleSAtIEVSUk9SKGdjcnlfY2lwaGVyX3Nl dGN0cik6ICVzIiwgZ3BnX3N0cmVycm9yKGNpcGhlckVycm9yKSk7CisjZWxzZQorICAgICAgICBV TlVTRURfVkFSSUFCTEUoY2lwaGVyRXJyb3IpOworI2VuZGlmCiAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICB9CiAKQEAgLTEwMyw4ICsxMDcsMTIgQEAgYm9vbCBDRE1Qcm94eUNsZWFyS2V5Ojpj ZW5jU2V0RGVjcnlwdGlvbktleShjb25zdCBjZW5jRGVjcnlwdENvbnRleHQmIGluKQogICAgIGlm ICgha2V5RGF0YSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKGdjcnlfZXJyb3Jf dCBlcnJvciA9IGdjcnlfY2lwaGVyX3NldGtleShtX2djcnlIYW5kbGUsIGtleURhdGEtPmRhdGEo KSwga2V5RGF0YS0+c2l6ZSgpKSkgewotICAgICAgICBMT0coRU1FLCAiRU1FIC0gQ0RNUHJveHlD bGVhcktleSAtIEVSUk9SKGdjcnlfY2lwaGVyX3NldGtleSk6ICVzIiwgZ3BnX3N0cmVycm9yKGVy cm9yKSk7CisgICAgaWYgKGdjcnlfZXJyb3JfdCBjaXBoZXJFcnJvciA9IGdjcnlfY2lwaGVyX3Nl dGtleShtX2djcnlIYW5kbGUsIGtleURhdGEtPmRhdGEoKSwga2V5RGF0YS0+c2l6ZSgpKSkgewor I2lmICFMT0dfRElTQUJMRUQKKyAgICAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5Q2xlYXJL ZXkgLSBFUlJPUihnY3J5X2NpcGhlcl9zZXRrZXkpOiAlcyIsIGdwZ19zdHJlcnJvcihjaXBoZXJF cnJvcikpOworI2Vsc2UKKyAgICAgICAgVU5VU0VEX1ZBUklBQkxFKGNpcGhlckVycm9yKTsKKyNl bmRpZgogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCkBAIC0xMTksNyArMTI3LDExIEBA IGJvb2wgQ0RNUHJveHlDbGVhcktleTo6Y2VuY0RlY3J5cHRGdWxsU2FtcGxlKGNlbmNEZWNyeXB0 Q29udGV4dCYgaW4pCiAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5Q2xlYXJLZXkgLSBmdWxs LXNhbXBsZSBkZWNyeXB0aW9uOiAlenUgZW5jcnlwdGVkIGJ5dGVzIiwgaW4uZW5jcnlwdGVkQnVm ZmVyU2l6ZUluQnl0ZXMpOwogCiAgICAgaWYgKGdjcnlfZXJyb3JfdCBjaXBoZXJFcnJvciA9IGdj cnlfY2lwaGVyX2RlY3J5cHQobV9nY3J5SGFuZGxlLCBpbi5lbmNyeXB0ZWRCdWZmZXIsIGluLmVu Y3J5cHRlZEJ1ZmZlclNpemVJbkJ5dGVzLCAwLCAwKSkgeworI2lmICFMT0dfRElTQUJMRUQKICAg ICAgICAgTE9HKEVNRSwgIkVNRSAtIENETVByb3h5Q2xlYXJLZXkgLSBFUlJPUihnY3J5X2NpcGhl cl9kZWNyeXB0KTogJXMiLCBncGdfc3RyZXJyb3IoY2lwaGVyRXJyb3IpKTsKKyNlbHNlCisgICAg ICAgIFVOVVNFRF9WQVJJQUJMRShjaXBoZXJFcnJvcik7CisjZW5kaWYKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0KIAo=