20769 2008-09-10 13:08:16 -0700 SVG refresh/redraw problems on scrolled or relative positioned canvas 2009-04-17 10:29:46 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED DUPLICATE 25268 GoogleBug, HasReduction, InRadar P2 Normal --- 23881 25224 25254 25268 1 aglenning webkit-unassigned dino hyatt oliver pam rwlbuis zimmermann oldest_to_newest 90789 0 aglenning 2008-09-10 13:08:16 -0700 SVG redraw is broken if the canvas is not positioned at the origin. More specifically, I suspect that the calculations to determine the region to refresh do not account for when the SVG canvas is offset. The SVG canvas can be offset either by using scrollbars or by putting it inside a relatively positioned DIV. In the attached test file, at normal "zoom" you can drag the red square around and everything looks fine. As the square is moved, the canvas is redrawn to remove the old square and draw the square in the new position. If you select "Zoom Out", moving the SVG canvas to a relative offset, and drag the square, strange things happen. Usually it appears that the drag has no effect. In reality the square is moved, it is just that the screen is not correctly repainted. You can check this by getting a canvas refresh to happen by again changing the zoom level and seeing the square in the updated position. In addition, the square has a 'move' cursor set on it. When you drag and drop the square, you'll see the move cursor appear where you dropped the square and not where the square is drawn. Similarly, if you select "Zoom In", while the scroll bars are at (0,0) the drag works. But if you scroll, the calculated repaint region is apparently off. As a really good example, try scrolling just a little bit, and you can see the repainted region is off by the amount of the scroll. 90790 1 23325 aglenning 2008-09-10 13:09:18 -0700 Created attachment 23325 Document illustrating reproducible test case 90796 2 ddkilzer 2008-09-10 13:35:28 -0700 <rdar://problem/6210760> 108372 3 eric 2009-02-04 16:58:52 -0800 Yeah, I think we have several dupes of this. The SVG renderers just don't know about scrolling. We need to fix clippedOverflowRectForRepaint to not suck. Hyatt plans to be in this code soon. If not, I'll dive in, cause this really should be fixed. 115626 4 eric 2009-03-27 15:31:35 -0700 Google has now launched "Sketchy" (the drawing feature for docs), which hits this bug hard. I've been meaning to fix it for a while, but now it actually effects a shipping product. :( 116865 5 29329 eric 2009-04-08 05:42:50 -0700 Created attachment 29329 further reduction 116876 6 eric 2009-04-08 07:02:14 -0700 I've looked at this some over the last two days (in between crash fixing for chromium 2.0) and it looks like the real fix here is to just kill absoluteTransform(). absoluteTransform() is wrong (or at least it's in conflict with how the rest of the rendering tree works) and doesn't always account for the full transform. SVG renders will need different "local" transform methods instead. (Which don't need to be virtual, and can just be helpers implemented on each renderer). All SVG renderers will need one which handles the parentToLocalTransform() (and probably should take passed in tx, ty values?) and containers will need a separate method to handle localToChildrenTransform() (for things like the viewport transform). parentToLocalTransform will be applied to the context before all paint calls, including filter painting, clipping, and outline/focus-rect painting. localToChildrenTransform() will be applied to the context before calling to children to have them paint. clippedOverflowRectForRepaint will need to be re-written to use overflowRect() and computeRectForRepaint() like the HTML renders use. I'll look at this again tomorrow. 117525 7 eric 2009-04-14 14:26:35 -0700 I wrote up a patch to fix this last week. I'm fixing some related bugs the patch uncovered, and I'll be posting it shortly. 117703 8 eric 2009-04-15 17:44:03 -0700 I wrote up a fix for this last week, but it depends on about 20 other local git commits I have in my tree. I'll be landing those over the next couple days, and then this bug (and bug 14015) will finally be fixed! (And the SVG rendering tree looks a lot saner as a result) 117815 9 zimmermann 2009-04-16 15:14:29 -0700 (In reply to comment #8) > I wrote up a fix for this last week, but it depends on about 20 other local git > commits I have in my tree. I'll be landing those over the next couple days, > and then this bug (and bug 14015) will finally be fixed! (And the SVG > rendering tree looks a lot saner as a result) Excellent Eric! I wish I would have some time to help... very promising work! I can at least help reviewing, if you cc me on the upcoming patches, hopefully we can finally find a sane way to integrate within the standard rendering tree :-) 117926 10 eric 2009-04-17 10:05:51 -0700 Ha! Never mind my patch to bug 25268 fixes this! YAY! 117938 11 eric 2009-04-17 10:29:46 -0700 I guess I'll just dupe this to bug 25268. There are still text scroll issues, covered by bug 16188, but I'll get to those later today. :) *** This bug has been marked as a duplicate of 25268 *** 23325 2008-09-10 13:09:18 -0700 2009-04-08 05:43:05 -0700 Document illustrating reproducible test case test.xml application/xhtml+xml 2417 aglenning PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgo8aGVhZD4KPHRpdGxl PlJlZHJhdyBUZXN0IENhc2U8L3RpdGxlPgo8c2NyaXB0PgogIHZhciBzY2FsZVggPSAzMDQ4MDAg LyA4MDA7CiAgdmFyIHNjYWxlWSA9IDIyODYwMCAvIDYwMDsKICB2YXIgb3V0ZXIsIGlubmVyLCBj YW52YXMsIHJlY3Q7CiAgdmFyIHgsIHksIHN0YXJ0WCwgc3RhcnRZOwoKICBmdW5jdGlvbiBpbml0 KCkgewogICAgaW5uZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaW5uZXInKTsKICAgIGNh bnZhcyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjYW52YXMnKTsKICAgIHJlY3QgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgncmVjdCcpOwoKICAgIHJlY3QuYWRkRXZlbnRMaXN0ZW5lcign bW91c2Vkb3duJywgbW91c2VEb3duLCBmYWxzZSk7CiAgfQoKICBmdW5jdGlvbiBtb3VzZURvd24o ZSkgewogICAgc3RhcnRYID0gZS5jbGllbnRYOwogICAgc3RhcnRZID0gZS5jbGllbnRZOwogICAg eCA9IE51bWJlcihyZWN0LmdldEF0dHJpYnV0ZSgneCcpKTsKICAgIHkgPSBOdW1iZXIocmVjdC5n ZXRBdHRyaWJ1dGUoJ3knKSk7CiAgICBjYW52YXMuYWRkRXZlbnRMaXN0ZW5lcignbW91c2V1cCcs IG1vdXNlVXAsIGZhbHNlKTsKICAgIGNhbnZhcy5hZGRFdmVudExpc3RlbmVyKCdtb3VzZW1vdmUn LCBtb3VzZU1vdmUsIGZhbHNlKTsKICB9CgogIGZ1bmN0aW9uIG1vdXNlTW92ZShlKSB7CiAgICB2 YXIgZHggPSAoZS5jbGllbnRYIC0gc3RhcnRYKSAqIHNjYWxlWDsKICAgIHZhciBkeSA9IChlLmNs aWVudFkgLSBzdGFydFkpICogc2NhbGVZOwogICAgcmVjdC5zZXRBdHRyaWJ1dGUoJ3gnLCB4ICsg ZHgpOwogICAgcmVjdC5zZXRBdHRyaWJ1dGUoJ3knLCB5ICsgZHkpCiAgfQoKICBmdW5jdGlvbiBt b3VzZVVwKGUpIHsKICAgIGNhbnZhcy5yZW1vdmVFdmVudExpc3RlbmVyKCdtb3VzZXVwJywgbW91 c2VVcCwgZmFsc2UpOwogICAgY2FudmFzLnJlbW92ZUV2ZW50TGlzdGVuZXIoJ21vdXNlbW92ZScs IG1vdXNlTW92ZSwgZmFsc2UpOwogIH0KCiAgZnVuY3Rpb24gem9vbShmYWN0b3IpIHsKICAgICAv LyBDaGFuZ2UgdGhlIHNpemUgb2YgdGhlIGlubmVyIERJVgogICAgdmFyIHdpZHRoID0gKDgwMCAq IGZhY3RvcikgKyAncHgnOwogICAgdmFyIGhlaWdodCA9ICg2MDAgKiBmYWN0b3IpICsgJ3B4JzsK ICAgIHZhciBzdHlsZSA9IGlubmVyLnN0eWxlOwogICAgc3R5bGUud2lkdGggPSB3aWR0aDsKICAg IHN0eWxlLmhlaWdodCA9IGhlaWdodDsKICAgIHN0eWxlLnRvcCA9IE1hdGgubWF4KDAsICgxIC0g ZmFjdG9yKSAqIDMwMCkgKyAncHgnOwogICAgc3R5bGUubGVmdCA9IE1hdGgubWF4KDAsICgxIC0g ZmFjdG9yKSAqIDQwMCkgKyAncHgnOwoKICAgIC8vIENoYW5nZSB0aGUgc2l6ZSBvZiB0aGUgU1ZH IGNhbnZhcwogICAgY2FudmFzLnNldEF0dHJpYnV0ZSgnd2lkdGgnLCB3aWR0aCk7CiAgICBjYW52 YXMuc2V0QXR0cmlidXRlKCdoZWlnaHQnLCBoZWlnaHQpOwoKICAgIC8vIENoYW5nZSB0aGUgc2Nh bGUKICAgIHNjYWxlWCA9IDMwNDgwMCAvIDgwMCAvIGZhY3RvcjsKICAgIHNjYWxlWSA9IDIyODYw MCAvIDYwMCAvIGZhY3RvcjsKICB9Cjwvc2NyaXB0Pgo8L2hlYWQ+Cgo8Ym9keSBvbmxvYWQ9Imlu aXQoKSI+CiAgPGRpdiBzdHlsZT0ib3ZlcmZsb3c6IGF1dG87IHdpZHRoOiA4MDBweDsgaGVpZ2h0 OiA2MDBweDsgYmFja2dyb3VuZC1jb2xvcjogIzk5OSI+CiAgICA8ZGl2IGlkPSJpbm5lciIgc3R5 bGU9InBvc2l0aW9uOiByZWxhdGl2ZTsgd2lkdGg6IDgwMHB4OyBoZWlnaHQ6IDYwMHB4OyBsZWZ0 OiAwcHg7IHRvcDogMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiAjQ0NDIj4KICAgICAgPHN2ZyB4bWxu cz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGlkPSJjYW52YXMiIHZlcnNpb249IjEuMSIg cHJlc2VydmVBc3BlY3RSYXRpbz0ibm9uZSIgdmlld0JveD0iMCAwIDMwNDgwMCAyMjg2MDAiIG92 ZXJmbG93PSJoaWRkZW4iIGhlaWdodD0iNjAwcHgiIHdpZHRoPSI4MDBweCI+CiAgICAgICAgPHJl Y3QgaWQ9InJlY3QiIHg9IjEwNDc3NSIgeT0iNjY2NzUiIHdpZHRoPSIzODEwMCIgaGVpZ2h0PSIz ODEwMCIgc3R5bGU9ImN1cnNvcjogbW92ZTsiIHN0cm9rZS13aWR0aD0iNzYyIiBzdHJva2Utb3Bh Y2l0eT0iMSIgc3Ryb2tlPSIjMDczNzYzIiBmaWxsLW9wYWNpdHk9IjEiIGZpbGw9IiNmZjAwMDAi PjwvcmVjdD4KICAgICAgPC9zdmc+CiAgICA8L2Rpdj4KICA8L2Rpdj4KICA8YnV0dG9uIG9uY2xp Y2s9Inpvb20oMC41KSI+Wm9vbSBPdXQ8L2J1dHRvbj4KICA8YnV0dG9uIG9uY2xpY2s9Inpvb20o MikiPlpvb20gSW48L2J1dHRvbj4KICA8YnV0dG9uIG9uY2xpY2s9Inpvb20oMSkiPlJlc2V0PC9i dXR0b24+CjwvYm9keT4KPC9odG1sPgo= 29329 2009-04-08 05:42:50 -0700 2009-04-08 05:42:50 -0700 further reduction scale.xhtml application/xhtml+xml 1501 eric PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgo8Ym9keT4KICA8ZGl2 IHN0eWxlPSJvdmVyZmxvdzogYXV0bzsgd2lkdGg6IDgwMHB4OyBoZWlnaHQ6IDYwMHB4OyBiYWNr Z3JvdW5kLWNvbG9yOiAjOTk5Ij4KICAgICAgb3V0ZXIgZGl2CiAgICA8ZGl2IGlkPSJpbm5lciIg c3R5bGU9InBvc2l0aW9uOiByZWxhdGl2ZTsgd2lkdGg6IDQwMHB4OyBoZWlnaHQ6IDMwMHB4OyBs ZWZ0OiA2MHB4OyB0b3A6IDgwcHg7IGJhY2tncm91bmQtY29sb3I6ICNDQ0MiPgogICAgICAgIGlu bmVyIGRpdgogICAgICA8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgaWQ9 ImNhbnZhcyIgIGhlaWdodD0iMzAwcHgiIHdpZHRoPSI0MDBweCIgcHJlc2VydmVBc3BlY3RSYXRp bz0ibm9uZSIgdmlld0JveD0iMCAwIDMwMCAyMDAiIG92ZXJmbG93PSJoaWRkZW4iPgogICAgICAg IDxyZWN0IGlkPSJyZWN0IiB4PSIxMCIgeT0iMTAiIHdpZHRoPSIxMDBweCIgaGVpZ2h0PSIxMDBw eCIgc3Ryb2tlLXdpZHRoPSI3IiBzdHJva2U9IiMwNzM3NjMiIGZpbGw9InJlZCIgLz4KICAgICAg PC9zdmc+CiAgICA8L2Rpdj4KICA8L2Rpdj4KICA8c2NyaXB0PgogICAgdmFyIGlubmVyID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lubmVyJyk7CiAgICB2YXIgY2FudmFzID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ2NhbnZhcycpOwogICAgdmFyIHJlY3QgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgncmVjdCcpOwogICAgZnVuY3Rpb24gdmFsdWVGb3JTdGVwKHN0ZXApCiAgICB7CiAg ICAgICAgdmFyIGxvY2FsU3RlcCA9IHN0ZXAgJSA3OwogICAgICAgIHN3aXRjaCAobG9jYWxTdGVw KSB7CiAgICAgICAgICAgIGNhc2UgMDogcmV0dXJuIDE7CiAgICAgICAgICAgIGNhc2UgMTogcmV0 dXJuIDA7CiAgICAgICAgICAgIGNhc2UgMjogcmV0dXJuIDI7CiAgICAgICAgICAgIGNhc2UgMzog cmV0dXJuIDA7CiAgICAgICAgICAgIGNhc2UgNDogcmV0dXJuIDA7CiAgICAgICAgICAgIGNhc2Ug NTogcmV0dXJuIC0xOwogICAgICAgICAgICBjYXNlIDY6IHJldHVybiAtMjsKICAgICAgICB9CiAg ICAgICAgcmV0dXJuIDIwMDA7CiAgICB9CgogICAgdmFyIHN0ZXAgPSAwOwogICAgZnVuY3Rpb24g amlnZ2xlKCkgewogICAgICAgIHZhciB4ID0gTnVtYmVyKHJlY3QuZ2V0QXR0cmlidXRlKCd4Jykp OwogICAgICAgIHZhciB5ID0gTnVtYmVyKHJlY3QuZ2V0QXR0cmlidXRlKCd5JykpOwogICAgICAg IHZhciBkeCA9IHZhbHVlRm9yU3RlcChzdGVwKyspOwogICAgICAgIHZhciBkeSA9IHZhbHVlRm9y U3RlcChzdGVwKyspOwogICAgICAgIHN0ZXArKzsKICAgICAgICByZWN0LnNldEF0dHJpYnV0ZSgn eCcsIHggKyBkeCk7CiAgICAgICAgcmVjdC5zZXRBdHRyaWJ1dGUoJ3knLCB5ICsgZHkpOwogICAg ICAgIHNldFRpbWVvdXQoamlnZ2xlLCAxMCk7CiAgICB9CiAgICBqaWdnbGUoKTsKICA8L3Njcmlw dD4KPC9ib2R5Pgo8L2h0bWw+Cg==