207663 2020-02-12 14:04:09 -0800 results.webkit.org: Remove debug JS logging 2020-02-12 14:53:23 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue slewis webkit-bug-importer zhifei_fang oldest_to_newest 1618213 0 jbedard 2020-02-12 14:04:09 -0800 I noticed that we had some debug JavaScript logging left in from previous commits, we should remove it. 1618216 1 390558 jbedard 2020-02-12 14:05:51 -0800 Created attachment 390558 Patch 1618238 2 390558 commit-queue 2020-02-12 14:52:56 -0800 Comment on attachment 390558 Patch Clearing flags on attachment: 390558 Committed r256483: <https://trac.webkit.org/changeset/256483> 1618239 3 commit-queue 2020-02-12 14:52:57 -0800 All reviewed patches have been landed. Closing bug. 1618240 4 webkit-bug-importer 2020-02-12 14:53:23 -0800 <rdar://problem/59402518> 390558 2020-02-12 14:05:51 -0800 2020-02-12 14:52:56 -0800 Patch bug-207663-20200212140550.patch text/plain 3334 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjQ3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDIwLTAyLTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IFJlbW92ZSBkZWJ1ZyBKUyBsb2dnaW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc2NjMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlc3Vs dHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2ludmVzdGlnYXRlLmpzOgorICAgICAg ICAoZWxhcHNlZCk6CisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0 aWMvanMvdG9vbHRpcC5qczoKKyAgICAgICAgKF9Ub29sVGlwLnByb3RvdHlwZS50b1N0cmluZyk6 CisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9q cy9SZWYuanM6CisgICAgICAgIChwcm90b3R5cGUuYWRkV2l0aERlbGF5KToKKyAgICAgICAgKiBy ZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9hcmNoaXZlX2xpc3QuaHRtbDoK KwogMjAyMC0wMi0xMiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWlkQGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMjU1MTU4KTogaHR0cC90ZXN0cy9mcmFtZS10aHJvdHRsaW5nL3Jh Zi10aHJvdHRsZS1pbi1jcm9zcy1vcmlnaW4tc3ViZnJhbWUuaHRtbCBpcyBhIGZsYWt5IGZhaWx1 cmUKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2lu dmVzdGlnYXRlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5 L3ZpZXcvc3RhdGljL2pzL2ludmVzdGlnYXRlLmpzCShyZXZpc2lvbiAyNTY0NzUpCisrKyBUb29s cy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9pbnZlc3RpZ2F0ZS5qcwko d29ya2luZyBjb3B5KQpAQCAtNjMsNyArNjMsNiBAQCBmdW5jdGlvbiBlbGFwc2VkKGRhdGEpCiAg ICAgICAgIHJldHVybiBgVG9vayAke2RhdGEudGltZSAvIDEwMDB9IHNlY29uZHNgOwogICAgIGlm IChkYXRhLnN0YXRzICYmIGRhdGEuc3RhdHMuc3RhcnRfdGltZSAmJiBkYXRhLnN0YXRzLmVuZF90 aW1lKSB7CiAgICAgICAgIGNvbnN0IHRpbWUgPSBuZXcgRGF0ZSgoZGF0YS5zdGF0cy5lbmRfdGlt ZSAtIGRhdGEuc3RhdHMuc3RhcnRfdGltZSkgKiAxMDAwKTsKLSAgICAgICAgY29uc29sZS5sb2co ZGF0YS5zdGF0cy5lbmRfdGltZSAtIGRhdGEuc3RhdHMuc3RhcnRfdGltZSk7CiAgICAgICAgIGxl dCByZXN1bHQgPSAnU3VpdGUgdG9vayAnOwogICAgICAgICBpZiAodGltZS5nZXRNaW51dGVzKCkp CiAgICAgICAgICAgICByZXN1bHQgKz0gYCR7dGltZS5nZXRNaW51dGVzKCl9OmA7CkluZGV4OiBU b29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy90b29sdGlwLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pz L3Rvb2x0aXAuanMJKHJldmlzaW9uIDI1NjQ3NSkKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3Vs dHNkYnB5L3ZpZXcvc3RhdGljL2pzL3Rvb2x0aXAuanMJKHdvcmtpbmcgY29weSkKQEAgLTE5NSw3 ICsxOTUsNiBAQCBjbGFzcyBfVG9vbFRpcCB7CiAgICAgICAgICAgICAgICAgaGVpZ2h0OiBNYXRo Lm1pbih3aW5kb3dIZWlnaHQsIHJlY3QuaGVpZ2h0KSwKICAgICAgICAgICAgIH07CiAgICAgICAg IH0KLSAgICAgICAgY29uc29sZS5sb2codmlld3BvcnQpOwogICAgICAgICB0aGlzLnJlZi5zZXRT dGF0ZSh7Y29udGVudDogY29udGVudCwgcG9pbnRzOiBwb2ludHMsIHZpZXdwb3J0OiB2aWV3cG9y dH0pOwogICAgIH0KICAgICBzZXRCeUVsZW1lbnQoY29udGVudCwgZWxlbWVudCwgb3B0aW9ucywg dmlld3BvcnQgPSBudWxsKSB7CkluZGV4OiBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92 aWV3L3N0YXRpYy9saWJyYXJ5L2pzL1JlZi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL1JlZi5qcwkocmV2aXNpb24g MjU2NDc1KQorKysgVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGli cmFyeS9qcy9SZWYuanMJKHdvcmtpbmcgY29weSkKQEAgLTEzNCw3ICsxMzQsNiBAQCBjbGFzcyBF dmVudFN0cmVhbSB7CiAgICAgfQogICAgIGFkZFdpdGhEZWxheShkZWxheSwgLi4uYXJncykgewog ICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHsKLSAgICAgICAgICAgIGNvbnNvbGUubG9nKGFyZ3Mp OwogICAgICAgICAgICAgdGhpcy5hZGQoLi4uYXJncyk7CiAgICAgICAgIH0sIGRlbGF5KTsKICAg ICAgICAgcmV0dXJuIHRoaXM7CkluZGV4OiBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92 aWV3L3RlbXBsYXRlcy9hcmNoaXZlX2xpc3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9yZXN1 bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9hcmNoaXZlX2xpc3QuaHRtbAkocmV2 aXNpb24gMjU2NDc1KQorKysgVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy90ZW1w bGF0ZXMvYXJjaGl2ZV9saXN0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTkxLDkgKzkxLDYgQEAg ZnVuY3Rpb24gbGlzdENvbnRlbnRGb3JQYXRocyhyb290LCBwYXRocwogfQogCiBjb25zdCBwYXRo cyA9IFt7JSBmb3IgdmFsIGluIHZhbHVlcyAlfSd7eyB2YWwgfX0nLCB7JSBlbmRmb3IgJX1dOwot cGF0aHMuZm9yRWFjaChwdGggPT4gewotICAgIGNvbnNvbGUubG9nKHB0aCk7Ci19KQogRE9NLmlu amVjdChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncGF0aHMnKSwgbGlzdENvbnRlbnRGb3JQYXRo cygnJywgcGF0aHMpKTsKIAogPC9zY3JpcHQ+Cg==