207615 2020-02-11 22:07:30 -0800 macCatalyst: Unable to grab scrollbar on editable text field 2020-02-12 07:39:22 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue simon.fraser thorton webkit-bug-importer oldest_to_newest 1617870 0 wenson_hsieh 2020-02-11 22:07:30 -0800 <rdar://problem/59212993> 1617872 1 390493 wenson_hsieh 2020-02-11 22:14:22 -0800 Created attachment 390493 Patch 1617875 2 390493 thorton 2020-02-11 22:17:17 -0800 Comment on attachment 390493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review > Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184 > + if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) { NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass? Or at least flip the conditions? 1617876 3 390493 wenson_hsieh 2020-02-11 22:22:49 -0800 Comment on attachment 390493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review >> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184 >> + if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) { > > NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass? > > Or at least flip the conditions? Good catch! I'll cache the class in a static helper (using dispatch_once) and pass it into -isKindOfClass. 1617878 4 390494 wenson_hsieh 2020-02-11 22:30:10 -0800 Created attachment 390494 Patch 1617989 5 commit-queue 2020-02-12 07:38:42 -0800 The commit-queue encountered the following flaky tests while processing attachment 390494: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1617990 6 390494 commit-queue 2020-02-12 07:39:20 -0800 Comment on attachment 390494 Patch Clearing flags on attachment: 390494 Committed r256433: <https://trac.webkit.org/changeset/256433> 1617991 7 commit-queue 2020-02-12 07:39:22 -0800 All reviewed patches have been landed. Closing bug. 390493 2020-02-11 22:14:22 -0800 2020-02-11 22:30:09 -0800 Patch bug-207615-20200211221422.patch text/plain 2821 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY2MmJiOWJiNWVjOWQ1Y2Nl Mjc3NTUxMTcxMjNmNDI5Zjg3M2RhZmUuLjY2ZmJmNmM2YzA2ZDc4ZDIzOWY1MmEzODhlOTI1Yjhm YmRkOGFmNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjAtMDItMTEgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgbWFjQ2F0YWx5c3Q6IFVu YWJsZSB0byBncmFiIHNjcm9sbGJhciBvbiBlZGl0YWJsZSB0ZXh0IGZpZWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc2MTUKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU5MjEyOTkzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluIG1hY0NhdGFseXN0LCBob3ZlcmluZyBvdmVyIHRoZSBzY3JvbGxi YXIgKGFuIGluc3RhbmNlIG9mIHRoZSBpbnRlcm5hbCBVSUtpdCBjbGFzcworICAgICAgICBgX1VJ U2Nyb2xsVmlld1Njcm9sbEluZGljYXRvcmApIGlzIHJlcXVpcmVkIGluIG9yZGVyIGZvciBhIGNs aWNrIGFuZCBkcmFnIHdpdGggdGhlIG1vdXNlIHRvIGFjdHVhbGx5IG1vdmUgdGhlCisgICAgICAg IHNjcm9sbGJhci4gVGhpcyBpcyBiZWNhdXNlIFVJS2l0IGRlcGVuZHMgb24gdGhlIGN1cnNvciBp bnRlcmFjdGlvbiBhZGRlZCB0byB0aGlzIHZpZXcgdG8gcmVjb2duaXplIGFuZCBjYWxsIGl0cwor ICAgICAgICBkZWxlZ2F0ZSBtZXRob2RzLgorCisgICAgICAgIEhvd2V2ZXIsIHdlIG92ZXJyaWRl IGhpdC10ZXN0aW5nIGluIFdlYktpdCB0byBza2lwIG92ZXIgYWxsIGNoaWxkcmVuIG9mIHNjcm9s bCB2aWV3cywgYW5kIGluc3RlYWQgZm9yY2UgaGl0LQorICAgICAgICB0ZXN0aW5nIHRvIGZpbmQg dGhlIHNjcm9sbCB2aWV3IGluc3RlYWQuIFRoaXMgbWVhbnMgdGhhdCBVSUtpdCBjYW4gbmV2ZXIg aGl0LXRlc3QgdG8gdGhlIHNjcm9sbCBpbmRpY2F0b3Igdmlld3MKKyAgICAgICAgZW1iZWRkZWQg ZGlyZWN0bHkgYmVuZWF0aCBlYWNoIFdLQ2hpbGRTY3JvbGxWaWV3LCBzbyB0aGUgY3Vyc29yIGlu dGVyYWN0aW9ucyBkZXNjcmliZWQgZWFybGllciB3aWxsIG5vdAorICAgICAgICByZWNvZ25pemUu IFRvIHdvcmsgYXJvdW5kIHRoaXMsIHNwZWNpYWwgY2FzZSB0aGVzZSBzY3JvbGwgaW5kaWNhdG9y IHZpZXdzLCBzdWNoIHRoYXQgd2Ugd2lsbCBhbGxvdworICAgICAgICAtaGl0VGVzdDp3aXRoRXZl bnQ6IHRvIGZpbmQgdGhlc2Ugdmlld3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvUmVtb3RlTGF5 ZXJUcmVlL2lvcy9SZW1vdGVMYXllclRyZWVWaWV3cy5tbToKKyAgICAgICAgKC1bVUlWaWV3IF93 ZWJfZmluZERlc2NlbmRhbnRWaWV3QXRQb2ludDp3aXRoRXZlbnQ6XSk6CisKIDIwMjAtMDItMTEg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViUGFn ZTo6Z2V0Rm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbiBzaG91bGQgYmUgcm9idXN0IHdoZW4gdGhl IGZvY3VzZWQgZWxlbWVudCBjaGFuZ2VzIGR1cmluZyBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9pb3MvUmVtb3RlTGF5ZXJUcmVlVmll d3MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUvaW9zL1JlbW90 ZUxheWVyVHJlZVZpZXdzLm1tCmluZGV4IDc2N2UwY2ZlOTFhMzliOTRlMmM0N2QzNDlhYzhhYTRi ZDc4NDJmODUuLjg1N2Q5NDUyN2RkYTUyMGVhMjgxZDdlNWQ4MDMwNWI4ZTVmNjJkZmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9pb3MvUmVtb3Rl TGF5ZXJUcmVlVmlld3MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVtb3RlTGF5 ZXJUcmVlL2lvcy9SZW1vdGVMYXllclRyZWVWaWV3cy5tbQpAQCAtMTgxLDYgKzE4MSwxMyBAQCAt IChVSVZpZXcgKilfd2ViX2ZpbmREZXNjZW5kYW50Vmlld0F0UG9pbnQ6KENHUG9pbnQpcG9pbnQg d2l0aEV2ZW50OihVSUV2ZW50ICopZQogICAgICAgICAgICAgfQogICAgICAgICB9CiAKKyAgICAg ICAgaWYgKFtOU1N0cmluZ0Zyb21DbGFzcyh2aWV3LmNsYXNzKSBpc0VxdWFsVG9TdHJpbmc6QCJf VUlTY3JvbGxWaWV3U2Nyb2xsSW5kaWNhdG9yIl0gJiYgW3ZpZXcuc3VwZXJ2aWV3IGlzS2luZE9m Q2xhc3M6V0tDaGlsZFNjcm9sbFZpZXcuY2xhc3NdKSB7CisgICAgICAgICAgICBpZiAoV2ViS2l0 Ojppc1Njcm9sbGVkQnkoKFdLQ2hpbGRTY3JvbGxWaWV3ICopdmlldy5zdXBlcnZpZXcsIHZpZXdz QXRQb2ludC5sYXN0KCkpKSB7CisgICAgICAgICAgICAgICAgTE9HX1dJVEhfU1RSRUFNKFVJSGl0 VGVzdGluZywgc3RyZWFtIDw8ICIgIiA8PCAodm9pZCopdmlldyA8PCAiIGlzIHRoZSBzY3JvbGwg aW5kaWNhdG9yIG9mIGNoaWxkIHNjcm9sbCB2aWV3LCB3aGljaCBpcyBzY3JvbGxlZCBieSAiIDw8 ICh2b2lkKil2aWV3c0F0UG9pbnQubGFzdCgpKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gdmll dzsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCiAgICAgICAgIExPR19XSVRIX1NUUkVBTShV SUhpdFRlc3RpbmcsIHN0cmVhbSA8PCAiIGlnbm9yaW5nICIgPDwgW3ZpZXcgY2xhc3NdIDw8ICIg IiA8PCAodm9pZCopdmlldyk7CiAgICAgfQogCg== 390494 2020-02-11 22:30:10 -0800 2020-02-12 07:39:20 -0800 Patch bug-207615-20200211223009.patch text/plain 3308 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY2MmJiOWJiNWVjOWQ1Y2Nl Mjc3NTUxMTcxMjNmNDI5Zjg3M2RhZmUuLjE4ZTczYTBiNjczYjRjMTBmYmMxMDU2N2JjZjUxMzQ3 MmM5YmQ0ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjAtMDItMTEgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgbWFjQ2F0YWx5c3Q6IFVu YWJsZSB0byBncmFiIHNjcm9sbGJhciBvbiBlZGl0YWJsZSB0ZXh0IGZpZWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc2MTUKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU5MjEyOTkzPgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24u CisKKyAgICAgICAgSW4gbWFjQ2F0YWx5c3QsIGhvdmVyaW5nIG92ZXIgdGhlIHNjcm9sbGJhciAo YW4gaW5zdGFuY2Ugb2YgdGhlIGludGVybmFsIFVJS2l0IGNsYXNzCisgICAgICAgIGBfVUlTY3Jv bGxWaWV3U2Nyb2xsSW5kaWNhdG9yYCkgaXMgcmVxdWlyZWQgaW4gb3JkZXIgZm9yIGEgY2xpY2sg YW5kIGRyYWcgd2l0aCB0aGUgbW91c2UgdG8gYWN0dWFsbHkgbW92ZSB0aGUKKyAgICAgICAgc2Ny b2xsYmFyLiBUaGlzIGlzIGJlY2F1c2UgVUlLaXQgZGVwZW5kcyBvbiB0aGUgY3Vyc29yIGludGVy YWN0aW9uIGFkZGVkIHRvIHRoaXMgdmlldyB0byByZWNvZ25pemUgYW5kIGNhbGwgaXRzCisgICAg ICAgIGRlbGVnYXRlIG1ldGhvZHMuCisKKyAgICAgICAgSG93ZXZlciwgd2Ugb3ZlcnJpZGUgaGl0 LXRlc3RpbmcgaW4gV2ViS2l0IHRvIHNraXAgb3ZlciBhbGwgY2hpbGRyZW4gb2Ygc2Nyb2xsIHZp ZXdzLCBhbmQgaW5zdGVhZCBmb3JjZSBoaXQtCisgICAgICAgIHRlc3RpbmcgdG8gZmluZCB0aGUg c2Nyb2xsIHZpZXcgaW5zdGVhZC4gVGhpcyBtZWFucyB0aGF0IFVJS2l0IGNhbiBuZXZlciBoaXQt dGVzdCB0byB0aGUgc2Nyb2xsIGluZGljYXRvciB2aWV3cworICAgICAgICBlbWJlZGRlZCBkaXJl Y3RseSBiZW5lYXRoIGVhY2ggV0tDaGlsZFNjcm9sbFZpZXcsIHNvIHRoZSBjdXJzb3IgaW50ZXJh Y3Rpb25zIGRlc2NyaWJlZCBlYXJsaWVyIHdpbGwgbm90CisgICAgICAgIHJlY29nbml6ZS4gVG8g d29yayBhcm91bmQgdGhpcywgc3BlY2lhbCBjYXNlIHRoZXNlIHNjcm9sbCBpbmRpY2F0b3Igdmll d3MsIHN1Y2ggdGhhdCB3ZSB3aWxsIGFsbG93CisgICAgICAgIC1oaXRUZXN0OndpdGhFdmVudDog dG8gZmluZCB0aGVzZSB2aWV3cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9SZW1vdGVMYXllclRy ZWUvaW9zL1JlbW90ZUxheWVyVHJlZVZpZXdzLm1tOgorICAgICAgICAoV2ViS2l0OjpzY3JvbGxW aWV3U2Nyb2xsSW5kaWNhdG9yQ2xhc3MpOgorICAgICAgICAoLVtVSVZpZXcgX3dlYl9maW5kRGVz Y2VuZGFudFZpZXdBdFBvaW50OndpdGhFdmVudDpdKToKKwogMjAyMC0wMi0xMSAgV2Vuc29uIEhz aWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJQYWdlOjpnZXRGb2N1 c2VkRWxlbWVudEluZm9ybWF0aW9uIHNob3VsZCBiZSByb2J1c3Qgd2hlbiB0aGUgZm9jdXNlZCBl bGVtZW50IGNoYW5nZXMgZHVyaW5nIGxheW91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL2lvcy9SZW1vdGVMYXllclRyZWVWaWV3cy5tbSBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9pb3MvUmVtb3RlTGF5ZXJUcmVl Vmlld3MubW0KaW5kZXggNzY3ZTBjZmU5MWEzOWI5NGUyYzQ3ZDM0OWFjOGFhNGJkNzg0MmY4NS4u N2IyODllYjk5MDU2YTFiMjY0YmNmNDUzZTIyN2U5ZmQwNjlmNzllOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL2lvcy9SZW1vdGVMYXllclRyZWVW aWV3cy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUvaW9z L1JlbW90ZUxheWVyVHJlZVZpZXdzLm1tCkBAIC0xNTIsNiArMTUyLDE2IEBAIFVJU2Nyb2xsVmll dyAqZmluZEFjdGluZ1Njcm9sbFBhcmVudChVSVNjcm9sbFZpZXcgKnNjcm9sbFZpZXcsIGNvbnN0 IFJlbW90ZUxheWVyCiAgICAgcmV0dXJuIG5pbDsKIH0KIAorc3RhdGljIENsYXNzIHNjcm9sbFZp ZXdTY3JvbGxJbmRpY2F0b3JDbGFzcygpCit7CisgICAgc3RhdGljIGRpc3BhdGNoX29uY2VfdCBv bmNlVG9rZW47CisgICAgc3RhdGljIENsYXNzIHNjcm9sbEluZGljYXRvckNsYXNzOworICAgIGRp c3BhdGNoX29uY2UoJm9uY2VUb2tlbiwgXnsKKyAgICAgICAgc2Nyb2xsSW5kaWNhdG9yQ2xhc3Mg PSBOU0NsYXNzRnJvbVN0cmluZyhAIl9VSVNjcm9sbFZpZXdTY3JvbGxJbmRpY2F0b3IiKTsKKyAg ICB9KTsKKyAgICByZXR1cm4gc2Nyb2xsSW5kaWNhdG9yQ2xhc3M7Cit9CisKIH0KIAogQGludGVy ZmFjZSBVSVZpZXcgKFdLSGl0VGVzdGluZykKQEAgLTE4MSw2ICsxOTEsMTMgQEAgLSAoVUlWaWV3 ICopX3dlYl9maW5kRGVzY2VuZGFudFZpZXdBdFBvaW50OihDR1BvaW50KXBvaW50IHdpdGhFdmVu dDooVUlFdmVudCAqKWUKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCisgICAgICAgIGlmIChb dmlldyBpc0tpbmRPZkNsYXNzOldlYktpdDo6c2Nyb2xsVmlld1Njcm9sbEluZGljYXRvckNsYXNz KCldICYmIFt2aWV3LnN1cGVydmlldyBpc0tpbmRPZkNsYXNzOldLQ2hpbGRTY3JvbGxWaWV3LmNs YXNzXSkgeworICAgICAgICAgICAgaWYgKFdlYktpdDo6aXNTY3JvbGxlZEJ5KChXS0NoaWxkU2Ny b2xsVmlldyAqKXZpZXcuc3VwZXJ2aWV3LCB2aWV3c0F0UG9pbnQubGFzdCgpKSkgeworICAgICAg ICAgICAgICAgIExPR19XSVRIX1NUUkVBTShVSUhpdFRlc3RpbmcsIHN0cmVhbSA8PCAiICIgPDwg KHZvaWQqKXZpZXcgPDwgIiBpcyB0aGUgc2Nyb2xsIGluZGljYXRvciBvZiBjaGlsZCBzY3JvbGwg dmlldywgd2hpY2ggaXMgc2Nyb2xsZWQgYnkgIiA8PCAodm9pZCopdmlld3NBdFBvaW50Lmxhc3Qo KSk7CisgICAgICAgICAgICAgICAgcmV0dXJuIHZpZXc7CisgICAgICAgICAgICB9CisgICAgICAg IH0KKwogICAgICAgICBMT0dfV0lUSF9TVFJFQU0oVUlIaXRUZXN0aW5nLCBzdHJlYW0gPDwgIiBp Z25vcmluZyAiIDw8IFt2aWV3IGNsYXNzXSA8PCAiICIgPDwgKHZvaWQqKXZpZXcpOwogICAgIH0K IAo=