207589 2020-02-11 15:09:16 -0800 results.webkit.org: Cache archive content 2020-02-12 10:49:12 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue webkit-bug-importer zhifei_fang oldest_to_newest 1617677 0 jbedard 2020-02-11 15:09:16 -0800 It occurred to me that we can (and should) ask the client to cache archive content since retrieving and unpacking that content is relatively expensive. 1617688 1 390446 jbedard 2020-02-11 15:26:26 -0800 Created attachment 390446 Patch 1617689 2 jbedard 2020-02-11 15:27:25 -0800 This is a pretty tremendous perf win, with it, I feel comfortable linking to and exposing archive details from the existing UI. 1617738 3 390446 zhifei_fang 2020-02-11 16:09:17 -0800 Comment on attachment 390446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390446&action=review > Tools/resultsdbpy/resultsdbpy/flask_support/util.py:127 > + response.headers.add('Expires', (datetime.now() + timedelta(hours=hours)).strftime('%a, %d %b %Y %H:%M:%S GMT')) https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires “If there is a Cache-Control header with the max-age or s-maxage directive in the response, the Expires header is ignored.” 1617745 4 390446 jbedard 2020-02-11 16:15:37 -0800 Comment on attachment 390446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390446&action=review >> Tools/resultsdbpy/resultsdbpy/flask_support/util.py:127 >> + response.headers.add('Expires', (datetime.now() + timedelta(hours=hours)).strftime('%a, %d %b %Y %H:%M:%S GMT')) > > https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires > “If there is a Cache-Control header with the max-age or s-maxage directive in the response, the Expires header is ignored.” So we can just use the max-age, then. Interesting that most web-servers I've pinged seem to set both 1617751 5 390459 jbedard 2020-02-11 16:21:52 -0800 Created attachment 390459 Patch 1617763 6 zhifei_fang 2020-02-11 16:38:58 -0800 (In reply to Jonathan Bedard from comment #4) > Comment on attachment 390446 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390446&action=review > > >> Tools/resultsdbpy/resultsdbpy/flask_support/util.py:127 > >> + response.headers.add('Expires', (datetime.now() + timedelta(hours=hours)).strftime('%a, %d %b %Y %H:%M:%S GMT')) > > > > https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires > > “If there is a Cache-Control header with the max-age or s-maxage directive in the response, the Expires header is ignored.” > > So we can just use the max-age, then. > > Interesting that most web-servers I've pinged seem to set both While this is because cache-control introduced in http 1.1 they have both defined for support http 1.0 I guess 1617764 7 zhifei_fang 2020-02-11 16:39:10 -0800 unofficially r=me 1618105 8 390459 commit-queue 2020-02-12 10:48:03 -0800 Comment on attachment 390459 Patch Clearing flags on attachment: 390459 Committed r256453: <https://trac.webkit.org/changeset/256453> 1618106 9 commit-queue 2020-02-12 10:48:05 -0800 All reviewed patches have been landed. Closing bug. 1618107 10 webkit-bug-importer 2020-02-12 10:49:12 -0800 <rdar://problem/59392678> 390446 2020-02-11 15:26:26 -0800 2020-02-11 16:21:51 -0800 Patch bug-207589-20200211152625.patch text/plain 4053 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjM4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTAyLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IENhY2hlIGFyY2hpdmUgY29udGVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NTg5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRz ZGJweS9yZXN1bHRzZGJweS9mbGFza19zdXBwb3J0L3V0aWwucHk6CisgICAgICAgIChjYWNoZV9m b3IpOiBBZGQgZGVjb3JhdG9yIGZ1bmN0aW9uIHdoaWNoIHNldHMgdGhlIGNhY2hlIHZhbHVlcyBv biB0aGUgcmV0dXJuZWQgcmVzcG9uc2UuCisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2Ri cHkvdmlldy9hcmNoaXZlX3ZpZXcucHk6CisgICAgICAgIChBcmNoaXZlVmlldyk6IENhY2hlIGFy Y2hpdmUgY29udGVudCBjbGllbnQtc2lkZSBmb3IgMTIgaG91cnMuCisgICAgICAgICogcmVzdWx0 c2RicHkvcmVzdWx0c2RicHkvdmlldy9hcmNoaXZlX3ZpZXdfdW5pdHRlc3QucHk6CisgICAgICAg IChBcmNoaXZlVmlld1VuaXR0ZXN0LnRlc3RfZmlsZSk6IFZlcmlmeSB0aGF0IGFyY2hpdmVkIGNv bnRlbnQgaXMgY2FjaGVkLgorCiAyMDIwLTAyLTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uOiBSVENSdHBTZW5kZXIuZ2V0Q2FwYWJpbGl0 aWVzKCJ2aWRlbyIpIHJldHVybnMgbnVsbCBvbiBpT1MgMTMuNCAoMTdFNTIyM2gpCkluZGV4OiBU b29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9mbGFza19zdXBwb3J0L3V0aWwucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvZmxhc2tfc3VwcG9ydC91dGls LnB5CShyZXZpc2lvbiAyNTYzNTkpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9m bGFza19zdXBwb3J0L3V0aWwucHkJKHdvcmtpbmcgY29weSkKQEAgLTIwLDYgKzIwLDcgQEAKICMg T1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFO WSBXQVkgT1VUIE9GIFRIRSBVU0UKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAorZnJvbSBkYXRldGltZSBpbXBv cnQgZGF0ZXRpbWUsIHRpbWVkZWx0YQogaW1wb3J0IGpzb24KIGZyb20gZmxhc2sgaW1wb3J0IGFi b3J0LCByZXF1ZXN0CiAKQEAgLTExNCwzICsxMTUsMTkgQEAgZGVmIGxpbWl0X2Zvcl9xdWVyeShk ZWZhdWx0X2xpbWl0PTEwMCk6CiAgICAgICAgIHJlYWxfbWV0aG9kLl9fbmFtZV9fID0gbWV0aG9k Ll9fbmFtZV9fCiAgICAgICAgIHJldHVybiByZWFsX21ldGhvZAogICAgIHJldHVybiBkZWNvcmF0 b3IKKworCitkZWYgY2FjaGVfZm9yKGhvdXJzPTEyKToKKyAgICBkZWYgZGVjb3JhdG9yKG1ldGhv ZCk6CisgICAgICAgIGRlZiByZWFsX21ldGhvZChzZWxmPU5vbmUsIG1ldGhvZD1tZXRob2QsICoq a3dhcmdzKToKKyAgICAgICAgICAgIGlmIHNlbGY6CisgICAgICAgICAgICAgICAgcmVzcG9uc2Ug PSBtZXRob2Qoc2VsZj1zZWxmLCAqKmt3YXJncykKKyAgICAgICAgICAgIGVsc2U6CisgICAgICAg ICAgICAgICAgcmVzcG9uc2UgPSBtZXRob2QoKiprd2FyZ3MpCisgICAgICAgICAgICByZXNwb25z ZS5oZWFkZXJzLmFkZCgnRXhwaXJlcycsIChkYXRldGltZS5ub3coKSArIHRpbWVkZWx0YShob3Vy cz1ob3VycykpLnN0cmZ0aW1lKCclYSwgJWQgJWIgJVkgJUg6JU06JVMgR01UJykpCisgICAgICAg ICAgICByZXNwb25zZS5oZWFkZXJzLmFkZCgnQ2FjaGUtQ29udHJvbCcsIGYncHVibGljLG1heC1h Z2U9e2hvdXJzICogNjAgKiA2MH0nKQorICAgICAgICAgICAgcmV0dXJuIHJlc3BvbnNlCisKKyAg ICAgICAgcmVhbF9tZXRob2QuX19uYW1lX18gPSBtZXRob2QuX19uYW1lX18KKyAgICAgICAgcmV0 dXJuIHJlYWxfbWV0aG9kCisgICAgcmV0dXJuIGRlY29yYXRvcgpJbmRleDogVG9vbHMvcmVzdWx0 c2RicHkvcmVzdWx0c2RicHkvdmlldy9hcmNoaXZlX3ZpZXcucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9hcmNoaXZlX3ZpZXcucHkJKHJldmlzaW9u IDI1NjM1OSkKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvYXJjaGl2ZV92 aWV3LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNiw3ICsyNiw3IEBAIGZyb20gZmxhc2sgaW1wb3J0 IGFib3J0LCBqc29uaWZ5LCByZXF1ZXMKIGZyb20gcmVzdWx0c2RicHkuY29udHJvbGxlci5jb21t aXRfY29udHJvbGxlciBpbXBvcnQgdXVpZF9yYW5nZV9mb3JfcXVlcnksIEhhc0NvbW1pdENvbnRl eHQKIGZyb20gcmVzdWx0c2RicHkuY29udHJvbGxlci5jb25maWd1cmF0aW9uX2NvbnRyb2xsZXIg aW1wb3J0IGNvbmZpZ3VyYXRpb25fZm9yX3F1ZXJ5CiBmcm9tIHJlc3VsdHNkYnB5LmNvbnRyb2xs ZXIuc3VpdGVfY29udHJvbGxlciBpbXBvcnQgdGltZV9yYW5nZV9mb3JfcXVlcnkKLWZyb20gcmVz dWx0c2RicHkuZmxhc2tfc3VwcG9ydC51dGlsIGltcG9ydCBBc3NlcnRSZXF1ZXN0LCBxdWVyeV9h c19rd2FyZ3MsIGxpbWl0X2Zvcl9xdWVyeSwgYm9vbGVhbl9xdWVyeSwgcXVlcnlfYXNfc3RyaW5n Citmcm9tIHJlc3VsdHNkYnB5LmZsYXNrX3N1cHBvcnQudXRpbCBpbXBvcnQgQXNzZXJ0UmVxdWVz dCwgYm9vbGVhbl9xdWVyeSwgY2FjaGVfZm9yLCBsaW1pdF9mb3JfcXVlcnksIHF1ZXJ5X2FzX2t3 YXJncywgcXVlcnlfYXNfc3RyaW5nCiBmcm9tIHJlc3VsdHNkYnB5LnZpZXcuc2l0ZV9tZW51IGlt cG9ydCBTaXRlTWVudQogCiAKQEAgLTYyLDYgKzYyLDcgQEAgY2xhc3MgQXJjaGl2ZVZpZXcoSGFz Q29tbWl0Q29udGV4dCk6CiAgICAgQGxpbWl0X2Zvcl9xdWVyeShERUZBVUxUX0xJTUlUKQogICAg IEBjb25maWd1cmF0aW9uX2Zvcl9xdWVyeSgpCiAgICAgQHRpbWVfcmFuZ2VfZm9yX3F1ZXJ5KCkK KyAgICBAY2FjaGVfZm9yKGhvdXJzPTEyKQogICAgIGRlZiBleHRyYWN0KAogICAgICAgICBzZWxm LCBwYXRoPU5vbmUsIGZvcm1hdD1Ob25lLAogICAgICAgICBzdWl0ZT1Ob25lLCBjb25maWd1cmF0 aW9ucz1Ob25lLCByZWNlbnQ9Tm9uZSwKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNk YnB5L3ZpZXcvYXJjaGl2ZV92aWV3X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL3Jl c3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvYXJjaGl2ZV92aWV3X3VuaXR0ZXN0LnB5CShyZXZp c2lvbiAyNTYzNTkpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L2FyY2hp dmVfdmlld191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNzMsMyArNzMsNCBAQCBjbGFz cyBBcmNoaXZlVmlld1VuaXR0ZXN0KFdlYlNpdGVUZXN0Q2FzCiAgICAgICAgIHJlc3BvbnNlID0g Y2xpZW50LmdldChzZWxmLlVSTCArICcvYXJjaGl2ZS9maWxlLnR4dCcpCiAgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwocmVzcG9uc2Uuc3RhdHVzX2NvZGUsIDIwMCkKICAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbChyZXNwb25zZS50ZXh0LCAnZGF0YScpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo cmVzcG9uc2UuaGVhZGVycy5nZXQoJ0NhY2hlLUNvbnRyb2wnKSwgJ3B1YmxpYyxtYXgtYWdlPTQz MjAwJykK 390459 2020-02-11 16:21:52 -0800 2020-02-12 10:48:03 -0800 Patch bug-207589-20200211162152.patch text/plain 3663 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjM4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTAyLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IENhY2hlIGFyY2hpdmUgY29udGVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NTg5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRz ZGJweS9yZXN1bHRzZGJweS9mbGFza19zdXBwb3J0L3V0aWwucHk6CisgICAgICAgIChjYWNoZV9m b3IpOiBBZGQgZGVjb3JhdG9yIGZ1bmN0aW9uIHdoaWNoIHNldHMgdGhlIGNhY2hlIHZhbHVlcyBv biB0aGUgcmV0dXJuZWQgcmVzcG9uc2UuCisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2Ri cHkvdmlldy9hcmNoaXZlX3ZpZXcucHk6CisgICAgICAgIChBcmNoaXZlVmlldyk6IENhY2hlIGFy Y2hpdmUgY29udGVudCBjbGllbnQtc2lkZSBmb3IgMTIgaG91cnMuCisgICAgICAgICogcmVzdWx0 c2RicHkvcmVzdWx0c2RicHkvdmlldy9hcmNoaXZlX3ZpZXdfdW5pdHRlc3QucHk6CisgICAgICAg IChBcmNoaXZlVmlld1VuaXR0ZXN0LnRlc3RfZmlsZSk6IFZlcmlmeSB0aGF0IGFyY2hpdmVkIGNv bnRlbnQgaXMgY2FjaGVkLgorCiAyMDIwLTAyLTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uOiBSVENSdHBTZW5kZXIuZ2V0Q2FwYWJpbGl0 aWVzKCJ2aWRlbyIpIHJldHVybnMgbnVsbCBvbiBpT1MgMTMuNCAoMTdFNTIyM2gpCkluZGV4OiBU b29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9mbGFza19zdXBwb3J0L3V0aWwucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvZmxhc2tfc3VwcG9ydC91dGls LnB5CShyZXZpc2lvbiAyNTYzNTkpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9m bGFza19zdXBwb3J0L3V0aWwucHkJKHdvcmtpbmcgY29weSkKQEAgLTExNCwzICsxMTQsMTggQEAg ZGVmIGxpbWl0X2Zvcl9xdWVyeShkZWZhdWx0X2xpbWl0PTEwMCk6CiAgICAgICAgIHJlYWxfbWV0 aG9kLl9fbmFtZV9fID0gbWV0aG9kLl9fbmFtZV9fCiAgICAgICAgIHJldHVybiByZWFsX21ldGhv ZAogICAgIHJldHVybiBkZWNvcmF0b3IKKworCitkZWYgY2FjaGVfZm9yKGhvdXJzPTEyKToKKyAg ICBkZWYgZGVjb3JhdG9yKG1ldGhvZCk6CisgICAgICAgIGRlZiByZWFsX21ldGhvZChzZWxmPU5v bmUsIG1ldGhvZD1tZXRob2QsICoqa3dhcmdzKToKKyAgICAgICAgICAgIGlmIHNlbGY6CisgICAg ICAgICAgICAgICAgcmVzcG9uc2UgPSBtZXRob2Qoc2VsZj1zZWxmLCAqKmt3YXJncykKKyAgICAg ICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgcmVzcG9uc2UgPSBtZXRob2QoKiprd2FyZ3Mp CisgICAgICAgICAgICByZXNwb25zZS5oZWFkZXJzLmFkZCgnQ2FjaGUtQ29udHJvbCcsIGYncHVi bGljLG1heC1hZ2U9e2hvdXJzICogNjAgKiA2MH0nKQorICAgICAgICAgICAgcmV0dXJuIHJlc3Bv bnNlCisKKyAgICAgICAgcmVhbF9tZXRob2QuX19uYW1lX18gPSBtZXRob2QuX19uYW1lX18KKyAg ICAgICAgcmV0dXJuIHJlYWxfbWV0aG9kCisgICAgcmV0dXJuIGRlY29yYXRvcgpJbmRleDogVG9v bHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9hcmNoaXZlX3ZpZXcucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9hcmNoaXZlX3ZpZXcucHkJ KHJldmlzaW9uIDI1NjM1OSkKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcv YXJjaGl2ZV92aWV3LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNiw3ICsyNiw3IEBAIGZyb20gZmxh c2sgaW1wb3J0IGFib3J0LCBqc29uaWZ5LCByZXF1ZXMKIGZyb20gcmVzdWx0c2RicHkuY29udHJv bGxlci5jb21taXRfY29udHJvbGxlciBpbXBvcnQgdXVpZF9yYW5nZV9mb3JfcXVlcnksIEhhc0Nv bW1pdENvbnRleHQKIGZyb20gcmVzdWx0c2RicHkuY29udHJvbGxlci5jb25maWd1cmF0aW9uX2Nv bnRyb2xsZXIgaW1wb3J0IGNvbmZpZ3VyYXRpb25fZm9yX3F1ZXJ5CiBmcm9tIHJlc3VsdHNkYnB5 LmNvbnRyb2xsZXIuc3VpdGVfY29udHJvbGxlciBpbXBvcnQgdGltZV9yYW5nZV9mb3JfcXVlcnkK LWZyb20gcmVzdWx0c2RicHkuZmxhc2tfc3VwcG9ydC51dGlsIGltcG9ydCBBc3NlcnRSZXF1ZXN0 LCBxdWVyeV9hc19rd2FyZ3MsIGxpbWl0X2Zvcl9xdWVyeSwgYm9vbGVhbl9xdWVyeSwgcXVlcnlf YXNfc3RyaW5nCitmcm9tIHJlc3VsdHNkYnB5LmZsYXNrX3N1cHBvcnQudXRpbCBpbXBvcnQgQXNz ZXJ0UmVxdWVzdCwgYm9vbGVhbl9xdWVyeSwgY2FjaGVfZm9yLCBsaW1pdF9mb3JfcXVlcnksIHF1 ZXJ5X2FzX2t3YXJncywgcXVlcnlfYXNfc3RyaW5nCiBmcm9tIHJlc3VsdHNkYnB5LnZpZXcuc2l0 ZV9tZW51IGltcG9ydCBTaXRlTWVudQogCiAKQEAgLTYyLDYgKzYyLDcgQEAgY2xhc3MgQXJjaGl2 ZVZpZXcoSGFzQ29tbWl0Q29udGV4dCk6CiAgICAgQGxpbWl0X2Zvcl9xdWVyeShERUZBVUxUX0xJ TUlUKQogICAgIEBjb25maWd1cmF0aW9uX2Zvcl9xdWVyeSgpCiAgICAgQHRpbWVfcmFuZ2VfZm9y X3F1ZXJ5KCkKKyAgICBAY2FjaGVfZm9yKGhvdXJzPTEyKQogICAgIGRlZiBleHRyYWN0KAogICAg ICAgICBzZWxmLCBwYXRoPU5vbmUsIGZvcm1hdD1Ob25lLAogICAgICAgICBzdWl0ZT1Ob25lLCBj b25maWd1cmF0aW9ucz1Ob25lLCByZWNlbnQ9Tm9uZSwKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5 L3Jlc3VsdHNkYnB5L3ZpZXcvYXJjaGl2ZV92aWV3X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvYXJjaGl2ZV92aWV3X3VuaXR0ZXN0 LnB5CShyZXZpc2lvbiAyNTYzNTkpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92 aWV3L2FyY2hpdmVfdmlld191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNzMsMyArNzMs NCBAQCBjbGFzcyBBcmNoaXZlVmlld1VuaXR0ZXN0KFdlYlNpdGVUZXN0Q2FzCiAgICAgICAgIHJl c3BvbnNlID0gY2xpZW50LmdldChzZWxmLlVSTCArICcvYXJjaGl2ZS9maWxlLnR4dCcpCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzcG9uc2Uuc3RhdHVzX2NvZGUsIDIwMCkKICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChyZXNwb25zZS50ZXh0LCAnZGF0YScpCisgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwocmVzcG9uc2UuaGVhZGVycy5nZXQoJ0NhY2hlLUNvbnRyb2wnKSwgJ3B1YmxpYyxt YXgtYWdlPTQzMjAwJykK