207579 2020-02-11 13:24:14 -0800 Refactor DocumentLoader::commitData to use a Document& internally 2020-02-12 11:14:14 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207506 InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue dbates ews-watchlist japhet webkit-bug-importer oldest_to_newest 1617588 0 youennf 2020-02-11 13:24:14 -0800 Refactor DocumentLoader::commitData to use a Document& 1617590 1 390414 youennf 2020-02-11 13:27:13 -0800 Created attachment 390414 Patch 1618124 2 390414 commit-queue 2020-02-12 11:13:41 -0800 Comment on attachment 390414 Patch Clearing flags on attachment: 390414 Committed r256460: <https://trac.webkit.org/changeset/256460> 1618125 3 commit-queue 2020-02-12 11:13:42 -0800 All reviewed patches have been landed. Closing bug. 1618126 4 webkit-bug-importer 2020-02-12 11:14:14 -0800 <rdar://problem/59393857> 390414 2020-02-11 13:27:13 -0800 2020-02-12 11:13:41 -0800 Patch bug-207579-20200211132712.patch text/plain 4736 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTA4MDY3NTdjMjQyMTRk MmVlOWZlY2QzYWVlM2UwMTJhNzdkMTNhMi4uOGQ2YmM5MTk5YzZlZWQ3MzFjZGNkMTIwYTlhMzYz NGZmY2ZlMWNmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWZhY3RvciBEb2N1bWVu dExvYWRlcjo6Y29tbWl0RGF0YSB0byB1c2UgYSBEb2N1bWVudCYgaW50ZXJuYWxseQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NTc5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25jZSB3ZSB3cml0ZSBz b21lIGJ5dGVzLCB0aGUgZnJhbWUgaGFzIGEgRG9jdW1lbnQuCisgICAgICAgIFB1dCBpdCBpbiBh IGxvY2FsIHZhcmlhYmxlIHRvIGltcHJvdmUgcmVhZGFiaWxpdHkgb2YgdGhlIGNvZGUuCisgICAg ICAgIE5vIGNoYW5nZSBvZiBiZWhhdmlvci4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExv YWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y29tbWl0RGF0YSk6 CisKIDIwMjAtMDItMTEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIFBhcmVudCBzZXJ2aWNlIHdvcmtlciBjb250cm9sbGVyIHNob3VsZCBiZSB1c2VkIGZvciBj aGlsZCBpZnJhbWUgYXMgcGVyIGh0dHBzOi8vdzNjLmdpdGh1Yi5pby9TZXJ2aWNlV29ya2VyLyNj b250cm9sLWFuZC11c2Utd2luZG93LWNsaWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu dExvYWRlci5jcHAKaW5kZXggYzY1NGI0MjE3MDZlYTYyNzFlY2EyNDQ1YTUyZjc0NmUyN2NjNGVh Mi4uZGE1MDMxNWQyMTYwODMzZTAyYWIxOWIyNTBlYTE5YWI2NTIyNDZhOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCkBAIC0xMDcxLDEyICsxMDcxLDE0IEBAIHZv aWQgRG9jdW1lbnRMb2FkZXI6OmNvbW1pdERhdGEoY29uc3QgY2hhciogYnl0ZXMsIHNpemVfdCBs ZW5ndGgpCiAgICAgICAgIGJvb2wgaGFzQmVndW4gPSBtX3dyaXRlci5iZWdpbihkb2N1bWVudFVS TCgpLCBmYWxzZSk7CiAgICAgICAgIG1fd3JpdGVyLnNldERvY3VtZW50V2FzTG9hZGVkQXNQYXJ0 T2ZOYXZpZ2F0aW9uKCk7CiAKKyAgICAgICAgYXV0byYgZG9jdW1lbnQgPSAqbV9mcmFtZS0+ZG9j dW1lbnQoKTsKKwogICAgICAgICBpZiAoU2VjdXJpdHlQb2xpY3k6OmFsbG93U3Vic3RpdHV0ZURh dGFBY2Nlc3NUb0xvY2FsKCkgJiYgbV9vcmlnaW5hbFN1YnN0aXR1dGVEYXRhV2FzVmFsaWQpIHsK ICAgICAgICAgICAgIC8vIElmIHRoaXMgZG9jdW1lbnQgd2FzIGxvYWRlZCB3aXRoIHN1YnN0aXR1 dGVEYXRhLCB0aGVuIHRoZSBkb2N1bWVudCBjYW4KICAgICAgICAgICAgIC8vIGxvYWQgbG9jYWwg cmVzb3VyY2VzLiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NzU2CiAgICAgICAgICAgICAvLyBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NzYwIGZvciBmdXJ0aGVyCiAgICAgICAgICAgICAvLyBkaXNjdXNzaW9uLgotICAg ICAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKS5ncmFudExvYWRM b2NhbFJlc291cmNlcygpOworICAgICAgICAgICAgZG9jdW1lbnQuc2VjdXJpdHlPcmlnaW4oKS5n cmFudExvYWRMb2NhbFJlc291cmNlcygpOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKGZyYW1l TG9hZGVyKCktPnN0YXRlTWFjaGluZSgpLmNyZWF0aW5nSW5pdGlhbEVtcHR5RG9jdW1lbnQoKSkK QEAgLTEwODQsMjAgKzEwODYsMjAgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6Y29tbWl0RGF0YShj b25zdCBjaGFyKiBieXRlcywgc2l6ZV90IGxlbmd0aCkKIAogI2lmIEVOQUJMRShXRUJfQVJDSElW RSkgfHwgRU5BQkxFKE1IVE1MKQogICAgICAgICBpZiAobV9hcmNoaXZlICYmIG1fYXJjaGl2ZS0+ c2hvdWxkT3ZlcnJpZGVCYXNlVVJMKCkpCi0gICAgICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgp LT5zZXRCYXNlVVJMT3ZlcnJpZGUobV9hcmNoaXZlLT5tYWluUmVzb3VyY2UoKS0+dXJsKCkpOwor ICAgICAgICAgICAgZG9jdW1lbnQuc2V0QmFzZVVSTE92ZXJyaWRlKG1fYXJjaGl2ZS0+bWFpblJl c291cmNlKCktPnVybCgpKTsKICNlbmRpZgogI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKICAg ICAgICAgaWYgKFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkuc2Vydmlj ZVdvcmtlckVuYWJsZWQoKSkgewogICAgICAgICAgICAgaWYgKG1fc2VydmljZVdvcmtlclJlZ2lz dHJhdGlvbkRhdGEgJiYgbV9zZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uRGF0YS0+YWN0aXZlV29y a2VyKSB7Ci0gICAgICAgICAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2V0QWN0aXZlU2Vy dmljZVdvcmtlcihTZXJ2aWNlV29ya2VyOjpnZXRPckNyZWF0ZSgqbV9mcmFtZS0+ZG9jdW1lbnQo KSwgV1RGTW92ZShtX3NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25EYXRhLT5hY3RpdmVXb3JrZXIu dmFsdWUoKSkpKTsKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5zZXRBY3RpdmVTZXJ2aWNlV29y a2VyKFNlcnZpY2VXb3JrZXI6OmdldE9yQ3JlYXRlKGRvY3VtZW50LCBXVEZNb3ZlKG1fc2Vydmlj ZVdvcmtlclJlZ2lzdHJhdGlvbkRhdGEtPmFjdGl2ZVdvcmtlci52YWx1ZSgpKSkpOwogICAgICAg ICAgICAgICAgIG1fc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRhdGEgPSB7IH07Ci0gICAgICAg ICAgICB9IGVsc2UgaWYgKGF1dG8qIHBhcmVudCA9IG1fZnJhbWUtPmRvY3VtZW50KCktPnBhcmVu dERvY3VtZW50KCkpIHsKLSAgICAgICAgICAgICAgICBpZiAoc2hvdWxkVXNlQWN0aXZlU2Vydmlj ZVdvcmtlckZyb21QYXJlbnQoKm1fZnJhbWUtPmRvY3VtZW50KCksICpwYXJlbnQpKQotICAgICAg ICAgICAgICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5zZXRBY3RpdmVTZXJ2aWNlV29ya2Vy KHBhcmVudC0+YWN0aXZlU2VydmljZVdvcmtlcigpKTsKKyAgICAgICAgICAgIH0gZWxzZSBpZiAo YXV0byogcGFyZW50ID0gZG9jdW1lbnQucGFyZW50RG9jdW1lbnQoKSkgeworICAgICAgICAgICAg ICAgIGlmIChzaG91bGRVc2VBY3RpdmVTZXJ2aWNlV29ya2VyRnJvbVBhcmVudChkb2N1bWVudCwg KnBhcmVudCkpCisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LnNldEFjdGl2ZVNlcnZpY2VX b3JrZXIocGFyZW50LT5hY3RpdmVTZXJ2aWNlV29ya2VyKCkpOwogICAgICAgICAgICAgfQogCi0g ICAgICAgICAgICBpZiAobV9mcmFtZS0+ZG9jdW1lbnQoKS0+YWN0aXZlU2VydmljZVdvcmtlcigp IHx8IExlZ2FjeVNjaGVtZVJlZ2lzdHJ5OjpjYW5TZXJ2aWNlV29ya2Vyc0hhbmRsZVVSTFNjaGVt ZShtX2ZyYW1lLT5kb2N1bWVudCgpLT51cmwoKS5wcm90b2NvbCgpLnRvU3RyaW5nV2l0aG91dENv cHlpbmcoKSkpCi0gICAgICAgICAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2V0U2Vydmlj ZVdvcmtlckNvbm5lY3Rpb24oJlNlcnZpY2VXb3JrZXJQcm92aWRlcjo6c2luZ2xldG9uKCkuc2Vy dmljZVdvcmtlckNvbm5lY3Rpb24oKSk7CisgICAgICAgICAgICBpZiAobV9mcmFtZS0+ZG9jdW1l bnQoKS0+YWN0aXZlU2VydmljZVdvcmtlcigpIHx8IExlZ2FjeVNjaGVtZVJlZ2lzdHJ5OjpjYW5T ZXJ2aWNlV29ya2Vyc0hhbmRsZVVSTFNjaGVtZShkb2N1bWVudC51cmwoKS5wcm90b2NvbCgpLnRv U3RyaW5nV2l0aG91dENvcHlpbmcoKSkpCisgICAgICAgICAgICAgICAgZG9jdW1lbnQuc2V0U2Vy dmljZVdvcmtlckNvbm5lY3Rpb24oJlNlcnZpY2VXb3JrZXJQcm92aWRlcjo6c2luZ2xldG9uKCku c2VydmljZVdvcmtlckNvbm5lY3Rpb24oKSk7CiAKICAgICAgICAgICAgIC8vIFdlIGN1cnJlbnRs eSB1bnJlZ2lzdGVyIHRoZSB0ZW1wb3Jhcnkgc2VydmljZSB3b3JrZXIgY2xpZW50IHNpbmNlIHdl IG5vdyByZWdpc3RlcmVkIHRoZSByZWFsIGRvY3VtZW50LgogICAgICAgICAgICAgLy8gRklYTUU6 IFdlIHNob3VsZCBtYWtlIHRoZSByZWFsIGRvY3VtZW50IHVzZSB0aGUgdGVtcG9yYXJ5IGNsaWVu dCBpZGVudGlmaWVyLgpAQCAtMTExMyw3ICsxMTE1LDcgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6 Y29tbWl0RGF0YShjb25zdCBjaGFyKiBieXRlcywgc2l6ZV90IGxlbmd0aCkKICAgICAgICAgaWYg KCFpc0xvYWRpbmcoKSkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAoYXV0byog d2luZG93ID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZG9tV2luZG93KCkpCisgICAgICAgIGlmIChh dXRvKiB3aW5kb3cgPSBkb2N1bWVudC5kb21XaW5kb3coKSkKICAgICAgICAgICAgIHdpbmRvdy0+ cHJld2FybUxvY2FsU3RvcmFnZUlmTmVjZXNzYXJ5KCk7CiAKICAgICAgICAgYm9vbCB1c2VyQ2hv c2VuOwo=