207565 2020-02-11 11:02:18 -0800 WebDriver: return invalidSessionID exception if the WebProcess doesn't respond (crashes) 2020-02-12 05:17:14 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clopez clopez aperez bburg bugs-noreply cgarcia clopez webkit-bug-importer oldest_to_newest 1617505 0 clopez 2020-02-11 11:02:18 -0800 One method the WPT runner uses to detect a crash inside the browser its to check if WebDriver continues to respond to a simple property get over the connection like current_window_handle If an exception its returned then its assumed the browser has crashed and WebDriver its restarted Currently the WebKitGTK webdriver hangs instead of returning an exception. The Chrome WebDriver returns an InvalidSessionID message in case of crash with the error code "session deleted because of page crash" We can do something similar for WebKitGTK WebDriver 1617512 1 390394 clopez 2020-02-11 11:08:47 -0800 Created attachment 390394 Patch 1617940 2 390394 clopez 2020-02-12 05:16:09 -0800 Comment on attachment 390394 Patch Clearing flags on attachment: 390394 Committed r256430: <https://trac.webkit.org/changeset/256430> 1617941 3 clopez 2020-02-12 05:16:13 -0800 All reviewed patches have been landed. Closing bug. 1617942 4 webkit-bug-importer 2020-02-12 05:17:14 -0800 <rdar://problem/59383477> 390394 2020-02-11 11:08:47 -0800 2020-02-12 05:16:09 -0800 Patch bug-207565-20200211200846.patch text/plain 1544 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IDc5NmY3NmNhZmJh MDgzMDAzM2Y4ZGQ4ZDYwYjFkM2MwMjZhY2IyZTIuLmZmYTQzZGUxOTZkYjkyMWViZGY3ODdhYjVk NTFmY2M3YWIwOWEzNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDIt MTEgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAg ICAgICAgV2ViRHJpdmVyOiByZXR1cm4gaW52YWxpZFNlc3Npb25JRCBleGNlcHRpb24gaWYgdGhl IFdlYlByb2Nlc3MgZG9lc24ndCByZXNwb25kIChjcmFzaGVzKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NTY1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwb3J0IEludmFsaWRTZXNzaW9uSUQgaWYg dGhlIHNlc3Npb24gY29ubmVjdGlvbiBpdHMgbm90IGNvbm5lY3RlZC4KKworICAgICAgICAqIFdl YkRyaXZlclNlcnZpY2UuY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpXZWJEcml2ZXJTZXJ2aWNl OjpmaW5kU2Vzc2lvbk9yQ29tcGxldGVXaXRoRXJyb3IpOgorCiAyMDIwLTAxLTI5ICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBXZWJE cml2ZXI6IHNjcmVlbnNob3QgaWdub3JlcyBDU1MgdHJhbnNmb3JtYXRpb25zIG9yIFdlYkdMIGNv bnRlbnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3Bw IGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAppbmRleCBjNGIzOWMwM2Q0 ZmEyZTY4NDg1NTQ4ZGUxYThhOTJjMDQ3N2JmNjhlLi45YjdjMWIzMmU5MDFiZDhhMjFmN2RlNTYx ZTA0YmZlNTg4MWUwZjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNl cnZpY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAKQEAg LTUxNyw2ICs1MTcsMTIgQEAgYm9vbCBXZWJEcml2ZXJTZXJ2aWNlOjpmaW5kU2Vzc2lvbk9yQ29t cGxldGVXaXRoRXJyb3IoSlNPTjo6T2JqZWN0JiBwYXJhbWV0ZXJzLAogICAgICAgICByZXR1cm4g ZmFsc2U7CiAgICAgfQogCisgICAgaWYgKCFtX3Nlc3Npb24tPmlzQ29ubmVjdGVkKCkpIHsKKyAg ICAgICAgbV9zZXNzaW9uID0gbnVsbHB0cjsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29t bWFuZFJlc3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OkludmFsaWRTZXNzaW9u SUQsIFN0cmluZygic2Vzc2lvbiBkZWxldGVkIGJlY2F1c2Ugb2YgcGFnZSBjcmFzaCBvciBoYW5n LiIpKSk7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKICAgICByZXR1cm4gdHJ1ZTsK IH0KIAo=