207556 2020-02-11 09:10:26 -0800 [ews] add SetBuildSummary step for Windows EWS 2020-02-17 08:50:18 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain jbedard webkit-bug-importer oldest_to_newest 1617409 0 aakash_jain 2020-02-11 09:10:26 -0800 add SetBuildSummary step for Windows EWS. Follow-up to Bug 207492. 1617419 1 390373 aakash_jain 2020-02-11 09:16:16 -0800 Created attachment 390373 Patch 1617420 2 390374 aakash_jain 2020-02-11 09:22:06 -0800 Created attachment 390374 Patch 1617634 3 390374 jbedard 2020-02-11 14:29:33 -0800 Comment on attachment 390374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390374&action=review > Tools/ChangeLog:10 > + (GTKBuildAndTestFactory.__init__): Adding it for GTK too? 1617637 4 aakash_jain 2020-02-11 14:33:02 -0800 This change would fix the build summary for builds like this: https://ews-build.webkit.org/#/builders/10/builds/7056 1617638 5 aakash_jain 2020-02-11 14:33:25 -0800 (In reply to Jonathan Bedard from comment #3) > Adding it for GTK too? Yes, because GTK factory also have the same layout-test step which was modified in Bug 207492. Although that code path is not used currently by any GTK factory. 1619675 6 aakash_jain 2020-02-17 08:49:05 -0800 Committed r256729: <https://trac.webkit.org/changeset/256729> 1619678 7 webkit-bug-importer 2020-02-17 08:50:18 -0800 <rdar://problem/59512176> 390373 2020-02-11 09:16:16 -0800 2020-02-11 09:18:13 -0800 Patch bug-207556-20200211121615.patch text/plain 3232 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjMxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBhZGQgU2V0QnVpbGRTdW1tYXJ5IHN0ZXAgZm9yIFdpbmRvd3Mg RVdTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc1 NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHk6CisgICAgICAgIChXaW5kb3dz RmFjdG9yeS5fX2luaXRfXyk6CisgICAgICAgIChHVEtCdWlsZEFuZFRlc3RGYWN0b3J5Ll9faW5p dF9fKToKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3Vu aXR0ZXN0LnB5OgorICAgICAgICAoVGVzdEJ1aWxkQW5kVGVzdHNGYWN0b3J5LnRlc3Rfd2luZG93 c19mYWN0b3J5KTogQWRkZWQgdW5pdC10ZXN0LgorCiAyMDIwLTAyLTExICBMYXVybyBNb3VyYSAg PGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW1dlYkRyaXZlcl0gTWluaUJyb3dz ZXIgc2hvdWxkIHJlYWN0IHRvIGNsb3NlIHNlc3Npb24gY29tbWFuZHMKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjU2 MzExKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQko d29ya2luZyBjb3B5KQpAQCAtMTU4LDYgKzE1OCw3IEBAIGNsYXNzIFdpbmRvd3NGYWN0b3J5KEZh Y3RvcnkpOgogICAgICAgICBzZWxmLmFkZFN0ZXAoQ29tcGlsZVdlYktpdChza2lwVXBsb2FkPVRy dWUpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoVmFsaWRhdGVQYXRjaCh2ZXJpZnlCdWdDbG9zZWQ9 RmFsc2UsIGFkZFVSTHM9RmFsc2UpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuV2ViS2l0MVRl c3RzKCkpCisgICAgICAgIHNlbGYuYWRkU3RlcChTZXRCdWlsZFN1bW1hcnkoKSkKIAogCiBjbGFz cyBXaW5DYWlyb0ZhY3RvcnkoRmFjdG9yeSk6CkBAIC0xODUsNiArMTg2LDcgQEAgY2xhc3MgR1RL QnVpbGRBbmRUZXN0RmFjdG9yeShHVEtCdWlsZEZhYwogICAgICAgICBzZWxmLmFkZFN0ZXAoVmFs aWRhdGVQYXRjaCh2ZXJpZnlCdWdDbG9zZWQ9RmFsc2UsIGFkZFVSTHM9RmFsc2UpKQogICAgICAg ICBpZiBzZWxmLkxheW91dFRlc3RDbGFzczoKICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChzZWxm LkxheW91dFRlc3RDbGFzcygpKQorICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFNldEJ1aWxkU3Vt bWFyeSgpKQogICAgICAgICBpZiBzZWxmLkFQSVRlc3RDbGFzczoKICAgICAgICAgICAgIHNlbGYu YWRkU3RlcChzZWxmLkFQSVRlc3RDbGFzcygpKQogCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXNfdW5pdHRlc3QucHkJKHJldmlz aW9uIDI1NjMxMSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3Jp ZXNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1NCwzICsxNTQsMjEgQEAgY2xhc3Mg VGVzdFRlc3RzRmFjdG9yeShUZXN0Q2FzZSk6CiAgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9y eShzdGVwcy5SdW5SZXN1bHRzZGJweVRlc3RzKSwKICAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0 b3J5KHN0ZXBzLlJ1bkJ1aWxkV2ViS2l0T3JnVW5pdFRlc3RzKSwKICAgICAgICAgXSkKKworCitj bGFzcyBUZXN0QnVpbGRBbmRUZXN0c0ZhY3RvcnkoVGVzdENhc2UpOgorICAgIGRlZiB0ZXN0X3dp bmRvd3NfZmFjdG9yeShzZWxmKToKKyAgICAgICAgZmFjdG9yeSA9IGZhY3Rvcmllcy5XaW5kb3dz RmFjdG9yeShwbGF0Zm9ybT0nd2luJywgY29uZmlndXJhdGlvbj0ncmVsZWFzZScsIGFyY2hpdGVj dHVyZXM9WyJ4ODZfNjQiXSkKKyAgICAgICAgc2VsZi5hc3NlcnRCdWlsZFN0ZXBzKGZhY3Rvcnku c3RlcHMsIFsKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkNvbmZpZ3VyZUJ1 aWxkLCBwbGF0Zm9ybT0nd2luJywgY29uZmlndXJhdGlvbj0ncmVsZWFzZScsIGFyY2hpdGVjdHVy ZXM9Ing4Nl82NCIsIGJ1aWxkT25seT1GYWxzZSwgdHJpZ2dlcnM9Tm9uZSwgcmVtb3Rlcz1Ob25l LCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rv cnkoc3RlcHMuVmFsaWRhdGVQYXRjaCwgdmVyaWZ5Y3FwbHVzPUZhbHNlKSwKKyAgICAgICAgICAg IF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlByaW50Q29uZmlndXJhdGlvbiksCisgICAgICAgICAg ICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5DaGVja091dFNvdXJjZSksCisgICAgICAgICAgICBf QnVpbGRTdGVwRmFjdG9yeShzdGVwcy5DaGVja091dFNwZWNpZmljUmV2aXNpb24pLAorICAgICAg ICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQXBwbHlQYXRjaCksCisgICAgICAgICAgICBf QnVpbGRTdGVwRmFjdG9yeShzdGVwcy5LaWxsT2xkUHJvY2Vzc2VzKSwKKyAgICAgICAgICAgIF9C dWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkNvbXBpbGVXZWJLaXQsIHNraXBVcGxvYWQ9VHJ1ZSksCisg ICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5WYWxpZGF0ZVBhdGNoLCB2ZXJpZnlC dWdDbG9zZWQ9RmFsc2UsIGFkZFVSTHM9RmFsc2UpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZh Y3Rvcnkoc3RlcHMuUnVuV2ViS2l0MVRlc3RzKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0 b3J5KHN0ZXBzLlNldEJ1aWxkU3VtbWFyeSksCisgICAgICAgIF0pCg== 390374 2020-02-11 09:22:06 -0800 2020-02-17 08:49:13 -0800 Patch bug-207556-20200211122205.patch text/plain 3234 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjMxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBhZGQgU2V0QnVpbGRTdW1tYXJ5IHN0ZXAgZm9yIFdpbmRvd3Mg RVdTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc1 NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHk6CisgICAgICAgIChXaW5kb3dz RmFjdG9yeS5fX2luaXRfXyk6CisgICAgICAgIChHVEtCdWlsZEFuZFRlc3RGYWN0b3J5Ll9faW5p dF9fKToKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3Vu aXR0ZXN0LnB5OgorICAgICAgICAoVGVzdEJ1aWxkQW5kVGVzdHNGYWN0b3J5LnRlc3Rfd2luZG93 c19mYWN0b3J5KTogQWRkZWQgdW5pdC10ZXN0LgorCiAyMDIwLTAyLTExICBMYXVybyBNb3VyYSAg PGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW1dlYkRyaXZlcl0gTWluaUJyb3dz ZXIgc2hvdWxkIHJlYWN0IHRvIGNsb3NlIHNlc3Npb24gY29tbWFuZHMKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjU2 MzExKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQko d29ya2luZyBjb3B5KQpAQCAtMTU4LDYgKzE1OCw3IEBAIGNsYXNzIFdpbmRvd3NGYWN0b3J5KEZh Y3RvcnkpOgogICAgICAgICBzZWxmLmFkZFN0ZXAoQ29tcGlsZVdlYktpdChza2lwVXBsb2FkPVRy dWUpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoVmFsaWRhdGVQYXRjaCh2ZXJpZnlCdWdDbG9zZWQ9 RmFsc2UsIGFkZFVSTHM9RmFsc2UpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuV2ViS2l0MVRl c3RzKCkpCisgICAgICAgIHNlbGYuYWRkU3RlcChTZXRCdWlsZFN1bW1hcnkoKSkKIAogCiBjbGFz cyBXaW5DYWlyb0ZhY3RvcnkoRmFjdG9yeSk6CkBAIC0xODUsNiArMTg2LDcgQEAgY2xhc3MgR1RL QnVpbGRBbmRUZXN0RmFjdG9yeShHVEtCdWlsZEZhYwogICAgICAgICBzZWxmLmFkZFN0ZXAoVmFs aWRhdGVQYXRjaCh2ZXJpZnlCdWdDbG9zZWQ9RmFsc2UsIGFkZFVSTHM9RmFsc2UpKQogICAgICAg ICBpZiBzZWxmLkxheW91dFRlc3RDbGFzczoKICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChzZWxm LkxheW91dFRlc3RDbGFzcygpKQorICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFNldEJ1aWxkU3Vt bWFyeSgpKQogICAgICAgICBpZiBzZWxmLkFQSVRlc3RDbGFzczoKICAgICAgICAgICAgIHNlbGYu YWRkU3RlcChzZWxmLkFQSVRlc3RDbGFzcygpKQogCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXNfdW5pdHRlc3QucHkJKHJldmlz aW9uIDI1NjMxMSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3Jp ZXNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1NCwzICsxNTQsMjEgQEAgY2xhc3Mg VGVzdFRlc3RzRmFjdG9yeShUZXN0Q2FzZSk6CiAgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9y eShzdGVwcy5SdW5SZXN1bHRzZGJweVRlc3RzKSwKICAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0 b3J5KHN0ZXBzLlJ1bkJ1aWxkV2ViS2l0T3JnVW5pdFRlc3RzKSwKICAgICAgICAgXSkKKworCitj bGFzcyBUZXN0QnVpbGRBbmRUZXN0c0ZhY3RvcnkoVGVzdENhc2UpOgorICAgIGRlZiB0ZXN0X3dp bmRvd3NfZmFjdG9yeShzZWxmKToKKyAgICAgICAgZmFjdG9yeSA9IGZhY3Rvcmllcy5XaW5kb3dz RmFjdG9yeShwbGF0Zm9ybT0nd2luJywgY29uZmlndXJhdGlvbj0ncmVsZWFzZScsIGFyY2hpdGVj dHVyZXM9WyJ4ODZfNjQiXSkKKyAgICAgICAgc2VsZi5hc3NlcnRCdWlsZFN0ZXBzKGZhY3Rvcnku c3RlcHMsIFsKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkNvbmZpZ3VyZUJ1 aWxkLCBwbGF0Zm9ybT0nd2luJywgY29uZmlndXJhdGlvbj0ncmVsZWFzZScsIGFyY2hpdGVjdHVy ZXM9WyJ4ODZfNjQiXSwgYnVpbGRPbmx5PUZhbHNlLCB0cmlnZ2Vycz1Ob25lLCByZW1vdGVzPU5v bmUsIGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9uZSksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFj dG9yeShzdGVwcy5WYWxpZGF0ZVBhdGNoLCB2ZXJpZnljcXBsdXM9RmFsc2UpLAorICAgICAgICAg ICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuUHJpbnRDb25maWd1cmF0aW9uKSwKKyAgICAgICAg ICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkNoZWNrT3V0U291cmNlKSwKKyAgICAgICAgICAg IF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkNoZWNrT3V0U3BlY2lmaWNSZXZpc2lvbiksCisgICAg ICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5BcHBseVBhdGNoKSwKKyAgICAgICAgICAg IF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLktpbGxPbGRQcm9jZXNzZXMpLAorICAgICAgICAgICAg X0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ29tcGlsZVdlYktpdCwgc2tpcFVwbG9hZD1UcnVlKSwK KyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlZhbGlkYXRlUGF0Y2gsIHZlcmlm eUJ1Z0Nsb3NlZD1GYWxzZSwgYWRkVVJMcz1GYWxzZSksCisgICAgICAgICAgICBfQnVpbGRTdGVw RmFjdG9yeShzdGVwcy5SdW5XZWJLaXQxVGVzdHMpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZh Y3Rvcnkoc3RlcHMuU2V0QnVpbGRTdW1tYXJ5KSwKKyAgICAgICAgXSkK