<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>207536</bug_id>
          
          <creation_ts>2020-02-11 04:42:23 -0800</creation_ts>
          <short_desc>Regression r256298: WPE build broken</short_desc>
          <delta_ts>2020-02-11 05:05:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=206999</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1617327</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-02-11 04:42:23 -0800</bug_when>
    <thetext>WPE build seems to be broken since r256298.

r256297 passed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Debug%20%28Build%29/builds/16189
r256298 failed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Debug%20%28Build%29/builds/16189

Similarly for release:
r256297 passed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/29093
r256298 failed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/29094


Logs:
FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-46.cpp.o 
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-46.cpp:1:
../../Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp: In member function ‘void WebCore::ResourceRequest::updateFromSoupMessage(SoupMessage*)’:
../../Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:186:23: error: ‘areRegistrableDomainsEqual’ was not declared in this scope
         setIsSameSite(areRegistrableDomainsEqual(soupURIToURL(siteForCookies), m_url));

In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-3.cpp:2:
../../Source/WebCore/rendering/HighlightData.cpp: In member function ‘WebCore::RenderObject::HighlightState WebCore::HighlightData::highlightStateForRenderer(WebCore::RenderObject&amp;)’:
../../Source/WebCore/rendering/HighlightData.cpp:174:19: warning: variable ‘highlightEnd’ set but not used [-Wunused-but-set-variable]
     RenderObject* highlightEnd = nullptr;
                   ^~~~~~~~~~~~</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617335</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2020-02-11 04:59:11 -0800</bug_when>
    <thetext>Thanks for the report.

Not sure if r256298 actually caused it, but at least triggered the failure.

I see r256298 touches SourcesWPE.txt, that causes the CMake cache to be cleared when a re-build its attempted (which the bot did)

I have triggered a clean build in GTK-Release bot to see if its also affected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617336</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2020-02-11 05:05:35 -0800</bug_when>
    <thetext>Committed r256301: &lt;https://trac.webkit.org/changeset/256301&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>