<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>207503</bug_id>
          
          <creation_ts>2020-02-10 13:38:08 -0800</creation_ts>
          <short_desc>[WebCore] Shrink Vectors passed to SharedBuffer</short_desc>
          <delta_ts>2020-02-10 15:18:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Basuke Suzuki">basuke</reporter>
          <assigned_to name="Basuke Suzuki">basuke</assigned_to>
          <cc>basuke</cc>
    
    <cc>commit-queue</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1617076</commentid>
    <comment_count>0</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2020-02-10 13:38:08 -0800</bug_when>
    <thetext>SharedBuffer::DataSegment is const data and never change is size and content after creation. Shrink the passed vector before assigning to member variable to save space.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617082</commentid>
    <comment_count>1</comment_count>
      <attachid>390288</attachid>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2020-02-10 13:45:42 -0800</bug_when>
    <thetext>Created attachment 390288
PATCH</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617113</commentid>
    <comment_count>2</comment_count>
      <attachid>390288</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-10 14:24:17 -0800</bug_when>
    <thetext>Comment on attachment 390288
PATCH

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617137</commentid>
    <comment_count>3</comment_count>
      <attachid>390288</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-02-10 15:17:22 -0800</bug_when>
    <thetext>Comment on attachment 390288
PATCH

Clearing flags on attachment: 390288

Committed r256223: &lt;https://trac.webkit.org/changeset/256223&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617138</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-02-10 15:17:24 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617139</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-02-10 15:18:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/59328015&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>390288</attachid>
            <date>2020-02-10 13:45:42 -0800</date>
            <delta_ts>2020-02-10 15:17:22 -0800</delta_ts>
            <desc>PATCH</desc>
            <filename>bug-207503.diff</filename>
            <type>text/plain</type>
            <size>1706</size>
            <attacher name="Basuke Suzuki">basuke</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBhZjE0NTcwYmZmYy4uNmE2ZDc3Y2EwMGYgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxOSBAQAorMjAyMC0wMi0xMCAgQmFzdWtlIFN1enVraSAgPGJhc3VrZS5zdXp1a2lAc29u
eS5jb20+CisKKyAgICAgICAgW1dlYkNvcmVdIFNocmluayBWZWN0b3JzIHBhc3NlZCB0byBTaGFy
ZWRCdWZmZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIwNzUwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE9uY2UgU2hhcmVkQnVmZmVyOjpEYXRhU2VnbWVudCBpcyBjcmVhdGVkLCB0aGUgY29udGVudCB3
b24ndCBjaGFuZ2UgaW4gaXRzIGxpZmUgY3ljbGUuIFNocmluayB0aGUgcGFzc2VkIHZlY3Rvcgor
ICAgICAgICBiZWZvcmUgYXNzaWduaW5nIHRvIG1lbWJlciB2YXJpYWJsZSB0byBzYXZlIHNwYWNl
LgorCisgICAgICAgIFdpdGggdGhlIHF1aWNrIHJlc2VhcmNoLCB3aGVuIGRpc3BsYXlpbmcgQXBw
bGUncyB3ZWJzaXRlLCAxfjMlIFJTUyB1c2FnZSByZWR1Y3Rpb24gb24gUGxheVN0YXRpb24gcG9y
dC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSdzIG5vIGJlaGF2aW9yIGNo
YW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL1NoYXJlZEJ1ZmZlci5oOgorCiAyMDIwLTAyLTA3
ICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaWx0ZXIgb3V0
IFRVUk4vU1RVTiAubG9jYWwgVVJMcyBmcm9tIGEgUlRDUGVlckNvbm5lY3Rpb24gaWNlU2VydmVy
cyBsaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIu
aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5oCmluZGV4IDVmYmYwMzZj
MDNjLi5iNjgzY2E3ZDMyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hh
cmVkQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmgK
QEAgLTEyOSw3ICsxMjksMTIgQEAgcHVibGljOgogICAgICAgICBXRUJDT1JFX0VYUE9SVCBjb25z
dCBjaGFyKiBkYXRhKCkgY29uc3Q7CiAgICAgICAgIFdFQkNPUkVfRVhQT1JUIHNpemVfdCBzaXpl
KCkgY29uc3Q7CiAKLSAgICAgICAgc3RhdGljIFJlZjxEYXRhU2VnbWVudD4gY3JlYXRlKFZlY3Rv
cjxjaGFyPiYmIGRhdGEpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgRGF0YVNlZ21lbnQoV1RGTW92
ZShkYXRhKSkpOyB9CisgICAgICAgIHN0YXRpYyBSZWY8RGF0YVNlZ21lbnQ+IGNyZWF0ZShWZWN0
b3I8Y2hhcj4mJiBkYXRhKQorICAgICAgICB7CisgICAgICAgICAgICBkYXRhLnNocmlua1RvRml0
KCk7CisgICAgICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBEYXRhU2VnbWVudChXVEZNb3Zl
KGRhdGEpKSk7CisgICAgICAgIH0KKwogI2lmIFVTRShDRikKICAgICAgICAgc3RhdGljIFJlZjxE
YXRhU2VnbWVudD4gY3JlYXRlKFJldGFpblB0cjxDRkRhdGFSZWY+JiYgZGF0YSkgeyByZXR1cm4g
YWRvcHRSZWYoKm5ldyBEYXRhU2VnbWVudChXVEZNb3ZlKGRhdGEpKSk7IH0KICNlbmRpZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>