207484 2020-02-10 11:03:53 -0800 arm64_32: Mark microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out on all Apple Watch models 2020-04-01 16:13:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_michaud justin_michaud commit-queue mark.lam ryanhaddad webkit-bug-importer ysuzuki oldest_to_newest 1616973 0 justin_michaud 2020-02-10 11:03:53 -0800 arm64_32: microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out 1616974 1 390268 justin_michaud 2020-02-10 11:04:20 -0800 Created attachment 390268 Patch 1616975 2 justin_michaud 2020-02-10 11:05:27 -0800 rdar://59262882 1616980 3 390268 ysuzuki 2020-02-10 11:10:50 -0800 Comment on attachment 390268 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390268&action=review r=me > JSTests/microbenchmarks/delete-property-keeps-cacheable-structure.js:1 > +//@ skip if $architecture == "arm64_32" or $architecture == "arm7k" Should we use something like, `$model =~ /^Apple Watch/` etc.? But I don't have strong preference. 1616989 4 390272 justin_michaud 2020-02-10 11:20:46 -0800 Created attachment 390272 Patch 1617020 5 390272 commit-queue 2020-02-10 12:09:49 -0800 Comment on attachment 390272 Patch Clearing flags on attachment: 390272 Committed r256199: <https://trac.webkit.org/changeset/256199> 1617021 6 commit-queue 2020-02-10 12:09:50 -0800 All reviewed patches have been landed. Closing bug. 1617106 7 ap 2020-02-10 14:12:59 -0800 Re-titling, because this wasn't fixed, just the test skipped. 1636718 8 mark.lam 2020-04-01 16:11:55 -0700 (In reply to Alexey Proskuryakov from comment #7) > Re-titling, because this wasn't fixed, just the test skipped. 1636720 9 mark.lam 2020-04-01 16:13:43 -0700 (In reply to Mark Lam from comment #8) > (In reply to Alexey Proskuryakov from comment #7) > > Re-titling, because this wasn't fixed, just the test skipped. There's nothing more to fix here. The test runs 5000000 iterations of its workload. On Apple Watch which doesn't use the JIT, this is going to take forever, and will surely time out. Skipping it is the right thing to do. 390268 2020-02-10 11:04:20 -0800 2020-02-10 11:20:44 -0800 Patch bug-207484-20200210110420.patch text/plain 1365 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTk0CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE3YjQxMmVjNWVkMjdiY2U1OWY4N2QwNTBiOWZl YTQwNzU3YmY0OTEuLjY4MzFiYzdjOGE5MTYwODkzMDljNGU0MzY3M2ViODM0MGE4Nzc2ODcgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMjAtMDItMTAgIEp1c3RpbiBNaWNoYXVkICA8anVzdGluX21pY2hhdWRA YXBwbGUuY29tPgorCisgICAgICAgIGFybTY0XzMyOiBtaWNyb2JlbmNobWFya3MvZGVsZXRlLXBy b3BlcnR5LWtlZXBzLWNhY2hlYWJsZS1zdHJ1Y3R1cmUuanMgaXMgdGltaW5nIG91dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NDg0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtaWNyb2JlbmNobWFy a3MvZGVsZXRlLXByb3BlcnR5LWtlZXBzLWNhY2hlYWJsZS1zdHJ1Y3R1cmUuanM6CisKIDIwMjAt MDItMDYgIFN1a29sc2FrIFNha3NodXdvbmcgIDxzdWtvbHNha0BnbWFpbC5jb20+IGFuZCBBbGV4 ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBKYXZhU2NyaXB0 IHN0cmluZyBjb3JydXB0aW9uIHVzaW5nIFJlZ0V4cCB3aXRoIHVuaWNvZGUgY2hhcmFjdGVyCmRp ZmYgLS1naXQgYS9KU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9kZWxldGUtcHJvcGVydHkta2VlcHMt Y2FjaGVhYmxlLXN0cnVjdHVyZS5qcyBiL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2RlbGV0ZS1w cm9wZXJ0eS1rZWVwcy1jYWNoZWFibGUtc3RydWN0dXJlLmpzCmluZGV4IDIyY2NhOWZkMjFkYjA3 MjZiYTZiMWQyYjY1ZDlkYTViODNhOGE4MzguLjQ0MzNiNThlNGEyY2M3OTdkMmFlNTk4N2UwNjdk NmY1ZDhjYTMxY2QgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2RlbGV0ZS1w cm9wZXJ0eS1rZWVwcy1jYWNoZWFibGUtc3RydWN0dXJlLmpzCisrKyBiL0pTVGVzdHMvbWljcm9i ZW5jaG1hcmtzL2RlbGV0ZS1wcm9wZXJ0eS1rZWVwcy1jYWNoZWFibGUtc3RydWN0dXJlLmpzCkBA IC0xLDQgKzEsNCBAQAotLy9AIHNraXAgaWYgJG1vZGVsID09ICJBcHBsZSBXYXRjaCBTZXJpZXMg MyIgIyBhZGRlZCBieSBtYXJrLWpzYy1zdHJlc3MtdGVzdC5weQorLy9AIHNraXAgaWYgJGFyY2hp dGVjdHVyZSA9PSAiYXJtNjRfMzIiIG9yICRhcmNoaXRlY3R1cmUgPT0gImFybTdrIgogZnVuY3Rp b24gYXNzZXJ0KGIpIHsKICAgICBpZiAoIWIpCiAgICAgICAgIHRocm93IG5ldyBFcnJvcjsK 390272 2020-02-10 11:20:46 -0800 2020-02-10 12:09:49 -0800 Patch bug-207484-20200210112044.patch text/plain 1333 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTk0CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE3YjQxMmVjNWVkMjdiY2U1OWY4N2QwNTBiOWZl YTQwNzU3YmY0OTEuLjk4MjljY2I3ZTI2ZDM0MDdkOWM4NTU1YjA0ZDcxM2Y0YzdjZTJlMDYgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMjAtMDItMTAgIEp1c3RpbiBNaWNoYXVkICA8anVzdGluX21pY2hhdWRA YXBwbGUuY29tPgorCisgICAgICAgIGFybTY0XzMyOiBtaWNyb2JlbmNobWFya3MvZGVsZXRlLXBy b3BlcnR5LWtlZXBzLWNhY2hlYWJsZS1zdHJ1Y3R1cmUuanMgaXMgdGltaW5nIG91dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NDg0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraS4KKworICAgICAgICAqIG1pY3JvYmVuY2htYXJr cy9kZWxldGUtcHJvcGVydHkta2VlcHMtY2FjaGVhYmxlLXN0cnVjdHVyZS5qczoKKwogMjAyMC0w Mi0wNiAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdtYWlsLmNvbT4gYW5kIEFsZXhl eSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIEphdmFTY3JpcHQg c3RyaW5nIGNvcnJ1cHRpb24gdXNpbmcgUmVnRXhwIHdpdGggdW5pY29kZSBjaGFyYWN0ZXIKZGlm ZiAtLWdpdCBhL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2RlbGV0ZS1wcm9wZXJ0eS1rZWVwcy1j YWNoZWFibGUtc3RydWN0dXJlLmpzIGIvSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZGVsZXRlLXBy b3BlcnR5LWtlZXBzLWNhY2hlYWJsZS1zdHJ1Y3R1cmUuanMKaW5kZXggMjJjY2E5ZmQyMWRiMDcy NmJhNmIxZDJiNjVkOWRhNWI4M2E4YTgzOC4uNzc5NWRjNTgxNTc4ZTRjMzk4MWMyMmFjODc2YzQ1 NTQxM2U2NGQzYyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZGVsZXRlLXBy b3BlcnR5LWtlZXBzLWNhY2hlYWJsZS1zdHJ1Y3R1cmUuanMKKysrIGIvSlNUZXN0cy9taWNyb2Jl bmNobWFya3MvZGVsZXRlLXByb3BlcnR5LWtlZXBzLWNhY2hlYWJsZS1zdHJ1Y3R1cmUuanMKQEAg LTEsNCArMSw0IEBACi0vL0Agc2tpcCBpZiAkbW9kZWwgPT0gIkFwcGxlIFdhdGNoIFNlcmllcyAz IiAjIGFkZGVkIGJ5IG1hcmstanNjLXN0cmVzcy10ZXN0LnB5CisvL0Agc2tpcCBpZiAkbW9kZWwg PX4gL15BcHBsZSBXYXRjaC8KIGZ1bmN0aW9uIGFzc2VydChiKSB7CiAgICAgaWYgKCFiKQogICAg ICAgICB0aHJvdyBuZXcgRXJyb3I7Cg==