207480 2020-02-10 10:41:51 -0800 REGRESSION ( r254044 ): [ Win ] css1/box_properties/padding_left.html is failing 2020-02-10 15:14:45 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205762 InRadar P2 Normal --- 1 tsavell webkit-unassigned commit-queue koivisto webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1616957 0 tsavell 2020-02-10 10:41:51 -0800 css1/box_properties/padding_left.html This test is failing on windows. It began between r254044-254042 History: https://results.webkit.org/?suite=layout-tests&test=css1%2Fbox_properties%2Fpadding_left.html&platform=win Diff: --- /home/buildbot/worker/win10-release-tests/build/layout-test-results/css1/box_properties/padding_left-expected.txt +++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/css1/box_properties/padding_left-actual.txt @@ -9,11 +9,17 @@ RenderBlock {PRE} at (0,34) size 769x90 RenderText {#text} at (0,0) size 416x90 text run at (0,0) width 400: ".zero {background-color: silver; padding-left: 0;}" + text run at (400,0) width 0: " " text run at (0,15) width 408: ".one {padding-left: 0.5in; background-color: aqua;}" + text run at (408,15) width 0: " " text run at (0,30) width 400: ".two {padding-left: 25px; background-color: aqua;}" + text run at (400,30) width 0: " " text run at (0,45) width 408: ".three {padding-left: 5em; background-color: aqua;}" + text run at (408,45) width 0: " " text run at (0,60) width 400: ".four {padding-left: 25%; background-color: aqua;}" + text run at (400,60) width 0: " " text run at (0,75) width 416: ".five {padding-left: -20px; background-color: aqua;}" + text run at (416,75) width 0: " " RenderBlock {HR} at (0,137) size 769x2 [border: (1px inset #000000)] RenderBlock {P} at (0,155) size 769x18 [bgcolor=#C0C0C0] RenderText {#text} at (0,0) size 203x18 1616959 1 webkit-bug-importer 2020-02-10 10:42:12 -0800 <rdar://problem/59316463> 1616963 2 tsavell 2020-02-10 10:50:33 -0800 marked test as failing on https://trac.webkit.org/changeset/256195/webkit 1617003 3 ryanhaddad 2020-02-10 11:42:12 -0800 It looks like the test was rebaselined for macOS here: https://trac.webkit.org/changeset/254044/webkit#file176 Perhaps we just need to land a new baseline for Windows, too. 1617004 4 koivisto 2020-02-10 11:44:02 -0800 Yeah, this needs rebaseline 1617101 5 390295 koivisto 2020-02-10 14:08:01 -0800 Created attachment 390295 patch 1617134 6 390295 commit-queue 2020-02-10 15:14:43 -0800 Comment on attachment 390295 patch Clearing flags on attachment: 390295 Committed r256222: <https://trac.webkit.org/changeset/256222> 1617135 7 commit-queue 2020-02-10 15:14:45 -0800 All reviewed patches have been landed. Closing bug. 390295 2020-02-10 14:08:01 -0800 2020-02-10 15:14:43 -0800 patch win-padding_left-gardening.patch text/plain 2171 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMzdiZGNkZjBmOC4uMGNkOTc3YjJiYTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAyMC0wMi0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTjogWyBXaW4gXSAoIHIyNTQwNDQgKSBjc3MxL2JveF9wcm9wZXJ0aWVzL3BhZGRp bmdfbGVmdC5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzQ4MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkzMTY0NjM+ CisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZy4KKworICAgICAgICAqIHBsYXRm b3JtL3dpbi9jc3MxL2JveF9wcm9wZXJ0aWVzL3BhZGRpbmdfbGVmdC1leHBlY3RlZC50eHQ6CisK IDIwMjAtMDItMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgRXh0ZW50IG9mIGEgY29tcG9zaXRlZCBhbmltYXRpb24gc2hvdWxkIG5vdCBpbmNsdWRl IHRoZSB1bnRyYW5zZm9ybWVkIHBvc2l0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS93aW4vY3NzMS9ib3hfcHJvcGVydGllcy9wYWRkaW5nX2xlZnQtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2NzczEvYm94X3Byb3BlcnRpZXMvcGFkZGluZ19sZWZ0 LWV4cGVjdGVkLnR4dAppbmRleCA1YWEyMTVmZDI0YS4uY2M2MTUwN2VlOWYgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9jc3MxL2JveF9wcm9wZXJ0aWVzL3BhZGRpbmdfbGVm dC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2NzczEvYm94X3By b3BlcnRpZXMvcGFkZGluZ19sZWZ0LWV4cGVjdGVkLnR4dApAQCAtOSwxMSArOSwxNyBAQCBsYXll ciBhdCAoMCwwKSBzaXplIDc4NXg5OTEKICAgICAgIFJlbmRlckJsb2NrIHtQUkV9IGF0ICgwLDM0 KSBzaXplIDc2OXg5MAogICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSA0 MTZ4OTAKICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA0MDA6ICIuemVybyB7YmFj a2dyb3VuZC1jb2xvcjogc2lsdmVyOyBwYWRkaW5nLWxlZnQ6IDA7fSIKKyAgICAgICAgICB0ZXh0 IHJ1biBhdCAoNDAwLDApIHdpZHRoIDA6ICIgIgogICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDE1 KSB3aWR0aCA0MDg6ICIub25lIHtwYWRkaW5nLWxlZnQ6IDAuNWluOyBiYWNrZ3JvdW5kLWNvbG9y OiBhcXVhO30iCisgICAgICAgICAgdGV4dCBydW4gYXQgKDQwOCwxNSkgd2lkdGggMDogIiAiCiAg ICAgICAgICAgdGV4dCBydW4gYXQgKDAsMzApIHdpZHRoIDQwMDogIi50d28ge3BhZGRpbmctbGVm dDogMjVweDsgYmFja2dyb3VuZC1jb2xvcjogYXF1YTt9IgorICAgICAgICAgIHRleHQgcnVuIGF0 ICg0MDAsMzApIHdpZHRoIDA6ICIgIgogICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDQ1KSB3aWR0 aCA0MDg6ICIudGhyZWUge3BhZGRpbmctbGVmdDogNWVtOyBiYWNrZ3JvdW5kLWNvbG9yOiBhcXVh O30iCisgICAgICAgICAgdGV4dCBydW4gYXQgKDQwOCw0NSkgd2lkdGggMDogIiAiCiAgICAgICAg ICAgdGV4dCBydW4gYXQgKDAsNjApIHdpZHRoIDQwMDogIi5mb3VyIHtwYWRkaW5nLWxlZnQ6IDI1 JTsgYmFja2dyb3VuZC1jb2xvcjogYXF1YTt9IgorICAgICAgICAgIHRleHQgcnVuIGF0ICg0MDAs NjApIHdpZHRoIDA6ICIgIgogICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDc1KSB3aWR0aCA0MTY6 ICIuZml2ZSB7cGFkZGluZy1sZWZ0OiAtMjBweDsgYmFja2dyb3VuZC1jb2xvcjogYXF1YTt9Igor ICAgICAgICAgIHRleHQgcnVuIGF0ICg0MTYsNzUpIHdpZHRoIDA6ICIgIgogICAgICAgUmVuZGVy QmxvY2sge0hSfSBhdCAoMCwxMzcpIHNpemUgNzY5eDIgW2JvcmRlcjogKDFweCBpbnNldCAjMDAw MDAwKV0KICAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwxNTUpIHNpemUgNzY5eDE4IFtiZ2Nv bG9yPSNDMEMwQzBdCiAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDIw M3gxOAo=