207455 2020-02-10 02:04:51 -0800 [GTK][WebInspector] Do not make Web Inspector windows transient 2020-02-10 03:21:44 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez bugs-noreply cgarcia commit-queue hi jonlee timothy zan oldest_to_newest 1616808 0 aperez 2020-02-10 02:04:51 -0800 Currently when popping out the Web Inspector panel into its own top level window, its “transient-for“ property is set to the window that contains the WebKitWebView. This forces the Inspector window to be stacked always on top of the window that contains the web view, making it impossible to bring the window with the web view to the front. This can be an issue in small screens where there is not enough space to comfortable arrange both windows in some way that both can be seen at the same time (e.g. side-by-side). 1616812 1 390237 aperez 2020-02-10 02:18:22 -0800 Created attachment 390237 Patch 1616818 2 commit-queue 2020-02-10 03:21:10 -0800 The commit-queue encountered the following flaky tests while processing attachment 390237: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1616819 3 390237 commit-queue 2020-02-10 03:21:42 -0800 Comment on attachment 390237 Patch Clearing flags on attachment: 390237 Committed r256114: <https://trac.webkit.org/changeset/256114> 1616820 4 commit-queue 2020-02-10 03:21:44 -0800 All reviewed patches have been landed. Closing bug. 390237 2020-02-10 02:18:22 -0800 2020-02-10 03:21:42 -0800 Patch bug-207455-20200210121820.patch text/plain 5517 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFhMmRiMjRhNjY1YWQwNmI0 NWI3NTdlYjhhOTJhZWYyZWZlNjJmODkuLmI1N2ZjYmZhNTJkZTQ2NzZkMWIyYThhMDQ4OGViMTdj ZmJiNzFiZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMjAtMDItMTAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXZWJJ bnNwZWN0b3JdIERvIG5vdCBtYWtlIFdlYiBJbnNwZWN0b3Igd2luZG93cyB0cmFuc2llbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzQ1NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3Agc2V0dGlu ZyBXZWIgSW5zcGVjdG9yIHdpbmRvd3MgYXMgdHJhbnNpZW50IGZvciB0aGUgd2luZG93CisgICAg ICAgIGNvbnRhaW5pbmcgdGhlIHdlYiB2aWV3IGJlaW5nIGluc3BlY3RlZCwgdG8gYWxsb3cgY2hh bmdpbmcgdGhlaXIKKyAgICAgICAgcmVsYXRpdmUgc3RhY2tpbmcgb3JkZXIuIE5vIGNoYW5nZXMg YXJlIG5lZWRlZCBmb3IgaW5zcGVjdG9yIHdpbmRvd3MKKyAgICAgICAgdG8gY29udGludWUgYmVp bmcgZGVzdHJveWVkIGNvcnJlY3RseSB3aGVuIHRoZSBjb3JyZXNwb25kaW5nIHdlYiB2aWV3Cisg ICAgICAgIGlzIGRlc3Ryb3llZCBiZWNhdXNlIGNvZGUgZm9yIGhhbmRsaW5nIHRoYXQgd2FzIGFs cmVhZHkgcHJlc2VudCBpbgorICAgICAgICBXZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0 b3IvZ3RrL1JlbW90ZVdlYkluc3BlY3RvclByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 UmVtb3RlV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRlRnJvbnRlbmRQYWdlQW5kV2lu ZG93KToKKyAgICAgICAgRG8gbm90IHBhc3MgYSBwYXJlbnQgd2luZG93IHBhcmFtZXRlciB0byB3 ZWJraXRJbnNwZWN0b3JXaW5kb3dOZXcoKS4KKyAgICAgICAgKiBVSVByb2Nlc3MvSW5zcGVjdG9y L2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3Bl Y3RvclByb3h5OjpwbGF0Zm9ybUNyZWF0ZUZyb250ZW5kV2luZG93KTogUmVtb3ZlIGNvZGUKKyAg ICAgICAgdG8gb2J0YWluIHRoZSB0b3AgbGV2ZWwgd2luZG93IG9mIHRoZSBXZWJLaXRXZWJWaWV3 LCB3aGljaCBubyBsb25nZXIKKyAgICAgICAgbmVlZHMgYmVpbmcgcGFzc2VkIHRvIHdlYmtpdElu c3BlY3RvcldpbmRvd05ldygpLgorICAgICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0b3IvZ3RrL1dl YktpdEluc3BlY3RvcldpbmRvdy5jcHA6CisgICAgICAgICh3ZWJraXRJbnNwZWN0b3JXaW5kb3dO ZXcpOiBEbyBub3Qgc2V0IHRoZSBHdGtXaW5kb3cudHJhbnNpZW50LWZvcgorICAgICAgICBwcm9w ZXJ0eSBmb3IgdGhlIFdlYiBJbnNwZWN0b3Igd2luZG93LiBSZW1vdmUgdGhlIHBhcmVudCB3aW5k b3cKKyAgICAgICAgcGFyYW1ldGVyLgorICAgICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0b3IvZ3Rr L1dlYktpdEluc3BlY3RvcldpbmRvdy5oOiBSZW1vdmUgdGhlIHBhcmVudAorICAgICAgICB3aW5k b3cgcGFyYW1ldGVyIGZvciB3ZWJraXRJbnNwZWN0b3JXaW5kb3dOZXcoKS4KKwogMjAyMC0wMi0w OSAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVd IEV4cG9zZSBhbGxvd1RvcE5hdmlnYXRpb25Ub0RhdGFVUkwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9ndGsvUmVtb3RlV2ViSW5zcGVjdG9yUHJveHlHdGsu Y3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL2d0ay9SZW1vdGVXZWJJbnNw ZWN0b3JQcm94eUd0ay5jcHAKaW5kZXggMTEwODhkZDA4YjA2MDJkMmU5NGU4NTc5NDYwNGEyMjYy OGNiNDIwNS4uOWRmNTE3OWFkNjkwODZlMDM3NzAzMjc3M2NlNzIwYjZhMGZkY2JjZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL2d0ay9SZW1vdGVXZWJJbnNw ZWN0b3JQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9y L2d0ay9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKQEAgLTcxLDcgKzcxLDcgQEAgV2Vi UGFnZVByb3h5KiBSZW1vdGVXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVGcm9udGVu ZFBhZ2VBbmRXaW5kb3coKQogICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChtX3dlYlZpZXcs ICJkZXN0cm95IiwgR19DQUxMQkFDSyhyZW1vdGVJbnNwZWN0b3JWaWV3RGVzdHJveWVkKSwgdGhp cyk7CiAgICAgZ19vYmplY3RfYWRkX3dlYWtfcG9pbnRlcihHX09CSkVDVChtX3dlYlZpZXcpLCBy ZWludGVycHJldF9jYXN0PHZvaWQqKj4oJm1fd2ViVmlldykpOwogCi0gICAgbV93aW5kb3cgPSB3 ZWJraXRJbnNwZWN0b3JXaW5kb3dOZXcobnVsbHB0cik7CisgICAgbV93aW5kb3cgPSB3ZWJraXRJ bnNwZWN0b3JXaW5kb3dOZXcoKTsKICAgICBndGtfY29udGFpbmVyX2FkZChHVEtfQ09OVEFJTkVS KG1fd2luZG93KSwgbV93ZWJWaWV3KTsKICAgICBndGtfd2lkZ2V0X3Nob3cobV93ZWJWaWV3KTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL2d0ay9XZWJJ bnNwZWN0b3JQcm94eUd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3Iv Z3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcAppbmRleCA4MTdjMzk4NmQzY2FiNDUyZmVlYTM2 OTE1Y2FkMTU4ZDVlZThkNTVkLi5kMjcyN2QwYWUxYTliNThkMGRiZjQzMmRhZDYxYTJhYWU3NDQy NDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvZ3RrL1dl Ykluc3BlY3RvclByb3h5R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNw ZWN0b3IvZ3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcApAQCAtMjYwLDEyICsyNjAsOCBAQCB2 b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNyZWF0ZUZyb250ZW5kV2luZG93KCkKICAg ICBpZiAobV9jbGllbnQgJiYgbV9jbGllbnQtPm9wZW5XaW5kb3coKnRoaXMpKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBHdGtXaWRnZXQqIGluc3BlY3RlZFZpZXdQYXJlbnQgPSBndGtfd2lkZ2V0 X2dldF90b3BsZXZlbChpbnNwZWN0ZWRQYWdlKCktPnZpZXdXaWRnZXQoKSk7Ci0gICAgaWYgKCFX ZWJDb3JlOjp3aWRnZXRJc09uc2NyZWVuVG9wbGV2ZWxXaW5kb3coaW5zcGVjdGVkVmlld1BhcmVu dCkpCi0gICAgICAgIGluc3BlY3RlZFZpZXdQYXJlbnQgPSBudWxscHRyOwotCiAgICAgQVNTRVJU KCFtX2luc3BlY3RvcldpbmRvdyk7Ci0gICAgbV9pbnNwZWN0b3JXaW5kb3cgPSB3ZWJraXRJbnNw ZWN0b3JXaW5kb3dOZXcoaW5zcGVjdGVkVmlld1BhcmVudCA/IEdUS19XSU5ET1coaW5zcGVjdGVk Vmlld1BhcmVudCkgOiBudWxscHRyKTsKKyAgICBtX2luc3BlY3RvcldpbmRvdyA9IHdlYmtpdElu c3BlY3RvcldpbmRvd05ldygpOwogICAgIGd0a19jb250YWluZXJfYWRkKEdUS19DT05UQUlORVIo bV9pbnNwZWN0b3JXaW5kb3cpLCBtX2luc3BlY3RvclZpZXcpOwogICAgIGd0a193aWRnZXRfc2hv dyhtX2luc3BlY3RvclZpZXcpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9JbnNwZWN0b3IvZ3RrL1dlYktpdEluc3BlY3RvcldpbmRvdy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9JbnNwZWN0b3IvZ3RrL1dlYktpdEluc3BlY3RvcldpbmRvdy5jcHAKaW5kZXgg MTQ5MGYwZTZmMzBmODNjYzY3NGFkODc3MTIwZDlhODlhYTc3OTVmZS4uNTUwZDAwM2Y2MTY0MjJm MmQ0MTZiZTllNjNiMzE4Y2I4MWY3NTBhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvSW5zcGVjdG9yL2d0ay9XZWJLaXRJbnNwZWN0b3JXaW5kb3cuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9ndGsvV2ViS2l0SW5zcGVjdG9yV2luZG93LmNw cApAQCAtNTcsOSArNTcsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfaW5zcGVjdG9yX3dpbmRvd19p bml0KFdlYktpdEluc3BlY3RvcldpbmRvdyogd2luZG93KQogICAgIGd0a193aWRnZXRfc2hvdyh3 aW5kb3ctPmhlYWRlckJhcik7CiB9CiAKLUd0a1dpZGdldCogd2Via2l0SW5zcGVjdG9yV2luZG93 TmV3KEd0a1dpbmRvdyogcGFyZW50KQorR3RrV2lkZ2V0KiB3ZWJraXRJbnNwZWN0b3JXaW5kb3dO ZXcoKQogewotICAgIHJldHVybiBHVEtfV0lER0VUKGdfb2JqZWN0X25ldyhXRUJLSVRfVFlQRV9J TlNQRUNUT1JfV0lORE9XLCAidHlwZSIsIEdUS19XSU5ET1dfVE9QTEVWRUwsICJ0cmFuc2llbnQt Zm9yIiwgcGFyZW50LAorICAgIHJldHVybiBHVEtfV0lER0VUKGdfb2JqZWN0X25ldyhXRUJLSVRf VFlQRV9JTlNQRUNUT1JfV0lORE9XLCAidHlwZSIsIEdUS19XSU5ET1dfVE9QTEVWRUwsCiAgICAg ICAgICJkZWZhdWx0LXdpZHRoIiwgV2ViSW5zcGVjdG9yUHJveHk6OmluaXRpYWxXaW5kb3dXaWR0 aCwgImRlZmF1bHQtaGVpZ2h0IiwgV2ViSW5zcGVjdG9yUHJveHk6OmluaXRpYWxXaW5kb3dIZWln aHQsIG51bGxwdHIpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv SW5zcGVjdG9yL2d0ay9XZWJLaXRJbnNwZWN0b3JXaW5kb3cuaCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0luc3BlY3Rvci9ndGsvV2ViS2l0SW5zcGVjdG9yV2luZG93LmgKaW5kZXggZWJkYzI4 ZDEwOWYwNzlmYTI0YTI3ODA5YjJiY2ZmMzlmYmFmY2ZkZi4uMjNkZTMwYmVjYWQ3NmQ4ZGU0NWIx MWYwZjNiNTVlYWRkNWZhYjM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv SW5zcGVjdG9yL2d0ay9XZWJLaXRJbnNwZWN0b3JXaW5kb3cuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9JbnNwZWN0b3IvZ3RrL1dlYktpdEluc3BlY3RvcldpbmRvdy5oCkBAIC00MSw3 ICs0MSw3IEBAIHR5cGVkZWYgc3RydWN0IF9XZWJLaXRJbnNwZWN0b3JXaW5kb3dDbGFzcyBXZWJL aXRJbnNwZWN0b3JXaW5kb3dDbGFzczsKIAogR1R5cGUgd2Via2l0X2luc3BlY3Rvcl93aW5kb3df Z2V0X3R5cGUodm9pZCk7CiAKLUd0a1dpZGdldCogd2Via2l0SW5zcGVjdG9yV2luZG93TmV3KEd0 a1dpbmRvdyogcGFyZW50KTsKK0d0a1dpZGdldCogd2Via2l0SW5zcGVjdG9yV2luZG93TmV3KCk7 CiB2b2lkIHdlYmtpdEluc3BlY3RvcldpbmRvd1NldFN1YnRpdGxlKFdlYktpdEluc3BlY3Rvcldp bmRvdyosIGNvbnN0IGNoYXIqIHN1YnRpdGxlKTsKIAogR19FTkRfREVDTFMK