207449 2020-02-09 20:29:51 -0800 [WK2][Soup] Implement NetworkStorageSession::getAllCookies 2020-02-12 18:14:17 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pfeldman pfeldman aperez berto cgarcia commit-queue ews-watchlist gustavo webkit-bug-importer yurys oldest_to_newest 1616754 0 pfeldman 2020-02-09 20:29:51 -0800 Getting is implemented for GTK/WPE ports. 1616755 1 390228 pfeldman 2020-02-09 20:31:30 -0800 Created attachment 390228 Patch 1616783 2 390228 cgarcia 2020-02-10 00:15:18 -0800 Comment on attachment 390228 Patch This looks good, but it seems to be deadcode for ports using libsoup. Why do you need this? This is only used by cocoa API, I think. 1617576 3 pfeldman 2020-02-11 13:10:27 -0800 Thanks for looking into it. This achieves feature parity with the Cocoa API in terms of raw cookie management. We'd like to be able to manage cookies on the datastore / processpool level over the remote debugging protocol. The harness / web inspector client is not there (yet) and it'll take time, so this does not make any tests green yet. But it looks innocent in terms of adding simple yet functional implementations for those. 1617894 4 390228 cgarcia 2020-02-12 01:13:11 -0800 Comment on attachment 390228 Patch Ok, then. Thanks! 1618351 5 390228 commit-queue 2020-02-12 18:13:16 -0800 Comment on attachment 390228 Patch Clearing flags on attachment: 390228 Committed r256496: <https://trac.webkit.org/changeset/256496> 1618352 6 commit-queue 2020-02-12 18:13:18 -0800 All reviewed patches have been landed. Closing bug. 1618353 7 webkit-bug-importer 2020-02-12 18:14:17 -0800 <rdar://problem/59409694> 390228 2020-02-09 20:31:30 -0800 2020-02-12 18:13:16 -0800 Patch bug-207449-20200209203130.patch text/plain 1789 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY1YWYyM2QyZTU4NThh MmZkM2NiZjM3NDg1M2FiOGEzMWRiZWM2Ni4uOTM0ZDE4OWFlZGM5ZmI4ZDI5NTBlZTExMzQ5YzM2 NTIwNjdmNGZjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAyLTA5ICBQYXZl bCBGZWxkbWFuICA8cGF2ZWwuZmVsZG1hbkBnbWFpbC5jb20+CisKKyAgICAgICAgW1dLMl1bU291 cF0gSW1wbGVtZW50IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6Z2V0QWxsQ29va2llcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NDQ5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU291cC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpOZXR3b3JrU3RvcmFnZVNlc3Npb246OmdldEFsbENvb2tpZXMpOgorCiAyMDIwLTAyLTA3ICBT YW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHRyaXZpYWwgZGVm aW5pdGlvbnMgZnJvbSBGZWF0dXJlRGVmaW5lcy54Y2NvbmZpZyB0byBQbGF0Zm9ybUVuYWJsZUNv Y29hLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9O ZXR3b3JrU3RvcmFnZVNlc3Npb25Tb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvc291cC9OZXR3b3JrU3RvcmFnZVNlc3Npb25Tb3VwLmNwcAppbmRleCAzZWU3N2VjNWY3 NTk4NTdjNjc0Mjc4MGU4NjAyNjk0ZWMxYmE5ODQ3Li5jNGYwOWU2YWI5ZjViZjIwNWJjN2M0MGNj NTlkMDE2ZGNiYTc4MGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL05ldHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3BwCkBA IC00MTMsOCArNDEzLDEzIEBAIHZvaWQgTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpnZXRIb3N0bmFt ZXNXaXRoQ29va2llcyhIYXNoU2V0PFN0cmluZz4mIGhvc3RuYW1lcykKIAogVmVjdG9yPENvb2tp ZT4gTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpnZXRBbGxDb29raWVzKCkKIHsKLSAgICAvLyBGSVhN RTogSW1wbGVtZW50IGZvciBXSzIgdG8gdXNlLgotICAgIHJldHVybiB7IH07CisgICAgVmVjdG9y PENvb2tpZT4gY29va2llczsKKyAgICBHVW5pcXVlUHRyPEdTTGlzdD4gY29va2llc0xpc3Qoc291 cF9jb29raWVfamFyX2FsbF9jb29raWVzKGNvb2tpZVN0b3JhZ2UoKSkpOworICAgIGZvciAoR1NM aXN0KiBpdGVtID0gY29va2llc0xpc3QuZ2V0KCk7IGl0ZW07IGl0ZW0gPSBnX3NsaXN0X25leHQo aXRlbSkpIHsKKyAgICAgICAgR1VuaXF1ZVB0cjxTb3VwQ29va2llPiBzb3VwQ29va2llKHN0YXRp Y19jYXN0PFNvdXBDb29raWUqPihpdGVtLT5kYXRhKSk7CisgICAgICAgIGNvb2tpZXMuYXBwZW5k KFdlYkNvcmU6OkNvb2tpZShzb3VwQ29va2llLmdldCgpKSk7CisgICAgfQorICAgIHJldHVybiBj b29raWVzOwogfQogCiBWZWN0b3I8Q29va2llPiBOZXR3b3JrU3RvcmFnZVNlc3Npb246OmdldENv b2tpZXMoY29uc3QgVVJMJiB1cmwpCg==