207445 2020-02-09 15:49:31 -0800 [LFC][BFC] Move updatePositiveNegativeMarginValues out of MarginCollapse class 2020-02-09 17:34:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1616712 0 zalan 2020-02-09 15:49:31 -0800 so that it does not need all the state and context. 1616713 1 webkit-bug-importer 2020-02-09 15:49:50 -0800 <rdar://problem/59297879> 1616714 2 390216 zalan 2020-02-09 15:53:32 -0800 Created attachment 390216 Patch 1616725 3 commit-queue 2020-02-09 17:33:41 -0800 The commit-queue encountered the following flaky tests while processing attachment 390216: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1616726 4 390216 commit-queue 2020-02-09 17:34:15 -0800 Comment on attachment 390216 Patch Clearing flags on attachment: 390216 Committed r256106: <https://trac.webkit.org/changeset/256106> 1616727 5 commit-queue 2020-02-09 17:34:16 -0800 All reviewed patches have been landed. Closing bug. 390216 2020-02-09 15:53:32 -0800 2020-02-09 17:34:15 -0800 Patch bug-207445-20200209155331.patch text/plain 5918 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGExMDNiNjU1OGE1NmU4 MDBhZmY0N2U4MmYyZDNlZDc4YWEyMjljNy4uMjhlMmFjOGUyN2RhZWQwZWJjMDkyNDRjZWM3NjY1 MGYwMmVjZThmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAyLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBNb3ZlIHVw ZGF0ZVBvc2l0aXZlTmVnYXRpdmVNYXJnaW5WYWx1ZXMgb3V0IG9mIE1hcmdpbkNvbGxhcHNlIGNs YXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc0 NDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5Mjk3ODc5PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hcmdpbkNvbGxhcHNlOjp1cGRhdGVQb3Np dGl2ZU5lZ2F0aXZlTWFyZ2luVmFsdWVzIGlzIGp1c3QgYSBzdGF0aWMgaGVscGVyLgorICAgICAg ICBMZXQncyBzcGxpdCB0aGlzIGZ1bmN0aW9uIHNvIHRoYXQgaXQgY2FuIGJlIGp1c3QgYSByZWd1 bGFyIG1lbWJlciBmdW5jdGlvbiAobW92ZSB0aGUgc3RhdGUgdXBkYXRpbmcgdG8gdGhlIEJsb2Nr Rm9ybWF0dGluZ0NvbnRleHQgY2FsbGVyKS4KKworICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1h dHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVIZWlnaHRBbmRNYXJnaW4pOgorICAg ICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5oOgor ICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Ok1hcmdp bkNvbGxhcHNlOjpyZXNvbHZlZFBvc2l0aXZlTmVnYXRpdmVNYXJnaW5WYWx1ZXMpOgorICAgICAg ICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpNYXJnaW5Db2xsYXBz ZTo6dXBkYXRlUG9zaXRpdmVOZWdhdGl2ZU1hcmdpblZhbHVlcyk6IERlbGV0ZWQuCisKIDIwMjAt MDItMDggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtC RkNdIFJlcGxhY2UgImVzdGltYXRlZCIgdGVybSB3aXRoICJwcmVjb21wdXRlZCIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5n Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2Nr Rm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IDM2MmRhNDA1ZGIwOGZmNTQ0MjZmODBlZWY1MTIw MDQ3MDZlNjU1MzEuLjRjYmEwMDQ3YTA5MDc5MzM0M2RhODRhZmU5OTZjZmM5MDZiZmE0YTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3Jt YXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0 dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcApAQCAtNDMwLDcgKzQzMCw3IEBAIHZvaWQg QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZUhlaWdodEFuZE1hcmdpbihjb25zdCBCb3gm IGxheW91dEJveCwgY29uc3QKICAgICBkaXNwbGF5Qm94LnNldFZlcnRpY2FsTWFyZ2luKHZlcnRp Y2FsTWFyZ2luKTsKIAogICAgIGF1dG8gbWFyZ2luQ29sbGFwc2UgPSB0aGlzLT5tYXJnaW5Db2xs YXBzZSgpOwotICAgIE1hcmdpbkNvbGxhcHNlOjp1cGRhdGVQb3NpdGl2ZU5lZ2F0aXZlTWFyZ2lu VmFsdWVzKCp0aGlzLCBtYXJnaW5Db2xsYXBzZSwgbGF5b3V0Qm94KTsKKyAgICBmb3JtYXR0aW5n U3RhdGUoKS5zZXRQb3NpdGl2ZUFuZE5lZ2F0aXZlVmVydGljYWxNYXJnaW4obGF5b3V0Qm94LCBt YXJnaW5Db2xsYXBzZS5yZXNvbHZlZFBvc2l0aXZlTmVnYXRpdmVNYXJnaW5WYWx1ZXMobGF5b3V0 Qm94LCBjb250ZW50SGVpZ2h0QW5kTWFyZ2luLm5vbkNvbGxhcHNlZE1hcmdpbikpOwogICAgIC8v IEFkanVzdCB0aGUgcHJldmlvdXMgc2libGluZydzIG1hcmdpbiBib3R0b20gbm93IHRoYXQgdGhp cyBib3gncyB2ZXJ0aWNhbCBtYXJnaW4gaXMgY29tcHV0ZWQuCiAgICAgTWFyZ2luQ29sbGFwc2U6 OnVwZGF0ZU1hcmdpbkFmdGVyRm9yUHJldmlvdXNTaWJsaW5nKCp0aGlzLCBtYXJnaW5Db2xsYXBz ZSwgbGF5b3V0Qm94KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9j a2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmgKaW5kZXggZjQ0NjVl OTZhOTUyZjQ1YTA2MmMzY2FlNjQ2NjMxMGQxMjY2MTg2ZC4uNzlkNjg2N2NhMjIzY2U2NjE4NTIy ZTIzYTBkYjEyNGRkYzlmNzQ0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Js b2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmgKQEAgLTEw Nyw3ICsxMDcsNyBAQCBwcml2YXRlOgogICAgICAgICBQcmVjb21wdXRlZE1hcmdpbkJlZm9yZSBw cmVjb21wdXRlZE1hcmdpbkJlZm9yZShjb25zdCBCb3gmLCBVc2VkVmVydGljYWxNYXJnaW46Ok5v bkNvbGxhcHNlZFZhbHVlcyk7CiAgICAgICAgIExheW91dFVuaXQgbWFyZ2luQmVmb3JlSWdub3Jp bmdDb2xsYXBzaW5nVGhyb3VnaChjb25zdCBCb3gmLCBVc2VkVmVydGljYWxNYXJnaW46Ok5vbkNv bGxhcHNlZFZhbHVlcyk7CiAgICAgICAgIHN0YXRpYyB2b2lkIHVwZGF0ZU1hcmdpbkFmdGVyRm9y UHJldmlvdXNTaWJsaW5nKEJsb2NrRm9ybWF0dGluZ0NvbnRleHQmLCBjb25zdCBNYXJnaW5Db2xs YXBzZSYsIGNvbnN0IEJveCYpOwotICAgICAgICBzdGF0aWMgdm9pZCB1cGRhdGVQb3NpdGl2ZU5l Z2F0aXZlTWFyZ2luVmFsdWVzKEJsb2NrRm9ybWF0dGluZ0NvbnRleHQmLCBjb25zdCBNYXJnaW5D b2xsYXBzZSYsIGNvbnN0IEJveCYpOworICAgICAgICBQb3NpdGl2ZUFuZE5lZ2F0aXZlVmVydGlj YWxNYXJnaW4gcmVzb2x2ZWRQb3NpdGl2ZU5lZ2F0aXZlTWFyZ2luVmFsdWVzKGNvbnN0IEJveCYs IGNvbnN0IFVzZWRWZXJ0aWNhbE1hcmdpbjo6Tm9uQ29sbGFwc2VkVmFsdWVzJik7CiAKICAgICAg ICAgYm9vbCBtYXJnaW5CZWZvcmVDb2xsYXBzZXNXaXRoUGFyZW50TWFyZ2luQmVmb3JlKGNvbnN0 IEJveCYpIGNvbnN0OwogICAgICAgICBib29sIG1hcmdpbkJlZm9yZUNvbGxhcHNlc1dpdGhGaXJz dEluRmxvd0NoaWxkTWFyZ2luQmVmb3JlKGNvbnN0IEJveCYpIGNvbnN0OwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5D b2xsYXBzZS5jcHAKaW5kZXggMzNlZTc4OWY2ZTFkYjMzMjc3NTUwMTFiNjQ2OTYzMGEzOTA3YmM1 ZS4uZWVmMzg4ODMzM2YzMTk4MjgyOTRiYmI4ZTc2ODA5MzE2NDY4YjE0OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFy Z2luQ29sbGFwc2UuY3BwCkBAIC01OTMsMTkgKzU5MywxNyBAQCBMYXlvdXRVbml0IEJsb2NrRm9y bWF0dGluZ0NvbnRleHQ6Ok1hcmdpbkNvbGxhcHNlOjptYXJnaW5CZWZvcmVJZ25vcmluZ0NvbGxh cHNpbgogICAgIHJldHVybiBtYXJnaW5WYWx1ZShwb3NpdGl2ZU5lZ2F0aXZlTWFyZ2luQmVmb3Jl KGxheW91dEJveCwgbm9uQ29sbGFwc2VkVmFsdWVzKSkudmFsdWVPcihub25Db2xsYXBzZWRWYWx1 ZXMuYmVmb3JlKTsKIH0KIAotdm9pZCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpNYXJnaW5Db2xs YXBzZTo6dXBkYXRlUG9zaXRpdmVOZWdhdGl2ZU1hcmdpblZhbHVlcyhCbG9ja0Zvcm1hdHRpbmdD b250ZXh0JiBibG9ja0Zvcm1hdHRpbmdDb250ZXh0LCBjb25zdCBNYXJnaW5Db2xsYXBzZSYgbWFy Z2luQ29sbGFwc2UsIGNvbnN0IEJveCYgbGF5b3V0Qm94KQorUG9zaXRpdmVBbmROZWdhdGl2ZVZl cnRpY2FsTWFyZ2luIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Ok1hcmdpbkNvbGxhcHNlOjpyZXNv bHZlZFBvc2l0aXZlTmVnYXRpdmVNYXJnaW5WYWx1ZXMoY29uc3QgQm94JiBsYXlvdXRCb3gsIGNv bnN0IFVzZWRWZXJ0aWNhbE1hcmdpbjo6Tm9uQ29sbGFwc2VkVmFsdWVzJiBub25Db2xsYXBzZWRW YWx1ZXMpCiB7CiAgICAgQVNTRVJUKGxheW91dEJveC5pc0Jsb2NrTGV2ZWxCb3goKSk7Ci0gICAg YXV0byBub25Db2xsYXBzZWRWYWx1ZXMgPSBibG9ja0Zvcm1hdHRpbmdDb250ZXh0Lmdlb21ldHJ5 Rm9yQm94KGxheW91dEJveCkudmVydGljYWxNYXJnaW4oKS5ub25Db2xsYXBzZWRWYWx1ZXMoKTsK LQotICAgIGF1dG8gcG9zaXRpdmVOZWdhdGl2ZU1hcmdpbkJlZm9yZSA9IG1hcmdpbkNvbGxhcHNl LnBvc2l0aXZlTmVnYXRpdmVNYXJnaW5CZWZvcmUobGF5b3V0Qm94LCBub25Db2xsYXBzZWRWYWx1 ZXMpOwotICAgIGF1dG8gcG9zaXRpdmVOZWdhdGl2ZU1hcmdpbkFmdGVyID0gbWFyZ2luQ29sbGFw c2UucG9zaXRpdmVOZWdhdGl2ZU1hcmdpbkFmdGVyKGxheW91dEJveCwgbm9uQ29sbGFwc2VkVmFs dWVzKTsKKyAgICBhdXRvIHBvc2l0aXZlTmVnYXRpdmVNYXJnaW5CZWZvcmUgPSB0aGlzLT5wb3Np dGl2ZU5lZ2F0aXZlTWFyZ2luQmVmb3JlKGxheW91dEJveCwgbm9uQ29sbGFwc2VkVmFsdWVzKTsK KyAgICBhdXRvIHBvc2l0aXZlTmVnYXRpdmVNYXJnaW5BZnRlciA9IHRoaXMtPnBvc2l0aXZlTmVn YXRpdmVNYXJnaW5BZnRlcihsYXlvdXRCb3gsIG5vbkNvbGxhcHNlZFZhbHVlcyk7CiAKLSAgICBp ZiAobWFyZ2luQ29sbGFwc2UubWFyZ2luc0NvbGxhcHNlVGhyb3VnaChsYXlvdXRCb3gpKSB7Cisg ICAgaWYgKG1hcmdpbnNDb2xsYXBzZVRocm91Z2gobGF5b3V0Qm94KSkgewogICAgICAgICBwb3Np dGl2ZU5lZ2F0aXZlTWFyZ2luQmVmb3JlID0gY29tcHV0ZWRQb3NpdGl2ZUFuZE5lZ2F0aXZlTWFy Z2luKHBvc2l0aXZlTmVnYXRpdmVNYXJnaW5CZWZvcmUsIHBvc2l0aXZlTmVnYXRpdmVNYXJnaW5B ZnRlcik7CiAgICAgICAgIHBvc2l0aXZlTmVnYXRpdmVNYXJnaW5BZnRlciA9IHBvc2l0aXZlTmVn YXRpdmVNYXJnaW5CZWZvcmU7CiAgICAgfQotICAgIGJsb2NrRm9ybWF0dGluZ0NvbnRleHQuZm9y bWF0dGluZ1N0YXRlKCkuc2V0UG9zaXRpdmVBbmROZWdhdGl2ZVZlcnRpY2FsTWFyZ2luKGxheW91 dEJveCwgeyBwb3NpdGl2ZU5lZ2F0aXZlTWFyZ2luQmVmb3JlLCBwb3NpdGl2ZU5lZ2F0aXZlTWFy Z2luQWZ0ZXIgfSk7CisgICAgcmV0dXJuIHsgcG9zaXRpdmVOZWdhdGl2ZU1hcmdpbkJlZm9yZSwg cG9zaXRpdmVOZWdhdGl2ZU1hcmdpbkFmdGVyIH07CiB9CiAKIFVzZWRWZXJ0aWNhbE1hcmdpbjo6 Q29sbGFwc2VkVmFsdWVzIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Ok1hcmdpbkNvbGxhcHNlOjpj b2xsYXBzZWRWZXJ0aWNhbFZhbHVlcyhjb25zdCBCb3gmIGxheW91dEJveCwgVXNlZFZlcnRpY2Fs TWFyZ2luOjpOb25Db2xsYXBzZWRWYWx1ZXMgbm9uQ29sbGFwc2VkVmFsdWVzKQo=