207441 2020-02-09 10:51:49 -0800 Remove setHTTPAccept call for main resources 2020-06-25 16:55:11 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 213626 1 rbuis rbuis achristensen beidson cdumez commit-queue darin dbates ews-watchlist japhet webkit-bug-importer oldest_to_newest 1616682 0 rbuis 2020-02-09 10:51:49 -0800 Remove setHTTPAccept call for main resources since all main resource loading goes through CachedResourceLoader, which sets the Accept header as specified in: https://fetch.spec.whatwg.org/#fetching (Step 1.3). 1616683 1 390208 rbuis 2020-02-09 10:54:57 -0800 Created attachment 390208 Patch 1616745 2 390208 darin 2020-02-09 19:59:58 -0800 Comment on attachment 390208 Patch This leaves us with the ResourceRequestBase::httpAccept(), ResourceRequestBase::setHTTPAccept() and ResourceRequestBase::clearHTTPAccept() functions in ResourceRequestBase all unused. Lets remove those functions. 1616746 3 390208 darin 2020-02-09 20:00:35 -0800 Comment on attachment 390208 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390208&action=review > Source/WebCore/ChangeLog:12 > + No test since no change in behavior. It would be worth pointing out which tests check the accept header for main resource loads, since those are the tests that prove there is no change in behavior. 1616786 4 390235 rbuis 2020-02-10 00:29:17 -0800 Created attachment 390235 Patch 1616837 5 390235 commit-queue 2020-02-10 06:01:24 -0800 Comment on attachment 390235 Patch Clearing flags on attachment: 390235 Committed r256166: <https://trac.webkit.org/changeset/256166> 1616838 6 commit-queue 2020-02-10 06:01:26 -0800 All reviewed patches have been landed. Closing bug. 1616839 7 webkit-bug-importer 2020-02-10 06:02:15 -0800 <rdar://problem/59308698> 1666275 8 achristensen 2020-06-25 16:37:36 -0700 This broke our API. See https://bugs.webkit.org/show_bug.cgi?id=213626 390208 2020-02-09 10:54:57 -0800 2020-02-10 00:29:13 -0800 Patch bug-207441-20200209195455.patch text/plain 1858 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU2MzgwMWRkMjJiY2Y4 ZTcyNDljOTRjNDdlNDE3Y2JiMTA4NmRjZi4uNmM3MmE3ZmY1OGE3ZmZlNmQ4MzJlZTUzMjRhZmFh MTQyMzg1M2M1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAyLTA5ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNldEhUVFBBY2NlcHQg Y2FsbCBmb3IgbWFpbiByZXNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzQ0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbW92ZSBzZXRIVFRQQWNjZXB0IGNhbGwgZm9yIG1haW4gcmVzb3Vy Y2VzIHNpbmNlIGFsbCBtYWluIHJlc291cmNlIGxvYWRpbmcgZ29lcworICAgICAgICB0aHJvdWdo IENhY2hlZFJlc291cmNlTG9hZGVyLCB3aGljaCBzZXRzIHRoZSBBY2NlcHQgaGVhZGVyIGFzIHNw ZWNpZmllZCBpbjoKKyAgICAgICAgaHR0cHM6Ly9mZXRjaC5zcGVjLndoYXR3Zy5vcmcvI2ZldGNo aW5nIChTdGVwIDEuMykuCisKKyAgICAgICAgTm8gdGVzdCBzaW5jZSBubyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVMb2FkZXI6OmFkZEV4dHJhRmllbGRzVG9SZXF1ZXN0KToKKwogMjAyMC0wMi0w OCAgRG91ZyBLZWxseSAgPGRvdWdrQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBSZW5k ZXJUcmVlQnVpbGRlcjo6VGFibGU6OmZpbmRPckNyZWF0ZVBhcmVudEZvckNoaWxkIHdpdGggbXVs dGljb2wgc3Bhbm5lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggNGVl Y2NkYzI4YWQ4ZDFmOWNiZjBmZThlZTYzYjBiN2YwNzdkZDRjMi4uOGNmOWM1YzQ3Y2VhM2FkMjdm MjgyYjVkNzNjZmQ1ZDZlM2U3ODM0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCkBAIC0xNjEsOCArMTYxLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogdXNpbmcgbmFtZXNw YWNlIEhUTUxOYW1lczsKIHVzaW5nIG5hbWVzcGFjZSBTVkdOYW1lczsKIAotc3RhdGljIGNvbnN0 IGNoYXIgZGVmYXVsdEFjY2VwdEhlYWRlcltdID0gInRleHQvaHRtbCxhcHBsaWNhdGlvbi94aHRt bCt4bWwsYXBwbGljYXRpb24veG1sO3E9MC45LCovKjtxPTAuOCI7Ci0KIGJvb2wgaXNCYWNrRm9y d2FyZExvYWRUeXBlKEZyYW1lTG9hZFR5cGUgdHlwZSkKIHsKICAgICBzd2l0Y2ggKHR5cGUpIHsK QEAgLTI5NjgsOSArMjk2Niw2IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmFkZEV4dHJhRmllbGRzVG9S ZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgRnJhbWVMb2FkVHlwCiAKICAgICBhcHBs eVVzZXJBZ2VudElmTmVlZGVkKHJlcXVlc3QpOwogCi0gICAgaWYgKGlzTWFpblJlc291cmNlKQot ICAgICAgICByZXF1ZXN0LnNldEhUVFBBY2NlcHQoZGVmYXVsdEFjY2VwdEhlYWRlcik7Ci0KICAg ICAvLyBNYWtlIHN1cmUgd2Ugc2VuZCB0aGUgT3JpZ2luIGhlYWRlci4KICAgICBhZGRIVFRQT3Jp Z2luSWZOZWVkZWQocmVxdWVzdCwgU3RyaW5nKCkpOwogCg== 390235 2020-02-10 00:29:17 -0800 2020-02-10 06:01:24 -0800 Patch bug-207441-20200210092915.patch text/plain 3906 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE1YjczMWNiZWE5ZmUz ZGQ4MWM4NWQ0MzNkY2Q2ZDNiYzhlOGRmZi4uMmE3MTI1M2JlYjFjN2JkYjI5Y2E5MDhhMDlkZjcy M2JmMmIwMGEyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTAyLTEwICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNldEhUVFBBY2NlcHQg Y2FsbCBmb3IgbWFpbiByZXNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzQ0MQorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgIFJlbW92ZSBzZXRIVFRQQWNjZXB0IGNhbGwgZm9yIG1haW4gcmVzb3VyY2Vz IHNpbmNlIGFsbCBtYWluIHJlc291cmNlIGxvYWRpbmcgZ29lcworICAgICAgICB0aHJvdWdoIENh Y2hlZFJlc291cmNlTG9hZGVyLCB3aGljaCBzZXRzIHRoZSBBY2NlcHQgaGVhZGVyIGFzIHNwZWNp ZmllZCBpbjoKKyAgICAgICAgaHR0cHM6Ly9mZXRjaC5zcGVjLndoYXR3Zy5vcmcvI2ZldGNoaW5n IChTdGVwIDEuMykuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhbHNvIHJlbW92ZWQgdW51c2VkIEFj Y2VwdCBoZWFkZXIgcmVsYXRlZCBmdW5jdGlvbmFsaXR5CisgICAgICAgIGluIFJlc291cmNlUmVx dWVzdC4KKworICAgICAgICBObyB0ZXN0IHNpbmNlIG5vIGNoYW5nZSBpbiBiZWhhdmlvciwgdGVz dGVkIGJ5IGh0dHAvdGVzdHMvbWlzYy94aHRtbC5waHAuCisKKyAgICAgICAgKiBsb2FkZXIvRnJh bWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmFkZEV4dHJhRmll bGRzVG9SZXF1ZXN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVz dEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0QmFzZTo6aHR0cEFj Y2VwdCBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3RC YXNlOjpzZXRIVFRQQWNjZXB0KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNl UmVxdWVzdEJhc2U6OmNsZWFySFRUUEFjY2VwdCk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZv cm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmg6CisKIDIwMjAtMDItMDkgIEJhc3VrZSBT dXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgogCiAgICAgICAgIFJlcGxhY2UgcmVkdW5k YW50IGZ1bmN0aW9ucyB3aXRoIHZhcmlhZGljIHRlbXBsYXRlIGZ1bmN0aW9uLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggNGVlY2NkYzI4YWQ4ZDFmOWNiZjBmZThlZTYz YjBiN2YwNzdkZDRjMi4uOGNmOWM1YzQ3Y2VhM2FkMjdmMjgyYjVkNzNjZmQ1ZDZlM2U3ODM0YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0xNjEsOCArMTYxLDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIHVzaW5nIG5h bWVzcGFjZSBTVkdOYW1lczsKIAotc3RhdGljIGNvbnN0IGNoYXIgZGVmYXVsdEFjY2VwdEhlYWRl cltdID0gInRleHQvaHRtbCxhcHBsaWNhdGlvbi94aHRtbCt4bWwsYXBwbGljYXRpb24veG1sO3E9 MC45LCovKjtxPTAuOCI7Ci0KIGJvb2wgaXNCYWNrRm9yd2FyZExvYWRUeXBlKEZyYW1lTG9hZFR5 cGUgdHlwZSkKIHsKICAgICBzd2l0Y2ggKHR5cGUpIHsKQEAgLTI5NjgsOSArMjk2Niw2IEBAIHZv aWQgRnJhbWVMb2FkZXI6OmFkZEV4dHJhRmllbGRzVG9SZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYg cmVxdWVzdCwgRnJhbWVMb2FkVHlwCiAKICAgICBhcHBseVVzZXJBZ2VudElmTmVlZGVkKHJlcXVl c3QpOwogCi0gICAgaWYgKGlzTWFpblJlc291cmNlKQotICAgICAgICByZXF1ZXN0LnNldEhUVFBB Y2NlcHQoZGVmYXVsdEFjY2VwdEhlYWRlcik7Ci0KICAgICAvLyBNYWtlIHN1cmUgd2Ugc2VuZCB0 aGUgT3JpZ2luIGhlYWRlci4KICAgICBhZGRIVFRQT3JpZ2luSWZOZWVkZWQocmVxdWVzdCwgU3Ry aW5nKCkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jl c291cmNlUmVxdWVzdEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9S ZXNvdXJjZVJlcXVlc3RCYXNlLmNwcAppbmRleCA2MGZjOTQ1M2ZhMzgxMWM2MGVhOTgzYzQzODM1 ZGM1Y2NmMDQxYWZkLi5kMjliZTAwYTNkNzQ5NDQ4MzhiZjgzMzFiZWY2MTIxZDlhMDA5MzMxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVz dEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VS ZXF1ZXN0QmFzZS5jcHAKQEAgLTQ0NiwyNSArNDQ2LDYgQEAgdm9pZCBSZXNvdXJjZVJlcXVlc3RC YXNlOjpjbGVhckhUVFBVc2VyQWdlbnQoKQogICAgIG1fcGxhdGZvcm1SZXF1ZXN0VXBkYXRlZCA9 IGZhbHNlOwogfQogCi1TdHJpbmcgUmVzb3VyY2VSZXF1ZXN0QmFzZTo6aHR0cEFjY2VwdCgpIGNv bnN0Ci17Ci0gICAgcmV0dXJuIGh0dHBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6QWNjZXB0 KTsKLX0KLQotdm9pZCBSZXNvdXJjZVJlcXVlc3RCYXNlOjpzZXRIVFRQQWNjZXB0KGNvbnN0IFN0 cmluZyYgaHR0cEFjY2VwdCkKLXsKLSAgICBzZXRIVFRQSGVhZGVyRmllbGQoSFRUUEhlYWRlck5h bWU6OkFjY2VwdCwgaHR0cEFjY2VwdCk7Ci19Ci0KLXZvaWQgUmVzb3VyY2VSZXF1ZXN0QmFzZTo6 Y2xlYXJIVFRQQWNjZXB0KCkKLXsKLSAgICB1cGRhdGVSZXNvdXJjZVJlcXVlc3QoKTsgCi0KLSAg ICBtX2h0dHBIZWFkZXJGaWVsZHMucmVtb3ZlKEhUVFBIZWFkZXJOYW1lOjpBY2NlcHQpOwotCi0g ICAgbV9wbGF0Zm9ybVJlcXVlc3RVcGRhdGVkID0gZmFsc2U7Ci19Ci0KIHZvaWQgUmVzb3VyY2VS ZXF1ZXN0QmFzZTo6Y2xlYXJIVFRQQWNjZXB0RW5jb2RpbmcoKQogewogICAgIHVwZGF0ZVJlc291 cmNlUmVxdWVzdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9SZXNvdXJjZVJlcXVlc3RCYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L1Jlc291cmNlUmVxdWVzdEJhc2UuaAppbmRleCBlMTJmNTU0ZjgzYWExYWM4MzFhOWNhMjNiMmY4 YWY3OTVmYWZiZWU3Li4wOWZiZDQ5NDFiMGJkZjljOGFiM2Y3NWYzMDIwODZiNmMzNjg0OGY4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVz dEJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVx dWVzdEJhc2UuaApAQCAtMTM1LDEwICsxMzUsNiBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBP UlQgdm9pZCBzZXRIVFRQVXNlckFnZW50KGNvbnN0IFN0cmluZyYpOwogICAgIHZvaWQgY2xlYXJI VFRQVXNlckFnZW50KCk7CiAKLSAgICBTdHJpbmcgaHR0cEFjY2VwdCgpIGNvbnN0OwotICAgIHZv aWQgc2V0SFRUUEFjY2VwdChjb25zdCBTdHJpbmcmKTsKLSAgICB2b2lkIGNsZWFySFRUUEFjY2Vw dCgpOwotCiAgICAgdm9pZCBjbGVhckhUVFBBY2NlcHRFbmNvZGluZygpOwogCiAgICAgV0VCQ09S RV9FWFBPUlQgdm9pZCBjbGVhclB1cnBvc2UoKTsK