207431 2020-02-08 12:30:09 -0800 [LFC][BFC] Remove establishesBlockFormattingContextOnly and establishesInlineFormattingContextOnly 2020-02-08 18:51:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1616577 0 zalan 2020-02-08 12:30:09 -0800 We don't really need them. 1616578 1 webkit-bug-importer 2020-02-08 12:30:28 -0800 <rdar://problem/59288366> 1616581 2 390177 zalan 2020-02-08 12:54:45 -0800 Created attachment 390177 Patch 1616644 3 390177 commit-queue 2020-02-08 18:51:50 -0800 Comment on attachment 390177 Patch Clearing flags on attachment: 390177 Committed r256098: <https://trac.webkit.org/changeset/256098> 1616645 4 commit-queue 2020-02-08 18:51:52 -0800 All reviewed patches have been landed. Closing bug. 390177 2020-02-08 12:54:45 -0800 2020-02-08 18:51:50 -0800 Patch bug-207431-20200208125444.patch text/plain 5735 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZmM2U4MmVhZWFmYjhk ODdjMjQyMzkyNDE2OTAxMDI2YjAzYWM2My4uOWNhMGNmMDg1YjAzNmM2YzEwNGI1YTk1YzNhZTQw ZDE5MTRkZTE0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAyLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBSZW1vdmUg ZXN0YWJsaXNoZXNCbG9ja0Zvcm1hdHRpbmdDb250ZXh0T25seSBhbmQgZXN0YWJsaXNoZXNJbmxp bmVGb3JtYXR0aW5nQ29udGV4dE9ubHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzQzMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkyODgzNjY+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1 cnJlbnQgY2FsbGVyIG9mIGVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGluZ0NvbnRleHRPbmx5IGlz IGFjdHVhbGx5IGludGVyZXN0ZWQgaW4gd2hldGhlciB0aGUgYm94IGlzIGZsb2F0IGF2b2lkZXIK KyAgICAgICAgKGFuZCB0aGUgZGVidWctb25seSBjYWxsZXIgb2YgZXN0YWJsaXNoZXNCbG9ja0Zv cm1hdHRpbmdDb250ZXh0T25seSBzaG91bGQgaW5zdGVhZCBjaGVjayBpZiB0aGUgYm94IGFsc28g ZXN0YWJsaXNoZXMgYW4gSUZDKS4KKworICAgICAgICAqIGxheW91dC9MYXlvdXRDb250ZXh0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGF5b3V0Q29udGV4dDo6Y3JlYXRlRm9ybWF0 dGluZ0NvbnRleHQpOgorICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3Jt YXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0 dGluZ0NvbnRleHQ6OmNvbXB1dGVFc3RpbWF0ZWRWZXJ0aWNhbFBvc2l0aW9uRm9yRm9ybWF0dGlu Z1Jvb3QpOgorICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJveDo6ZXN0YWJsaXNoZXNJbmxpbmVGb3JtYXR0aW5nQ29u dGV4dE9ubHkgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCb3g6 OmVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dE9ubHkgY29uc3QpOiBEZWxldGVkLgor ICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oOgorCiAyMDIwLTAyLTA4ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXSBBZGp1 c3QgQm94Ojppc0Zsb2F0QXZvaWRlcigpIGZvciBJbmxpbmUgYW5kIEluZGVwZW5kZW50IEZDcy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRDb250ZXh0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRDb250ZXh0LmNwcAppbmRleCAzMjdhODU0YTU4NmFj YjUyMzU4ZTFlZWZjYWZiMmQzZjYyN2Y0MzhmLi4xN2UzZDIwMDhiNmRkODFhOTczMDM2YzhlMGI4 YjRlZTY3ZmEwY2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0Q29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dENvbnRleHQuY3BwCkBA IC0xMTgsNyArMTE4LDcgQEAgc3RkOjp1bmlxdWVfcHRyPEZvcm1hdHRpbmdDb250ZXh0PiBMYXlv dXRDb250ZXh0OjpjcmVhdGVGb3JtYXR0aW5nQ29udGV4dChjb25zdAogICAgIH0KIAogICAgIGlm IChmb3JtYXR0aW5nQ29udGV4dFJvb3QuZXN0YWJsaXNoZXNCbG9ja0Zvcm1hdHRpbmdDb250ZXh0 KCkpIHsKLSAgICAgICAgQVNTRVJUKGZvcm1hdHRpbmdDb250ZXh0Um9vdC5lc3RhYmxpc2hlc0Js b2NrRm9ybWF0dGluZ0NvbnRleHRPbmx5KCkpOworICAgICAgICBBU1NFUlQoIWZvcm1hdHRpbmdD b250ZXh0Um9vdC5lc3RhYmxpc2hlc0lubGluZUZvcm1hdHRpbmdDb250ZXh0KCkpOwogICAgICAg ICBhdXRvJiBibG9ja0Zvcm1hdHRpbmdTdGF0ZSA9IGxheW91dFN0YXRlLmVuc3VyZUJsb2NrRm9y bWF0dGluZ1N0YXRlKGZvcm1hdHRpbmdDb250ZXh0Um9vdCk7CiAgICAgICAgIHJldHVybiBtYWtl VW5pcXVlPEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ+KGZvcm1hdHRpbmdDb250ZXh0Um9vdCwgYmxv Y2tGb3JtYXR0aW5nU3RhdGUpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3Bw CmluZGV4IGE1NjE2MzE0ODY1NDE4MzVhZGQ1YzNiOWY3YzJkNzQ1ZTZkMjU2NjQuLmFiOGYyY2Fj YTIyNWVjMDVkNDkzNDFhMjZkNWYzYmMxYjgxMWM4YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdD b250ZXh0LmNwcApAQCAtMzAzLDEwICszMDMsOCBAQCB2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRl eHQ6OmNvbXB1dGVFc3RpbWF0ZWRWZXJ0aWNhbFBvc2l0aW9uRm9yRm9ybWF0dGluZ1Jvb3QoYwog ICAgIGNvbXB1dGVFc3RpbWF0ZWRWZXJ0aWNhbFBvc2l0aW9uKGxheW91dEJveCwgaG9yaXpvbnRh bENvbnN0cmFpbnRzLmNvbnRhaW5pbmdCbG9jaywgdmVydGljYWxDb25zdHJhaW50cy5jb250YWlu aW5nQmxvY2spOwogICAgIGNvbXB1dGVFc3RpbWF0ZWRWZXJ0aWNhbFBvc2l0aW9uRm9yQW5jZXN0 b3JzKGxheW91dEJveCwgaG9yaXpvbnRhbENvbnN0cmFpbnRzLCB2ZXJ0aWNhbENvbnN0cmFpbnRz KTsKIAotICAgIC8vIElmIHRoZSBpbmxpbmUgZm9ybWF0dGluZyByb290IGlzIGFsc28gdGhlIHJv b3QgZm9yIHRoZSBmbG9hdHMgKGhhcHBlbnMgd2hlbiB0aGUgcm9vdCBib3ggYWxzbyBlc3RhYmxp c2hlcyBhIGJsb2NrIGZvcm1hdHRpbmcgY29udGV4dCkKLSAgICAvLyB0aGUgZmxvYXRzIGFyZSBp biB0aGUgY29vcmRpbmF0ZSBzeXN0ZW0gb2YgdGhpcyByb290LiBObyBuZWVkIHRvIGZpbmQgdGhl IGZpbmFsIHZlcnRpY2FsIHBvc2l0aW9uLgotICAgIGF1dG8gaW5saW5lQ29udGV4dEluaGVyaXRz RmxvYXRzID0gbGF5b3V0Qm94LmVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGluZ0NvbnRleHRPbmx5 KCk7Ci0gICAgaWYgKGlubGluZUNvbnRleHRJbmhlcml0c0Zsb2F0cykgeworICAgIC8vIFdlIG9u bHkgbmVlZCB0aGUgZmluYWwgdmVydGljYWwgcG9zaXRpb24gaWYgdGhlIGZvcm1hdHRpbmcgY29u dGV4dCBkb2VzIGxldCBpbnRydXNpdmUgZmxvYXRzIGluIChha2Egbm90IGEgZmxvYXQgYXZvaWRl cikuCisgICAgaWYgKCFsYXlvdXRCb3guaXNGbG9hdEF2b2lkZXIoKSkgewogICAgICAgICBjb21w dXRlRXN0aW1hdGVkVmVydGljYWxQb3NpdGlvbihsYXlvdXRCb3gsIGhvcml6b250YWxDb25zdHJh aW50cy5jb250YWluaW5nQmxvY2ssIHZlcnRpY2FsQ29uc3RyYWludHMuY29udGFpbmluZ0Jsb2Nr KTsKICAgICAgICAgY29tcHV0ZUVzdGltYXRlZFZlcnRpY2FsUG9zaXRpb25Gb3JBbmNlc3RvcnMo bGF5b3V0Qm94LCBob3Jpem9udGFsQ29uc3RyYWludHMsIHZlcnRpY2FsQ29uc3RyYWludHMpOwog ICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91 dEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3Bw CmluZGV4IDFmY2Q5MjkxNjZlZjA3NzE1MTRhNmMwOGE0YWM1OWU3YzlkYjkxZTkuLmI0ZDYwYTRl NmFkMDI1ZmNjNDQyMDkxMzVlNzYwNGEyMmNlZmVjNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNwcApAQCAtMTI0LDExICsxMjQsNiBAQCBib29s IEJveDo6ZXN0YWJsaXNoZXNJbmxpbmVGb3JtYXR0aW5nQ29udGV4dCgpIGNvbnN0CiAgICAgcmV0 dXJuIGRvd25jYXN0PENvbnRhaW5lcj4oKnRoaXMpLmZpcnN0SW5GbG93Q2hpbGQoKS0+aXNJbmxp bmVMZXZlbEJveCgpOwogfQogCi1ib29sIEJveDo6ZXN0YWJsaXNoZXNJbmxpbmVGb3JtYXR0aW5n Q29udGV4dE9ubHkoKSBjb25zdAotewotICAgIHJldHVybiBlc3RhYmxpc2hlc0lubGluZUZvcm1h dHRpbmdDb250ZXh0KCkgJiYgIWVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dCgpOwot fQotCiBib29sIEJveDo6ZXN0YWJsaXNoZXNUYWJsZUZvcm1hdHRpbmdDb250ZXh0KCkgY29uc3QK IHsKICAgICByZXR1cm4gaXNUYWJsZUJveCgpOwpAQCAtMTQwLDExICsxMzUsNiBAQCBib29sIEJv eDo6ZXN0YWJsaXNoZXNJbmRlcGVuZGVudEZvcm1hdHRpbmdDb250ZXh0KCkgY29uc3QKICAgICBy ZXR1cm4gaXNBYnNvbHV0ZWx5UG9zaXRpb25lZCgpOwogfQogCi1ib29sIEJveDo6ZXN0YWJsaXNo ZXNCbG9ja0Zvcm1hdHRpbmdDb250ZXh0T25seSgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGVzdGFi bGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dCgpICYmICFlc3RhYmxpc2hlc0lubGluZUZvcm1h dHRpbmdDb250ZXh0KCk7Ci19Ci0KIGJvb2wgQm94Ojppc1JlbGF0aXZlbHlQb3NpdGlvbmVkKCkg Y29uc3QKIHsKICAgICByZXR1cm4gbV9zdHlsZS5wb3NpdGlvbigpID09IFBvc2l0aW9uVHlwZTo6 UmVsYXRpdmU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9M YXlvdXRCb3guaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5o CmluZGV4IDQ0MTcyOWNkN2FhZTdmMDM5Nzk4MjQyMDIzYTZjNWI1MDU2MTk5Y2MuLjk0NTNiM2Uz MDdkNzJmZjEyMDI2MTEzMzQxZjMzODM1MzI4N2IyOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oCkBAIC03OSw5ICs3OSw2IEBAIHB1YmxpYzoKICAg ICBib29sIGVzdGFibGlzaGVzVGFibGVGb3JtYXR0aW5nQ29udGV4dCgpIGNvbnN0OwogICAgIGJv b2wgZXN0YWJsaXNoZXNJbmRlcGVuZGVudEZvcm1hdHRpbmdDb250ZXh0KCkgY29uc3Q7CiAKLSAg ICBib29sIGVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dE9ubHkoKSBjb25zdDsKLSAg ICBib29sIGVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGluZ0NvbnRleHRPbmx5KCkgY29uc3Q7Ci0K ICAgICBib29sIGlzSW5GbG93KCkgY29uc3QgeyByZXR1cm4gIWlzRmxvYXRpbmdPck91dE9mRmxv d1Bvc2l0aW9uZWQoKTsgfQogICAgIGJvb2wgaXNQb3NpdGlvbmVkKCkgY29uc3QgeyByZXR1cm4g aXNJbkZsb3dQb3NpdGlvbmVkKCkgfHwgaXNPdXRPZkZsb3dQb3NpdGlvbmVkKCk7IH0KICAgICBi b29sIGlzSW5GbG93UG9zaXRpb25lZCgpIGNvbnN0IHsgcmV0dXJuIGlzUmVsYXRpdmVseVBvc2l0 aW9uZWQoKSB8fCBpc1N0aWNreVBvc2l0aW9uZWQoKTsgfQo=