207419 2020-02-07 16:47:57 -0800 Make FormDataElement::lengthInBytes() safe to call on a non-main thread 2020-02-10 08:17:41 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson ggaren webkit-bug-importer youennf oldest_to_newest 1616465 0 cdumez 2020-02-07 16:47:57 -0800 Make FormDataElement::lengthInBytes() safe to call on a non-main thread: Thread[8] EXC_BREAKPOINT (SIGTRAP) (0x0000000000000002, 0x0000000000000000) [ 0] 0x0000000101599583 WTFCrashWithInfo(int, char const*, char const*, int) + 19 [ 1] 0x000000010153e1df WebKit::WebProcess::ensureNetworkProcessConnection() + 659 [ 2] 0x000000010196757b WebKit::BlobRegistryProxy::blobSize(PAL::SessionID, WTF::URL const&) + 41 [ 3] 0x0000000103eb8675 WebCore::FormDataElement::lengthInBytes(PAL::SessionID) const + 117 [ 4] 0x000000010317eccb WebCore::CacheStorageConnection::computeRecordBodySize(WebCore::FetchResponse const&, WTF::Variant<std::nullptr_t, WTF::Ref<WebCore::FormData, WTF::DumbPtrTraits<WebCore::FormData> >, WTF::Ref<WebCore::SharedBuffer, WTF::DumbPtrTraits<WebCore::SharedBuffer> > > const&) + 683 [ 5] 0x00000001031810d7 WebCore::DOMCache::toConnectionRecord(WebCore::FetchRequest const&, WebCore::FetchResponse&, WTF::Variant<std::nullptr_t, WTF::Ref<WebCore::FormData, WTF::DumbPtrTraits<WebCore::FormData> >, WTF::Ref<WebCore::SharedBuffer, WTF::DumbPtrTraits<WebCore::SharedBuffer> > >&&) + 615 [ 6] 0x000000010318011c WebCore::DOMCache::batchPutOperation(WebCore::FetchRequest const&, WebCore::FetchResponse&, WTF::Variant<std::nullptr_t, WTF::Ref<WebCore::FormData, WTF::DumbPtrTraits<WebCore::FormData> >, WTF::Ref<WebCore::SharedBuffer, WTF::DumbPtrTraits<WebCore::SharedBuffer> > >&&, WTF::Function<void (WebCore::ExceptionOr<void>&&)>&&) + 60 [ 7] 0x0000000103180a3a WebCore::DOMCache::put(WTF::Variant<WTF::RefPtr<WebCore::FetchRequest, WTF::DumbPtrTraits<WebCore::FetchRequest> >, WTF::String>&&, WTF::Ref<WebCore::FetchResponse, WTF::DumbPtrTraits<WebCore::FetchResponse> >&&, WebCore::DOMPromiseDeferred<void>&&) + 2026 [ 8] 0x0000000102983d2b WebCore::jsDOMCachePrototypeFunctionPut(JSC::ExecState*) + 811 [ 9] 0x0000414ae22012ab 0 + 71789877138091 [ 10] 0x00000001061678f7 llint_entry + 94158 [ 11] 0x00000001061678f7 llint_entry + 94158 1616466 1 cdumez 2020-02-07 16:48:07 -0800 <rdar://problem/54386521> 1616469 2 390148 cdumez 2020-02-07 16:49:44 -0800 Created attachment 390148 Patch 1616471 3 cdumez 2020-02-07 16:50:23 -0800 Seems to be causing flaky crashes on the bots. 1616660 4 390148 youennf 2020-02-08 23:39:19 -0800 Comment on attachment 390148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390148&action=review > Source/WebCore/ChangeLog:10 > + ThreadableBlobRegistry. DOMCache code in workers may call this on worker threads for s/for// 1616868 5 cdumez 2020-02-10 08:17:41 -0800 Committed r256173: <https://trac.webkit.org/changeset/256173> 390148 2020-02-07 16:49:44 -0800 2020-02-08 23:39:40 -0800 Patch bug-207419-20200207164943.patch text/plain 1572 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBmNjAzNGZjYWZmNzAw MTg0OGM4MTkzZGZkOTk5MWU4MjM2NjAzNC4uNDQxNjhkMTVjMDM2OWFkNThmYmZkMjdhODY3ZWUw MGMxOTU0ODYwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTA3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBGb3JtRGF0YUVsZW1l bnQ6Omxlbmd0aEluQnl0ZXMoKSBzYWZlIHRvIGNhbGwgb24gYSBub24tbWFpbiB0aHJlYWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzQxOQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNTQzODY1MjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBGb3JtRGF0YUVsZW1lbnQ6Omxlbmd0aEluQnl0 ZXMoKSBzYWZlIHRvIGNhbGwgb24gYSBub24tbWFpbiB0aHJlYWQgYnkgdXNpbmcgdGhlCisgICAg ICAgIFRocmVhZGFibGVCbG9iUmVnaXN0cnkuIERPTUNhY2hlIGNvZGUgaW4gd29ya2VycyBtYXkg Y2FsbCB0aGlzIG9uIHdvcmtlciB0aHJlYWRzIGZvcgorICAgICAgICBlLmcuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvcm1E YXRhRWxlbWVudDo6bGVuZ3RoSW5CeXRlcyBjb25zdCk6CisKIDIwMjAtMDItMDcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbSGFyZGVuaW5nXSBWYWxpZGF0ZSBH ZW9sb2NhdGlvbiBhY2Nlc3MgcGVybWlzc2lvbiBvbiBVSVByb2Nlc3Mgc2lkZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmNwcAppbmRleCA1MzY0OWEyOWM1YWE1 Y2NkMTA4NjE1NWM0ZmM2ZTUyZmU3NjE0YjllLi4xY2MyZGI0ZWFmMTVkYmIzNDUxYmNmNGQ0ZGNj ZDk3OTc3M2VlZDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L0Zvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1E YXRhLmNwcApAQCAtMTQ0LDcgKzE0NCw3IEBAIHVpbnQ2NF90IEZvcm1EYXRhRWxlbWVudDo6bGVu Z3RoSW5CeXRlcyhjb25zdCBGdW5jdGlvbjx1aW50NjRfdChjb25zdCBVUkwmKT4mIGJsCiB1aW50 NjRfdCBGb3JtRGF0YUVsZW1lbnQ6Omxlbmd0aEluQnl0ZXMoKSBjb25zdAogewogICAgIHJldHVy biBsZW5ndGhJbkJ5dGVzKFtdKGF1dG8mIHVybCkgewotICAgICAgICByZXR1cm4gYmxvYlJlZ2lz dHJ5KCkuYmxvYlNpemUodXJsKTsKKyAgICAgICAgcmV0dXJuIFRocmVhZGFibGVCbG9iUmVnaXN0 cnk6OmJsb2JTaXplKHVybCk7CiAgICAgfSk7CiB9CiAK