207413 2020-02-07 15:23:35 -0800 Replace redundant functions with variadic template function. 2020-02-09 21:50:16 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke cdumez commit-queue darin dbates ews-watchlist japhet webkit-bug-importer youennf oldest_to_newest 1616409 0 basuke 2020-02-07 15:23:35 -0800 With variadic template function, there is no need to maintain the versions with variety number of arguments. 1616418 1 basuke 2020-02-07 15:31:58 -0800 This code generates exact same result with the original. https://godbolt.org/z/iwzGAP 1616420 2 390139 basuke 2020-02-07 15:35:28 -0800 Created attachment 390139 PATCH 1616772 3 390139 commit-queue 2020-02-09 21:49:50 -0800 Comment on attachment 390139 PATCH Clearing flags on attachment: 390139 Committed r256110: <https://trac.webkit.org/changeset/256110> 1616773 4 commit-queue 2020-02-09 21:49:52 -0800 All reviewed patches have been landed. Closing bug. 1616774 5 webkit-bug-importer 2020-02-09 21:50:16 -0800 <rdar://problem/59301380> 390139 2020-02-07 15:35:28 -0800 2020-02-09 21:49:50 -0800 PATCH bug-207413.diff text/plain 2320 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZjE0NTcwYmZmYy4uMTA4NjQzM2M0NTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wMi0wNyAgQmFzdWtlIFN1enVraSAgPGJhc3VrZS5zdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgUmVwbGFjZSByZWR1bmRhbnQgZnVuY3Rpb25zIHdpdGggdmFyaWFk aWMgdGVtcGxhdGUgZnVuY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDc0MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisK KyAgICAgICAgKiBsb2FkZXIvVGV4dFJlc291cmNlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpieXRlc0VxdWFsKToKKwogMjAyMC0wMi0wNyAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgRmlsdGVyIG91dCBUVVJOL1NUVU4gLmxvY2FsIFVSTHMgZnJv bSBhIFJUQ1BlZXJDb25uZWN0aW9uIGljZVNlcnZlcnMgbGlzdApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIuY3BwCmluZGV4IDgyNDZiYjA3MDZjLi43MDQ2MWEy OTQ4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1RleHRSZXNvdXJjZURlY29k ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9UZXh0UmVzb3VyY2VEZWNvZGVyLmNw cApAQCAtMzcsMjkgKzM3LDE1IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFtZXNw YWNlIEhUTUxOYW1lczsKIAotc3RhdGljIGlubGluZSBib29sIGJ5dGVzRXF1YWwoY29uc3QgY2hh ciogcCwgY2hhciBiMCwgY2hhciBiMSkKK3N0YXRpYyBjb25zdGV4cHIgYm9vbCBieXRlc0VxdWFs KGNvbnN0IGNoYXIqIHAsIGNoYXIgYikKIHsKLSAgICByZXR1cm4gcFswXSA9PSBiMCAmJiBwWzFd ID09IGIxOworICAgIHJldHVybiAqcCA9PSBiOwogfQogCi1zdGF0aWMgaW5saW5lIGJvb2wgYnl0 ZXNFcXVhbChjb25zdCBjaGFyKiBwLCBjaGFyIGIwLCBjaGFyIGIxLCBjaGFyIGIyLCBjaGFyIGIz LCBjaGFyIGI0KQordGVtcGxhdGU8dHlwZW5hbWUuLi4gVD4KK3N0YXRpYyBjb25zdGV4cHIgYm9v bCBieXRlc0VxdWFsKGNvbnN0IGNoYXIqIHAsIGNoYXIgYiwgVC4uLiBicykKIHsKLSAgICByZXR1 cm4gcFswXSA9PSBiMCAmJiBwWzFdID09IGIxICYmIHBbMl0gPT0gYjIgJiYgcFszXSA9PSBiMyAm JiBwWzRdID09IGI0OwotfQotCi1zdGF0aWMgaW5saW5lIGJvb2wgYnl0ZXNFcXVhbChjb25zdCBj aGFyKiBwLCBjaGFyIGIwLCBjaGFyIGIxLCBjaGFyIGIyLCBjaGFyIGIzLCBjaGFyIGI0LCBjaGFy IGI1KQotewotICAgIHJldHVybiBwWzBdID09IGIwICYmIHBbMV0gPT0gYjEgJiYgcFsyXSA9PSBi MiAmJiBwWzNdID09IGIzICYmIHBbNF0gPT0gYjQgJiYgcFs1XSA9PSBiNTsKLX0KLQotc3RhdGlj IGlubGluZSBib29sIGJ5dGVzRXF1YWwoY29uc3QgY2hhciogcCwgY2hhciBiMCwgY2hhciBiMSwg Y2hhciBiMiwgY2hhciBiMywgY2hhciBiNCwgY2hhciBiNSwgY2hhciBiNiwgY2hhciBiNykKLXsK LSAgICByZXR1cm4gcFswXSA9PSBiMCAmJiBwWzFdID09IGIxICYmIHBbMl0gPT0gYjIgJiYgcFsz XSA9PSBiMyAmJiBwWzRdID09IGI0ICYmIHBbNV0gPT0gYjUgJiYgcFs2XSA9PSBiNiAmJiBwWzdd ID09IGI3OwotfQotCi1zdGF0aWMgaW5saW5lIGJvb2wgYnl0ZXNFcXVhbChjb25zdCBjaGFyKiBw LCBjaGFyIGIwLCBjaGFyIGIxLCBjaGFyIGIyLCBjaGFyIGIzLCBjaGFyIGI0LCBjaGFyIGI1LCBj aGFyIGI2LCBjaGFyIGI3LCBjaGFyIGI4LCBjaGFyIGI5KQotewotICAgIHJldHVybiBwWzBdID09 IGIwICYmIHBbMV0gPT0gYjEgJiYgcFsyXSA9PSBiMiAmJiBwWzNdID09IGIzICYmIHBbNF0gPT0g YjQgJiYgcFs1XSA9PSBiNSAmJiBwWzZdID09IGI2ICYmIHBbN10gPT0gYjcgJiYgcFs4XSA9PSBi OCAmJiBwWzldID09IGI5OworICAgIHJldHVybiAqcCA9PSBiICYmIGJ5dGVzRXF1YWwocCArIDEs IGJzLi4uKTsKIH0KIAogLy8gWW91IG1pZ2h0IHRoaW5rIHdlIHNob3VsZCBwdXQgdGhlc2UgZmlu ZCBmdW5jdGlvbnMgZWxzZXdoZXJlLCBwZXJoYXBzIHdpdGggdGhlCg==