207407 2020-02-07 14:08:54 -0800 Crash under WKBundleFrameForJavaScriptContext dereferencing a NULL WebCore::Frame 2020-02-07 15:01:49 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bdakin commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1616358 0 timothy 2020-02-07 14:08:54 -0800 Safari is hitting a crash in the injected bundle when calling WKBundleFrameForJavaScriptContext with a context of a page that has been closed. #0 0x00000003b836f715 in std::__1::unique_ptr<WebCore::FrameLoader, std::__1::default_delete<WebCore::FrameLoader> >::operator bool() const at ~/Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.15.xctoolchain/usr/include/c++/v1/memory:2636 #1 0x00000003b836f69d in WTF::UniqueRef<WebCore::FrameLoader>::get() at /Users/Timothy/Work/Safari/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/UniqueRef.h:58 #2 0x00000003b83634ce in WebCore::Frame::loader() const at /Users/Timothy/Work/Safari/OpenSource/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/Frame.h:367 #3 0x00000003b949d835 in WebKit::WebFrame::fromCoreFrame(WebCore::Frame const&) at ~/Work/Safari/OpenSource/Source/WebKit/WebProcess/WebPage/WebFrame.cpp:182 #4 0x00000003b94a65f3 in WebKit::WebFrame::frameForContext(OpaqueJSContext const*) at ~/Work/Safari/OpenSource/Source/WebKit/WebProcess/WebPage/WebFrame.cpp:711 #5 0x00000003b92ea1b5 in ::WKBundleFrameForJavaScriptContext(JSContextRef) at ~/Work/Safari/OpenSource/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:104 <rdar://problem/59206599> 1616360 1 390120 timothy 2020-02-07 14:10:33 -0800 Created attachment 390120 Patch 1616394 2 390120 commit-queue 2020-02-07 15:01:48 -0800 Comment on attachment 390120 Patch Clearing flags on attachment: 390120 Committed r256068: <https://trac.webkit.org/changeset/256068> 1616395 3 commit-queue 2020-02-07 15:01:49 -0800 All reviewed patches have been landed. Closing bug. 390120 2020-02-07 14:10:33 -0800 2020-02-07 15:01:48 -0800 Patch bug-207407-20200207141033.patch text/plain 1706 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRhOTY1ZWYwZmU0MGQxYzY5 ZjA3Y2ZiZTkzNDlkOGUxYmI5NGM1ZTcuLmQ1YjgxYzVmOTNmMWNkODJlYmU4YTVkZDM1M2QyMGQ3 ZGI0OTU3ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDItMDcgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIHVuZGVyIFdLQnVu ZGxlRnJhbWVGb3JKYXZhU2NyaXB0Q29udGV4dCBkZXJlZmVyZW5jaW5nIGEgTlVMTCBXZWJDb3Jl OjpGcmFtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNzQwNworICAgICAgICByZGFyOi8vcHJvYmxlbS81OTIwNjU5OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YkZyYW1lLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWU6OmZyYW1lRm9yQ29udGV4dCk6 IEFkZCBhIG51bGwgY2hlY2sgZm9yIHRoZSBjb3JlRnJhbWUuCisKIDIwMjAtMDItMDYgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMjU1OTU1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViRnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJh bWUuY3BwCmluZGV4IDlmYmIxZmRmMGQ4Mjc4ODQ2NjVjZWM3NzM3YjMxMGI1MDMxZDQwYzUuLmY2 Yzk4NGUzMDVlYzdmN2RhZWQ5N2Y2ODZlODlhMjdmYjkwYmI0N2UgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5jcHAKQEAgLTcwMywxMiArNzAzLDE0IEBA IHZvaWQgV2ViRnJhbWU6OnN0b3BMb2FkaW5nKCkKIAogV2ViRnJhbWUqIFdlYkZyYW1lOjpmcmFt ZUZvckNvbnRleHQoSlNDb250ZXh0UmVmIGNvbnRleHQpCiB7Ci0KICAgICBKU0M6OkpTR2xvYmFs T2JqZWN0KiBnbG9iYWxPYmplY3RPYmogPSB0b0pTKGNvbnRleHQpOwogICAgIEpTRE9NV2luZG93 KiB3aW5kb3cgPSBqc0R5bmFtaWNDYXN0PEpTRE9NV2luZG93Kj4oZ2xvYmFsT2JqZWN0T2JqLT52 bSgpLCBnbG9iYWxPYmplY3RPYmopOwogICAgIGlmICghd2luZG93KQogICAgICAgICByZXR1cm4g bnVsbHB0cjsKLSAgICByZXR1cm4gV2ViRnJhbWU6OmZyb21Db3JlRnJhbWUoKih3aW5kb3ctPndy YXBwZWQoKS5mcmFtZSgpKSk7CisgICAgYXV0byogY29yZUZyYW1lID0gd2luZG93LT53cmFwcGVk KCkuZnJhbWUoKTsKKyAgICBpZiAoIWNvcmVGcmFtZSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7 CisgICAgcmV0dXJuIFdlYkZyYW1lOjpmcm9tQ29yZUZyYW1lKCpjb3JlRnJhbWUpOwogfQogCiBK U1ZhbHVlUmVmIFdlYkZyYW1lOjpqc1dyYXBwZXJGb3JXb3JsZChJbmplY3RlZEJ1bmRsZU5vZGVI YW5kbGUqIG5vZGVIYW5kbGUsIEluamVjdGVkQnVuZGxlU2NyaXB0V29ybGQqIHdvcmxkKQo=