207405 2020-02-07 13:57:14 -0800 TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst 2020-02-07 15:39:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1616348 0 jbedard 2020-02-07 13:57:14 -0800 Our ActionSheet tests test behavior not applicable to Catalyst. Disable these tests on Catalyst. 1616349 1 390119 jbedard 2020-02-07 13:59:44 -0800 Created attachment 390119 Patch 1616377 2 390119 wenson_hsieh 2020-02-07 14:38:22 -0800 Comment on attachment 390119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390119&action=review > Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:29 > +#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST) You should update the corresponding #endif as well. 1616385 3 390128 jbedard 2020-02-07 14:48:24 -0800 Created attachment 390128 Patch for landing 1616421 4 390128 commit-queue 2020-02-07 15:38:23 -0800 Comment on attachment 390128 Patch for landing Clearing flags on attachment: 390128 Committed r256074: <https://trac.webkit.org/changeset/256074> 1616422 5 commit-queue 2020-02-07 15:38:24 -0800 All reviewed patches have been landed. Closing bug. 1616425 6 webkit-bug-importer 2020-02-07 15:39:18 -0800 <rdar://problem/59276605> 390119 2020-02-07 13:59:44 -0800 2020-02-07 14:48:22 -0800 Patch bug-207405-20200207135944.patch text/plain 1109 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjA1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTAyLTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBUZXN0V2ViS2l0QVBJOiBEaXNhYmxlIGxlZ2FjeSBBY3Rpb25TaGVldCB0 ZXN0cyBvbiBDYXRhbHlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA3NDA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tOgor CiAyMDIwLTAyLTA3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAg ICBMZWdhY3kgV2ViS2l0OiBIYXZlIGxpbmtlZE9uT3JBZnRlcigpIHJlc3BlY3QgdGhlIE5TRGVm YXVsdCBXZWJLaXRMaW5rZWRPbk9yQWZ0ZXJFdmVyeXRoaW5nIGFuZCBvcHQgRHVtcFJlbmRlclRy ZWUgaW4KSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0FjdGlvblNoZWV0VGVz dHMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvQWN0aW9u U2hlZXRUZXN0cy5tbQkocmV2aXNpb24gMjU2MDE3KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYs NyBAQAogI2ltcG9ydCAiY29uZmlnLmgiCiAjaW1wb3J0ICJUZXN0LmgiCiAKLSNpZiBQTEFURk9S TShJT1NfRkFNSUxZKQorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpICYmICFQTEFURk9STShNQUND QVRBTFlTVCkKIAogI2ltcG9ydCAiQ2xhc3NNZXRob2RTd2l6emxlci5oIgogI2ltcG9ydCAiSVBh ZFVzZXJJbnRlcmZhY2VTd2l6emxlci5oIgo= 390128 2020-02-07 14:48:24 -0800 2020-02-07 15:38:23 -0800 Patch for landing bug-207405-20200207144824.patch text/plain 1218 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjA2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTAyLTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBUZXN0V2ViS2l0QVBJOiBEaXNhYmxlIGxlZ2FjeSBBY3Rpb25TaGVldCB0 ZXN0cyBvbiBDYXRhbHlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA3NDA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgV2Vuc29uIEhzaWVoLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbToKKwog MjAyMC0wMi0wNyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAg ICAgaVBhZCB0ZXN0ZXJzIGZhaWxpbmcgdG8gbGF1bmNoIHByb2Nlc3NlcwpJbmRleDogVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tCShyZXZp c2lvbiAyNTYwNjUpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVl dFRlc3RzLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw3ICsyNiw3IEBACiAjaW1wb3J0ICJjb25m aWcuaCIKICNpbXBvcnQgIlRlc3QuaCIKIAotI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisjaWYg UExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgIVBMQVRGT1JNKE1BQ0NBVEFMWVNUKQogCiAjaW1wb3J0 ICJDbGFzc01ldGhvZFN3aXp6bGVyLmgiCiAjaW1wb3J0ICJJUGFkVXNlckludGVyZmFjZVN3aXp6 bGVyLmgiCkBAIC0zNTQsNCArMzU0LDQgQEAgVEVTVChBY3Rpb25TaGVldFRlc3RzLCBDb3B5TGlu a1dyaXRlc1VSTAogCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCiAKLSNlbmRpZiAvLyBQ TEFURk9STShJT1NfRkFNSUxZKQorI2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1JTFkpICYmICFQ TEFURk9STShNQUNDQVRBTFlTVCkK