207401 2020-02-07 13:09:16 -0800 iPad testers failing to launch processes 2020-02-10 09:25:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap ews-watchlist ryanhaddad slewis webkit-bug-importer oldest_to_newest 1616324 0 jbedard 2020-02-07 13:09:16 -0800 Our iPad testers are consistently failing to launch processes. Reproducing the issue is difficult, even when attempting to do so on the bots themselves, but our automation is constantly struggling with this. 1616325 1 jbedard 2020-02-07 13:09:39 -0800 <rdar://problem/58184777> 1616332 2 390118 jbedard 2020-02-07 13:17:27 -0800 Created attachment 390118 Patch 1616339 3 jbedard 2020-02-07 13:35:18 -0800 I've managed to reproduce this twice by running kill-old-processes right before running tests. 1616382 4 jbedard 2020-02-07 14:45:42 -0800 Committed r256065: <https://trac.webkit.org/changeset/256065> 1616451 5 390118 ap 2020-02-07 16:29:09 -0800 Comment on attachment 390118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390118&action=review > Tools/BuildSlaveSupport/kill-old-processes:102 > + "Simulator.app", This is surprising, apps don't usually have .app in the process name. Does this updated line have any effect now? 1616863 6 jbedard 2020-02-10 08:07:32 -0800 (In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 390118 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390118&action=review > > > Tools/BuildSlaveSupport/kill-old-processes:102 > > + "Simulator.app", > > This is surprising, apps don't usually have .app in the process name. Does > this updated line have any effect now? It's in the path: Xcode.app/Contents/Developer/Applications/Simulator.app/Contents/MacOS/Simulator Not sure we should really be doing this at actually. This did fix our iPad testers, but it also hosed one of our iPhone bots in the process: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/2490 That bot was in a pretty bad state, grabbed a sysdiagnose, but couldn't really do anything else. I restarted it and will continue to monitor it. 1616898 7 ap 2020-02-10 09:25:18 -0800 > It's in the path: Xcode.app/Contents/Developer/Applications/Simulator.app/Contents/MacOS/Simulator Elements in the tasksToKillMac array are passed to killall as regex matches: 'os.system("killall -9 -v -m " + task)' This means that path isn't considered, just the process name. Also, it means that the dot in "Simulator.app" matches any character, which is not a big deal, but is unclean. Try "killall -9 -v -m Terminal.app" in your Terminal session to confirm that it won't be killed. 390118 2020-02-07 13:17:27 -0800 2020-02-07 14:45:55 -0800 Patch bug-207401-20200207131721.patch text/plain 1407 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjA1MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDIwLTAyLTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBpUGFkIHRlc3RlcnMgZmFpbGluZyB0byBsYXVuY2ggcHJvY2Vzc2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc0MDEKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MTg0Nzc3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSBzcGVjdWxhdGl2ZSBmaXggYmVjYXVz ZSBJJ3ZlIGhhZCBwcm9ibGVtcyByZXByb2R1Y2luZyB0aGlzIGVycm9yLgorICAgICAgICBUaGUg b25seSB0aW1lIEkgbWFuYWdlZCB0byByZXByb2R1Y2UgdGhlIHByb2JsZW0gd2FzIGltbWVkaWF0 ZWx5IGFmdGVyIGtpbGxpbmcgdGhlIAorICAgICAgICBTaW11bGF0b3JUcmFtcG9saW5lIGFuZCBD b3JlU2ltdWxhdG9yLnhwYyBwcm9jZXNzZXMuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9y dC9raWxsLW9sZC1wcm9jZXNzZXM6CisgICAgICAgIChtYWluKTogT25seSBraWxsIFNpbXVsYXRv ci5hcHAsIG5vdCBhbGwgYXNzb2NpYXRlZCBzaW11bGF0b3IgcHJvY2Vzc2VzLgorCiAyMDIwLTAy LTAzICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHRyaXZp YWwgZGVmaW5pdGlvbnMgZnJvbSBGZWF0dXJlRGVmaW5lcy54Y2NvbmZpZyB0byBQbGF0Zm9ybUVu YWJsZUNvY29hLmgKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nl c3Nlcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9raWxsLW9sZC1wcm9j ZXNzZXMJKHJldmlzaW9uIDI1NjA1MSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwt b2xkLXByb2Nlc3Nlcwkod29ya2luZyBjb3B5KQpAQCAtOTksNyArOTksNyBAQCBkZWYgbWFpbih1 c2VyPU5vbmUpOgogICAgICAgICAiV2ViUHJvY2VzcyIsCiAgICAgICAgICJ4Y29kZWJ1aWxkIiwK ICAgICAgICAgIyBGSVhNRTogQ29uc2lkZXIgbW92aW5nIGlPUy1zcGVjaWZpYyB0YXNrcyB0byB0 aGVpciBvd24gbGlzdC4KLSAgICAgICAgIlNpbXVsYXRvciIsCisgICAgICAgICJTaW11bGF0b3Iu YXBwIiwKICAgICBdCiAKICAgICB0YXNrVG9LaWxsVW5peCA9IFsK