207398 2020-02-07 12:06:03 -0800 Handle deprecated APIs in WKImagePreviewViewController 2020-02-08 17:59:02 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue krollin thorton webkit-bug-importer oldest_to_newest 1616290 0 jbedard 2020-02-07 12:06:03 -0800 We are using some deprecated APIs in WKImagePreviewViewController and we need to allow them. Not sure how our OpenSource build is working at the moment. 1616292 1 390114 jbedard 2020-02-07 12:08:09 -0800 Created attachment 390114 Patch 1616343 2 390114 commit-queue 2020-02-07 13:45:56 -0800 Comment on attachment 390114 Patch Clearing flags on attachment: 390114 Committed r256057: <https://trac.webkit.org/changeset/256057> 1616344 3 commit-queue 2020-02-07 13:45:57 -0800 All reviewed patches have been landed. Closing bug. 1616345 4 webkit-bug-importer 2020-02-07 13:46:14 -0800 <rdar://problem/59272048> 1616583 5 390114 ap 2020-02-08 13:01:43 -0800 Comment on attachment 390114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390114&action=review > Source/WebKit/UIProcess/WKImagePreviewViewController.mm:98 > +ALLOW_DEPRECATED_DECLARATIONS_BEGIN > ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN > - (NSArray<UIPreviewAction *> *)previewActionItems Why is this right? Surely there is no need for ALLOW_DEPRECATED_DECLARATIONS_BEGIN around previewActionItems, because it's not even a declaration. 1616618 6 390114 thorton 2020-02-08 15:10:54 -0800 Comment on attachment 390114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390114&action=review >> Source/WebKit/UIProcess/WKImagePreviewViewController.mm:98 >> - (NSArray<UIPreviewAction *> *)previewActionItems > > Why is this right? Surely there is no need for ALLOW_DEPRECATED_DECLARATIONS_BEGIN around previewActionItems, because it's not even a declaration. It could definitely be tighter (it's about things inside the method body), but also doesn't really matter? 1616626 7 ap 2020-02-08 17:09:23 -0800 Usually these annotate code that needs rework. If we don't care about precisely identifying such code, it would be easier to just disable deprecation warnings for the whole project. Or are you saying that everything between these lines needs to be reworked? 1616635 8 thorton 2020-02-08 17:34:55 -0800 (In reply to Alexey Proskuryakov from comment #7) > Usually these annotate code that needs rework. If we don't care about > precisely identifying such code, it would be easier to just disable > deprecation warnings for the whole project. > > Or are you saying that everything between these lines needs to be reworked? More than half, anyway. 1616636 9 thorton 2020-02-08 17:35:50 -0800 (In reply to Alexey Proskuryakov from comment #7) > Usually these annotate code that needs rework. If we don't care about > precisely identifying such code, it would be easier to just disable > deprecation warnings for the whole project. Also, it's ... 10 lines. This seems a little unnecessarily melodramatic :) 1616641 10 ap 2020-02-08 17:59:02 -0800 Excuses. 390114 2020-02-07 12:08:09 -0800 2020-02-07 13:45:56 -0800 Patch bug-207398-20200207120803.patch text/plain 1580 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTYwNTApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTA3ICBKb25hdGhhbiBC ZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgZGVwcmVjYXRlZCBB UElzIGluIFdLSW1hZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzM5OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4LgorCisg ICAgICAgICogVUlQcm9jZXNzL1dLSW1hZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIubW06CisgICAg ICAgICgtW1dLSW1hZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIgcHJldmlld0FjdGlvbkl0ZW1zXSk6 IEFkZCBkZXByZWNhdGlvbiBtYWNyb3MuCisKIDIwMjAtMDItMDcgIEthdGUgQ2hlbmV5ICA8a2F0 aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIFdlYlZpZXcgY2F0ZWdv cnkgbmFtZSB0byBiZSBtb3JlIGFjY3VyYXRlCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XS0ltYWdlUHJldmlld1ZpZXdDb250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dLSW1hZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIubW0JKHJldmlzaW9u IDI1NjA0MSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dLSW1hZ2VQcmV2aWV3Vmlld0Nv bnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTkzLDkgKzkzLDkgQEAgc3RhdGljIENHU2l6 ZSBfc2NhbGVTaXplV2l0aGluU2l6ZShDR1NpegogfQogCiAjaWYgSEFWRShMSU5LX1BSRVZJRVcp CitBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJTgogQUxMT1dfREVQUkVDQVRFRF9J TVBMRU1FTlRBVElPTlNfQkVHSU4KIC0gKE5TQXJyYXk8VUlQcmV2aWV3QWN0aW9uICo+ICopcHJl dmlld0FjdGlvbkl0ZW1zCi1BTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKIHsK ICAgICBOU011dGFibGVBcnJheTxVSVByZXZpZXdBY3Rpb24gKj4gKnByZXZpZXdBY3Rpb25zID0g W05TTXV0YWJsZUFycmF5IGFycmF5XTsKICAgICBmb3IgKF9XS0VsZW1lbnRBY3Rpb24gKmltYWdl QWN0aW9uIGluIF9pbWFnZUFjdGlvbnMuZ2V0KCkpIHsKQEAgLTEwOSw2ICsxMDksOCBAQCBBTExP V19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKIAogICAgIHJldHVybiBwcmV2aWV3QWN0 aW9uczsKIH0KK0FMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0VORAorQUxMT1dfREVQ UkVDQVRFRF9ERUNMQVJBVElPTlNfRU5ECiAjZW5kaWYKIAogQGVuZAo=